Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/ --- (Updated June 7, 2018, 10:43 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review204332 --- Ship it! Ship It! - Sahil Takiar On June 4, 2018, 6:34

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/ --- (Updated June 4, 2018, 6:34 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 67263: HIVE-19602

> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 304 (original), 231 (patched) > > > > > > whats the point of this class? >

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/ --- (Updated June 1, 2018, 4:58 a.m.) Review request for hive, Sahil Takiar and

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review204126 --- Fix it, then Ship it! minor comment otherwise LGTM

Re: Review Request 67263: HIVE-19602

> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 70 (original), 67 (patched) > > > > > > is this still used? > >

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/ --- (Updated May 29, 2018, 10:53 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203993 ---

Re: Review Request 67263: HIVE-19602

> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 70 (original), 67 (patched) > > > > > > is this still used? > >

Re: Review Request 67263: HIVE-19602

> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > are there any logic changes, or is most of the code just copied into the > > new class? Most of the code is copied to new class. Mostly I have the doubts mentioned in above comments. - Bharathkrishna

Re: Review Request 67263: HIVE-19602

> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 70 (original), 67 (patched) > > > > > > is this still used? Will remove

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203891 --- are there any logic changes, or is most of the code just copied

Re: Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203640 ---

Review Request 67263: HIVE-19602

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/ --- Review request for hive, Sahil Takiar and Vihang Karajgaonkar. Bugs: