Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Oct. 1, 2018, 11:42 a.m.) Review request for hive, Zoltan Haindrich, Z

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review209081 --- Thanks Denys, I like this new version. My last comments are below.

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 26, 2018, 11:47 a.m., Antal Sinkovits wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3062 (patched) > > > > > > Why is the default value -1? All the checks seems to go agai

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 26, 2018, 1:08 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review209017 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 3

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 24, 2018, 11:14 p.m., Peter Vary wrote: > > Hi Denys, > > > > Could you please think a little about separating the Manager/Factory and > > the tryAcquire mess? > > > > Incomplete thoughts, but I had to run > > > > Thanks, and sorry :( > > Peter Please review new patch. Really

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > I'm not sure but I feel that it would be probably simpler to add something > > which covers some reentrant-s and semaphores. > > It feels like this lock handling is a littlebit scattered around...I think > > it would be better to have

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 25, 2018, 10:19 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review208968 --- Hi Denys, Could you please think a little about separating the Ma

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 507 (original), 666 (patched) > > > > > > please don't make this method more visible; use compile

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 19, 2018, 9:37 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On szept. 17, 2018, 9:15 de, Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 507 (original), 666 (patched) > > > > > > please don't make this method more visible; use compile(

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 17, 2018, 5:55 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > I'm not sure but I feel that it would be probably simpler to add something > > which covers some reentrant-s and semaphores. > > It feels like this lock handling is a littlebit scattered around...I think > > it would be better to have

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 17, 2018, 12:52 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review208625 --- I'm not sure but I feel that it would be probably simpler to add s

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 13, 2018, 8:18 p.m.) Review request for hive, Zoltan Haindrich,

Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- Review request for hive, Zoltan Haindrich, Zoltan Haindrich, and Peter Vary. Bu