Re: Review Request 68897: Allow merge statement to have column schema

[Ashutosh Chauhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68897/#review209179
---




ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java
Line 1376 (original), 1376 (patched)


Can you add a comment on what this for loop is suppose to do?



ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java
Lines 1409 (patched)


replaceDefaultKeywordForMerge() is based on index. That is it assumes 
values list is in same order as in column list in target table which was true 
till now, but now with this change columns can be in any order and this may not 
work.



ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java
Line 1388 (original), 1410 (patched)


valuesClause may need to reorder column which are in columnListNode order 
to match them to order of target table. See, my ask to add new tests in later 
comments.



ql/src/test/queries/clientpositive/sqlmerge_stats.q
Line 34 (original), 34 (patched)


Can you please add following tests:

1. This should throw an error, since values clause cardinality need to 
match columnlist cardinality.  MERGE into t as t using upd_t as u ON t.a = u.a 
WHEN MATCHED THEN DELETE
WHEN NOT MATCHED THEN INSERT (a) VALUES(u.a);

2. merge into t as t using upd_t as u ON t.a = u.a 
WHEN MATCHED THEN DELETE
WHEN NOT MATCHED THEN INSERT (b, a) VALUES(u.a, u.b);

3. Assuming t's schema is create table t (a int, b default 1) then merge 
into t as t using upd_t as u ON t.a = u.a 
WHEN MATCHED THEN DELETE
WHEN NOT MATCHED THEN INSERT (b, a) VALUES(default, u.b);

4. Assuming t's schema is create table t (a int, b default 1) then merge 
into t as t using upd_t as u ON t.a = u.a 
WHEN MATCHED THEN update set b = default
WHEN NOT MATCHED THEN INSERT (b, a) VALUES(default, u.b);


- Ashutosh Chauhan


On Oct. 2, 2018, 1:26 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68897/
> ---
> 
> (Updated Oct. 2, 2018, 1:26 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-20590
> https://issues.apache.org/jira/browse/HIVE-20590
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Allow merge statement to have column schema.
> 
> Also removed some unused code, and made the rewritten query more consistent 
> (upper case SQL keywords everywhere)
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 78bc87c 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
> e8823e1 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCardinalityViolation.java
>  b688447 
>   ql/src/test/queries/clientpositive/sqlmerge_stats.q c480eb6 
>   ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out 02aa87a 
> 
> 
> Diff: https://reviews.apache.org/r/68897/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster using the new syntax. Also modified a q file to use 
> the new syntax.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

[Bharathkrishna Guruvayoor Murali via Review Board]

> On Oct. 2, 2018, 11:51 p.m., Alexander Kolbasov wrote:
> > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
> > Lines 123 (patched)
> > 
> >
> > Style: class fields usually follow normal camelCase.
> > Do we need a subdirectory for tests?
> > It is better to use joining with Path or File, e.g.
> > 
> > Path currentPath = Paths.get(System.getProperty("java.io.tmpdir"));
> > Path filePath = Paths.get(currentPath.toString(), "testDbNotif");

Fixed style issue.
Now using Paths.get to create the path.
Just added subDirectory just in case not to delete the java.io.tmpdir when it 
is being used somewhere (if at all that's possible).


- Bharathkrishna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/#review209167
---


On Oct. 3, 2018, 5:09 a.m., Bharathkrishna Guruvayoor Murali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68889/
> ---
> 
> (Updated Oct. 3, 2018, 5:09 a.m.)
> 
> 
> Review request for hive, Alexander Kolbasov and Andrew Sherman.
> 
> 
> Bugs: HIVE-20610
> https://issues.apache.org/jira/browse/HIVE-20610
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Adding java.io.tmpdir as tmp directory instead of /tmp
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
>  82429e36a575918d92a9b22bedcd63788ec51c5f 
> 
> 
> Diff: https://reviews.apache.org/r/68889/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharathkrishna Guruvayoor Murali
> 
>

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

[Bharathkrishna Guruvayoor Murali via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/
---

(Updated Oct. 3, 2018, 5:09 a.m.)


Review request for hive, Alexander Kolbasov and Andrew Sherman.


Bugs: HIVE-20610
https://issues.apache.org/jira/browse/HIVE-20610


Repository: hive-git


Description
---

Adding java.io.tmpdir as tmp directory instead of /tmp


Diffs (updated)
-

  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
 82429e36a575918d92a9b22bedcd63788ec51c5f 


Diff: https://reviews.apache.org/r/68889/diff/3/

Changes: https://reviews.apache.org/r/68889/diff/2-3/


Testing
---


Thanks,

Bharathkrishna Guruvayoor Murali

Confluence edit permission

[Ashutosh Bapat]

Hi Lefty,
I would like to get permissions to edit pages in confluence. I am working
with Hive team in Hortonworks. I couldn't find a way to request edit
permissions through confluence, hence this mail.


--
Best Wishes,
Ashutosh Bapat

[jira] [Created] (HIVE-20678) HiveHBaseTableOutputFormat should implement HiveOutputFormat to ensure compatibility

[Alice Fan (JIRA)]

Alice Fan created HIVE-20678:


 Summary: HiveHBaseTableOutputFormat should implement 
HiveOutputFormat to ensure compatibility
 Key: HIVE-20678
 URL: https://issues.apache.org/jira/browse/HIVE-20678
 Project: Hive
  Issue Type: Bug
  Components: HBase Handler, Hive, Spark
Affects Versions: 4.0.0
Reporter: Alice Fan
Assignee: Alice Fan


This issue was caused by same reason described in 
https://issues.apache.org/jira/browse/HIVE-11166. As the original Jira seems to 
be abandoned, so create this one to resolve the issue.

HiveHBaseTableOutputFormat does not implemented HiveOutputFormat, it will break 
the compatibility in spark's API when it is using hive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-20677) JDBC storage handler ordering problem - single split flag

[Jesus Camacho Rodriguez (JIRA)]

Jesus Camacho Rodriguez created HIVE-20677:
--

 Summary: JDBC storage handler ordering problem - single split flag
 Key: HIVE-20677
 URL: https://issues.apache.org/jira/browse/HIVE-20677
 Project: Hive
  Issue Type: Bug
  Components: StorageHandler
Reporter: Gunther Hagleitner
Assignee: Jesus Camacho Rodriguez


When Calcite is pushing queries into the JDBC handler splitting the query via 
offset/limit can cause issues (RDBMs is not guaranteed to return the data in 
the same order every time.)

For these cases we want to:

a) Add a "do not split" flag to the jdbc handler. In that mode jdbc handler 
will skip the count and offset/limit processing but just run the query in a 
single node. Flag default will be false.

b) Have calcite automatically set this flag.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

[Jesús Camacho Rodríguez]

> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> >

I will take a look at the q files today, there were several plans that I did 
not have time to check.


> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java
> > Lines 288 (patched)
> > 
> >
> > We may have Volcano node too, we need to include it.
> 
> Vineet Garg wrote:
> How do I include volcano nodes? Can you point me to an example? Tried 
> searching for it but couldn't figure out.

The volcano nodes are RelSubset.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68868/#review209136
---


On Oct. 3, 2018, 12:44 a.m., Vineet Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68868/
> ---
> 
> (Updated Oct. 3, 2018, 12:44 a.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-17043
> https://issues.apache.org/jira/browse/HIVE-17043
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> This patch implements/test the following optimizations
> * Removal of group by on primary keys
> * Reduction of group by keys on primary keys
> * is NOT NULL filter removal if NOT NULL constraint is defined
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties fdd8ecc77c 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java
>  635d27e723 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
> 42e60de6a8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
>  f43ef01293 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
>  5857f730a8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdColumnUniqueness.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
>  1ca1937ed9 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java
>  3bf62c535c 
>   ql/src/test/queries/clientpositive/constraints_optimization.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68868/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

[Vineet Garg]

> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java
> > Lines 223 (patched)
> > 
> >
> > Should it be key.contains(columns) ?

You are correct, good eye.


> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java
> > Line 285 (original), 311 (patched)
> > 
> >
> > Can we either return a Pair, or make it void and that it sets both 
> > _keys_ and _nonNullablekeys_? Currently it is a bit weird that one of them 
> > is set via return of the method, and the second one from the method.

Made it void, i thought it that was more simpler.


> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
> > Line 363 (original), 414 (patched)
> > 
> >
> > return...

Not sure what do you mean by that?


> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java
> > Lines 53 (patched)
> > 
> >
> > This should be a new metadata provider or a modification of the 
> > existing _RelMdUniqueKeys_ but introducing a new boolean parameter 
> > _acceptEstimatedResults_. However, this would need changes in Calcite side. 
> > Please, leave a TODO comment though.

Left a TODO comment


> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java
> > Lines 288 (patched)
> > 
> >
> > We may have Volcano node too, we need to include it.

How do I include volcano nodes? Can you point me to an example? Tried searching 
for it but couldn't figure out.


> On Oct. 1, 2018, 8:07 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
> > Line 320 (original), 320 (patched)
> > 
> >
> > We do not use metadata providers anymore for unique keys estimation, 
> > which means some features will be disabled, e.g., caching of metadata 
> > results. I am not sure whether this may cause an increase in compilation 
> > time for several queries, specially those containing many joins, but it 
> > would be worth leaving a comment and maybe monitoring it in future.

Good point, left a note


- Vineet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68868/#review209136
---


On Oct. 3, 2018, 12:44 a.m., Vineet Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68868/
> ---
> 
> (Updated Oct. 3, 2018, 12:44 a.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-17043
> https://issues.apache.org/jira/browse/HIVE-17043
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> This patch implements/test the following optimizations
> * Removal of group by on primary keys
> * Reduction of group by keys on primary keys
> * is NOT NULL filter removal if NOT NULL constraint is defined
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties fdd8ecc77c 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java
>  635d27e723 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
> 42e60de6a8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
>  f43ef01293 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
>  5857f730a8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdColumnUniqueness.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
>  1ca1937ed9 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java
>  3bf62c535c 
>   ql/src/test/queries/clientpositive/constraints_optimization.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 
> PRE-CREATION 
> 

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

[Vineet Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68868/
---

(Updated Oct. 3, 2018, 12:44 a.m.)


Review request for hive and Jesús Camacho Rodríguez.


Bugs: HIVE-17043
https://issues.apache.org/jira/browse/HIVE-17043


Repository: hive-git


Description
---

This patch implements/test the following optimizations
* Removal of group by on primary keys
* Reduction of group by keys on primary keys
* is NOT NULL filter removal if NOT NULL constraint is defined


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties fdd8ecc77c 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java
 635d27e723 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
42e60de6a8 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
 f43ef01293 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
 5857f730a8 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/EstimateUniqueKeys.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdColumnUniqueness.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
 1ca1937ed9 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java
 3bf62c535c 
  ql/src/test/queries/clientpositive/constraints_optimization.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/68868/diff/2/

Changes: https://reviews.apache.org/r/68868/diff/1-2/


Testing
---


Thanks,

Vineet Garg

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

[Vihang Karajgaonkar via Review Board]

> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote:
> > All looks good, just a few nits which I noticed

Unfortunately, I cannot update this review board URL since its owned by 
Alexander. Latest patch on the JIRA has the suggested changes. Will see if I 
can update the diffs here somehow.


> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Line 1667 (original), 1667 (patched)
> > 
> >
> > I think he previous text 'E.g.' is better

done


> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Line 1673 (original), 1673 (patched)
> > 
> >
> > Not sure why this changed, should be 'compliant'

done


> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Line 1676 (original), 1676 (patched)
> > 
> >
> > Not sure why this changed, should be 'compliant'

done


> On Oct. 3, 2018, 12:33 a.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
> > Lines 3765 (patched)
> > 
> >
> > Arguably clearer to say "providing different ways of filtering and 
> > controlling output"

changed


- Vihang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68664/#review209171
---


On Oct. 3, 2018, 12:07 a.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68664/
> ---
> 
> (Updated Oct. 3, 2018, 12:07 a.m.)
> 
> 
> Review request for hive, Aihua Xu, Andrew Sherman, Peter Vary, Todd Lipcon, 
> and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20306: Implement projection spec for fetching only requested fields from 
> partitions
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
>  0ad2a2469e0330e050fdb8983078b80617afbbf1 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
>  ae0956870a7d01c24f5fdaa07094c3dc6604ab9a 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
>  4574c6a4925ae3df9dd1ee7b8786976ae6fc8397 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php
>  22deffe1d31a64f95c49d7f017dfeb2994233e71 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
>  a595732f04af4304974186178377192227bb80fb 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
>  38074ce79b8a06b3795d00431025240778abb569 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
>  38fac465d73c264f85fc512548ebe1919ee35c17 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
>  0192c6da314694c1253b49949bbe749902f49b4b 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
>  e6a72762bb7b0d36fdf6d20d02cb1da3337a98a0 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  d226db50a520707abee11fe7b81e2d95c39a6679 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
>  

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

[Vihang Karajgaonkar via Review Board]

> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java
> > Lines 38 (patched)
> > 
> >
> > Why is this new interface marked Stable? I know this is generated code, 
> > but where does ths come from?
> 
> Alexander Kolbasov wrote:
> There is probably some magic code that marks everything here as stable 
> interface

I think this is done in the "process-sources" phase during maven execution. See 
"process-thrift-sources-interface-annotations" in metastore-common/pom.xml


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
> > Lines 1101 (patched)
> > 
> >
> > add method description

done


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 65 (patched)
> > 
> >
> > Add a brief comment explaining what the test does

done


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 84 (patched)
> > 
> >
> > This seems weird
> 
> Alexander Kolbasov wrote:
> This is copied from TestHiveMetastore. I am not sure why it is needed.

removed this line. It was not needed.


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 278 (patched)
> > 
> >
> > Shoudl we have the fields here that are not supported in direct sqL?  
> > serdeType, serializerClass and deserializerClass

added them in the test.


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 300 (patched)
> > 
> >
> > I couldn't work out what "i" was so pls document

added a description


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 309 (patched)
> > 
> >
> > is 3 here just the length of "sd." ?

yes


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 400 (patched)
> > 
> >
> > weird that you set an exclude prefix with a method called include?

the test is actually using setIncludeParamKeyPattern to test the include 
parameters. I just reused existing parameter keys instead of creating new ones. 
Added a comment to make it slightly better :)


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 442 (patched)
> > 
> >
> > assertion message should be that key is found in the list?

fixed.


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 568 (patched)
> > 
> >
> > maybe this should be an old fashioned for loop?

done


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java
> > Lines 396 (patched)
> > 
> >
> > objects *with* null

done


- Vihang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68664/#review208866
---


On Oct. 3, 2018, 12:07 a.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically 

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

[Andrew Sherman via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68664/#review209171
---


Fix it, then Ship it!




All looks good, just a few nits which I noticed


standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Line 1667 (original), 1667 (patched)


I think he previous text 'E.g.' is better



standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Line 1673 (original), 1673 (patched)


Not sure why this changed, should be 'compliant'



standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Line 1676 (original), 1676 (patched)


Not sure why this changed, should be 'compliant'



standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
Lines 3765 (patched)


Arguably clearer to say "providing different ways of filtering and 
controlling output"


- Andrew Sherman


On Oct. 3, 2018, 12:07 a.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68664/
> ---
> 
> (Updated Oct. 3, 2018, 12:07 a.m.)
> 
> 
> Review request for hive, Aihua Xu, Andrew Sherman, Peter Vary, Todd Lipcon, 
> and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20306: Implement projection spec for fetching only requested fields from 
> partitions
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
>  0ad2a2469e0330e050fdb8983078b80617afbbf1 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
>  ae0956870a7d01c24f5fdaa07094c3dc6604ab9a 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
>  4574c6a4925ae3df9dd1ee7b8786976ae6fc8397 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php
>  22deffe1d31a64f95c49d7f017dfeb2994233e71 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
>  a595732f04af4304974186178377192227bb80fb 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
>  38074ce79b8a06b3795d00431025240778abb569 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
>  38fac465d73c264f85fc512548ebe1919ee35c17 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
>  0192c6da314694c1253b49949bbe749902f49b4b 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
>  e6a72762bb7b0d36fdf6d20d02cb1da3337a98a0 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  d226db50a520707abee11fe7b81e2d95c39a6679 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
>  54e7eda0da796877f1331de137d534126375c6ba 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  a92f34bb1f149ab063c6f97b80b112f3a9e7f85e 
>   standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
> 85a5c601e03ecd2fb6ac5d30d789193e10bf38c2 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  ba82a9327cf18e8d55ebddcd774786d3d72f753a 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
>  571c789eddfd2b1a27c65c48bdc6dccfafaaf676 
>   
> 

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

[Alexander Kolbasov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68664/
---

(Updated Oct. 3, 2018, 12:07 a.m.)


Review request for hive, Aihua Xu, Andrew Sherman, Peter Vary, Todd Lipcon, and 
Vihang Karajgaonkar.


Changes
---

Addressed code review comments


Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306


Repository: hive-git


Description
---

HIVE-20306: Implement projection spec for fetching only requested fields from 
partitions


Diffs (updated)
-

  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 0ad2a2469e0330e050fdb8983078b80617afbbf1 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java
 PRE-CREATION 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java
 PRE-CREATION 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java
 PRE-CREATION 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java
 PRE-CREATION 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java
 PRE-CREATION 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 ae0956870a7d01c24f5fdaa07094c3dc6604ab9a 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
 4574c6a4925ae3df9dd1ee7b8786976ae6fc8397 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php
 22deffe1d31a64f95c49d7f017dfeb2994233e71 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
 a595732f04af4304974186178377192227bb80fb 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
 38074ce79b8a06b3795d00431025240778abb569 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
 38fac465d73c264f85fc512548ebe1919ee35c17 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
 0192c6da314694c1253b49949bbe749902f49b4b 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
 e6a72762bb7b0d36fdf6d20d02cb1da3337a98a0 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 d226db50a520707abee11fe7b81e2d95c39a6679 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
 54e7eda0da796877f1331de137d534126375c6ba 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 a92f34bb1f149ab063c6f97b80b112f3a9e7f85e 
  standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
85a5c601e03ecd2fb6ac5d30d789193e10bf38c2 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 ba82a9327cf18e8d55ebddcd774786d3d72f753a 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
 571c789eddfd2b1a27c65c48bdc6dccfafaaf676 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java
 PRE-CREATION 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 64945060f7152486671c9fe10e2835e67417977c 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java
 PRE-CREATION 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
 b61ee81533930c889f23d2551041055cbdd1a6b2 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java
 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 b9a545872f94ffe0a2583c14652e82840d3c6bdd 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java
 68f07e2569b6531cf3e18919209aed1a17e88bf7 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MStorageDescriptor.java
 4c6ce008f89469353bfee3175168a518534a42b1 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
 10ff9dfbb6d8f61fa75f731f4cd0f006c98e0067 
  

[jira] [Created] (HIVE-20676) HiveServer2: PrivilegeSynchronizer is not set to daemon status

[Vaibhav Gumashta (JIRA)]

Vaibhav Gumashta created HIVE-20676:
---

 Summary: HiveServer2: PrivilegeSynchronizer is not set to daemon 
status
 Key: HIVE-20676
 URL: https://issues.apache.org/jira/browse/HIVE-20676
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Affects Versions: 4.0.0
Reporter: Vaibhav Gumashta






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-20675) Log pollution from PrivilegeSynchronizer if zk is not configured

[Daniel Dai (JIRA)]

Daniel Dai created HIVE-20675:
-

 Summary: Log pollution from PrivilegeSynchronizer if zk is not 
configured
 Key: HIVE-20675
 URL: https://issues.apache.org/jira/browse/HIVE-20675
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Reporter: Daniel Dai
Assignee: Daniel Dai


Shall stop PrivilegeSynchronizer if "hive.zookeeper.quorum" is not configured. 
Note "hive.privilege.synchronizer" is on by default.

{code}
2018-10-02T16:04:12,488  WARN [main-SendThread(localhost:2181)] 
zookeeper.ClientCnxn: Session 0x0 for server null, unexpected error, closing 
socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
~[?:1.8.0_91]
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
~[?:1.8.0_91]
at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
 ~[zookeeper-3.4.6.jar:3.4.6-1569965]
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
~[zookeeper-3.4.6.jar:3.4.6-1569965]
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

[Alexander Kolbasov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/#review209167
---



The fix is fine, kust some style issues.


itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
Lines 123 (patched)


Style: class fields usually follow normal camelCase.
Do we need a subdirectory for tests?
It is better to use joining with Path or File, e.g.

Path currentPath = Paths.get(System.getProperty("java.io.tmpdir"));
Path filePath = Paths.get(currentPath.toString(), "testDbNotif");



itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
Line 876 (original), 883 (patched)


It is better to join using Path or FIle methods.


- Alexander Kolbasov


On Oct. 2, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68889/
> ---
> 
> (Updated Oct. 2, 2018, 9:55 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov and Andrew Sherman.
> 
> 
> Bugs: HIVE-20610
> https://issues.apache.org/jira/browse/HIVE-20610
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Adding java.io.tmpdir as tmp directory instead of /tmp
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
>  82429e36a575918d92a9b22bedcd63788ec51c5f 
> 
> 
> Diff: https://reviews.apache.org/r/68889/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharathkrishna Guruvayoor Murali
> 
>

[jira] [Created] (HIVE-20674) TestJdbcWithMiniLlapArrow.testKillQuery fail frequently

[Daniel Dai (JIRA)]

Daniel Dai created HIVE-20674:
-

 Summary: TestJdbcWithMiniLlapArrow.testKillQuery fail frequently
 Key: HIVE-20674
 URL: https://issues.apache.org/jira/browse/HIVE-20674
 Project: Hive
  Issue Type: Bug
Reporter: Daniel Dai
Assignee: Daniel Dai






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68900: HIVE-20671: Hive Streaming has a broken dependency on metastore-server

[Alexander Kolbasov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68900/
---

(Updated Oct. 2, 2018, 11:39 p.m.)


Review request for hive, Alan Gates and Vihang Karajgaonkar.


Changes
---

hive-streaming doesn't need metastore-server test dependency


Bugs: HIVE-20671
https://issues.apache.org/jira/browse/HIVE-20671


Repository: hive-git


Description
---

HIVE-20671: Hive Streaming has a broken dependency on metastore-server


Diffs (updated)
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java
  
  streaming/pom.xml 22fe61995df397c7aabae26c9161ff08aea4d3f0 


Diff: https://reviews.apache.org/r/68900/diff/2/

Changes: https://reviews.apache.org/r/68900/diff/1-2/


Testing
---


Thanks,

Alexander Kolbasov

[jira] [Created] (HIVE-20673) vectorized map join fail with Unexpected column vector type STRUCT.

[Rajkumar Singh (JIRA)]

Rajkumar Singh created HIVE-20673:
-

 Summary: vectorized map join fail with Unexpected column vector 
type STRUCT.
 Key: HIVE-20673
 URL: https://issues.apache.org/jira/browse/HIVE-20673
 Project: Hive
  Issue Type: Bug
  Components: Hive, Transactions, Vectorization
Affects Versions: 3.1.0
 Environment: hive-3, java-8
Reporter: Rajkumar Singh


update query on ACID table fails with the following exception.
 
UPDATE census_clus SET name = 'updated name' where ssn=100 and   EXISTS (select 
distinct ssn from census where ssn=census_clus.ssn);

{code}
Caused by: java.lang.RuntimeException: Map operator initialization failed
at 
org.apache.hadoop.hive.ql.exec.tez.MapRecordProcessor.init(MapRecordProcessor.java:354)
at 
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:266)
... 16 more
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unexpected column 
vector type STRUCT
at 
org.apache.hadoop.hive.ql.exec.vector.VectorCopyRow.init(VectorCopyRow.java:302)
at 
org.apache.hadoop.hive.ql.exec.vector.mapjoin.VectorMapJoinCommonOperator.initializeOp(VectorMapJoinCommonOperator.java:419)
at 
org.apache.hadoop.hive.ql.exec.vector.mapjoin.VectorMapJoinGenerateResultOperator.initializeOp(VectorMapJoinGenerateResultOperator.java:115)
at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375)
at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:572)
at 
org.apache.hadoop.hive.ql.exec.Operator.initializeChildren(Operator.java:524)
at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:385)
at 
org.apache.hadoop.hive.ql.exec.tez.MapRecordProcessor.init(MapRecordProcessor.java:335)
{code}

STEPS TO REPRODUCE
{code}
create table census(
ssn int,
name string,
city string,
email string) 
row format delimited 
fields terminated by ',';

insert into census values(100,"raj","san jose","email");
create table census_clus(
ssn int,
name string,
city string,
email string) 
clustered by (ssn) into 4 buckets  stored as orc TBLPROPERTIES 
('transactional'='true');

insert into  table census_clus select *  from census;

UPDATE census_clus SET name = 'updated name' where ssn=100 and   EXISTS (select 
distinct ssn from census where ssn=census_clus.ssn);
{code}

looking at the exception it seems the join operator getting typeInfo 
incorrectly while doing join, _col6 seems to be of struct type.

{code}
2018-10-02 22:22:23,392 [INFO] [TezChild] |exec.CommonJoinOperator|: JOIN 
struct<_col2:string,_col3:string,_col6:struct>
 totalsz = 3

{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 68900: HIVE-20671: Hive Streaming has a broken dependency on metastore-server

[Alexander Kolbasov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68900/
---

Review request for hive, Alan Gates and Vihang Karajgaonkar.


Bugs: HIVE-20671
https://issues.apache.org/jira/browse/HIVE-20671


Repository: hive-git


Description
---

HIVE-20671: Hive Streaming has a broken dependency on metastore-server


Diffs
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java
  


Diff: https://reviews.apache.org/r/68900/diff/1/


Testing
---


Thanks,

Alexander Kolbasov

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

[Andrew Sherman via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/#review209165
---


Ship it!




Ship It!

- Andrew Sherman


On Oct. 2, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68889/
> ---
> 
> (Updated Oct. 2, 2018, 9:55 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov and Andrew Sherman.
> 
> 
> Bugs: HIVE-20610
> https://issues.apache.org/jira/browse/HIVE-20610
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Adding java.io.tmpdir as tmp directory instead of /tmp
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
>  82429e36a575918d92a9b22bedcd63788ec51c5f 
> 
> 
> Diff: https://reviews.apache.org/r/68889/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharathkrishna Guruvayoor Murali
> 
>

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

[Bharathkrishna Guruvayoor Murali via Review Board]

> On Oct. 1, 2018, 3:43 p.m., Andrew Sherman wrote:
> > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
> > Lines 123 (patched)
> > 
> >
> > General comment: don't try to do too much in static initializers in 
> > server code. Just like in HIVE-20545 you have to consider what will happen 
> > if there is a failure during initialization, and the result is always ugly. 
> > In this case it looks safe but IT MADE ME THINK which is bad.

I made it final, no longer static


> On Oct. 1, 2018, 3:43 p.m., Andrew Sherman wrote:
> > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
> > Line 802 (original), 804 (patched)
> > 
> >
> > This looks ugly to me. I think the string concatenation operator + 
> > should be separated on both sides by spaces. I think that is what is most 
> > commonly used on Hive - I'll leave it to you to check. But the usage is 
> > here is different from that in the static initializer code and that 
> > inconsistency is ugly too. IMHO You should teach Intellij to do your 
> > formatting and then let it decide this stuff

Corrected checkstyle


- Bharathkrishna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/#review209131
---


On Oct. 2, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68889/
> ---
> 
> (Updated Oct. 2, 2018, 9:55 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov and Andrew Sherman.
> 
> 
> Bugs: HIVE-20610
> https://issues.apache.org/jira/browse/HIVE-20610
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Adding java.io.tmpdir as tmp directory instead of /tmp
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
>  82429e36a575918d92a9b22bedcd63788ec51c5f 
> 
> 
> Diff: https://reviews.apache.org/r/68889/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharathkrishna Guruvayoor Murali
> 
>

Re: Review Request 68889: HIVE-20610 : TestDbNotificationListener should not use /tmp directory

[Bharathkrishna Guruvayoor Murali via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68889/
---

(Updated Oct. 2, 2018, 9:55 p.m.)


Review request for hive, Alexander Kolbasov and Andrew Sherman.


Changes
---

Making some checkstyle corrections. Also, adding TEST_TEMP_DIR as just final 
and not static.


Bugs: HIVE-20610
https://issues.apache.org/jira/browse/HIVE-20610


Repository: hive-git


Description
---

Adding java.io.tmpdir as tmp directory instead of /tmp


Diffs (updated)
-

  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
 82429e36a575918d92a9b22bedcd63788ec51c5f 


Diff: https://reviews.apache.org/r/68889/diff/2/

Changes: https://reviews.apache.org/r/68889/diff/1-2/


Testing
---


Thanks,

Bharathkrishna Guruvayoor Murali

[jira] [Created] (HIVE-20672) Logging thread in LlapTaskSchedulerService should report every fixed interval

[Jaume M (JIRA)]

Jaume M created HIVE-20672:
--

 Summary: Logging thread in LlapTaskSchedulerService should report 
every fixed interval
 Key: HIVE-20672
 URL: https://issues.apache.org/jira/browse/HIVE-20672
 Project: Hive
  Issue Type: Bug
Reporter: Jaume M






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68664: HIVE-20306: Implement projection spec for fetching only requested fields from partitions

[Alexander Kolbasov]

> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java
> > Lines 38 (patched)
> > 
> >
> > Why is this new interface marked Stable? I know this is generated code, 
> > but where does ths come from?

There is probably some magic code that marks everything here as stable interface


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Lines 2389 (patched)
> > 
> >
> > this is get_partitions with filter and projectspec and unimplemented 
> > filter spec?

Correct


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java
> > Lines 84 (patched)
> > 
> >
> > This seems weird

This is copied from TestHiveMetastore. I am not sure why it is needed.


> On Sept. 21, 2018, 8:50 p.m., Andrew Sherman wrote:
> > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java
> > Lines 577 (patched)
> > 
> >
> > name should contain One not one ?

Fixed


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68664/#review208866
---


On Sept. 20, 2018, 9:46 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68664/
> ---
> 
> (Updated Sept. 20, 2018, 9:46 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Andrew Sherman, Peter Vary, Todd Lipcon, 
> and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20306: Implement projection spec for fetching only requested fields from 
> partitions
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
>  0ad2a2469e0330e050fdb8983078b80617afbbf1 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java
>  PRE-CREATION 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
>  ae0956870a7d01c24f5fdaa07094c3dc6604ab9a 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
>  4574c6a4925ae3df9dd1ee7b8786976ae6fc8397 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php
>  22deffe1d31a64f95c49d7f017dfeb2994233e71 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
>  a595732f04af4304974186178377192227bb80fb 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
>  38074ce79b8a06b3795d00431025240778abb569 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py
>  38fac465d73c264f85fc512548ebe1919ee35c17 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb
>  0192c6da314694c1253b49949bbe749902f49b4b 
>   
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
>  e6a72762bb7b0d36fdf6d20d02cb1da3337a98a0 
>   standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
> 85a5c601e03ecd2fb6ac5d30d789193e10bf38c2 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  ba82a9327cf18e8d55ebddcd774786d3d72f753a 
>   
> 

[jira] [Created] (HIVE-20671) Change pom dependency scope of hive-standalone-metastore-server to compile

[Jaume M (JIRA)]

Jaume M created HIVE-20671:
--

 Summary: Change pom dependency scope of 
hive-standalone-metastore-server to compile
 Key: HIVE-20671
 URL: https://issues.apache.org/jira/browse/HIVE-20671
 Project: Hive
  Issue Type: Bug
Reporter: Jaume M


{{mvn -DskipTests -Pitests clean test-compile -DskipTests=true}} fails from the 
root directory of hive. This is sometimes run as part of the yetus tests 
depending on the modified files. The error is
{code}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) 
on project hive-streaming: Compilation failure: Compilation failure:
[ERROR] 
/Users/jmarhuenda/workspace/hive/streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java:[44,40]
 cannot find symbol
[ERROR]   symbol:   class LockComponentBuilder
[ERROR]   location: package org.apache.hadoop.hive.metastore
[ERROR] 
/Users/jmarhuenda/workspace/hive/streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java:[45,40]
 cannot find symbol
[ERROR]   symbol:   class LockRequestBuilder
[ERROR]   location: package org.apache.hadoop.hive.metastore
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :hive-streaming
{code}
I'm not sure why this would happen since {{test-compile}} works from 
{{hive/streaming}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-20670) ShuffleHandler should use HiveConf.LLAP_DAEMON_YARN_SHUFFLE_PORT instead of local variable

[Jaume M (JIRA)]

Jaume M created HIVE-20670:
--

 Summary: ShuffleHandler should use 
HiveConf.LLAP_DAEMON_YARN_SHUFFLE_PORT instead of local variable
 Key: HIVE-20670
 URL: https://issues.apache.org/jira/browse/HIVE-20670
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2, llap
Affects Versions: 3.1.0
Reporter: Jaume M






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-20669) JdbcStorageHandler push union of two different datasource to jdbc driver

[Jesus Camacho Rodriguez (JIRA)]

Jesus Camacho Rodriguez created HIVE-20669:
--

 Summary: JdbcStorageHandler push union of two different datasource 
to jdbc driver
 Key: HIVE-20669
 URL: https://issues.apache.org/jira/browse/HIVE-20669
 Project: Hive
  Issue Type: Bug
  Components: Query Planning
Reporter: Daniel Dai
Assignee: Jesus Camacho Rodriguez
 Attachments: external_jdbc_table2.q

Test case attached. The following query fail:
{code}
SELECT * FROM ext_auth1 JOIN ext_auth2 ON ext_auth1.ikey = ext_auth2.ikey
{code}
Error message:
{code}
2018-09-28T00:36:23,860 DEBUG [17b954d9-3250-45a9-995e-1b3f8277a681 main] 
dao.GenericJdbcDatabaseAccessor: Query to execute is [SELECT *
FROM (SELECT *
FROM "SIMPLE_DERBY_TABLE1"
WHERE "ikey" IS NOT NULL) AS "t"
INNER JOIN (SELECT *
FROM "SIMPLE_DERBY_TABLE2"
WHERE "ikey" IS NOT NULL) AS "t0" ON "t"."ikey" = "t0"."ikey" {LIMIT 1}]
2018-09-28T00:36:23,864 ERROR [17b954d9-3250-45a9-995e-1b3f8277a681 main] 
dao.GenericJdbcDatabaseAccessor: Error while trying to get column names.
java.sql.SQLSyntaxErrorException: Table/View 'SIMPLE_DERBY_TABLE2' does not 
exist.
at 
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source) 
~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at 
org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at 
org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedPreparedStatement42.(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.jdbc.Driver42.newEmbedPreparedStatement(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
at 
org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:281)
 ~[commons-dbcp-1.4.jar:1.4]
at 
org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:313)
 ~[commons-dbcp-1.4.jar:1.4]
at 
org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getColumnNames(GenericJdbcDatabaseAccessor.java:74)
 [hive-jdbc-handler-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at org.apache.hive.storage.jdbc.JdbcSerDe.initialize(JdbcSerDe.java:78) 
[hive-jdbc-handler-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.serde2.AbstractSerDe.initialize(AbstractSerDe.java:54) 
[hive-serde-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.serde2.SerDeUtils.initializeSerDe(SerDeUtils.java:540) 
[hive-serde-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:90)
 [hive-metastore-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getDeserializer(HiveMetaStoreUtils.java:77)
 [hive-metastore-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:295)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.metadata.Table.getDeserializer(Table.java:277) 
[hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genTablePlan(SemanticAnalyzer.java:11100)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:11468)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:11427)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:525)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12319)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:356)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:289)
 [hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
at 

[GitHub] hive pull request #442: Fix incorrect derivation of command args

[soumabrata-chakraborty]

GitHub user soumabrata-chakraborty opened a pull request:

https://github.com/apache/hive/pull/442

Fix incorrect derivation of command args

Fix incorrect derivation of command args

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soumabrata-chakraborty/hive HIVE-20608

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #442


commit 6be2819538a4bb3aa74ab9f82490ecd033c8c5d5
Author: Soumabrata Chakraborty 
Date:   2018-09-21T14:12:32Z

Fix incorrect derivation of command args




---

Review Request 68897: Allow merge statement to have column schema

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68897/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20590
https://issues.apache.org/jira/browse/HIVE-20590


Repository: hive-git


Description
---

Allow merge statement to have column schema.

Also removed some unused code, and made the rewritten query more consistent 
(upper case SQL keywords everywhere)


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 78bc87c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java 
e8823e1 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCardinalityViolation.java
 b688447 
  ql/src/test/queries/clientpositive/sqlmerge_stats.q c480eb6 
  ql/src/test/results/clientpositive/llap/sqlmerge_stats.q.out 02aa87a 


Diff: https://reviews.apache.org/r/68897/diff/1/


Testing
---

Tested on local cluster using the new syntax. Also modified a q file to use the 
new syntax.


Thanks,

Miklos Gergely

[jira] [Created] (HIVE-20668) Java11 and TLS1.3 support

[t oo (JIRA)]

t oo created HIVE-20668:
---

 Summary: Java11 and TLS1.3 support
 Key: HIVE-20668
 URL: https://issues.apache.org/jira/browse/HIVE-20668
 Project: Hive
  Issue Type: New Feature
Reporter: t oo






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 68895: HadoopVer was ignored in QTestUtil

[denys kuzmenko via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68895/
---

Review request for hive, Zoltan Haindrich and Peter Vary.


Bugs: HIVE-20647
https://issues.apache.org/jira/browse/HIVE-20647


Repository: hive-git


Description
---

- Removed obsolete hadoopVer from QTestUtil

- Cleaned up QTestUtil, QTestArgumentsBuilder

- Refactored AccumuloTestSetup, AccumuloQTestUtil due to findbugs violation:
(UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR: Uninitialized read of field 
method called from constructor of superclass)


Diffs
-

  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java
 b7e563aebf 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMTQueries.java 
3d8eb83b04 
  
itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloQTestUtil.java
 060e0cd3e2 
  
itests/util/src/main/java/org/apache/hadoop/hive/accumulo/AccumuloTestSetup.java
 47cf7ac79a 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java
 64f29194d5 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java
 0d64cfa1ac 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreCliDriver.java
 bdb15b3869 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBlobstoreNegativeCliDriver.java
 801c44b40c 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java 
841344438e 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java
 8ce43495e6 
  itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreDummy.java 
4d40ef9047 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java
 252e9f6b90 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java
 c009cec57b 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java
 0807da1c7c 
  
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java
 badb4a5888 
  itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java 
6a6b1003b6 
  itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseTestSetup.java 
cc63a6cc83 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestArguments.java 
18269ebc92 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 0e8b82930e 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java
 77de3faa1f 


Diff: https://reviews.apache.org/r/68895/diff/1/


Testing
---


Thanks,

denys kuzmenko