Review Request 29051: HIVE-9091 Add additional unit tests for HiveSQLException

--- Testing is done in https://issues.apache.org/jira/browse/HIVE-9091 with one Tez failure (org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan). Seems not related to my change. Thanks, Aihua Xu

Re: [ANNOUNCE] New Hive PMC Members - Szehon Ho, Vikram Dixit, Jason Dere, Owen O'Malley and Prasanth Jayachandran

+1. Cong~ everyone! On Jan 29, 2015, at 9:43 AM, Philippe Kernévez pkerne...@octo.com wrote: Congratulations everyone ! On Wed, Jan 28, 2015 at 10:15 PM, Carl Steinbach c...@apache.org wrote: I am pleased to announce that Szehon Ho, Vikram Dixit, Jason Dere, Owen O'Malley and Prasanth

Review Request 32491: HIVE-10085 Lateral view on top of a view throws RuntimeException

/results/clientpositive/lateral_view_onview.q.out PRE-CREATION Diff: https://reviews.apache.org/r/32491/diff/ Testing --- Thanks, Aihua Xu

Review Request 32551: HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2

/HiveAuthFactory.java 22c309fbfd941fb517370057ef38fbec903ce088 Diff: https://reviews.apache.org/r/32551/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 32551: HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2

://reviews.apache.org/r/32551/#review77956 --- On March 26, 2015, 9:55 p.m., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32551

Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

has been done and the unit tests failures seem to be unrelated. https://issues.apache.org/jira/browse/HIVE-10643 Thanks, Aihua Xu

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34040/#review83257 --- On May 11, 2015, 2:24 p.m., Aihua Xu wrote

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

://reviews.apache.org/r/34040/diff/ Testing --- Testing has been done and the unit tests failures seem to be unrelated. https://issues.apache.org/jira/browse/HIVE-10643 Thanks, Aihua Xu

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

/ptf/WindowFrameDef.java, line 51 https://reviews.apache.org/r/34040/diff/1/?file=955309#file955309line51 Should this take into account direction information? e.g., for 3 precceding 2 following, window size = 6, but for 3 preceeding 2 following, window size = 1, isn't it? Aihua Xu

Review Request 34166: HIVE-10650 Improve sum() function over windowing to support additional range formats

://reviews.apache.org/r/34166/diff/ Testing --- Test is done here: https://issues.apache.org/jira/browse/HIVE-10650. One test failed is unrelated. Thanks, Aihua Xu

Review Request 32775: HIVE-9917 After HIVE-3454 is done, make int to timestamp conversion configurable

7641f94208c513ba3791604e5ca439f7fcc364f0 serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/primitive/TestPrimitiveObjectInspectorUtils.java 1f318f52165b370c9b5c8979f545a86e31804121 Diff: https://reviews.apache.org/r/32775/diff/ Testing --- Thanks, Aihua Xu

Review Request 35132: HIVE-10906 Value based UDAF function without orderby expression throws NPE

/windowing_windowspec3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35132/diff/ Testing --- Thanks, Aihua Xu

Review Request 35218: HIVE-10963 Hive throws NPE rather than meaningful error message when window is missing

/results/clientnegative/ptf_negative_NoWindowDefn.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35218/diff/ Testing --- Thanks, Aihua Xu

Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

/WindowingTableFunction.java 40fd6a459a733bc465afe6108a184f2e8abf1a7d ql/src/test/queries/clientpositive/windowing_windowspec3.q PRE-CREATION ql/src/test/results/clientpositive/windowing_windowspec3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35136/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35136/#review86824 --- On June 5, 2015, 8:42 p.m., Aihua Xu wrote

Re: Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function

/WindowingTableFunction.java 40fd6a4 ql/src/test/queries/clientpositive/windowing_windowspec3.q PRE-CREATION ql/src/test/results/clientpositive/windowing_windowspec3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35136/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35218: HIVE-10963 Hive throws NPE rather than meaningful error message when window is missing

--- Thanks, Aihua Xu

Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

/TestObjectStore.java PRE-CREATION Diff: https://reviews.apache.org/r/35803/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

/metastore/tools/HiveMetaTool.java d0ff329 metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java PRE-CREATION Diff: https://reviews.apache.org/r/35803/diff/ Testing --- Testing has been done. Thanks, Aihua Xu

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

/metastore/TestObjectStore.java PRE-CREATION Diff: https://reviews.apache.org/r/35803/diff/ Testing (updated) --- Testing has been done. Thanks, Aihua Xu

Review Request 35323: HIVE-10972 DummyTxnManager always locks the current database in shared mode, which is incorrect.

://reviews.apache.org/r/35323/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35323: HIVE-10972 DummyTxnManager always locks the current database in shared mode, which is incorrect.

--- On June 10, 2015, 8:35 p.m., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35323

Re: Review Request 35323: HIVE-10972 DummyTxnManager always locks the current database in shared mode, which is incorrect.

e75a90a ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 4f86dd9 ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java 5abb729 Diff: https://reviews.apache.org/r/35323/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35323: HIVE-10972 DummyTxnManager always locks the current database in shared mode, which is incorrect.

On June 10, 2015, 8:44 p.m., Damien Carol wrote: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java, line 54 https://reviews.apache.org/r/35323/diff/1/?file=982259#file982259line54 Is this change connected to this bug? Aihua Xu wrote: Not directly related

Re: Review Request 34961: HIVE-10895: ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

. - Aihua Xu On June 2, 2015, 11:07 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34961/ --- (Updated

Review Request 35532: HIVE-11025 In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly

32471f2dc864c38a2969909efa5b21508e27d7f8 ql/src/test/queries/clientpositive/windowing_windowspec3.q 608a6cf45e3c1e0b928800dae0470e8acfd77734 ql/src/test/results/clientpositive/windowing_windowspec3.q.out 42c042f2cf80f0a5a8269ad9eb9864d7e76525cc Diff: https://reviews.apache.org/r/35532/diff/ Testing --- Thanks, Aihua

Re: Review Request 35532: HIVE-11025 In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly

/test/queries/clientpositive/windowing_windowspec3.q 608a6cf ql/src/test/results/clientpositive/windowing_windowspec3.q.out 42c042f Diff: https://reviews.apache.org/r/35532/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35532: HIVE-11025 In windowing spec, when the datatype is decimal, it's comparing the value against NULL value incorrectly

., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35532/ --- (Updated June 16, 2015, 8:13 p.m.) Review request

Review Request 35390: HIVE-10985 Value based windowing on timestamp and double can't handle NULL value

c87aaff2634efdd3e8861926582d4d1227312cde ql/src/test/results/clientpositive/windowing_windowspec3.q.out bf7797a2b1a91162795cc5c11eb3ffaaa02cab6d Diff: https://reviews.apache.org/r/35390/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35323: HIVE-10972 DummyTxnManager always locks the current database in shared mode, which is incorrect.

e75a90a ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 4f86dd9 ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java 5abb729 Diff: https://reviews.apache.org/r/35323/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35323: HIVE-10972 DummyTxnManager always locks the current database in shared mode, which is incorrect.

On June 11, 2015, 10:26 p.m., Aihua Xu wrote: Why do you think holding a Shared lock in user current database is a problem? it should not stop others from acquiring Shared locks on this table, right? Or are you expecting that others might want to acquire an Exclusive lock

Review Request 34716: HIVE-10826 Support min()/max() functions over x preceding and y preceding windowing

--- Thanks, Aihua Xu

Review Request 34815: HIVE-10834 Support First_value()/last_value() over x preceding and y preceding windowing

/clientpositive/windowing_windowspec2.q.out b187f35e493ee0c1d7a95c3c634e2b1ab790ecd0 Diff: https://reviews.apache.org/r/34815/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 34850: HIVE-10802 Table join query with some constant field in select fails

/test/results/clientpositive/spark/udf_in_file.q.out c5b6205 ql/src/test/results/clientpositive/udf_in_file.q.out b9d0d25 ql/src/test/results/clientpositive/udf_nondeterministic.q.out PRE-CREATION Diff: https://reviews.apache.org/r/34850/diff/ Testing --- Thanks, Aihua Xu

Review Request 34850: HIVE-10802 Table join query with some constant field in select fails

/clientpositive/udf_nondeterministic.q.out PRE-CREATION Diff: https://reviews.apache.org/r/34850/diff/ Testing --- Thanks, Aihua Xu

Review Request 36139: HIVE-11130 Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database object

lock table issue. Thanks, Aihua Xu

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

) --- Thanks, Aihua Xu

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

/#review89749 --- On June 26, 2015, 5:23 p.m., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803

Re: Review Request 36139: HIVE-11130 Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database object

--- On July 2, 2015, 5:24 p.m., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36139

Re: Review Request 36139: HIVE-11130 Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database object

to solve the explicit lock table issue. Thanks, Aihua Xu

Re: Review Request 34593: HIVE-10702 COUNT(*) over windowing 'x preceding and y preceding' doesn't work properly

://reviews.apache.org/r/34593/diff/ Testing --- Test has been done here https://issues.apache.org/jira/browse/HIVE-10702 Seems one test failed for unrelated reason. Thanks, Aihua Xu

Review Request 34593: HIVE-10702 COUNT(*) over windowing 'x preceding and y preceding' doesn't work properly

--- Test has been done here https://issues.apache.org/jira/browse/HIVE-10702 Seems one test failed for unrelated reason. Thanks, Aihua Xu

Re: Review Request 37150: HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x 0)

--- Thanks, Aihua Xu

Re: Review Request 37150: HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x 0)

ql/src/test/results/clientpositive/folder_predicate.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37150/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

a list of queryWrappers with each wrapper for a different listXXX call? If so, we need open eight queries for this removeRole methods. Could we use only one and reuse it? Aihua Xu wrote: Originally we were already using eight queries and I was not trying to change that logic

Re: Review Request 36893: HIVE-11258 The function drop_database_core() of HiveMetaStore.java may not drop all the tables

--- Thanks, Aihua Xu

Re: Review Request 36942: HIVE-11401: Predicate push down does not work with Parquet when partitions are in the expression

can show only the data from p1 are returned? Not completely follow the logic, but I'm worrying that p='p1' gets removed. - Aihua Xu On July 30, 2015, 9:22 p.m., Sergio Pena wrote: --- This is an automatically generated e-mail

Review Request 36893: HIVE-11258 The function drop_database_core() of HiveMetaStore.java may not drop all the tables

-11258 The function drop_database_core() of HiveMetaStore.java may not drop all the tables Diffs - metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ee2cea05fb3b4c9582b7b5ac9d5cd929d3b9ec1a Diff: https://reviews.apache.org/r/36893/diff/ Testing --- Thanks, Aihua

Re: Review Request 36893: HIVE-11258 The function drop_database_core() of HiveMetaStore.java may not drop all the tables

are right. I missed that. - Aihua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36893/#review93342 --- On July 28, 2015, 6:54 p.m., Aihua Xu

Re: Review Request 37096: HIVE-11451 SemanticAnalyzer throws IndexOutOfBounds Exception

/clientnegative/mismatch_columns_insertion.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37096/diff/ Testing --- Thanks, Aihua Xu

Review Request 37096: HIVE-11451 SemanticAnalyzer throws IndexOutOfBounds Exception

/mismatch_columns_insertion.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37096/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 37150: HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x 0)

--- On Aug. 6, 2015, 12:01 a.m., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37150

Review Request 37150: HIVE-11375 Broken processing of queries containing NOT (x IS NOT NULL and x 0)

/results/clientpositive/folder_predicate.q.out PRE-CREATION Diff: https://reviews.apache.org/r/37150/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 36506: HIVE-11255 get_table_objects_by_name() in HiveMetaStore.java needs to retrieve table objects in multiple batches

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36506/#review91837 --- On July 15, 2015, 1:30 p.m., Aihua Xu wrote

Re: Review Request 36506: HIVE-11255 get_table_objects_by_name() in HiveMetaStore.java needs to retrieve table objects in multiple batches

/hadoop/hive/metastore/HiveMetaStore.java 2ef5aa0 Diff: https://reviews.apache.org/r/36506/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 36139: HIVE-11130 Refactoring the code so that HiveTxnManager interface will support lock/unlock table/database object

to solve the explicit lock table issue. Thanks, Aihua Xu

Review Request 36506: HIVE-11255 get_table_objects_by_name() in HiveMetaStore.java needs to retrieve table objects in multiple batches

/metastore/HiveMetaStore.java 2ef5aa0706f7043639fcac38d058bec4289ee9a1 Diff: https://reviews.apache.org/r/36506/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 39735: HIVE-12215 Exchange partition does not show outputs field for post/pre execute hooks

/exchange_partition2.q.out 8c7c583 ql/src/test/results/clientpositive/exchange_partition3.q.out 3815861 ql/src/test/results/clientpositive/exchgpartition2lel.q.out 5997d6b Diff: https://reviews.apache.org/r/39735/diff/ Testing --- Thanks, Aihua Xu

Review Request 39735: HIVE-12215 Exchange partition does not show outputs field for post/pre execute hooks

/clientpositive/exchange_partition3.q.out 3815861dbae5606415ad6565522dd07e6f3f9bf4 Diff: https://reviews.apache.org/r/39735/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 39863: HIVE-12304 "drop database cascade" needs to unregister functions

-mail. To reply, visit: https://reviews.apache.org/r/39863/#review104748 ------- On Nov. 2, 2015, 4:56 p.m., Aihua Xu wrote: > > --- > This is an auto

Re: Review Request 39863: HIVE-12304 "drop database cascade" needs to unregister functions

op/hive/ql/exec/Registry.java 1121819 ql/src/test/queries/clientnegative/drop_database_cascade.q PRE-CREATION ql/src/test/results/clientnegative/drop_database_cascade.q.out PRE-CREATION Diff: https://reviews.apache.org/r/39863/diff/ Testing --- Thanks, Aihua Xu

Review Request 39863: HIVE-12304 "drop database cascade" needs to unregister functions

Testing --- Thanks, Aihua Xu

Review Request 36403: HIVE-11194 Exchange partition on external tables should fail with error message when target folder already exists

4c9cd7983400aa4490c54745acac6d2b28b17a53 ql/src/test/queries/clientnegative/exchange_partition.q PRE-CREATION ql/src/test/results/clientnegative/exchange_partition.q.out PRE-CREATION Diff: https://reviews.apache.org/r/36403/diff/ Testing --- Thanks, Aihua Xu

Review Request 37810: HIVE-10021 Alter index rebuild statements submitted through HiveServer2 fail when Sentry is enabled

/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9f8c756bed3811f04ec1dc8625f89724faab99ff Diff: https://reviews.apache.org/r/37810/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 37810: HIVE-10021 Alter index rebuild statements submitted through HiveServer2 fail when Sentry is enabled

--- On Aug. 26, 2015, 8:14 p.m., Aihua Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37810/ --- (Updated Aug

Re: Review Request 37810: HIVE-10021 Alter index rebuild statements submitted through HiveServer2 fail when Sentry is enabled

On Aug. 27, 2015, 8:57 p.m., Chao Sun wrote: Patch looks good. Just one question: instead of populating the user name in several places, is it possible to use the one stored in SessionState (by calling SessionState.get().getUserName() before creating the Driver)? Aihua Xu wrote

Re: Review Request 37810: HIVE-10021 Alter index rebuild statements submitted through HiveServer2 fail when Sentry is enabled

--- Thanks, Aihua Xu

Review Request 37963: HIVE-11617 Explain plan for multiple lateral views is very slow

, Aihua Xu

Re: Review Request 38009: HIVE-11696 Exception when table-level serde is Parquet while partition-level serde is JSON

/parquet_mixed_partition_formats.q PRE-CREATION ql/src/test/results/clientpositive/parquet_mixed_partition_formats.q.out PRE-CREATION Diff: https://reviews.apache.org/r/38009/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 38009: HIVE-11696 Exception when table-level serde is Parquet while partition-level serde is JSON

/parquet_mixed_partition_formats.q PRE-CREATION ql/src/test/results/clientpositive/parquet_mixed_partition_formats.q.out PRE-CREATION Diff: https://reviews.apache.org/r/38009/diff/ Testing --- Thanks, Aihua Xu

Review Request 38009: HIVE-11696 Exception when table-level serde is Parquet while partition-level serde is JSON

PRE-CREATION ql/src/test/results/clientpositive/parquet_mixed_partition_formats.q.out PRE-CREATION Diff: https://reviews.apache.org/r/38009/diff/ Testing --- Thanks, Aihua Xu

Review Request 38558: HIVE-11785 Support escaping carriage return and new line for LazySimpleSerDe

a5e4be4ef1b142af3b9000dab26603b98dbc3e84 Diff: https://reviews.apache.org/r/38558/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 40628: HIVE-12505: Insert overwrite in same encrypted zone silently fails to remove some existing files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40628/#review108724 --- Ship it! Ship It! - Aihua Xu On Dec. 2, 2015, 7:50 p.m

Re: Review Request 40887: HIVE-12574: windowing function returns incorrect result when the window size is larger than the partition size

-CREATION Diff: https://reviews.apache.org/r/40887/diff/ Testing --- Thanks, Aihua Xu

Review Request 40887: HIVE-12574: windowing function returns incorrect result when the window size is larger than the partition size

://reviews.apache.org/r/40887/diff/ Testing --- Thanks, Aihua Xu

Review Request 41984: HIVE-12762: Common join on parquet tables returns incorrect result when hive.optimize.index.filter set to true

splitting stage. rewriteLeaves is reimplemented to get all the unique leaves first and replace in place. Thanks, Aihua Xu

Review Request 40549: HIVE-12456: QueryId can't be stored in the configuration of the SessionState since multiple queries can run in a single session

8b4226522f1ff6c5c777fe372490f0fd157a3b2b service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0d978c04ce674dc06b1adc0cf3d8d5f984 Diff: https://reviews.apache.org/r/40549/diff/ Testing --- Thanks, Aihua Xu

Review Request 40550: HIVE-12406: HIVE-9500 introduced incompatible change to LazySimpleSerDe public interface (Aihua Xu)

-12406: HIVE-9500 introduced incompatible change to LazySimpleSerDe public interface (Aihua Xu) Diffs - serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 0a2f44cf890bdfc7f9efba4d80b818a1e2a7fae4 serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java

Re: Review Request 40549: HIVE-12456: QueryId can't be stored in the configuration of the SessionState since multiple queries can run in a single session

Diff: https://reviews.apache.org/r/40549/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 40549: HIVE-12456: QueryId can't be stored in the configuration of the SessionState since multiple queries can run in a single session

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40549/#review107399 --- On Nov. 20, 2015, 4:56 p.m., Aihua Xu wrote: > > ---

Re: Review Request 40549: HIVE-12456: QueryId can't be stored in the configuration of the SessionState since multiple queries can run in a single session

> On Nov. 20, 2015, 7:30 p.m., Mohit Sabharwal wrote: > > service/src/java/org/apache/hive/service/cli/operation/Operation.java, line > > 56 > > <https://reviews.apache.org/r/40549/diff/1/?file=1134612#file1134612line56> > > > > what does MDC sta

Re: Review Request 47787: HIVE-13453: Support ORDER BY and windowing clause in partitioning clause with distinct function

eviews.apache.org/r/47787/#review134784 ------- On May 24, 2016, 6:51 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 43332: HIVE-9534: incorrect result set for query that projects a windowed aggregate

://reviews.apache.org/r/43332/diff/ Testing --- Thanks, Aihua Xu

Review Request 43332: HIVE-9534: incorrect result set for query that projects a windowed aggregate

0858f0f38c977c77fd0fc9919094f48ebf3a09f3 Diff: https://reviews.apache.org/r/43332/diff/ Testing --- Thanks, Aihua Xu

Review Request 43192: HIVE-9534: incorrect result set for query that projects a windowed aggregate

/results/clientpositive/windowing_distinct.q.out 0858f0f38c977c77fd0fc9919094f48ebf3a09f3 Diff: https://reviews.apache.org/r/43192/diff/ Testing --- Similar to sum(distinct) and count(distinct) supported, add avg(distinct) in this patch. Thanks, Aihua Xu

Re: Review Request 43192: HIVE-9534: incorrect result set for query that projects a windowed aggregate

--- Similar to sum(distinct) and count(distinct) supported, add avg(distinct) in this patch. Thanks, Aihua Xu

Review Request 42858: HIVE-12944: Support SUM(DISTINCT) for partitioning query.

/test/queries/clientpositive/windowing_distinct.q 94f4044b8a491e9e13ebe7fd879fd49715860e94 ql/src/test/results/clientpositive/windowing_distinct.q.out 50f8ff81934c6a9338e74e9e6d4116d5f2b3ba4b Diff: https://reviews.apache.org/r/42858/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

webapps/static/js/tab.js (line 29) <https://reviews.apache.org/r/43008/#comment178465> Remove the spaces here and below. - Aihua Xu On Feb. 1, 2016, 8:05 p.m., Szehon Ho wrote: > > --- > This is an automatically gen

Re: Review Request 42777: HIVE-12550 : Cache and display last N completed queries in HS2 WebUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42777/#review116612 --- Ship it! Ship It! - Aihua Xu On Jan. 27, 2016, 7:38 p.m

Re: Review Request 42858: HIVE-12944: Support SUM(DISTINCT) for partitioning query.

/clientpositive/windowing_distinct.q.out 50f8ff8 Diff: https://reviews.apache.org/r/42858/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

ent. 3. We insert the distinct fields into the order by list, so during counting, we only need to compare the current row against the previous remembered row. Thanks, Aihua Xu

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

won't work with the functions of distinct due to performance concern and implementation requirement. 3. We insert the distinct fields into the order by list, so during counting, we only need to compare the current row against the previous remembered row. Thanks, Aihua Xu

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

https://reviews.apache.org/r/42508/#review116218 ------- On Jan. 25, 2016, 4:36 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-m

Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

won't work with the functions of distinct due to performance concern and implementation requirement. 3. We insert the distinct fields into the order by list, so during counting, we only need to compare the current row against the previous remembered row. Thanks, Aihua Xu

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

hash comparison is enough? Any better idea to make a copy? - Aihua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/#review115804 --------

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43008/#review117405 --- Ship it! Ship It! - Aihua Xu On Feb. 2, 2016, 12:22 a.m

Re: Review Request 44910: HIVE-13294: AvroSerde leaks the connection in a case when reading schema from a url

/AvroSerdeUtils.java (line 276) <https://reviews.apache.org/r/44910/#comment186156> nit: typo "//Ignore" serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java (line 280) <https://reviews.apache.org/r/44910/#comment186157> nit: remove the empty space here -

Review Request 47787: HIVE-13453: Support ORDER BY and windowing clause in partitioning clause with distinct function

/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java c58e8ed05453c78cbe2e4daf0b7afa51adbc0ce9 Diff: https://reviews.apache.org/r/47787/diff/ Testing --- Thanks, Aihua Xu

Re: Review Request 47353: HIVE-13616: Investigate renaming a table without invalidating the column stats

ly, visit: https://reviews.apache.org/r/47353/#review133446 ------- On May 17, 2016, 1:25 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47353: HIVE-13616: Investigate renaming a table without invalidating the column stats

the table, the patch 1. Save affected column stats 2. Rename the table 3. Write the saved column stats for the new table. In this order, column stats will find the foreign key when writing in 3). Thanks, Aihua Xu

  1   2   3   4   5   6   7   >