Nov. 18, 2014, 7:21 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
---
HIVE-8435
Patch with the most conservative approach of project remover optimization.
Diffs
-
common/src/java/org/apache/hadoop/hive/conf
shims/pom.xml d43086f
Diff: https://reviews.apache.org/r/27895/diff/
Testing
---
Existing tests. Refactoring patch.
Thanks,
Ashutosh Chauhan
.
Thanks,
Ashutosh Chauhan
. Refactoring patch.
Thanks,
Ashutosh Chauhan
://reviews.apache.org/r/27895/diff/
Testing
---
Existing tests. Refactoring patch.
Thanks,
Ashutosh Chauhan
tests. Refactoring patch.
Thanks,
Ashutosh Chauhan
/
Testing
---
Existing tests. Refactoring patch.
Thanks,
Ashutosh Chauhan
---
Existing tests. Refactoring patch.
Thanks,
Ashutosh Chauhan
://reviews.apache.org/r/27895/#review62947
---
On Nov. 25, 2014, 2:59 p.m., Ashutosh Chauhan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/DelegationTokenSelector.java
83257f5
shims/pom.xml 48bb421
Diff: https://reviews.apache.org/r/28520/diff/
Testing
---
Refactoring patch. Existing tests.
Thanks,
Ashutosh Chauhan
/test/results/clientpositive/windowing_streaming.q.out be97b61
Diff: https://reviews.apache.org/r/28632/diff/
Testing
---
existing tests.
Thanks,
Ashutosh Chauhan
/test/results/clientpositive/windowing_streaming.q.out be97b61
Diff: https://reviews.apache.org/r/28632/diff/
Testing
---
existing tests.
Thanks,
Ashutosh Chauhan
://reviews.apache.org/r/28787/diff/
Testing
---
existing tests
Thanks,
Ashutosh Chauhan
://reviews.apache.org/r/28787/diff/
Testing
---
existing tests
Thanks,
Ashutosh Chauhan
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28791/
---
(Updated Dec. 7, 2014, 9:30 a.m.)
Review request for hive, Ashutosh Chauhan
greater than one?
Ashutosh Chauhan wrote:
yeah.. I think its a good idea to add testcase for this which reproduces
the bug. [~tedxu] For having more than 1 reducer in tests, you need to run
it through TestMinimrCliDriver. To achieve that, add name of your new test in
itests/src/test
/vectorized_dynamic_partition_pruning.q.out
fd380fa
ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out 3c5b267
ql/src/test/results/clientpositive/tez/vectorized_shufflejoin.q.out 726ac93
Diff: https://reviews.apache.org/r/2/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh
---
Existing tests.
Thanks,
Ashutosh Chauhan
can ignore those for
now.
- Ashutosh Chauhan
On Dec. 10, 2014, 6:09 p.m., Ted Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28791
://reviews.apache.org/r/29552/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29800/#review69402
---
Ship it!
Ship It!
- Ashutosh Chauhan
On Jan. 23, 2015, 5:41 a.m
/groupby_multi_insert_common_distinct.q.out
c2766f8
ql/src/test/results/clientpositive/union17.q.out 75d2253
Diff: https://reviews.apache.org/r/30602/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/clientpositive/spark/groupby9.q.out 9b5095a
ql/src/test/results/clientpositive/spark/groupby_multi_insert_common_distinct.q.out
c2766f8
ql/src/test/results/clientpositive/union17.q.out 75d2253
Diff: https://reviews.apache.org/r/30602/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30549/#review70897
---
Ship it!
Ship It!
- Ashutosh Chauhan
On Feb. 4, 2015, 1:43 a.m
/groupby_multi_insert_common_distinct.q.out
c2766f8
ql/src/test/results/clientpositive/union17.q.out 75d2253
Diff: https://reviews.apache.org/r/30602/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/clientpositive/spark/groupby_multi_insert_common_distinct.q.out
c2766f8
ql/src/test/results/clientpositive/union17.q.out 75d2253
Diff: https://reviews.apache.org/r/30602/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
Done. I have removed two offending ids from list.
On Wed, Jan 21, 2015 at 3:22 PM, Nick Dimiduk ndimi...@gmail.com wrote:
Seriously, these guys are still spamming this list? Why hasn't the dev-list
admin booted these receivers yet? It's been *months*.
On Wed, Jan 21, 2015 at 3:19 PM,
/infer_bucket_sort_grouping_operators.q.out
https://reviews.apache.org/r/29878/#comment112675
seems like agg column should not be present there? Can you check?
- Ashutosh Chauhan
On Jan. 14, 2015, 9:13 a.m., Navis Ryu wrote:
---
This is an automatically generated e-mail
+1
With so much active development in different areas of project, proposal
makes sense.
On Wed, Feb 11, 2015 at 8:49 AM, Alan Gates alanfga...@gmail.com wrote:
+1
Alan.
Vikram Dixit K vikram.di...@gmail.com
February 9, 2015 at 14:43
Hi Folks,
We seem to have quite a few projects
https://reviews.apache.org/r/30779/#comment118919
Didn't follow whats the bug here? Why the condition in if will ever be true?
- Ashutosh Chauhan
On Feb. 9, 2015, 1:58 a.m., Navis Ryu wrote:
---
This is an automatically generated e
Seems like there is consensus all around.
Vikram,
would you like to update the wiki with new bylaws?
Thanks,
Ashutosh
On Wed, Feb 18, 2015 at 8:58 AM, Prasad Mujumdar pras...@apache.org wrote:
+1
thanks
Prasad
On Mon, Feb 9, 2015 at 2:43 PM, Vikram Dixit K vikram.di...@gmail.com
Hi all,
Some of us are wanting to do a new round of improvements for Cost Based
Optimizer. Mainly related to but not limited to :
https://issues.apache.org/jira/browse/HIVE-9132 Since there may be
potentially disruptive changes idea is to do them in branch. For example we
may depend on calcite
This is what we have been doing for cbo work. e.g.
https://issues.apache.org/jira/browse/HIVE-9581
On Thu, Feb 19, 2015 at 11:17 AM, Thejas Nair thejas.n...@gmail.com wrote:
I agree, using a label for fix version makes sense in this case. I believe
that is what had been done for hive-on-spark
such parsing. Will be good to reuse that, if available.
- Ashutosh Chauhan
On Jan. 20, 2015, 12:34 a.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29898
/vectorized_ptf.q.out 75c8144
Diff: https://reviews.apache.org/r/30151/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/clientpositive/varchar_serde.q.out 5f3f2ed
serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 38e8b77
Diff: https://reviews.apache.org/r/30422/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
ql/src/test/results/clientpositive/varchar_serde.q.out 5f3f2ed
serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 38e8b77
Diff: https://reviews.apache.org/r/30422/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/clientpositive/vector_bucket.q.out 952c033
ql/src/test/results/clientpositive/vectorized_ptf.q.out 75c8144
Diff: https://reviews.apache.org/r/30151/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29898/#review70512
---
Ship it!
Ship It!
- Ashutosh Chauhan
On Jan. 31, 2015, 2:25 a.m
Diff: https://reviews.apache.org/r/30151/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
On Jan. 28, 2015, 1:22 a.m., Ashutosh Chauhan wrote:
common/pom.xml, lines 59-63
https://reviews.apache.org/r/29898/diff/2/?file=825966#file825966line59
Since joda jar will be shipped to task nodes, this needs to be added in
hive-exec jar. I think we keep that list in one
---
On Jan. 29, 2015, 2:22 a.m., Ashutosh Chauhan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30151
/vectorized_nested_mapjoin.q.out 74983ee
Diff: https://reviews.apache.org/r/29611/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
Hi all,
Hive started out as Hadoop subproject. That time Hadoop's jira is used to
track Hive's bugs and features. As I try to find lineage of some very old
code in Hive, I sometimes end up on those jiras. It will be nice to move
those issues from Hadoop to Hive so that its easy to search as all
trunk/ql/src/test/results/clientpositive/vectorized_context.q.out 1650812
Diff: https://reviews.apache.org/r/29795/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/results/clientpositive/vector_decimal_udf.q.out 102fd07
Diff: https://reviews.apache.org/r/31041/diff/
Testing
---
Existing tests and also added a new test.
Thanks,
Ashutosh Chauhan
/
Testing
---
Refactor patch. Existing tests.
Thanks,
Ashutosh Chauhan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31696/#review76772
---
Ship it!
Ship It!
- Ashutosh Chauhan
On March 17, 2015, 6:37
/r/31696/#comment124370
Constant folding kicked in. Cool!
- Ashutosh Chauhan
On March 12, 2015, 7:50 p.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31696
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32314/#review77279
---
Ship it!
Ship It!
- Ashutosh Chauhan
On March 20, 2015, 6:06
://reviews.apache.org/r/31807/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
---
existing tests.
Thanks,
Ashutosh Chauhan
/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/java/org/apache/hadoop/hive/ql/exec/tez/explain/Vertex.java
https://reviews.apache.org/r/32406/#comment126968
Similar comment about state being with printer.
- Ashutosh Chauhan
On March 26, 2015, 8:10 p.m., pengcheng xiong wrote
/diff/
Testing
---
existing tests.
Thanks,
Ashutosh Chauhan
/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 38e8b77
Diff: https://reviews.apache.org/r/30422/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
Awesome work, Sergio!
Much appreciated.
Thanks for doing this,
Ashutosh
On Mon, Mar 23, 2015 at 4:17 PM, Sergio Pena sergio.p...@cloudera.com
wrote:
Hi All,
I configured a new jenkins job that will run HMS upgrade tests whenever a
change on metastore/scripts/upgrade/ files is detected.
/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
Hi all,
Seems like Hive QA is still doing checkouts from locked down svn repo for
running tests. When I went to configure page of jenkins job, it doesn't
list git as an option in Source code management section. Does anyone know
if git repo is supported there? And if so, how to enable it?
Thanks,
are they already turned off because of git transition? I tried a commit on
svn trunk today morning and got access denied exception. Any one else
getting this exception?
If it indeed is because of git transition, do any one know when commits on
git repo will be enabled?
yeah.. make sense. No one need to ask for 'permission' to work on an issue.
On Sat, May 2, 2015 at 12:59 PM, Szehon Ho sze...@cloudera.com wrote:
It makes sense to me, it can always be reassigned.
Thanks
Szehon
On Fri, May 1, 2015 at 1:53 PM, Thejas Nair thejas.n...@gmail.com wrote:
I
/src/test/results/clientpositive/fold_case.q.out PRE-CREATION
ql/src/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75
Diff: https://reviews.apache.org/r/33814/diff/
Testing
---
New tests added.
Thanks,
Ashutosh Chauhan
I think its time to discuss about dropping support for Hadoop-1 line. What
do folks think about Hive-1.2 being last release supporting Hadoop-1 line?
Thanks,
Ashutosh
On Tue, Apr 28, 2015 at 11:02 AM, Alexander Pivovarov apivova...@gmail.com
wrote:
Hi Everyone
I tried to compile the latest
test.
Thanks,
Ashutosh Chauhan
d815938
ql/src/test/results/clientpositive/tez/vectorized_distinct_gby.q.out 90c9934
Diff: https://reviews.apache.org/r/33882/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/test/results/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75
Diff: https://reviews.apache.org/r/33814/diff/
Testing
---
New tests added.
Thanks,
Ashutosh Chauhan
,
Ashutosh Chauhan
Harish has done some good work for popular use-case of windowing on
https://issues.apache.org/jira/browse/HIVE-7062 which are available from
0.14 onwards. Will that be useful in your scenario? Or, are you targeting
non-windowing PTFs?
Thanks,
Ashutosh
On Thu, May 7, 2015 at 6:43 AM,
/clientpositive/ql_rewrite_gbtoidx_cbo_2.q.out 6340a75
Diff: https://reviews.apache.org/r/33814/diff/
Testing
---
New tests added.
Thanks,
Ashutosh Chauhan
such a case.
- Ashutosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33814/#review82652
---
On May 6, 2015, 6:35 a.m., Ashutosh Chauhan
/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
/AbstractPrimitiveObjectInspector.java
baa4a94
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableVoidObjectInspector.java
f3f4838
Diff: https://reviews.apache.org/r/34001/diff/
Testing
---
Refactoring patch. Existing regression tests will suffice.
Thanks,
Ashutosh Chauhan
here.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java
https://reviews.apache.org/r/34040/#comment134166
d can't be null here.
- Ashutosh Chauhan
On May 11, 2015, 2:24 p.m., Aihua Xu wrote
ql/src/test/results/clientpositive/fold_case.q.out de6c43e
ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 45a0cb1
ql/src/test/results/clientpositive/fold_when.q.out 51d4767
Diff: https://reviews.apache.org/r/34249/diff/
Testing
---
New tests.
Thanks,
Ashutosh
Diff: https://reviews.apache.org/r/34385/diff/
Testing
---
Thanks,
Ashutosh Chauhan
/clientpositive/vectorized_ptf.q.out 7ffb8bd
ql/src/test/results/clientpositive/windowing_streaming.q.out 9fee6d0
Diff: https://reviews.apache.org/r/5/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
?
-Ashutosh
On Mon, Mar 23, 2015 at 4:38 PM, Ashutosh Chauhan hashut...@apache.org
wrote:
Awesome work, Sergio!
Much appreciated.
Thanks for doing this,
Ashutosh
On Mon, Mar 23, 2015 at 4:17 PM, Sergio Pena sergio.p...@cloudera.com
wrote:
Hi All,
I configured a new jenkins job
://reviews.apache.org/r/31041/diff/
Testing
---
Existing tests and also added a new test.
Thanks,
Ashutosh Chauhan
/src/test/results/clientpositive/tez/hybridgrace_hashjoin_2.q.out
https://reviews.apache.org/r/34143/#comment135747
GBy followed by gby has double the # of rows. Expected it to go lower.
- Ashutosh Chauhan
On May 14, 2015, 4:50 p.m., pengcheng xiong wrote
. expected to remain constant.
ql/src/test/results/clientpositive/spark/union30.q.out
https://reviews.apache.org/r/34143/#comment135688
cascade of select operator. With each one increasing # of rows, looks wrong.
- Ashutosh Chauhan
On May 14, 2015, 4:50 p.m., pengcheng xiong wrote
/34385/#comment135641
Ok, will update the exception message.
- Ashutosh Chauhan
On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34385
/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
48f34a9
Diff: https://reviews.apache.org/r/34385/diff/
Testing
---
Thanks,
Ashutosh Chauhan
/vector/VectorizationContext.java
48f34a9
Diff: https://reviews.apache.org/r/34385/diff/
Testing
---
Thanks,
Ashutosh Chauhan
f08321c
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
48f34a9
Diff: https://reviews.apache.org/r/34385/diff/
Testing
---
Thanks,
Ashutosh Chauhan
d90b27f
ql/src/test/results/clientpositive/tez/vectorization_limit.q.out 1c5b51f
Diff: https://reviews.apache.org/r/34515/diff/
Testing
---
Existing tests.
Thanks,
Ashutosh Chauhan
https://reviews.apache.org/r/35218/#comment139389
It will be good to add PartitionSpec as well as WindowFrameSpec in
toString() (with null checks)
- Ashutosh Chauhan
On June 8, 2015, 6:33 p.m., Aihua Xu wrote
/#comment138919
Can you add few rows with NULL value for date column? Want to make sure
DateValueBoundaryScanner.isGreater() and isEqual() methods are null resilient.
- Ashutosh Chauhan
On June 5, 2015, 3:46 p.m., Aihua Xu wrote
/diff/
Testing
---
Added new test pre-existing ones.
Thanks,
Ashutosh Chauhan
/ReduceRecordSource.java
cdabe3a
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java
99cb620
Diff: https://reviews.apache.org/r/35930/diff/
Testing
---
Regression suite.
Thanks,
Ashutosh Chauhan
On June 17, 2015, 4:08 p.m., Ashutosh Chauhan wrote:
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java,
line 1240
https://reviews.apache.org/r/35532/diff/1/?file=985909#file985909line1240
This doesn't seem right. isGreater() (as oppose to isEqual
, it will still
return v1 v2. Either NULLs should always be greater or always be smaller,
otherwise this has potential to generate incorrect result set.
- Ashutosh Chauhan
On June 16, 2015, 8:13 p.m., Aihua Xu wrote:
---
This is an automatically
/clientpositive/union_remove_7.q.out 76c678f
ql/src/test/results/clientpositive/union_remove_8.q.out fe67448
ql/src/test/results/clientpositive/union_remove_9.q.out 684091b
Diff: https://reviews.apache.org/r/34713/diff/
Testing
---
Existing tests + added new tests
Thanks,
Ashutosh Chauhan
Are you running pre-0.12 or with hive.metastore.try.direct.sql = false;
Work done on https://issues.apache.org/jira/browse/HIVE-4051 should
alleviate some of your problems.
On Mon, May 25, 2015 at 8:19 PM, Sivaramakrishnan Narayanan
tarb...@gmail.com wrote:
Apologies if this has been
a dynamic proxy class over the metastore client class which does
whatever you need it to. Similar technique could work in the server side -
I believe there is already a RetryingMetaStoreClient proxy class in place.
On Wed, May 27, 2015 at 7:32 AM, Ashutosh Chauhan hashut...@apache.org
wrote
/StatsUtils.java ad481bc
ql/src/test/queries/clientpositive/stats_only_null.q a91022c
ql/src/test/results/clientpositive/tez/stats_only_null.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/34754/diff/
Testing
---
Modified existing test to increase its coverage.
Thanks,
Ashutosh
/
Testing
---
Existing tests + added new tests
Thanks,
Ashutosh Chauhan
,
Ashutosh Chauhan
/apache/hadoop/hive/shims/Hadoop23Shims.java
e5be8d6
Diff: https://reviews.apache.org/r/37635/diff/
Testing
---
Thanks,
Ashutosh Chauhan
/org/apache/hadoop/hive/shims/Hadoop20SShims.java
a56309f
shims/0.23/pom.xml 060dd17
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
e5be8d6
Diff: https://reviews.apache.org/r/37635/diff/
Testing
---
Thanks,
Ashutosh Chauhan
approach is better… +1
Can you create a detailed instruction?
Is it enforceable in git?
On 15/7/10, 11:08, Ashutosh Chauhan hashut...@apache.org wrote:
There was a problem of attributing contributions correctly back when we
were using svn, now that we are on git, that problem can
501 - 600 of 8395 matches
Mail list logo
