Would like to see HIVE-4844 make it in if possible.
Thanks,
Jason
On Aug 29, 2013, at 10:31 PM, Eugene Koifman ekoif...@hortonworks.com wrote:
I think we should make sure that several items under HIVE-4869 get checked
in before branching.
Eugene
On Thu, Aug 29, 2013 at 9:18 PM, Thejas
I notice that in the Jiras where I add NO PRECOMMIT TESTS, if I remove that
line from the description and upload a patch the pre commit build system still
won't pick up this patch for testing. For example, in the build output:
+ JIRA_TEXT=/tmp/tmp.voD5s6RxFu
+ trap 'rm -f /tmp/tmp.voD5s6RxFu'
be moved here since they are all varchar-specific now.
- Jason Dere
On Oct. 4, 2013, 2:07 p.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14490
qualified with
precision/scale?
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
https://reviews.apache.org/r/14674/#comment52747
remove or convert to log statement
- Jason Dere
On Oct. 16, 2013, 5:06 p.m., Xuefu Zhang wrote
to HiveDecimal and back to
HiveDecimalWritable on every call to getWritableConstantValue().
- Jason Dere
On Oct. 16, 2013, 5:06 p.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
that
the precision/scale is preserved correctly for ORC.
- Jason Dere
On Oct. 28, 2013, 4:49 a.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14985
On Oct. 28, 2013, 7:38 p.m., Xuefu Zhang wrote:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java, line 548
https://reviews.apache.org/r/14985/diff/1/?file=372080#file372080line548
This is a valid concern. However, there is no way to preserve
previous precision/scale,
a table. So all of these instances of convert() from all of these UDFs
needs to be changed.
Please also add tests to verify the result TypeInfo of the the arithmetic
operations using various different types.
- Jason Dere
On Oct. 31, 2013, 5:43 a.m., Xuefu Zhang wrote
Xuefu, congrats!
On Nov 4, 2013, at 9:53 AM, Vaibhav Gumashta vgumas...@hortonworks.com wrote:
Congrats Xuefu!
On Mon, Nov 4, 2013 at 9:17 AM, Prasad Mujumdar pras...@cloudera.comwrote:
Congratulations Xuefu!
thanks
Prasad
On Sun, Nov 3, 2013 at 8:06 PM, Carl Steinbach
/HiveDecimalUtils.java
https://reviews.apache.org/r/15113/#comment54714
Same as previous comment.
- Jason Dere
On Nov. 3, 2013, 7:26 p.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
numericTypePriority and how numeric types are resolved.
- Jason Dere
On Nov. 3, 2013, 7:26 p.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113
patch. So I don't think a qfile test is
the right thing here - how about doing a JUnit to directly test the
TypeInfoParser behavior? Using the example above you can test the typestring
decimal(4,2):decimal(5):decimal and see if you get the correct TypeInfos back.
- Jason Dere
On Nov. 7, 2013
/HadoopShimsSecure.java
fd0d526
shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java
62ff878
Diff: https://reviews.apache.org/r/15373/diff/
Testing
---
Thanks,
Jason Dere
://reviews.apache.org/r/15375/diff/
Testing
---
Thanks,
Jason Dere
, I don't see any
need to modify this part of the diff. V4 is in this file, it's not missing.
- Jason Dere
On Nov. 8, 2013, 11:05 p.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15375/#review28616
---
On Nov. 8, 2013, 11:05 p.m., Jason Dere wrote
---
Thanks,
Jason Dere
/#comment55926
If you are allowing numeric value to timestamp conversion, not sure if it
needs to be so strict that it returns null because of the nanos. Looks like
TimestampWritable.decimalToTimestamp() behavior isn't so strict.
- Jason Dere
On Oct. 30, 2013, 10:05 p.m., Venki Korukanti wrote
: (c1 / c1)
type: decimal(23,13)
expr: (c1 / c2)
type: decimal(20,9)
This is looking good, just the one issue about result precision/scale when both
left/right operands are the same.
- Jason Dere
On Nov. 14, 2013, 8:44
Congrats Harish!
On Nov 14, 2013, at 5:17 PM, Carl Steinbach c...@apache.org wrote:
I am pleased to announce that Harish Butani has been elected to the Hive
Project Management Committee. Please join me in congratulating Harish!
Thanks.
Carl
--
CONFIDENTIALITY NOTICE
NOTICE: This
ql/src/test/results/clientpositive/udf_when.q.out 367f48a
Diff: https://reviews.apache.org/r/15607/diff/
Testing
---
Thanks,
Jason Dere
/operation/GetTypeInfoOperation.java
2daa9cd
Diff: https://reviews.apache.org/r/15666/diff/
Testing
---
Thanks,
Jason Dere
size for
the given column. For numeric data, this is the maximum precision. For
character data, this is the length in characters. For datetime datatypes, this
is the length in characters of the String representation
- Jason Dere
On Nov. 19, 2013, 3:28 a.m., Jason Dere wrote
Congrats!
On Nov 22, 2013, at 2:25 AM, Biswajit Nayak biswajit.na...@inmobi.com wrote:
Congrats to both of you..
On Fri, Nov 22, 2013 at 1:26 PM, Lefty Leverenz leftylever...@gmail.com
wrote:
Congratulations, Jitendra and Eric! The more the merrier.
-- Lefty
On Thu, Nov 21,
the return type.
- Jason Dere
On Nov. 22, 2013, 9:42 p.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15804
://reviews.apache.org/r/15896/diff/
Testing
---
Thanks,
Jason Dere
://reviews.apache.org/r/16008/#comment57222
How do the code changes in sum/average contribute to this change in the
test results for floor()? Was the diff generated on a branch that had other
changes on it?
Changes look good.
- Jason Dere
On Dec. 4, 2013, 7:31 p.m., Xuefu Zhang wrote
() if you want to get bytes from the string. Or just do the padding
as Strings.
- Jason Dere
On Dec. 18, 2013, 3:16 a.m., Mohammad Islam wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/org/apache/hadoop/hive/shims/HadoopShims.java
697d4b7
Diff: https://reviews.apache.org/r/24439/diff/
Testing
---
Thanks,
Jason Dere
/HadoopThriftAuthBridge23.java
https://reviews.apache.org/r/24460/#comment87397
May want to initialize SASL_PROPS_FIELD. In the case that
SASL_PROPERTIES_RESOLVER_CLASS != null, SASL_PROPS_FIELD is never initialized,
but we check the value at line 69.
- Jason Dere
On Aug. 7, 2014, 5:49 p.m., Thejas
,
Jason Dere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24460/#review50648
---
Ship it!
Ship It!
- Jason Dere
On Aug. 14, 2014, 9:07 p.m
://reviews.apache.org/r/24472/diff/
Testing
---
Thanks,
Jason Dere
/HiveAuthorizationTaskFactoryImpl.java
https://reviews.apache.org/r/25037/#comment90005
Does this affect the role names seen by the other (non-SQL Std)
authorizers? Would they now be responsible for handling any case-sensitivity
issues as a result of this change?
- Jason Dere
On Aug. 25, 2014, 9
() and SessionHiveMetaStoreClient.dropTempTable()
both call Warehouse.isWritable(), but this functionality in this method may be
more appropriate.
- Jason Dere
On Aug. 27, 2014, 10:30 p.m., Thejas Nair wrote:
---
This is an automatically generated e-mail. To reply
---
On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24472/
---
(Updated Aug. 26, 2014, 6:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24472/#review51762
---
On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote
://reviews.apache.org/r/24472/#review51754
---
On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/SessionHiveMetaStoreClient.java
https://reviews.apache.org/r/24472/#comment90424
This is wrong - deleting all stats on a table when we only want to delete
stats for one column. Will fix.
- Jason Dere
On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote
to
columnstats_partlvl.q
Jason Dere wrote:
Not currently supporting partitioned temp tables.
Prasanth_J wrote:
Will it throw an exception in that case? If so can you add a
NegativeCliDriver test just to make sure it throws some exception if used
with partitioned tables.
Yep, there is already
?
Jason Dere wrote:
FieldSchema.equals() also compares the column comment, which could be
changed during alter table. If just the column comment changed the columns
are still relatively similar.
Prasanth_J wrote:
Can you add equalsIgnoreComment() to FieldSchema then?
Unfortunately
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25125/#review51862
---
Ship it!
Ship It!
- Jason Dere
On Aug. 28, 2014, 8:16 p.m
/temp_table_column_stats.q.out 486597a
ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/24472/diff/
Testing
---
Thanks,
Jason Dere
-CREATION
Diff: https://reviews.apache.org/r/25320/diff/
Testing
---
New qfile test added
Thanks,
Jason Dere
we also use implicitConvertable() here?
- Jason Dere
On July 9, 2014, 6:57 a.m., Navis Ryu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23352
/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
734b9d8
Diff: https://reviews.apache.org/r/25524/diff/
Testing
---
New q file test
Thanks,
Jason Dere
Diff: https://reviews.apache.org/r/25524/diff/
Testing
---
New q file test
Thanks,
Jason Dere
/WritableHiveVarcharObjectInspector.java
7bbfd1f
Diff: https://reviews.apache.org/r/25524/diff/
Testing
---
New q file test
Thanks,
Jason Dere
/#review53197
---
On Sept. 3, 2014, 11:57 p.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25320
/GenericUDFBaseNumeric.java
https://reviews.apache.org/r/17302/#comment67253
This method (deriveResultApproxTypeInfo) would not get called for 2
decimals - deriveResultExactTypeInfo() would be called.
- Jason Dere
On Feb. 7, 2014, 12:13 a.m., Jason Dere wrote
://reviews.apache.org/r/17302/diff/
Testing
---
Thanks,
Jason Dere
Would like to get these in, if possible:
HIVE-6012 restore backward compatibility of arithmetic operations
HIVE-6434 Restrict function create/drop to admin roles
On Mar 5, 2014, at 5:41 PM, Navis류승우 navis@nexr.com wrote:
I have really big wish list(65 pending) but it would be time to
Would like to get these in, if possible:
HIVE-6012 restore backward compatibility of arithmetic operations
HIVE-6434 Restrict function create/drop to admin roles
On Mar 5, 2014, at 5:41 PM, Navis류승우 navis@nexr.com wrote:
I have really big wish list(65 pending) but it would be time to
Noticed this since internally we set the version number to something different
than simply 0.13.0, and mvn version:set doesn't really work correctly with
itests because itests isn't listed as one of the root POM's submodules. Is
there a particular reason for it not being listed as a submodule
/#comment68389
why is this removed?
- Jason Dere
On March 12, 2014, 4:49 p.m., Ashutosh Chauhan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18992
On March 13, 2014, 7:38 p.m., Ashutosh Chauhan wrote:
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java, line 454
https://reviews.apache.org/r/18992/diff/2/?file=517499#file517499line454
Can I do that cleanup in a followup? Tests have ran already once and I
dont when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18992/#review37111
---
Ship it!
- Jason Dere
On March 12, 2014, 4:49 p.m., Ashutosh
dc259c6
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 384ce4e
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestamp.java
PRE-CREATION
Diff: https://reviews.apache.org/r/19212/diff/
Testing
---
Thanks,
Jason Dere
/#review37177
---
On March 14, 2014, 2:40 a.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19212
for
arguments[0]?
Or the converter will handle it and return 'null'.
Jason Dere wrote:
I'll add the testcase for this, and we'll find out :)
It does work fine, but probably for the best to have that null check in there
as well.
- Jason
-CREATION
Diff: https://reviews.apache.org/r/19212/diff/
Testing
---
Thanks,
Jason Dere
://reviews.apache.org/r/19329/#comment69047
I'm sure Lefty will mention this too, I believe new config settings also
should have updated entry in conf/hive-default.xml.template.
- Jason Dere
On March 17, 2014, 11:25 p.m., Ashutosh Chauhan wrote
/clientpositive/groupby_resolution.q.out 7970df5
Diff: https://reviews.apache.org/r/19334/diff/
Testing
---
Thanks,
Jason Dere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19329/#review37543
---
Ship it!
- Jason Dere
On March 17, 2014, 11:57 p.m., Ashutosh
/WindowFunctionInfo.java f136500
Diff: https://reviews.apache.org/r/19435/diff/
Testing
---
Manually tested with hiveserver2
Thanks,
Jason Dere
/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java 46153e0
Diff: https://reviews.apache.org/r/19447/diff/
Testing
---
Thanks,
Jason Dere
/jdbc/miniHS2/MiniHS2.java
d76750c
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b7da95e
Diff: https://reviews.apache.org/r/19623/diff/
Testing
---
test added
Thanks,
Jason Dere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19705/#review38675
---
Ship it!
Ship It!
- Jason Dere
On March 26, 2014, 11:08 p.m
/TestExecDriver.java 5991aae
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java
e453f56
Diff: https://reviews.apache.org/r/16403/diff/
Testing
---
Thanks,
Jason Dere
that change.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16403/#review39243
---
On April 2, 2014, 2:11 a.m., Jason Dere wrote
., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16403/
---
(Updated April 2, 2014, 2:11 a.m.)
Review request
/vectorized_timestamp_funcs.q.out c964692
Diff: https://reviews.apache.org/r/19978/diff/
Testing
---
Thanks,
Jason Dere
91efb58
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java
e453f56
Diff: https://reviews.apache.org/r/16403/diff/
Testing
---
Thanks,
Jason Dere
c3121e5
ql/src/test/results/clientpositive/vectorized_rcfile_columnar.q.out b44c296
ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out c964692
Diff: https://reviews.apache.org/r/19978/diff/
Testing
---
Thanks,
Jason Dere
0008ae5
ql/src/test/queries/clientpositive/tez_insert_overwrite_local_directory_1.q
d7a652f
ql/src/test/results/clientpositive/scriptfile1_win.q.out dfaa057
Diff: https://reviews.apache.org/r/20472/diff/
Testing
---
Thanks,
Jason Dere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20103/#review40839
---
Ship it!
Ship It!
- Jason Dere
On April 19, 2014, 12:06 a.m
Congrats! Nice job guys!
On Apr 25, 2014, at 10:38 AM, Selina Zhang seli...@yahoo-inc.com wrote:
Congratulations!
Selina
On 4/25/14, 10:35 AM, Prasad Mujumdar pras...@cloudera.com wrote:
Congratulations !!
thanks
Prasad
On Thu, Apr 24, 2014 at 7:33 PM, Carl Steinbach
by the deleted
test.
- Jason Dere
On May 2, 2014, 6:19 p.m., Ashutosh Chauhan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21016
Looking into some code cleanup and question of these SerDes/InputFormats came
up. Are these still ones that are being used by folks?
DynamicSerDe
SymlinkTextInputFormat
If there is not much usage then we could try to set them as deprecated, so they
could be removed in a future release.
://reviews.apache.org/r/16403/diff/
Testing
---
Thanks,
Jason Dere
Congrats Vikram!
On Jan 6, 2014, at 11:10 AM, Prasanth Jayachandran
pjayachand...@hortonworks.com wrote:
Congratulations Vikram!!
Thanks
Prasanth Jayachandran
On Jan 6, 2014, at 11:50 PM, Eugene Koifman ekoif...@hortonworks.com wrote:
Congratulations!
On Mon, Jan 6, 2014 at 9:44
/windowing_invalid_udaf.q.out PRE-CREATION
ql/src/test/results/clientpositive/windowing_udaf2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/16921/diff/
Testing
---
Added positive/negative test
Thanks,
Jason Dere
://reviews.apache.org/r/17200/diff/
Testing
---
Thanks,
Jason Dere
6193257
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java
702e3e7
Diff: https://reviews.apache.org/r/17302/diff/
Testing
---
Thanks,
Jason Dere
and Jason!
Thanks
Vikram.
On Jan 27, 2014, at 8:36 AM, Carl Steinbach wrote:
The Apache Hive PMC has voted to make Sergey Shelukhin and Jason Dere
committers on the Apache Hive Project.
Please join me in congratulating Sergey and Jason!
Thanks.
Carl
/clientnegative/udf_invalid.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_qualified_name.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/17493/diff/
Testing
---
Thanks,
Jason Dere
/drop_func_nonexistent.q.out PRE-CREATION
ql/src/test/results/clientpositive/create_func1.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/17494/diff/
Testing
---
Thanks,
Jason Dere
/clientnegative/create_function_nonudf_class.q.out
PRE-CREATION
ql/src/test/results/clientnegative/drop_func_nonexistent.q.out PRE-CREATION
ql/src/test/results/clientpositive/create_func1.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/17494/diff/
Testing
---
Thanks,
Jason Dere
---
On Jan. 24, 2014, 2:54 a.m., Jason Dere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17302
double - decimal - double in the case of the double arg, which I suppose is
less than ideal.
- Jason Dere
On Feb. 3, 2014, 2:26 p.m., Xuefu Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
ql/src/test/results/clientnegative/udf_qualified_name.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/17493/diff/
Testing
---
Thanks,
Jason Dere
/test/results/clientnegative/udf_qualified_name.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/17493/diff/
Testing
---
Thanks,
Jason Dere
/
Testing
---
Thanks,
Jason Dere
Diff: https://reviews.apache.org/r/17494/diff/
Testing
---
Thanks,
Jason Dere
/results/clientpositive/windowing_expressions.q.out e08d0bc
Diff: https://reviews.apache.org/r/17302/diff/
Testing
---
Thanks,
Jason Dere
://reviews.apache.org/r/17957/diff/
Testing
---
Thanks,
Jason Dere
-CREATION
ql/src/test/results/clientpositive/authorization_create_macro1.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/18162/diff/
Testing
---
positive/negative q files added
Thanks,
Jason Dere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17494/#review34715
---
On Feb. 6, 2014, 6:34 a.m., Jason Dere wrote
/drop_func_nonexistent.q.out PRE-CREATION
ql/src/test/results/clientpositive/create_func1.q.out PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 3400ac2
Diff: https://reviews.apache.org/r/17494/diff/
Testing
---
Thanks,
Jason Dere
Thanks,
Jason Dere
1 - 100 of 1978 matches
Mail list logo
