Re: Review Request: HIVE-4708: Fix TestCliDriver.combine2.q on 0.23

2013-06-11 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11795/#review21775 --- Ship it! Ship It! - Navis Ryu On June 11, 2013, 4:20 a.m

Re: Review Request 11326: HIVE-4588: Support session level hooks for HiveServer2

2013-08-22 Thread Navis Ryu
://reviews.apache.org/r/11326/#comment49822 This is not related to this issue, but would it be better to use interface (HiveSemanticAnalyzerHook)? ql/src/java/org/apache/hadoop/hive/ql/Driver.java https://reviews.apache.org/r/11326/#comment49821 Isn't this message should be logged? - Navis Ryu

Review Request: HIVE-2329 RS dedup optimization shoud be avoided in some cases

2011-08-08 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1313/ --- Review request for hive. Summary --- If map aggregation is set to false,

Review Request: HIVE-2332 If all of the parameters of distinct functions are exists in group by columns, query fails in runtime

2011-08-08 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1314/ --- Review request for hive. Summary --- If all of the distinct params are in

Review Request: HIVE-2503: create per-session HiveConf instance

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- Review request for hive and Carl Steinbach. Summary --- We uses multiple

Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- Review request for hive and Carl Steinbach. Summary --- Extension from

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- (Updated 2011-11-15 02:14:32.702033) Review request for hive and Carl

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- (Updated 2011-11-15 07:06:04.002057) Review request for hive and Carl

Re: Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

2011-11-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1304/ --- (Updated 2011-11-15 08:13:13.468713) Review request for hive and namit jain.

Re: Review Request: HIVE-2332 If all of the parameters of distinct functions are exists in group by columns, query fails in runtime

2011-11-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1314/ --- (Updated 2011-11-15 08:56:07.599798) Review request for hive and Ashutosh

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-15 Thread Navis Ryu
as a in-house patch. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/#review3281 --- On 2011-11-15 07:06:04, Navis Ryu wrote

Review Request: HIVE-2340: optimizer for RS-RS-GBY case

2011-12-02 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2991/ --- Review request for hive. Summary --- Mostly copied from existing code. Not

Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- Review request for hive, John Sichi and Carl Steinbach. Summary ---

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-06 00:17:31.391722) Review request for hive, John Sichi and

Review Request: HIVE-2264 Hive server is SHUTTING DOWN when invalid queries beeing executed

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3025/ --- Review request for hive, John Sichi and Carl Steinbach. Summary ---

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/#review3656 --- On 2011-12-06 00:17:31, Navis Ryu wrote: --- This is an automatically generated e-mail

Re: Review Request: HIVE-2340: optimizer for RS-RS-GBY case

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2991/ --- (Updated 2011-12-06 11:02:00.777597) Review request for hive and Carl

Re: Review Request: HIVE-2329 RS dedup optimization shoud be avoided in some cases

2011-12-07 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1313/ --- (Updated 2011-12-07 08:15:06.858543) Review request for hive, John Sichi and

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-07 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-08 04:21:44.611068) Review request for hive, John Sichi and

Review Request: HIVE-2586 Implement literal float/double type and make possible to compare

2011-12-08 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3073/ --- Review request for hive, John Sichi and Carl Steinbach. Summary --- Is

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
/3008/#review3923 --- On 2011-12-08 04:21:44, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-16 02:09:08.375278) Review request for hive, John Sichi and

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
and EXPLAIN part, shortly. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/#review3943 --- On 2011-12-16 02:09:08, Navis Ryu

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-16 04:23:03.804398) Review request for hive, John Sichi and

Re: Review Request: HIVE-2503: create per-session HiveConf instance

2011-12-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15.242903) Review request for hive and Carl

Re: Review Request: HIVE-2503: create per-session HiveConf instance

2011-12-19 Thread Navis Ryu
://reviews.apache.org/r/2820/#review3986 --- On 2011-12-16 05:44:15, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820

Re: Review Request: HIVE-2586 Implement literal float/double type and make possible to compare

2011-12-19 Thread Navis Ryu
://reviews.apache.org/r/3073/#review3982 --- On 2011-12-08 09:33:37, Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3073

Re: Review Request: HIVE-2586 Implement literal float/double type and make possible to compare

2011-12-19 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3073/ --- (Updated 2011-12-20 07:22:34.645716) Review request for hive, John Sichi and

Re: Review Request: HIVE-2503: create per-session HiveConf instance

2012-01-03 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2012-01-04 05:08:24.994913) Review request for hive and Carl

Review Request 15389: Skip useless string encoding stage for hiveserver2

2013-11-09 Thread Navis Ryu
/session/HiveSessionImpl.java cfda752 Diff: https://reviews.apache.org/r/15389/diff/ Testing --- Thanks, Navis Ryu

Review Request 15449: session/operation timeout for hiveserver2

2013-11-11 Thread Navis Ryu
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 25c6f38 Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2013-11-12 Thread Navis Ryu
/service/cli/session/HiveSessionImpl.java cfda752 service/src/java/org/apache/hive/service/cli/session/SessionManager.java 25c6f38 Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2013-11-17 Thread Navis Ryu
/service/cli/session/HiveSessionImpl.java cfda752 service/src/java/org/apache/hive/service/cli/session/SessionManager.java e262b72 Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15816: HIVE-3181 getDatabaseMajor/Minor version does not return values

2013-11-24 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15816/#review29348 --- Ship it! Ship It! - Navis Ryu On Nov. 23, 2013, 1:40 a.m

Re: Review Request 15820: HIVE-5839: BytesRefArrayWritable compareTo violates contract

2013-11-24 Thread Navis Ryu
://reviews.apache.org/r/15820/#comment56556 Took some time to get why this is changed. Could you add some comments on this? - Navis Ryu On Nov. 23, 2013, 4:42 a.m., Xuefu Zhang wrote: --- This is an automatically generated e-mail

Review Request 15855: Check DATABASES/TABLE privilege for metastore authorizer

2013-11-26 Thread Navis Ryu
/AuthorizationPreEventListener.java 9a90549 Diff: https://reviews.apache.org/r/15855/diff/ Testing --- Thanks, Navis Ryu

Review Request 15873: Query cancel should stop running MR tasks

2013-11-27 Thread Navis Ryu
/hadoop/hive/ql/exec/TaskRunner.java ead7b59 service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ecbf3cd Diff: https://reviews.apache.org/r/15873/diff/ Testing --- Thanks, Navis Ryu

Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-03 Thread Navis Ryu
f15d8c5 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-03 Thread Navis Ryu
/StatsFactory.java 8ae32f0 ql/src/test/queries/clientpositive/stats_counter.q 20769e4 ql/src/test/results/clientpositive/stats_counter.q.out f15d8c5 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-04 Thread Navis Ryu
/clientpositive/stats_noscan_1.q.out 054ca38 ql/src/test/results/clientpositive/stats_noscan_2.q.out e55fa94 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16026: No need to aggregate statistics collected via counter mechanism

2013-12-04 Thread Navis Ryu
be fixed accordantly trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java https://reviews.apache.org/r/16026/#comment57281 would it better to just adding , e) in the end? nit: formats - Navis Ryu On Dec. 5, 2013, 1:01 a.m., Ashutosh Chauhan wrote

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-04 Thread Navis Ryu
/diff/ Testing --- Thanks, Navis Ryu

Review Request 16034: Add explain authorize for checking privileges

2013-12-04 Thread Navis Ryu
/queries/clientpositive/authorization_explain.q PRE-CREATION ql/src/test/results/clientpositive/authorization_explain.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16034/diff/ Testing --- Thanks, Navis Ryu

Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-05 Thread Navis Ryu
://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-08 Thread Navis Ryu
/src/test/results/clientpositive/stats_counter.q.out f15d8c5 ql/src/test/results/clientpositive/stats_noscan_1.q.out 054ca38 ql/src/test/results/clientpositive/stats_noscan_2.q.out e55fa94 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-09 Thread Navis Ryu
a247c4a Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16034: Add explain authorize for checking privileges

2013-12-09 Thread Navis Ryu
/DelegatableAuthorizationProvider.java PRE-CREATION ql/src/test/queries/clientpositive/authorization_explain.q PRE-CREATION ql/src/test/results/clientpositive/authorization_explain.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16034/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-09 Thread Navis Ryu
--- On Dec. 10, 2013, 12:42 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15993

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-09 Thread Navis Ryu
a247c4a Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-10 Thread Navis Ryu
/auto_join25.q.out 7427239 Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-15 Thread Navis Ryu
/results/clientpositive/stats_publisher_error_1.q.out a122b83 ql/src/test/results/clientpositive/truncate_column.q.out a247c4a Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-15 Thread Navis Ryu
/org/apache/hive/service/cli/operation/SQLOperation.java 296f8b3 Diff: https://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-17 Thread Navis Ryu
/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-17 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16172/#review30594 --- On Dec. 11, 2013, 2:12 a.m., Navis Ryu wrote

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-17 Thread Navis Ryu
/results/clientpositive/mapjoin_hook.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-17 Thread Navis Ryu
://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-17 Thread Navis Ryu
--- Thanks, Navis Ryu

Re: Review Request 23674: Handle db qualified names consistently across all HiveQL statements

2014-08-06 Thread Navis Ryu
--- On Aug. 1, 2014, 1:55 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23674/ --- (Updated Aug. 1, 2014, 1:55

Review Request 24488: List Jars or Files are not supported by Beeline

2014-08-07 Thread Navis Ryu
/ql/processors/ListResourceProcessor.java PRE-CREATION Diff: https://reviews.apache.org/r/24488/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 23674: Handle db qualified names consistently across all HiveQL statements

2014-08-10 Thread Navis Ryu
940684c ql/src/test/results/clientpositive/temp_table_precedence.q.out 1075b2c Diff: https://reviews.apache.org/r/23674/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 23674: Handle db qualified names consistently across all HiveQL statements

2014-08-11 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23674/#review50132 --- On Aug. 11, 2014, 12:53 a.m., Navis Ryu wrote

Re: Review Request 24137: allow disabling direct sql per query with external metastore

2014-08-11 Thread Navis Ryu
/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495 Diff: https://reviews.apache.org/r/24137/diff/ Testing --- Thanks, Navis Ryu

Review Request 24636: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-13 Thread Navis Ryu
/ExecDriver.java ef72039 Diff: https://reviews.apache.org/r/24636/diff/ Testing --- Thanks, Navis Ryu

Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-13 Thread Navis Ryu
/ExecDriver.java ef72039 Diff: https://reviews.apache.org/r/24688/diff/ Testing --- Thanks, Navis Ryu

Review Request 24792: RCFile and bzip2 compression not working

2014-08-18 Thread Navis Ryu
--- Thanks, Navis Ryu

Review Request 24833: qualified tablenames usage does not work with several alter-table commands

2014-08-18 Thread Navis Ryu
6a1a6c5 ql/src/test/results/clientpositive/touch.q.out 7ea3807 ql/src/test/results/clientpositive/unset_table_view_property.q.out 8cf6686 Diff: https://reviews.apache.org/r/24833/diff/ Testing --- Thanks, Navis Ryu

Review Request 24876: VectorizedBatchUtil.addRowToBatchFrom is not optimized for Vectorized execution and takes 25% CPU

2014-08-19 Thread Navis Ryu
- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java 2acd842 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java 16454e7 Diff: https://reviews.apache.org/r/24876/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 24833: qualified tablenames usage does not work with several alter-table commands

2014-08-24 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24833/#review51243 --- On Aug. 19, 2014, 1:20 a.m., Navis Ryu wrote

Re: Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-25 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24688/#review51426 --- On Aug. 14, 2014, 2:29 a.m., Navis Ryu wrote

Re: Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-25 Thread Navis Ryu
/PartitionKeySampler.java 166461a ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ef72039 ql/src/test/org/apache/hadoop/hive/ql/exec/TestPartitionKeySampler.java PRE-CREATION Diff: https://reviews.apache.org/r/24688/diff/ Testing --- Thanks, Navis Ryu

Review Request 25059: Ambiguous column reference error on query

2014-08-26 Thread Navis Ryu
/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 33b8a21 ql/src/test/queries/clientpositive/complex_alias.q PRE-CREATION ql/src/test/results/clientpositive/complex_alias.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25059/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-26 Thread Navis Ryu
/PartitionKeySampler.java 166461a ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ef72039 ql/src/test/org/apache/hadoop/hive/ql/exec/TestPartitionKeySampler.java PRE-CREATION Diff: https://reviews.apache.org/r/24688/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-26 Thread Navis Ryu
://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-27 Thread Navis Ryu
--- On Aug. 27, 2014, 4:42 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Aug. 27, 2014

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-27 Thread Navis Ryu
://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-27 Thread Navis Ryu
/15449/#review51654 --- On Aug. 27, 2014, 8:05 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-27 Thread Navis Ryu
environment. Thanks, Navis Ryu

Re: Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-28 Thread Navis Ryu
: https://reviews.apache.org/r/24688/#review51744 --- On Aug. 27, 2014, 2:18 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-28 Thread Navis Ryu
, 2:31 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Aug. 28, 2014, 2:31 a.m.) Review

Re: Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-29 Thread Navis Ryu
--- On Aug. 27, 2014, 2:18 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24688

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-29 Thread Navis Ryu
On Aug. 28, 2014, 7:56 a.m., Lefty Leverenz wrote: Navis Ryu wrote: Addressing previous comments, I've revised validator to describe itself to description. For StringSet validator, the description of the conf will be started with something like, Expects one of [textfile

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-29 Thread Navis Ryu
: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 24688: parallel order by clause on a string column fails with IOException: Split points are out of order

2014-08-29 Thread Navis Ryu
/PartitionKeySampler.java 166461a ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ef72039 ql/src/test/org/apache/hadoop/hive/ql/exec/TestPartitionKeySampler.java PRE-CREATION Diff: https://reviews.apache.org/r/24688/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-31 Thread Navis Ryu
--- On Aug. 29, 2014, 9:05 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-08-31 Thread Navis Ryu
/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-09-01 Thread Navis Ryu
--- On Sept. 1, 2014, 5:14 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449

Review Request 25238: make timestamp accessible in the hbase KeyValue

2014-09-02 Thread Navis Ryu
/IndexPredicateAnalyzer.java 683618f serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java 0ab27ff Diff: https://reviews.apache.org/r/25238/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 25059: Ambiguous column reference error on query

2014-09-11 Thread Navis Ryu
://reviews.apache.org/r/25059/#review52982 --- On Aug. 26, 2014, 9:06 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 25059: Ambiguous column reference error on query

2014-09-11 Thread Navis Ryu
/src/test/results/clientpositive/complex_alias.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25059/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 23352: Support non-constant expressions for MAP type indices.

2014-09-11 Thread Navis Ryu
a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23352/ --- (Updated July 9, 2014, 6:57 a.m.) Review request

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-04 Thread Navis Ryu
collection classes are being used here, I don't see other concurrency issues that would make it necessary to make all these functions synchronized. Navis Ryu wrote: It just only polls status of running tasks and goes into wait state quite quickly, so it would not hinder

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-04 Thread Navis Ryu
/serde2/lazybinary/LazyBinaryStruct.java caf3517 Diff: https://reviews.apache.org/r/18179/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16281: Predicates following UDTF operator are removed by PPD

2014-03-04 Thread Navis Ryu
c7591a4 Diff: https://reviews.apache.org/r/16281/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-03-06 Thread Navis Ryu
/java/org/apache/hadoop/hive/ql/DriverContext.java c51a9c8 ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java 854cd52 ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java ead7b59 Diff: https://reviews.apache.org/r/15873/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-06 Thread Navis Ryu
/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java caf3517 Diff: https://reviews.apache.org/r/18179/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-06 Thread Navis Ryu
--- On March 7, 2014, 3:32 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18179/ --- (Updated March 7, 2014, 3:32 a.m

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-06 Thread Navis Ryu
/serde2/lazybinary/LazyBinaryObject.java 598683f serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java caf3517 Diff: https://reviews.apache.org/r/18179/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-10 Thread Navis Ryu
--- On March 7, 2014, 7:46 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18179

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-10 Thread Navis Ryu
://reviews.apache.org/r/18179/#review36711 --- On March 7, 2014, 7:46 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18179

Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler

2014-03-10 Thread Navis Ryu
--- On March 7, 2014, 7:46 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18179

  1   2   3   4   >