Review Request: fix for HIVE-3246

2012-07-17 Thread Thejas Nair
1360908 Diff: https://reviews.apache.org/r/5943/diff/ Testing --- Thanks, Thejas Nair

Re: [ANNOUNCE] Apache Hive 0.11.0 Released

2013-05-17 Thread Thejas Nair
Thanks to all the contributors who helped create this new release! And special thanks to the release managers Ashutosh Chauhan and Owen O'Malley - for driving this release. On Thu, May 16, 2013 at 2:19 PM, Owen O'Malley omal...@apache.org wrote: The Apache Hive team is proud to announce the

Re: Removing the PGP sigs from dist

2013-05-17 Thread Thejas Nair
+1 . While you are editing the releases.html, if its not too much, can you also make the download link more visible ? People tend to scroll down and expect a download link next to the release number. Making it clear that there are two sections might help. On Wed, May 15, 2013 at 9:37 PM, Owen

webhcat component in hive jira

2013-05-22 Thread Thejas Nair
Can a hive jira admin please create a webhcat component in hive project in jira ? (webhcat - http://hive.apache.org/docs/hcat_r0.5.0/rest.html) Thanks, Thejas

Review Request: HIVE-3253- ArrayIndexOutOfBounds exception for deeply nested structs

2013-06-12 Thread Thejas Nair
/TestLazyArrayMapStruct.java 99628dc Diff: https://reviews.apache.org/r/11854/diff/ Testing --- unit tests and beeline Thanks, Thejas Nair

Re: Review Request 11854: HIVE-3253- ArrayIndexOutOfBounds exception for deeply nested structs

2013-07-02 Thread Thejas Nair
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 27ed4ef serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java 99628dc Diff: https://reviews.apache.org/r/11854/diff/ Testing --- unit tests and beeline Thanks, Thejas Nair

call it Hive-SQL instead of HiveQL ?

2013-07-02 Thread Thejas Nair
I see that the hive community intends to make hive SQL compliant and is on that path. Just like other databases, it has some extensions to SQL, and there are some standard features it does not support. SQL is also one of the strong selling points of hive. But using the term HiveQL, I think

Re: call it Hive-SQL instead of HiveQL ?

2013-07-02 Thread Thejas Nair
On Tue, Jul 2, 2013 at 6:52 PM, Edward Capriolo edlinuxg...@gmail.com wrote: I see that the hive community intends to make hive SQL compliant and is on that path. . I was not under the general impression that we are on that path. Well, whenever we try to decide what the behavior should be, we

Re: call it Hive-SQL instead of HiveQL ?

2013-07-03 Thread Thejas Nair
On Tue, Jul 2, 2013 at 8:39 PM, Edward Capriolo edlinuxg...@gmail.com wrote: What is in a name? :) Which SQL feature you are talking about here, that forces single reducer and hence should not be supported? Joining on anything besides = comes to mind Pretty sure the query mentioned here

Re: call it Hive-SQL instead of HiveQL ?

2013-07-03 Thread Thejas Nair
On Wed, Jul 3, 2013 at 12:25 PM, Edward Capriolo edlinuxg...@gmail.com wrote: If you thing hive has friends named DB2, Oracle, teradata, vertica, impala you are wrong. OK, feel free to replace 'friends' with 'not friends' in that sentence. That does not change the argument.

Re: Review Request 11865: Removed Http Status codes from DDLTask

2013-07-03 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11865/#review22750 --- Ship it! +1 Looks good - Thejas Nair On July 4, 2013, 1:46 a.m

Re: [ANNOUNCE] New Hive Committer - Brock Noland

2013-07-16 Thread Thejas Nair
Congrats Brock! On Tue, Jul 16, 2013 at 11:41 AM, Shreepadma Venugopalan shreepa...@cloudera.com wrote: Many congrats, Brock! On Tue, Jul 16, 2013 at 7:33 AM, Ricky Saltzer ri...@cloudera.com wrote: Congrats!! On Tue, Jul 16, 2013 at 10:30 AM, Alexander Alten-Lorenz

Review Request 12748: HIVE-4883 - TestHadoop20SAuthBridge tests fail sometimes because of race condition

2013-07-18 Thread Thejas Nair
/ Testing --- Thanks, Thejas Nair

Review Request 12749: HIVE-4886 - beeline code should have apache license headers

2013-07-18 Thread Thejas Nair
/XMLElementOutputFormat.java e187a6d Diff: https://reviews.apache.org/r/12749/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request 12749: HIVE-4886 - beeline code should have apache license headers

2013-07-18 Thread Thejas Nair
/hive/beeline/XMLAttributeOutputFormat.java 296a328 beeline/src/java/org/apache/hive/beeline/XMLElementOutputFormat.java e187a6d Diff: https://reviews.apache.org/r/12749/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request 12748: HIVE-4883 - TestHadoop20SAuthBridge tests fail sometimes because of race condition

2013-07-18 Thread Thejas Nair
/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 172e031 Diff: https://reviews.apache.org/r/12748/diff/ Testing --- Thanks, Thejas Nair

Re: [ANNOUNCE] New Hive Committer - Gunther Hagleitner

2013-07-21 Thread Thejas Nair
Congrats Gunther ! Great to see more bandwidth to get the patch available counts down ! On Jul 21, 2013 9:56 AM, Clark Yang (杨卓荦) yangzhuo...@gmail.com wrote: Congratulations Gunther! 2013/7/22 Brock Noland br...@cloudera.com Congratulations Gunther!! Cheers, Zhuoluo (Clark) Yang

Re: VOTE: moving hive from forest to Apache CMS

2013-07-22 Thread Thejas Nair
+1 (non binding) On Mon, Jul 22, 2013 at 2:01 PM, Gunther Hagleitner ghagleit...@hortonworks.com wrote: +1 Thanks, Gunther. On Mon, Jul 22, 2013 at 1:25 PM, Owen O'Malley omal...@apache.org wrote: +1 On Sun, Jul 21, 2013 at 10:53 AM, Edward Capriolo edlinuxg...@gmail.com wrote:

Re: Review Request 12749: HIVE-4886 - beeline code should have apache license headers

2013-07-22 Thread Thejas Nair
/12749/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request 12824: [HIVE-4911] Enable QOP configuration for Hive Server 2 thrift transport

2013-07-23 Thread Thejas Nair
metastore usually not exposed 'outside' the cluster unlike hive server2. It is often viewed as something 'inside the cluster'. Should we change this function to take in a configuration object and use that to call SaslRpcServer.init(conf) ? - Thejas Nair On July 22, 2013, 8:56 p.m., Arup

Re: Review Request 12824: [HIVE-4911] Enable QOP configuration for Hive Server 2 thrift transport

2013-07-23 Thread Thejas Nair
://reviews.apache.org/r/12824/#comment47598 should we just call this hive.server2.thrift.sasl.qop ? That seems more self describing. - Thejas Nair On July 22, 2013, 8:56 p.m., Arup Malakar wrote: --- This is an automatically

Re: Review Request 12824: [HIVE-4911] Enable QOP configuration for Hive Server 2 thrift transport

2013-07-24 Thread Thejas Nair
On July 23, 2013, 9:48 p.m., Thejas Nair wrote: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 142 https://reviews.apache.org/r/12824/diff/1/?file=324969#file324969line142 the HIVE_AUTH_TYPE env variable is called auth. Should we use something more descriptive

Re: [Discuss] project chop up

2013-07-26 Thread Thejas Nair
+1 to the idea of making the build of core hive and other downstream components independent. bq. I was under the impression that Hcat and hive-metastore was supposed to merge up somehow. The metastore code was never forked. Hcat was just using hive-metastore and making the metadata available to

Re: Review Request 10887: HIVE-4343

2013-08-02 Thread Thejas Nair
Diff: https://reviews.apache.org/r/10887/diff/ Testing --- tested that it works as desired with kerberos secure cluster Thanks, Thejas Nair

Re: Review Request 10887: HIVE-4343

2013-08-02 Thread Thejas Nair
/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 5a379df shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 Diff: https://reviews.apache.org/r/10887/diff/ Testing --- tested that it works as desired with kerberos secure cluster Thanks, Thejas Nair

Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

2013-08-02 Thread Thejas Nair
/shims/HadoopShims.java b0f5077 Diff: https://reviews.apache.org/r/11046/diff/ Testing --- manually tested on secure hadoop cluster. Thanks, Thejas Nair

Re: Review Request 13315: HIVE-5006: Re-factor HiveServer2 JDBC PreparedStatement to avoid duplicate code

2013-08-06 Thread Thejas Nair
Are the two ps.executeQuery() calls intentional ? (line 416,418). jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java https://reviews.apache.org/r/13315/#comment48858 looks like a redundant check here. - Thejas Nair On Aug. 6, 2013, 8:08 a.m., Prasad Mujumdar wrote

Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

2013-08-06 Thread Thejas Nair
report. I can change the rest of them in a separate patch. - Thejas Nair On Aug. 3, 2013, 3 a.m., Thejas Nair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11046

Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

2013-08-06 Thread Thejas Nair
: https://reviews.apache.org/r/11046/diff/ Testing --- manually tested on secure hadoop cluster. Thanks, Thejas Nair

Review Request 13383: HIVE-4545 - HS2 should return describe table results without space padding

2013-08-07 Thread Thejas Nair
/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0f48674 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7254491 Diff: https://reviews.apache.org/r/13383/diff/ Testing --- Updated TestJdbcDriver2 unit tests Thanks, Thejas Nair

Re: Review Request 13383: HIVE-4545 - HS2 should return describe table results without space padding

2013-08-07 Thread Thejas Nair
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7254491 Diff: https://reviews.apache.org/r/13383/diff/ Testing --- Updated TestJdbcDriver2 unit tests Thanks, Thejas Nair

Re: Review Request 11029: HIVE-4513 - disable hivehistory logs by default

2013-08-10 Thread Thejas Nair
/ql/history/TestHiveHistory.java a783303 ql/src/test/templates/TestCliDriver.vm a6ae6c3 Diff: https://reviews.apache.org/r/11029/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request 11029: HIVE-4513 - disable hivehistory logs by default

2013-08-10 Thread Thejas Nair
Diff: https://reviews.apache.org/r/11029/diff/ Testing --- Thanks, Thejas Nair

Re: [ANNOUNCE] New Hive Committer - Thejas Nair

2013-08-20 Thread Thejas Nair
, Aug 20, 2013 at 03:31:48AM -0700, Carl Steinbach wrote: The Apache Hive PMC has voted to make Thejas Nair a committer on the Apache Hive project. Please join me in congratulating Thejas! -- *Note that I'm no longer using my Yahoo! email address. Please email me at billgra

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-08-22 Thread Thejas Nair
. - Thejas Nair On Aug. 21, 2013, 5:42 a.m., Xuefu Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/ --- (Updated Aug

Hive 0.12 release

2013-08-29 Thread Thejas Nair
It has been more than 3 months since 0.11 was released and we already have 294 jiras in resolved-fixed state for 0.12. This includes several new features such as date data type, optimizer improvements, ORC format improvements and many bug fixes. There are also many features look ready to get

Re: Hive 0.12 release

2013-08-30 Thread Thejas Nair
under HIVE-4869 get checked in before branching. Eugene On Thu, Aug 29, 2013 at 9:18 PM, Thejas Nair the...@hortonworks.com wrote: It has been more than 3 months since 0.11 was released and we already have 294 jiras in resolved-fixed state for 0.12. This includes several new features

Re: Hive 0.12 release

2013-08-30 Thread Thejas Nair
29, 2013, at 10:31 PM, Eugene Koifman ekoif...@hortonworks.com wrote: I think we should make sure that several items under HIVE-4869 get checked in before branching. Eugene On Thu, Aug 29, 2013 at 9:18 PM, Thejas Nair the...@hortonworks.com wrote: It has been more than 3

Re: Export version of Wiki broken

2013-09-02 Thread Thejas Nair
Lars, Thanks for bringing this up! Can you please create an INFRA ticket for this ? The google search results often leads to the broken page versions of the doc. Thanks, Thejas On Mon, Sep 2, 2013 at 12:27 AM, Lars Francke lars.fran...@gmail.comwrote: Hi, does anyone know why the Auto

Re: Hive 0.12 release

2013-09-02 Thread Thejas Nair
of conflicts. So doing this after the branch adds complexity but does not add anything useful. Eugene On Fri, Aug 30, 2013 at 5:57 PM, Thejas Nair the...@hortonworks.com wrote: Hi Eugene, Can you please elaborate on why you would like to have this in before branching and not commit

Re: RFC: Major HCatalog refactoring

2013-09-03 Thread Thejas Nair
One thing to note is that the 0.11 interfaces are going to be deprecated and will be taken away in a later release. When the interface is taken away, the additional unit tests will also go away. On Tue, Sep 3, 2013 at 9:57 AM, Eugene Koifman ekoif...@hortonworks.com wrote: Current (sequential)

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-03 Thread Thejas Nair
not been made in revised patch. - Thejas Nair On Aug. 24, 2013, 8:19 p.m., Xuefu Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334

Re: HCatalog Refactoring - no checkins into hive/hcatalog part of the src tree

2013-09-03 Thread Thejas Nair
Eugene, I assume you want the hold off on checkins to hive/hcatalog dir to start from tomorrow AM pacific time (Sept 4) (say 8 am PDT ?) and you expect you changes to be done by Sept 5 around 6pm Pacific time. Is that correct ? Thanks, Thejas On Tue, Sep 3, 2013 at 6:00 PM, Eugene Koifman

Re: [ANNOUNCE] New Hive Committer - Yin Huai

2013-09-04 Thread Thejas Nair
Congrats Yin! Well deserved! Looking forward to many more contributions from you! On Tue, Sep 3, 2013 at 11:45 PM, Hari Subramaniyan hsubramani...@hortonworks.com wrote: Congrats !! On Tue, Sep 3, 2013 at 11:43 PM, Vaibhav Gumashta vgumas...@hortonworks.com wrote: Congrats Yin! On

Re: HCatalog Refactoring - no checkins into hive/hcatalog part of the src tree

2013-09-05 Thread Thejas Nair
-available patches that we do not get in by 8AM PDT will have to be canceled and regenerated. I'll do that tomorrow. On Tue, Sep 3, 2013 at 6:34 PM, Eugene Koifman ekoif...@hortonworks.com wrote: Yes, that is correct. On Tue, Sep 3, 2013 at 6:28 PM, Thejas Nair the...@hortonworks.com wrote

creating branch 0.12

2013-09-06 Thread Thejas Nair
As discussed in earlier thread, I will go ahead and create a branch for hive 0.12 release. I will do that in another hour. Please reply to this thread if there are any jiras that are not committed yet, that you feel should be included in hive 0.12. Please include only jiras that are being

Re: creating branch 0.12

2013-09-06 Thread Thejas Nair
Hive 0.12 branch has been created! (branch-0.12) On Fri, Sep 6, 2013 at 5:29 PM, Thejas Nair the...@hortonworks.com wrote: As discussed in earlier thread, I will go ahead and create a branch for hive 0.12 release. I will do that in another hour. Please reply to this thread if there are any

Re: creating branch 0.12

2013-09-09 Thread Thejas Nair
, Thejas Nair the...@hortonworks.com wrote: As discussed in earlier thread, I will go ahead and create a branch for hive 0.12 release. I will do that in another hour. Please reply to this thread if there are any jiras that are not committed yet, that you feel should be included in hive

Re: Review Request 10180: HIVE-4171

2013-09-11 Thread Thejas Nair
/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 81a3396 ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java PRE-CREATION Diff: https://reviews.apache.org/r/10180/diff/ Testing --- Manually tested, unit test to be added. Thanks, Thejas Nair

Review Request 14122: support jdbc documented table types in default configuration

2013-09-13 Thread Thejas Nair
, java.lang.String[]) Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c5a8ff3 conf/hive-default.xml.template 181011b jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java c658dbd Diff: https://reviews.apache.org/r/14122/diff/ Testing --- Thanks, Thejas

Re: Hive 0.12 release

2013-09-16 Thread Thejas Nair
blockers in by middle of next week. On Thu, Aug 29, 2013 at 9:18 PM, Thejas Nair the...@hortonworks.com wrote: It has been more than 3 months since 0.11 was released and we already have 294 jiras in resolved-fixed state for 0.12. This includes several new features such as date data type, optimizer

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-17 Thread Thejas Nair
); Then add (-f, scriptFileName) to the list it returns ? Similarly add params to the list in testBeelineCommandLineHiveVariable ? Everything else looks good. - Thejas Nair On Sept. 10, 2013, 9:45 p.m., Xuefu Zhang wrote

Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

2013-09-17 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11334/#review26198 --- Ship it! Ship It! - Thejas Nair On Sept. 18, 2013, 12:41 a.m

Re: How long will we support Hadoop 0.20.2?

2013-09-19 Thread Thejas Nair
How is 0.20.2 more easy for setup/development than the stable 1.x line ? On Wed, Sep 18, 2013 at 7:18 PM, Xuefu Zhang xzh...@cloudera.com wrote: Even not for production, I think 0.20.2 is very useful for development as well. it's simple and easy to set up, avoiding a lot of hassles that we

Re: how to read orcfile,OrcStruct is not public

2013-09-27 Thread Thejas Nair
you can use hcatalog input and output formats to read/write ORC from mapreduce. http://hive.apache.org/docs/hcat_r0.5.0/inputoutput.html On Thu, Sep 26, 2013 at 9:34 PM, 陈涛 bhsc.ha...@163.com wrote: i am trying to write orcfile(snappy) instead of sequencefile(lzo) in mapreduce,but OrcStruct

hive 0.12 release update

2013-10-03 Thread Thejas Nair
Short summary: I hope to have a release candidate out this weekend or by Monday. I have setup unit tests runs for hive 0.12 branch - https://builds.apache.org/job/Hive-branch-0.12-hadoop1/ https://builds.apache.org/job/Hive-branch-0.12-hadoop2/ There were some unit test failures, caused by test

[VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-07 Thread Thejas Nair
Apache Hive 0.12.0 Release Candidate 0 is available here: http://people.apache.org/~thejas/hive-0.12.0-rc0/ Maven artifacts are available here: https://repository.apache.org/content/repositories/orgapachehive-138/ This release has 406 issues fixed. This includes several new features such as data

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-07 Thread Thejas Nair
-0.12.0-rc0/). Is that correct? Brock On Mon, Oct 7, 2013 at 6:02 PM, Thejas Nair the...@hortonworks.com wrote: Apache Hive 0.12.0 Release Candidate 0 is available here: http://people.apache.org/~thejas/hive-0.12.0-rc0/ Maven artifacts are available here: https://repository.apache.org/content

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-07 Thread Thejas Nair
files are missing apache license headers On Mon, Oct 7, 2013 at 4:38 PM, Thejas Nair the...@hortonworks.com wrote: Yes, that is the correct tag. Thanks for pointing it out. I also update the tag as it was a little behind what is in the RC (found some issues with maven-publish). I have also

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-08 Thread Thejas Nair
. Brock On Mon, Oct 7, 2013 at 11:02 PM, Thejas Nair the...@hortonworks.com wrote: Carl pointed some issues with the RC. I will be rolling out a new RC to address those (hopefully sometime tomorrow). If anybody finds additional issues, please let me know, so that I can address those as well

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-08 Thread Thejas Nair
On Tue, Oct 8, 2013 at 3:56 PM, Thejas Nair the...@hortonworks.com wrote: On Tue, Oct 8, 2013 at 8:18 AM, Brock Noland br...@cloudera.com wrote: Hi Thejas, Again thank you very much for all the hard work! Two items of discussion: The tag contains .gitignore files so I believe the source

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-08 Thread Thejas Nair
On Tue, Oct 8, 2013 at 9:04 AM, Ashutosh Chauhan hashut...@apache.org wrote: Thejas, If you are considering respining RC, I would like to request inclusion of following: HIVE-5418 : Integer overflow bug in ConditionalResolverCommonJoin.AliasFileSizePair HIVE-5449 : Hive schematool info

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 0

2013-10-08 Thread Thejas Nair
it will be, but both I personally and the larger Bigtop community would greatly appreciate if Hive released a source tarball for 0.12 release. Would love to hear what you think. Thanks again! Mark On Tue, Oct 8, 2013 at 3:56 PM, Thejas Nair the...@hortonworks.com wrote: On Tue, Oct 8, 2013 at 8:18 AM

[VOTE] Apache Hive X.Y.Z Release Candidate 1

2013-10-09 Thread Thejas Nair
Apache Hive 0.12.0 Release Candidate 1 is available here: http://people.apache.org/~thejas/hive-0.12.0-rc1/ Maven artifacts are available here: https://repository.apache.org/content/repositories/orgapachehive-157/ Source tag for RC1 is at:

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 1

2013-10-09 Thread Thejas Nair
(Fixing subject of the email!) On Wed, Oct 9, 2013 at 7:31 PM, Thejas Nair the...@hortonworks.com wrote: Apache Hive 0.12.0 Release Candidate 1 is available here: http://people.apache.org/~thejas/hive-0.12.0-rc1/ Maven artifacts are available here: https://repository.apache.org/content

Re: HiveServer2 released in some branch

2013-03-20 Thread Thejas Nair
Rodrigo, New features usually go into new version (0.xx) . (0.xx.x versions are usually meant for releases with bug fixes). So HiveServer2 is likely to be part of next release (0.11), and not part of a (0.9.x or 0.10.x) . This is the usual practice that I have seen, and haven't heard of any

Review Request: HIVE-4269: fix handling of binary type in hiveserver2, jdbc driver

2013-03-31 Thread Thejas Nair
/Utils.java 433b2c5 jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 2e5c30e service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 405f0c7 Diff: https://reviews.apache.org/r/10210/diff/ Testing --- Unit tests included Thanks, Thejas Nair

Review Request: HIVE-4252 - hiveserver2 string representation of complex types are inconsistent with cli

2013-03-31 Thread Thejas Nair
test included Thanks, Thejas Nair

Re: Review Request: HIVE-4252 - hiveserver2 string representation of complex types are inconsistent with cli

2013-03-31 Thread Thejas Nair
://reviews.apache.org/r/10211/diff/ Testing --- unit test included Thanks, Thejas Nair

Review Request: HIVE-4267- hiveserver2 jdbc driver - remove trailing .0 in resultset.getString() for timestamp field

2013-03-31 Thread Thejas Nair
/ Testing --- unit tests included Thanks, Thejas Nair

Review Request: HIVE-4292 - adding support for -hiveconf arg

2013-04-03 Thread Thejas Nair
: https://reviews.apache.org/r/10280/diff/ Testing --- Unit test added. Thanks, Thejas Nair

Review Request: HIVE-3840 -hive cli null representation in output is inconsistent

2013-04-05 Thread Thejas Nair
/clientpositive/udtf_stack.q.out fe57cd1 serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java b728b18 serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 4954b29 Diff: https://reviews.apache.org/r/10312/diff/ Testing --- unit tests updated Thanks, Thejas Nair

Re: Review Request: HIVE-3840 -hive cli null representation in output is inconsistent

2013-04-05 Thread Thejas Nair
4954b29 Diff: https://reviews.apache.org/r/10312/diff/ Testing --- unit tests updated Thanks, Thejas Nair

Re: Review Request: HIVE-3840 -hive cli null representation in output is inconsistent

2013-04-05 Thread Thejas Nair
will be consistent. - Thejas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10312/#review18732 --- On April 5, 2013, 6:32 p.m., Thejas Nair wrote

Review Request: HIVE-4191

2013-04-08 Thread Thejas Nair
, Thejas Nair

Review Request: HIVE-4356 - remove duplicate impersonation parameters for hiveserver2

2013-04-16 Thread Thejas Nair
/service/cli/thrift/TestThriftCLIService.java PRE-CREATION Diff: https://reviews.apache.org/r/10554/diff/ Testing --- Unit tests included. Manually tested on (kerberos) secure and unsecure cluster. Thanks, Thejas Nair

Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect

2013-04-26 Thread Thejas Nair
/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 18594cb Diff: https://reviews.apache.org/r/10812/diff/ Testing --- Unit test included. Also tested with remote HS2 server. Thanks, Thejas Nair

Re: Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect

2013-04-27 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10812/#review19822 --- On April 27, 2013, 2:53 a.m., Thejas Nair wrote

Re: Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect

2013-04-27 Thread Thejas Nair
server. Thanks, Thejas Nair

Re: Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect

2013-04-27 Thread Thejas Nair
, Thejas Nair

Re: Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect

2013-04-27 Thread Thejas Nair
On April 27, 2013, 6:59 a.m., Carl Steinbach wrote: common/src/scripts/saveVersion.sh, line 66 https://reviews.apache.org/r/10812/diff/1/?file=285221#file285221line66 I think the output directory was correct to begin with. Please revert. Thejas Nair wrote: HiveVersionInfo

Review Request: HIVE-4343

2013-05-01 Thread Thejas Nair
://reviews.apache.org/r/10887/diff/ Testing --- tested that it works as desired with kerberos secure cluster Thanks, Thejas Nair

Re: Review Request: HIVE-4343

2013-05-01 Thread Thejas Nair
/HadoopShims.java https://reviews.apache.org/r/10887/#comment41260 I made this change to match function code with actual function - Thejas Nair On May 1, 2013, 9:19 p.m., Thejas Nair wrote: --- This is an automatically generated e-mail

Review Request: HIVE-4510

2013-05-07 Thread Thejas Nair
2fee93e Diff: https://reviews.apache.org/r/10977/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request: HIVE-4510

2013-05-07 Thread Thejas Nair
/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 2fee93e Diff: https://reviews.apache.org/r/10977/diff/ Testing --- Thanks, Thejas Nair

Review Request: HIVE-4500 2nd rb request

2013-05-07 Thread Thejas Nair
/cli/operation/HiveCommandOperation.java 60148cb service/src/java/org/apache/hive/service/cli/operation/Operation.java b354ac9 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 8f0adb5 Diff: https://reviews.apache.org/r/10986/diff/ Testing --- Thanks, Thejas

Re: Review Request: HIVE-4500 2nd rb request

2013-05-07 Thread Thejas Nair
/HiveSessionImpl.java 8f0adb5 Diff: https://reviews.apache.org/r/10986/diff/ Testing --- Thanks, Thejas Nair

Review Request: HIVE-4498

2013-05-08 Thread Thejas Nair
Diffs - service/src/java/org/apache/hive/service/auth/TUGIContainingProcessor.java 12250ec Diff: https://reviews.apache.org/r/11017/diff/ Testing --- verified that TestBeeLineWithArgs works . Thanks, Thejas Nair

Review Request: HIVE-4513

2013-05-09 Thread Thejas Nair
/history/HiveHistoryViewer.java fdd56db ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 3d43451 ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java a783303 Diff: https://reviews.apache.org/r/11029/diff/ Testing --- Thanks, Thejas Nair

Review Request: HIVE-4535 - hive build fails with hadoop 0.20

2013-05-10 Thread Thejas Nair
/metastore/MetaStoreUtils.java f9da781 Diff: https://reviews.apache.org/r/11036/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request: HIVE-4535 - hive build fails with hadoop 0.20

2013-05-10 Thread Thejas Nair
://issues.apache.org/jira/browse/HIVE-4535 Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f9da781 Diff: https://reviews.apache.org/r/11036/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request: HIVE-4535 - hive build fails with hadoop 0.20

2013-05-10 Thread Thejas Nair
. - Thejas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11036/#review20415 --- On May 10, 2013, 4:40 p.m., Thejas Nair wrote

Review Request: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

2013-05-10 Thread Thejas Nair
. Thanks, Thejas Nair

Re: Review Request: HIVE-4513 - disable hivehistory logs by default

2013-05-13 Thread Thejas Nair
/TestHiveHistory.java a783303 Diff: https://reviews.apache.org/r/11029/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request: HIVE-4513 - disable hivehistory logs by default

2013-05-13 Thread Thejas Nair
/apache/hadoop/hive/ql/history/TestHiveHistory.java a783303 Diff: https://reviews.apache.org/r/11029/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request: HIVE-4513 - disable hivehistory logs by default

2013-05-13 Thread Thejas Nair
/hadoop/hive/ql/history/HiveHistoryViewer.java fdd56db ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 3d43451 ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java a783303 Diff: https://reviews.apache.org/r/11029/diff/ Testing --- Thanks, Thejas Nair

Re: Review Request: HIVE-4513 - disable hivehistory logs by default

2013-05-13 Thread Thejas Nair
., Thejas Nair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11029/ --- (Updated May 13, 2013, 10:12 p.m.) Review request

Re: [VOTE] Apache Hive 0.11.0 Release Candidate 2

2013-05-13 Thread Thejas Nair
Owen, Where do I find the public keys you used to sign the files ? putting it in http://apache.org/dist/hive/KEYS seems to be the convention so far. (I found that location from similar location in pig howtorelease doc https://cwiki.apache.org/confluence/display/PIG/HowToRelease). Thanks, Thejas

Re: [VOTE] Apache Hive 0.11.0 Release Candidate 2

2013-05-14 Thread Thejas Nair
+1 (non binding) - Verified md5 checksums for hive-0.11.0.tar.gz and hive-0.11.0-bin.tar.gz - Verified gpg keys for hive-0.11.0.tar.gz and hive-0.11.0-bin.tar.gz - Built hive using the source release - Ran simple hive queries using new build , binary in hive-0.11.0.tar.gz and

Re: [VOTE] Apache Hive 0.12.0 Release Candidate 1

2013-10-11 Thread Thejas Nair
: OK - verify the PGP signature wget http://www.apache.org/dist/hive/KEYS gpg --import KEYS (if necessarily) gpg --verify hive-X.Y.Z.tar.gz.asc hive-X.Y.Z.tar.gz gpg --verify hive-X.Y.Z-bin.tar.gz.asc hive-X.Y.Z-bin.tar.gz On Wed, Oct 9, 2013 at 7:50 PM, Thejas Nair the...@hortonworks.com wrote

  1   2   3   4   5   6   7   8   9   >