Pushing patch to branch-3

Hello, If you have a patch to push to branch-3 which is not trivial or is not minor bug fix please make sure to run ptests. At this point master and branch-3 differs significantly and getting a clean run on master shouldn’t be used as +1 for branch-3. branch-3 has 2-3 known failures which will

Apache Hive 3.1. release preparation

Hello folks, It has been more than one month since Hive 3.0 release. Plenty of bug fixes and minor features have been pushed in to branch-3 and therefore I believe it is time for us to release Hive 3.1. I plan to cut off branch 3.1 off branch-3 tomorrow at end of day. Once the branch is cut pl

Re: Apache Hive 3.1. release preparation

; I think it would be useful to do a metastore 3.1 release as well along >>> with the release. In order to do that we should deploy metastore in >>> standalone mode, make sure it works as expected and also document how to >>> install and use metastore as a standalone modu

Re: Unstable Hive QA

I have also bumped into flaky druid failures although with different symptoms (Wait time exhausted and we have [1] out of [1] segments not loaded yet) All of the druid failures in this case are during create table with following error stack: (Not sure why this is intermittent) org.apache.hadoop

[VOTE] Apache Hive 3.1.0 Release Candidate 0

Apache Hive 3.1.0 Release Candidate 0 is available here: http://people.apache.org/~vgarg/apache-hive-3.1.0-rc-0 Maven artifacts are available here: https://repository.apache.org/content/repositories/orgapachehive-1089/ Source tag: https://github.com/apache/hive/tree/release-3.1.0-rc0 Voting wi

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 0

rifying the standalone-metastore for branch-3.1 On Wed, Jul 18, 2018 at 6:15 PM, Vineet Garg mailto:vg...@hortonworks.com>> wrote: Apache Hive 3.1.0 Release Candidate 0 is available here: http://people.apache.org/~vgarg/apache-hive-3.1.0-rc-0 Maven artifacts are available here: https://repo

Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

/union_remove_22.q.out 247db091ee ql/src/test/results/clientpositive/vector_case_when_2.q.out 9ff87502af ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out ee7602aa7a Diff: https://reviews.apache.org/r/68011/diff/1/ Testing --- Thanks, Vineet Garg

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 0

ax.el:jar:3.0.1-b11-SNAPSHOT > > Use 'mvn dependency:tree' to locate the source of the banned dependencies. > > > > Seems like we are getting snapshot dependency in our build. That shouldn't > be the case. > > > -1. > > > Thanks, > > A

[VOTE] Apache Hive 3.1.0 Release Candidate 1

Apache Hive 3.1.0 Release Candidate 1 is available here: http://people.apache.org/~vgarg/apache-hive-3.1.0-rc-1 Maven artifacts are available here: https://repository.apache.org/content/repositories/orgapachehive-1090/ Source tag: https://github.com/apache/hive/tree/release-3.1.0-rc1 Voting wi

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 1

operations like create, alter, drop >> on >> tables and partitions >> - Verified the signature for the tar files >> >> RC1 looks good to me. >> >> +1 (non-binding) >> >> On Mon, Jul 23, 2018 at 4:28 PM, Vineet Garg >> wrote: >> &

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

/vector_interval_arithmetic.q.out ee7602aa7a Diff: https://reviews.apache.org/r/68011/diff/2/ Changes: https://reviews.apache.org/r/68011/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

ira to investigate this. - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68011/#review206425 --- On July 27, 2018, 11:14 p.m.

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

a operator will result in perf loss. We do have an > > optimization rule to remove identity projects. Is that not able to optimize > > this select now? > > Vineet Garg wrote: > I am not sure. This query is now going through CBO resulting in this > extra select oper

Re: [VOTE] Apache Hive 3.1.0 Release Candidate 1

a and asc signatures >- Checked that the source tar.gz contains the same files that my repository > >If this considered enough, then +1 from me too. > >> On Jul 26, 2018, at 06:57, Vineet Garg wrote: >> >> Thanks for voting Vihang and Ashutosh. >> >>

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

Congratulations Vihang! > On Jul 26, 2018, at 11:27 AM, Ashutosh Chauhan wrote: > > On behalf of the Hive PMC I am delighted to announce Vihang Karajgaonkar > is joining Hive PMC. > Thanks Vihang for all your contributions till now. Looking forward to many > more. > > Welcome, Vihang! > > Tha

Re: [ANNOUNCE] New PMC Member : Peter Vary

Congratulations Peter! > On Jul 26, 2018, at 11:25 AM, Ashutosh Chauhan wrote: > > On behalf of the Hive PMC I am delighted to announce Peter Vary is joining > Hive PMC. > Thanks Peter for all your contributions till now. Looking forward to many > more. > > Welcome, Peter! > > Thanks, > Ashuto

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

Congratulations Sahil! > On Jul 26, 2018, at 11:28 AM, Ashutosh Chauhan wrote: > > On behalf of the Hive PMC I am delighted to announce Sahil Takiar is > joining Hive PMC. > Thanks Sahil for all your contributions till now. Looking forward to many > more. > > Welcome, Sahil! > > Thanks, > Ashu

[ANNOUNCE] Apache Hive 3.1.0 Released

The Apache Hive team is proud to announce the release of Apache Hive version 3.1.0. The Apache Hive (TM) data warehouse software facilitates querying and managing large datasets residing in distributed storage. Built on top of Apache Hadoop (TM), it provides, among others: * Tools to enable easy

Re: [ANNOUNCE] New committer: Slim Bouguerra

Congrats Slim! > On Jul 30, 2018, at 6:08 PM, Vihang Karajgaonkar > wrote: > > Congrats Slim! > > On Mon, Jul 30, 2018 at 4:35 PM, Deepak Jaiswal > wrote: > >> Congrats Slim! >> >> On 7/30/18, 4:03 PM, "Prasanth Jayachandran" < >> pjayachand...@hortonworks.com> wrote: >> >>Congratulat

Re: [ANNOUNCE] New PMC Member : Vineet Garg

52 AM Deepak Jaiswal < >>> djais...@hortonworks.com> >>>wrote: >>> >>>> Congratulations Vineet! >>>> >>>> On 7/30/18, 12:45 AM, "Peter Vary" >>> wrote: >>>> >>>>Congratulation

Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

--- Thanks, Vineet Garg

Re: Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

3c24928ffa Diff: https://reviews.apache.org/r/68202/diff/2/ Changes: https://reviews.apache.org/r/68202/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

s above - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68202/#review206858 ------- On Aug. 4, 2018, 12:59 a.m., Vineet G

Re: Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

3c24928ffa Diff: https://reviews.apache.org/r/68202/diff/3/ Changes: https://reviews.apache.org/r/68202/diff/2-3/ Testing --- Thanks, Vineet Garg

Re: Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

ly generated e-mail. To reply, visit: https://reviews.apache.org/r/68202/#review206867 --- On Aug. 4, 2018, 6:28 p.m., Vineet Garg wrote: > > --- > T

Re: Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

3c24928ffa Diff: https://reviews.apache.org/r/68202/diff/4/ Changes: https://reviews.apache.org/r/68202/diff/3-4/ Testing --- Thanks, Vineet Garg

Re: Review Request 68202: HIVE-20292 Bad join ordering in tpcds query93 with primary constraint defined

assume > > presence of project and can optimize the join-join plan too. > > > > On a side note default value for sq_count_check should be true. Lets do > > that too. > > Vineet Garg wrote: > sq_count_check can not be enhanced to work on JOIN-JOIN pat

Review Request 68313: HIVE-20366 TPC-DS query78 stats estimates are off for is null filter

e03948f8b0 ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 7d45328d41 ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 00f5d7ef11 Diff: https://reviews.apache.org/r/68313/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 68313: HIVE-20366 TPC-DS query78 stats estimates are off for is null filter

/test/results/clientpositive/spark/spark_explainuser_1.q.out 00f5d7ef11 Diff: https://reviews.apache.org/r/68313/diff/2/ Changes: https://reviews.apache.org/r/68313/diff/1-2/ Testing --- Thanks, Vineet Garg

Review Request 68534: HIVE-20432 Rewrite BETWEEN to IN for integer types for stats estimation

ql/src/test/results/clientpositive/spark/subquery_select.q.out dc7a510510 Diff: https://reviews.apache.org/r/68534/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 66370: HIVE-18725: Improve error handling for subqueries if there is wrong column reference

throwing semantic exception. This will cause the code to not try non-cbo in case of cbo failure. I don't think we want to do that. - Vineet Garg On July 1, 2018, 8:55 a.m., Igor Kryvenko wrote: > > --- > This is an autom

Re: Review Request 66370: HIVE-18725: Improve error handling for subqueries if there is wrong column reference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66370/#review208385 --- Ship it! Ship It! - Vineet Garg On Sept. 5, 2018, 8 p.m

Re: Review Request 68633: [HIVE-20481] Add record key column

/KafkaStorageHandler.java Line 71 (original), 77 (patched) <https://reviews.apache.org/r/68633/#comment292374> earlier both topic and broker string was being checked for null but now only for emptyness. Is it guranteed for them to be not null? - Vineet Garg On Sept. 5, 2018, 9:15 p.m., Slim Bou

Re: Review Request 68633: [HIVE-20481] Add record key column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68633/#review208459 --- Ship it! Ship It! - Vineet Garg On Sept. 5, 2018, 9:15 p.m

Re: Review Request 68310: HIVE-17040

l), 364 (patched) <https://reviews.apache.org/r/68310/#comment292642> Curious what caused this change? I don't see anything relevant. - Vineet Garg On Sept. 5, 2018, 9:11 p.m., Jesús Camacho Rodríguez wrote: > > --

Re: Review Request 68310: HIVE-17040

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68310/#review208669 --- Ship it! Ship It! - Vineet Garg On Sept. 14, 2018, 9:51 p.m

Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

3bf62c535c ql/src/test/queries/clientpositive/constraints_optimization.q PRE-CREATION ql/src/test/results/clientpositive/llap/constraints_optimization.q.out PRE-CREATION Diff: https://reviews.apache.org/r/68868/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

://reviews.apache.org/r/68868/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

r several queries, specially those containing many joins, but it > > would be worth leaving a comment and maybe monitoring it in future. Good point, left a note - Vineet --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

://reviews.apache.org/r/68868/diff/2-3/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

735a4db2ee Diff: https://reviews.apache.org/r/68868/diff/4/ Changes: https://reviews.apache.org/r/68868/diff/3-4/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

/clientpositive/llap/materialized_view_rewrite_1.q.out 735a4db2ee Diff: https://reviews.apache.org/r/68868/diff/5/ Changes: https://reviews.apache.org/r/68868/diff/4-5/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

/diff/6/ Changes: https://reviews.apache.org/r/68868/diff/5-6/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

/llap/materialized_view_rewrite_1.q.out 735a4db2ee Diff: https://reviews.apache.org/r/68868/diff/7/ Changes: https://reviews.apache.org/r/68868/diff/6-7/ Testing --- Thanks, Vineet Garg

Re: Review Request 68868: HIVE-17043: Remove non unique columns from group by keys if not referenced later

/materialized_view_rewrite_1.q.out 735a4db2ee Diff: https://reviews.apache.org/r/68868/diff/8/ Changes: https://reviews.apache.org/r/68868/diff/7-8/ Testing --- Thanks, Vineet Garg

Review Request 68967: HIVE-20660: Group by statistics estimation could be improved by bounding the total number of rows to source table

/test/queries/clientpositive/annotate_stats_groupby.q 081f057053 ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 932e208097 Diff: https://reviews.apache.org/r/68967/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

suited in ExprNodeDescUtils ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java Line 1287 (original), 1400 (patched) <https://reviews.apache.org/r/69019/#comment294336> Currently we don't handle case such as (s,t) IN ('c', 'b'). Here right sid

Re: [ANNOUNCE] New committer: Nishant Bangarwa

Congrats Nishant! > On Oct 19, 2018, at 8:36 AM, Gunther Hagleitner > wrote: > > Congrats Nishant! > > Cheers, > Gunther. > > From: Andrew Sherman > Sent: Friday, October 19, 2018 8:34 AM > To: dev@hive.apache.org > Subject: Re: [ANNOUNCE] New committe

Re: Review Request 69019: HIVE-20617 Fix type of constants in IN expressions to have correct type

> On Oct. 19, 2018, 7:54 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out > > Line 371 (original), 370 (patched) > > > > > > Unrelated to this patch, but I think subq de

Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

b7c31bdfca ql/src/test/queries/clientpositive/constraints_optimization.q 70ab8509c5 ql/src/test/results/clientpositive/llap/constraints_optimization.q.out 96caa4d6dd Diff: https://reviews.apache.org/r/69202/diff/1/ Testing --- Thanks, Vineet Garg

Review Request 69215: HIVE-20778 Join reordering may not be triggered if all joins in plan are created by decorrelation logic

, Vineet Garg

Re: Ptests not working

Ptest is again stuck “Waiting for next available executor”. Vineet On Nov 1, 2018, at 1:37 PM, Vihang Karajgaonkar mailto:vih...@cloudera.com.INVALID>> wrote: Precommit jobs are back up. The older precommit queue was drained by the infrastructure team so you may have to re-submit the patch in c

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

/69202/diff/2/ Changes: https://reviews.apache.org/r/69202/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210258 --- On Nov. 5, 2018, 10:57 p.m., Vineet Garg wrote: > > --- > Thi

Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

Diff: https://reviews.apache.org/r/69257/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

://reviews.apache.org/r/69202/diff/3/ Changes: https://reviews.apache.org/r/69202/diff/2-3/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

/perf/tez/query97.q.out 21daca3aed ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f Diff: https://reviews.apache.org/r/69257/diff/2/ Changes: https://reviews.apache.org/r/69257/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

://reviews.apache.org/r/69202/diff/3-4/ Testing --- Thanks, Vineet Garg

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

look like it take join condition into account while determining lineage. - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210362 ------

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

://reviews.apache.org/r/69202/diff/4-5/ Testing --- Thanks, Vineet Garg

Review Request 69294: HIVE-20826 Enhance HiveSemiJoin rule to convert join + group by on left side to Left Semi Join

/spark/semijoin.q.out a787bce4b4 Diff: https://reviews.apache.org/r/69294/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

/results/clientpositive/perf/tez/query97.q.out 21daca3aed ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f Diff: https://reviews.apache.org/r/69257/diff/3/ Changes: https://reviews.apache.org/r/69257/diff/2-3/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

://reviews.apache.org/r/69257/diff/3-4/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

/clientpositive/perf/tez/query97.q.out 21daca3aed ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f Diff: https://reviews.apache.org/r/69257/diff/5/ Changes: https://reviews.apache.org/r/69257/diff/4-5/ Testing --- Thanks, Vineet Garg

Re: Review Request 69294: HIVE-20826 Enhance HiveSemiJoin rule to convert join + group by on left side to Left Semi Join

/2/ Changes: https://reviews.apache.org/r/69294/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

.q.out 1f681944cd Diff: https://reviews.apache.org/r/69257/diff/6/ Changes: https://reviews.apache.org/r/69257/diff/5-6/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

/69257/diff/7/ Changes: https://reviews.apache.org/r/69257/diff/6-7/ Testing --- Thanks, Vineet Garg

Re: Review Request 69257: HIVE-20842 Fix logic introduced in HIVE-20660 to estimate statistics for group by

/ Changes: https://reviews.apache.org/r/69257/diff/7-8/ Testing --- Thanks, Vineet Garg

Review Request 69515: HIVE-21007 Semi join + Union can lead to wrong plans

--- Thanks, Vineet Garg

Re: Review Request 69515: HIVE-21007 Semi join + Union can lead to wrong plans

/test/results/clientpositive/perf/tez/query54.q.out a706e9459e ql/src/test/results/clientpositive/perf/tez/query8.q.out 9eb50396f9 Diff: https://reviews.apache.org/r/69515/diff/2/ Changes: https://reviews.apache.org/r/69515/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 69515: HIVE-21007 Semi join + Union can lead to wrong plans

/test/results/clientpositive/perf/tez/query54.q.out a706e9459e ql/src/test/results/clientpositive/perf/tez/query8.q.out 9eb50396f9 Diff: https://reviews.apache.org/r/69515/diff/3/ Changes: https://reviews.apache.org/r/69515/diff/2-3/ Testing --- Thanks, Vineet Garg

Re: Review Request 69515: HIVE-21007 Semi join + Union can lead to wrong plans

the plan? Probably we do not > > need the quick bail out. I am addressing this is latest patch - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69515/#review2

Re: Review Request 69515: HIVE-21007 Semi join + Union can lead to wrong plans

/test/results/clientpositive/perf/tez/query54.q.out a706e9459e ql/src/test/results/clientpositive/perf/tez/query8.q.out 9eb50396f9 Diff: https://reviews.apache.org/r/69515/diff/4/ Changes: https://reviews.apache.org/r/69515/diff/3-4/ Testing --- Thanks, Vineet Garg

Review Request 69535: HIVE-16100 Dynamic Sorted Partition optimizer loses sibling operators

://reviews.apache.org/r/69535/diff/1/ Testing --- Thanks, Vineet Garg

Re: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

+1 on early move. > On Dec 11, 2018, at 12:46 PM, Slim Bouguerra wrote: > > +1 on Early move. > > Having direct write access to Github is a good first step to move toward > one place that can be used to review and merge pull requests IMO. > > On Dec 11, 2018, at 12:06 PM, Alan Gates wrote: >

Re: Review Request 70031: HIVE-21167

ey, '45' from src s2 where key > 1 group by key) sub group by key; ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out Line 1332 (original), 1332 (patched) <https://reviews.apache.org/r/70031/#comment298897> Do you know the reason this size changed?

Re: Review Request 70031: HIVE-21167

Lines 1850 (patched) <https://reviews.apache.org/r/70031/#comment298963> Add NULL check for the parent. If a plan doesn't have reduce sink operator and you hit table scan its parent will be NULL - Vineet Garg On Feb. 22, 2019, 7:19 a.m., Deepak Ja

Re: [DISCUSS] Move gitbox notification emails to another list?

FYI I have opened an INFRA jira for RB issue: https://issues.apache.org/jira/browse/INFRA-17926. I personally prefer it over github pull request for reviews. On Thu, Feb 28, 2019 at 10:50 AM Jesus Camacho Rodriguez < jcamachorodrig...@hortonworks.com> wrote: > I think it is a good idea, I can as

Re: Review Request 70190: HIVE-21316 Varchar cmp

archar.q.out Line 125 (original) <https://reviews.apache.org/r/70190/#comment300171> Strange that this is not being vectorized anymore. - Vineet Garg On March 12, 2019, 11:55 a.m., Zoltan Haindrich wrote: > > --- > This is

Review Request 70326: HIVE-21230: LEFT OUTER JOIN does not generate transitive IS NOT NULL filter on right side (HiveJoinAddNotNullRule bails out for outer joins)

/clientpositive/vectorized_join46_mr.q.out 52107e91f8 Diff: https://reviews.apache.org/r/70326/diff/1/ Testing --- Thanks, Vineet Garg

Re: How to disable notification

Hi, You must be subscribed to iss...@hive.apache.org . Try unsubscribing from the mailing list. Vineet > On Mar 18, 2019, at 11:27 PM, Sandeep Katta > wrote: > > From Hive Dev mailing list I am getting mails for the following actions > > 1.Newly created jiras

Re: Review Request 70326: HIVE-21230: LEFT OUTER JOIN does not generate transitive IS NOT NULL filter on right side (HiveJoinAddNotNullRule bails out for outer joins)

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70326/#review214126 ------- On March 27, 2019, 5:39 p.m., Vineet Garg wrote: > > --- >

Re: Review Request 70326: HIVE-21230: LEFT OUTER JOIN does not generate transitive IS NOT NULL filter on right side (HiveJoinAddNotNullRule bails out for outer joins)

/vector_outer_join6.q.out bd938f631a ql/src/test/results/clientpositive/vectorized_join46_mr.q.out 52107e91f8 Diff: https://reviews.apache.org/r/70326/diff/2/ Changes: https://reviews.apache.org/r/70326/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: Review Request 70326: HIVE-21230: LEFT OUTER JOIN does not generate transitive IS NOT NULL filter on right side (HiveJoinAddNotNullRule bails out for outer joins)

/vector_outer_join6.q.out bd938f631a ql/src/test/results/clientpositive/vectorized_join46_mr.q.out 52107e91f8 Diff: https://reviews.apache.org/r/70326/diff/3/ Changes: https://reviews.apache.org/r/70326/diff/2-3/ Testing --- Thanks, Vineet Garg

Re: Review Request 70326: HIVE-21230: LEFT OUTER JOIN does not generate transitive IS NOT NULL filter on right side (HiveJoinAddNotNullRule bails out for outer joins)

/vector_outer_join6.q.out bd938f631a ql/src/test/results/clientpositive/vectorized_join46_mr.q.out 52107e91f8 Diff: https://reviews.apache.org/r/70326/diff/4/ Changes: https://reviews.apache.org/r/70326/diff/3-4/ Testing --- Thanks, Vineet Garg

Re: Review Request 71091: ACID: getAcidState() should cache a recursive dir listing locally

filtered out would be nice. ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java Lines 29 (patched) <https://reviews.apache.org/r/71091/#comment304061> Ununsed import statements - Vineet Garg On July 22, 2019, 5:35 p.m.

Re: Review Request 72073: HIVE-22808

e, but for now we can copy the implementation of LogicalTableFunctionScan from calcite and resuse it for HiveTableFunctionScan - Vineet Garg On Feb. 4, 2020, 5:26 a.m., Krisztian Kasa wrote: > > --- > This is an automatically gener

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

t partitioning, with the change this optimization is not kicking in anymore (PARTITION_BUCKET_SORTED keyword is missing in File sink). We should understand why is it happening and may be either fix it or log a jira. - Vineet Garg On Jan. 30, 2020, 3:30 p

Re: Review Request 72063: HIVE-10362: Support Type check/conversion in dynamic partition column

u'll need to run "TestTezMiniLlapCliDriver' to genrate q file - Vineet Garg On Feb. 6, 2020, 2:22 p.m., Karen Coppage wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 72431: HIVE-23206

ut Lines 240 (patched) <https://reviews.apache.org/r/72431/#comment308968> This looks like an extra join as compared to earlier (including few more in this plan). Any idea why is this? - Vineet Garg On April 27, 2020, 6:11 a.m., Kr

Re: Review Request 72466: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 2

entpositive/llap/insert0.q.out Line 126 (original), 122 (patched) <https://reviews.apache.org/r/72466/#comment309119> result changed - Vineet Garg On May 4, 2020, 10:40 a.m., Miklos Gergely wrote: > > --- > This is an a

Re: Review Request 72485: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 3

issing ql/src/test/results/clientpositive/llap/partition_discovery.q.out Line 317 (original) <https://reviews.apache.org/r/72485/#comment309284> msck not working - Vineet Garg On May 7, 2020, 5:04 p.m., Miklos Gergely wrote: > >

Re: Review Request 72491: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 4

/udf_mask_show_last_n.q.out Line 80 (original), 78 (patched) <https://reviews.apache.org/r/72491/#comment309339> Result mismatch - Vineet Garg On May 11, 2020, 7:05 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e

Review Request 62525: HIVE-17538 Enhance estimation of stats to estimate even if only one column is missing stats

--- Updated existing q files Thanks, Vineet Garg

Re: Review Request 62408: HIVE-17519 Transpose column stats display

/TextMetaDataTable.java Lines 30 (patched) <https://reviews.apache.org/r/62408/#comment262597> Is this an unused method? I don't see any code using this in patch. - Vineet Garg On Sept. 19, 2017, 2:11 p.m., Zoltan Hain

Review Request 62728: Fix for Explain plan not working

, Vineet Garg

Re: [Announce] New committer: Anishek Agarwal

Congrats Anishek. > On Sep 29, 2017, at 11:36 AM, Peter Vary wrote: > > Congratulations Anishek! > >> On Sep 29, 2017, at 7:55 PM, Ashutosh Chauhan wrote: >> >> The Project Management Committee (PMC) for Apache Hive has invited Anishek >> Agarwal to become a committer and we are pleased to an

Re: [Announce] New committer: Sankar Hariappan

Congrats Sankar > On Sep 29, 2017, at 4:00 PM, Vaibhav Gumashta > wrote: > > Congratulations Sankar! > > On 9/29/17, 3:58 PM, "Thejas Nair" wrote: > >> Congrats Sankar! >> >> On Fri, Sep 29, 2017 at 11:36 AM, Peter Vary wrote: >> >>> Congratulations Sankar! >>> On Sep 29, 2017, at 7

Re: Review Request 62728: Fix for Explain plan not working

da76c3ca28 Diff: https://reviews.apache.org/r/62728/diff/2/ Changes: https://reviews.apache.org/r/62728/diff/1-2/ Testing --- Thanks, Vineet Garg

Review Request 62776: HIVE-16511 CBO looses inner casts on constants of complex type

l/src/test/results/clientpositive/perf/tez/query86.q.out 6b59dd254f ql/src/test/results/clientpositive/vector_coalesce.q.out 445a246cb6 Diff: https://reviews.apache.org/r/62776/diff/1/ Testing --- Thanks, Vineet Garg

  1   2   3   4   5   6   >