Re: Review Request 71784: HiveProtoLoggingHook might consume lots of memory

2019-11-27 Thread Harish Jaiprakash via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218841 --- Ship it! LGTM. - Harish Jaiprakash On Nov. 21, 2019, 3:10

Re: Review Request 71784: HiveProtoLoggingHook might consume lots of memory

2019-11-20 Thread Harish Jaiprakash via Review Board
> On Nov. 20, 2019, 7:32 a.m., Harish Jaiprakash wrote: > > ql/src/test/org/apache/hadoop/hive/ql/hooks/TestHiveProtoLoggingHook.java > > Lines 176 (patched) > > <https://reviews.apache.org/r/71784/diff/1/?file=2173908#file2173908line176> > > > > We

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Harish Jaiprakash
/TestHiveProtoLoggingHook.java Lines 176 (patched) <https://reviews.apache.org/r/71784/#comment306576> We expect the dequeue to have not happened by this time. There is no guarantee, since its another thread. Can we atleast add a comment that this test can fail intermittently? - Harish Jaiprakash On N

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Harish Jaiprakash
writes are not happening in different files. FYI, the events are lost since it is not written to the hdfs file and DAS will not get these events. But that is better than crashing hiveserver2. - Harish Jaiprakash On Nov. 19, 2019, 9:13 p.m., Attila Magyar wrote

[jira] [Created] (HIVE-22148) S3A delegation tokens are not added in the job config of the Compactor.

2019-08-27 Thread Harish Jaiprakash (Jira)
Harish Jaiprakash created HIVE-22148: Summary: S3A delegation tokens are not added in the job config of the Compactor. Key: HIVE-22148 URL: https://issues.apache.org/jira/browse/HIVE-22148

[jira] [Created] (HIVE-21651) Move protobuf serde into hive-exec.

2019-04-25 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-21651: Summary: Move protobuf serde into hive-exec. Key: HIVE-21651 URL: https://issues.apache.org/jira/browse/HIVE-21651 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-21362) Add an input format and serde to read from protobuf files.

2019-02-28 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-21362: Summary: Add an input format and serde to read from protobuf files. Key: HIVE-21362 URL: https://issues.apache.org/jira/browse/HIVE-21362 Project: Hive

[jira] [Created] (HIVE-21250) NPE in HiveProtoLoggingHook for eventPerFile mode.

2019-02-11 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-21250: Summary: NPE in HiveProtoLoggingHook for eventPerFile mode. Key: HIVE-21250 URL: https://issues.apache.org/jira/browse/HIVE-21250 Project: Hive

[jira] [Created] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.

2018-10-15 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-20746: Summary: HiveProtoHookLogger does not close file at end of day. Key: HIVE-20746 URL: https://issues.apache.org/jira/browse/HIVE-20746 Project: Hive

[jira] [Created] (HIVE-20383) Invalid queue name and synchronisation issues in hive proto events hook.

2018-08-14 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-20383: Summary: Invalid queue name and synchronisation issues in hive proto events hook. Key: HIVE-20383 URL: https://issues.apache.org/jira/browse/HIVE-20383

[jira] [Created] (HIVE-20011) Move away from append mode in proto logging hook

2018-06-27 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-20011: Summary: Move away from append mode in proto logging hook Key: HIVE-20011 URL: https://issues.apache.org/jira/browse/HIVE-20011 Project: Hive Issue

[jira] [Created] (HIVE-19921) Fix perf duration and queue name in HiveProtoLoggingHook

2018-06-16 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-19921: Summary: Fix perf duration and queue name in HiveProtoLoggingHook Key: HIVE-19921 URL: https://issues.apache.org/jira/browse/HIVE-19921 Project: Hive

[jira] [Created] (HIVE-19646) Filesystem closed error in HiveProtoLoggingHook

2018-05-22 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-19646: Summary: Filesystem closed error in HiveProtoLoggingHook Key: HIVE-19646 URL: https://issues.apache.org/jira/browse/HIVE-19646 Project: Hive Issue

[jira] [Created] (HIVE-19288) Implement protobuf logging hive hook.

2018-04-24 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-19288: Summary: Implement protobuf logging hive hook. Key: HIVE-19288 URL: https://issues.apache.org/jira/browse/HIVE-19288 Project: Hive Issue Type

Re: Review Request 65579: HIVE-18658 WM: allow not specifying scheduling policy when creating a pool

2018-02-08 Thread Harish Jaiprakash
are fine. ql/src/test/results/clientpositive/llap/resourceplan.q.out Lines 1545 (patched) <https://reviews.apache.org/r/65579/#comment277275> Is this expected? I know its not related to the code changes, but this might supress someother error. - Harish Jaiprakash On Feb. 9, 2018, 4:

[jira] [Created] (HIVE-18630) Resource plan validate/activate does not verify trigger expressions.

2018-02-05 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-18630: Summary: Resource plan validate/activate does not verify trigger expressions. Key: HIVE-18630 URL: https://issues.apache.org/jira/browse/HIVE-18630 Project

[jira] [Created] (HIVE-18617) Workload management Action parser does not generate the correct pool path.

2018-02-02 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-18617: Summary: Workload management Action parser does not generate the correct pool path. Key: HIVE-18617 URL: https://issues.apache.org/jira/browse/HIVE-18617

Re: Review Request 65206: HIVE-18438 WM RP: it's impossible to unset things

2018-01-18 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65206/#review195699 --- Ship it! Ship It! - Harish Jaiprakash On Jan. 18, 2018, 9

Re: Review Request 65185: HIVE-18457 improve show plan output (triggers, mappings)

2018-01-17 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65185/#review195692 --- Ship it! Ship It! - Harish Jaiprakash On Jan. 18, 2018, 2

Re: Review Request 65185: HIVE-18457 improve show plan output (triggers, mappings)

2018-01-17 Thread Harish Jaiprakash
> On Jan. 17, 2018, 11:27 a.m., Harish Jaiprakash wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > > Lines 883 (patched) > > <https://reviews.apache.org/r/65185/diff/1/?file=1940765#file1940765line884> > > > >

Re: Review Request 65185: HIVE-18457 improve show plan output (triggers, mappings)

2018-01-16 Thread Harish Jaiprakash
of foreign key constraints unusedTriggers and unusedMappings should not happen. - Harish Jaiprakash On Jan. 17, 2018, 7:45 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 65002: HIVE-18229 add the unmanaged mapping command

2018-01-08 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65002/#review195011 --- Ship it! Ship It! - Harish Jaiprakash On Jan. 9, 2018, 7:30

Re: Review Request 64999: HIVE-18004 investigate deriving app name from JDBC connection for pool mapping

2018-01-07 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64999/#review194928 --- Ship it! Ship It! - Harish Jaiprakash On Jan. 6, 2018, 5:21

Re: Review Request 65002: HIVE-18229 add the unmanaged mapping command

2018-01-07 Thread Harish Jaiprakash
ut a mapping with null pool can be changed to have a pool. I suppose we should prevent that too. Should we throw an error informing that mapping cannot change from managed to unmanaged and vice versa. - Harish Jaiprakash On Jan. 6, 2018, 8:55 a.m., Sergey She

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

2017-12-18 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64595/#review194053 --- Ship it! Ship It! - Harish Jaiprakash On Dec. 16, 2017, 4

Re: Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

2017-12-18 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64555/#review194052 --- Ship it! Ship It! - Harish Jaiprakash On Dec. 16, 2017, 3

Re: Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

2017-12-18 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64433/#review194051 --- Ship it! Ship It! - Harish Jaiprakash On Dec. 16, 2017, 2

Re: Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

2017-12-14 Thread Harish Jaiprakash
- > > (Updated Dec. 13, 2017, 3:16 a.m.) > > > Review request for hive, Harish Jaiprakash and Prasanth_J. > > > Repository: hive-git > > > Description > --- > > see jira > > > Diffs > - > >

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

2017-12-14 Thread Harish Jaiprakash
/DDLSemanticAnalyzer.java Lines 1112 (patched) <https://reviews.apache.org/r/64595/#comment272422> We can use the API to add an invalid policy. Should we have this validation in the ObjectStore? Maybe the enum could be moved into the data classes like the resource plan status. - Harish Jaiprakash On D

Re: Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

2017-12-10 Thread Harish Jaiprakash
views.apache.org/r/64433/ > --- > > (Updated Dec. 8, 2017, 6:41 a.m.) > > > Review request for hive, Harish Jaiprakash and Prasanth_J. > > > Repository: hive-git > > > Description > --- > > see jira > > > Diffs > - > > > itests

[jira] [Created] (HIVE-18210) create resource plan allows duplicates

2017-12-03 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-18210: Summary: create resource plan allows duplicates Key: HIVE-18210 URL: https://issues.apache.org/jira/browse/HIVE-18210 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18179) Implement validate resource plan.

2017-11-29 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-18179: Summary: Implement validate resource plan. Key: HIVE-18179 URL: https://issues.apache.org/jira/browse/HIVE-18179 Project: Hive Issue Type: Sub-task

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-08 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63346/#review190432 --- Ship it! Ship It! - Harish Jaiprakash On Nov. 8, 2017, 2:25

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-07 Thread Harish Jaiprakash
115 (original), 115 (patched) <https://reviews.apache.org/r/63346/#comment267575> POOL_ID here should also become BIGINT. - Harish Jaiprakash On Nov. 7, 2017, 8:39 a.m., Sergey Shelukhin wrote: > > --- > This is a

[jira] [Created] (HIVE-17954) Implement create, alter and drop pool API's.

2017-10-31 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17954: Summary: Implement create, alter and drop pool API's. Key: HIVE-17954 URL: https://issues.apache.org/jira/browse/HIVE-17954 Project: Hive Issue Type

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-28 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63346/#review189514 --- Ship it! Ship It! - Harish Jaiprakash On Oct. 28, 2017, 2

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread Harish Jaiprakash
> On Oct. 27, 2017, 11:27 a.m., Harish Jaiprakash wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > > Lines 878 (patched) > > <https://reviews.apache.org/r/63346/diff/1/?file=1869929#file1869929line882> > > > > Desc is ov

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread Harish Jaiprakash
me when we have poolPath. - Harish Jaiprakash On Oct. 27, 2017, 6:18 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[jira] [Created] (HIVE-17910) Hive does not build, missing files in classification sub-module.

2017-10-26 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17910: Summary: Hive does not build, missing files in classification sub-module. Key: HIVE-17910 URL: https://issues.apache.org/jira/browse/HIVE-17910 Project: Hive

[jira] [Created] (HIVE-17884) Implement create, alter and drop workload management triggers.

2017-10-24 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17884: Summary: Implement create, alter and drop workload management triggers. Key: HIVE-17884 URL: https://issues.apache.org/jira/browse/HIVE-17884 Project: Hive

[jira] [Created] (HIVE-17839) Cannot generate thrift definitions in standalone-metastore.

2017-10-18 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17839: Summary: Cannot generate thrift definitions in standalone-metastore. Key: HIVE-17839 URL: https://issues.apache.org/jira/browse/HIVE-17839 Project: Hive

[jira] [Created] (HIVE-17771) Implement create and show resource plan.

2017-10-11 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17771: Summary: Implement create and show resource plan. Key: HIVE-17771 URL: https://issues.apache.org/jira/browse/HIVE-17771 Project: Hive Issue Type

[jira] [Created] (HIVE-17566) Create schema required for workload management.

2017-09-20 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17566: Summary: Create schema required for workload management. Key: HIVE-17566 URL: https://issues.apache.org/jira/browse/HIVE-17566 Project: Hive Issue

[jira] [Created] (HIVE-17019) Add support to download debugging information as an archive.

2017-07-04 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-17019: Summary: Add support to download debugging information as an archive. Key: HIVE-17019 URL: https://issues.apache.org/jira/browse/HIVE-17019 Project: Hive