Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

2019-03-21 Thread Morio Ramdenbourg via Review Board
the 1 object - which says that the getAllDatabases will result in > > exactly 1 object. > > > > How could that happen that there are lingering objects when we create a > > new client? Is there a way to get rid of the lingering object somehow, and > > then test the

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

2019-03-21 Thread Morio Ramdenbourg via Review Board
878 ------- On March 20, 2019, 6:43 p.m., Morio Ramdenbourg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

2019-03-20 Thread Morio Ramdenbourg via Review Board
ew :) - Morio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70256/#review213843 --- On March 20, 2019, 6:43 p.m., Morio Ra

Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

2019-03-20 Thread Morio Ramdenbourg via Review Board
the flakiness on this test. Diffs - standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 77e0c98265e7b561f2eb39536e3251dd92e9cab0 Diff: https://reviews.apache.org/r/70256/diff/1/ Testing --- Unit tests run Thanks, Morio

[jira] [Created] (HIVE-21480) Fix test TestRemoteHiveMetaStore.testJDOPersistanceManagerCleanup

2019-03-19 Thread Morio Ramdenbourg (JIRA)
Morio Ramdenbourg created HIVE-21480: Summary: Fix test TestRemoteHiveMetaStore.testJDOPersistanceManagerCleanup Key: HIVE-21480 URL: https://issues.apache.org/jira/browse/HIVE-21480 Project

[jira] [Created] (HIVE-21364) Reconsider the value of the "metastore.dbaccess.ssl.use.SSL" property

2019-02-28 Thread Morio Ramdenbourg (JIRA)
Morio Ramdenbourg created HIVE-21364: Summary: Reconsider the value of the "metastore.dbaccess.ssl.use.SSL" property Key: HIVE-21364 URL: https://issues.apache.org/jira/browse/HIVE-21364

[jira] [Created] (HIVE-21309) Support for Schema Tool to use HMS TLS to the Database properties

2019-02-21 Thread Morio Ramdenbourg (JIRA)
Morio Ramdenbourg created HIVE-21309: Summary: Support for Schema Tool to use HMS TLS to the Database properties Key: HIVE-21309 URL: https://issues.apache.org/jira/browse/HIVE-21309 Project

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-25 Thread Morio Ramdenbourg via Review Board
://reviews.apache.org/r/69834/diff/4/ Changes: https://reviews.apache.org/r/69834/diff/3-4/ Testing --- - Existing unit test coverage - Manual testing by verifying that these properties can configure TLS to a MySQL DB Thanks, Morio Ramdenbourg

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-25 Thread Morio Ramdenbourg via Review Board
file2122353line371> > > > > nit, instead of defaulting to default .. may be just say Using default > > Java truststore password. Done - Morio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212345 -

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-25 Thread Morio Ramdenbourg via Review Board
ps://reviews.apache.org/r/69834/#review212335 ------- On Jan. 25, 2019, 1:38 a.m., Morio Ramdenbourg wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-25 Thread Morio Ramdenbourg via Review Board
TLS to a MySQL DB Thanks, Morio Ramdenbourg

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-24 Thread Morio Ramdenbourg via Review Board
lly generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/#review212295 --- On Jan. 25, 2019, 1:38 a.m., Morio Ramdenbourg wrote: > > --- > This is an autom

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-24 Thread Morio Ramdenbourg via Review Board
coverage - Manual testing by verifying that these properties can configure TLS to a MySQL DB Thanks, Morio Ramdenbourg

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-24 Thread Morio Ramdenbourg via Review Board
--- - Existing unit test coverage - Manual testing by verifying that these properties can configure TLS to a MySQL DB Thanks, Morio Ramdenbourg

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-24 Thread Morio Ramdenbourg via Review Board
- Manual testing by verifying that these properties can configure TLS to a MySQL DB Thanks, Morio Ramdenbourg

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-24 Thread Morio Ramdenbourg via Review Board
TLS to a MySQL DB Thanks, Morio Ramdenbourg

Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

2019-01-24 Thread Morio Ramdenbourg via Review Board
29738ba19b0d5ed9ec224d2288c0c1c922d0674c Diff: https://reviews.apache.org/r/69834/diff/1/ Testing --- - Existing unit test coverage - Manual testing by verifying that these properties can configure TLS to a MySQL DB Thanks, Morio Ramdenbourg

[jira] [Created] (HIVE-21083) Remove the requirement to specify the truststore file location when TLS to the database is turned on

2019-01-03 Thread Morio Ramdenbourg (JIRA)
Morio Ramdenbourg created HIVE-21083: Summary: Remove the requirement to specify the truststore file location when TLS to the database is turned on Key: HIVE-21083 URL: https://issues.apache.org/jira/browse

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-21 Thread Morio Ramdenbourg via Review Board
> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 2458 (patched) > > <https://reviews.apache.org/r/69585/diff/2/?file=211

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-19 Thread Morio Ramdenbourg via Review Board
tore.java Lines 4621 (patched) <https://reviews.apache.org/r/69585/#comment296579> This is the same method as the one on the HiveMetaStoreClient. Would it be possible to move it to a common method under hive-standalone-metastore-common? - Morio Ramdenbourg On Dec. 19, 2018, 10:50 p.m., Na Li wrote: >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-17 Thread Morio Ramdenbourg via Review Board
which one I put. Will keep the IllegalArgumentException :) - Morio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211367 -

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-17 Thread Morio Ramdenbourg via Review Board
Wireshark, and ensured that none of the data was human-readable. I plan to upload a document to our Wiki explaining the process of enabling TLS to these databases. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-15 Thread Morio Ramdenbourg via Review Board
ot;Configuring SSL using a > > deprecated key " + ConfVars.DBACCESS_SSL_PROPS.toString() + ". This may be > > removed in the future. See HIVE-20992 for more details." Done > On Dec. 14, 2018, 10:43 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metasto

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-15 Thread Morio Ramdenbourg via Review Board
t captures to Wireshark, and ensured that none of the data was human-readable. I plan to upload a document to our Wiki explaining the process of enabling TLS to these databases. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-13 Thread Morio Ramdenbourg via Review Board
generic DB hosts and setting them up with SSL. Once SSL was set up, I triggered the metastore to perform database calls, and captured packets using tcpdump. I then uploaded my packet captures to Wireshark, and ensured that none of the data was human-readable. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-13 Thread Morio Ramdenbourg via Review Board
o our Wiki explaining the process of enabling TLS to these databases. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-13 Thread Morio Ramdenbourg via Review Board
perties. 2. Performed some manual and sanity tests to ensure that SSL was still configurable to a remote DB. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-13 Thread Morio Ramdenbourg via Review Board
deprecated here and maybe increase the LOG to warn > > and note that this might be changed in next version of hive. Done - Morio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-10 Thread Morio Ramdenbourg via Review Board
remote DB. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-10 Thread Morio Ramdenbourg via Review Board
Tests: 1. Unit tests were added to cover the functionality of configuring the Java system properties. 2. Performed some manual and sanity tests to ensure that SSL was still configurable to a remote DB. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-10 Thread Morio Ramdenbourg via Review Board
st > > store path is empty. Set the xxx property to enable SSL. Disabling SSL and > > continuing" Done! - Morio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-10 Thread Morio Ramdenbourg via Review Board
Unit tests were added to cover the functionality of configuring the Java system properties. 2. Performed some manual and sanity tests to ensure that SSL was still configurable to a remote DB. Thanks, Morio Ramdenbourg

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-10 Thread Morio Ramdenbourg via Review Board
ctionality of configuring the Java system properties. 2. Performed some manual and sanity tests to ensure that SSL was still configurable to a remote DB. Thanks, Morio Ramdenbourg

[jira] [Created] (HIVE-21024) Remove the property metastore.dbaccess.ssl.properties

2018-12-10 Thread Morio Ramdenbourg (JIRA)
Morio Ramdenbourg created HIVE-21024: Summary: Remove the property metastore.dbaccess.ssl.properties Key: HIVE-21024 URL: https://issues.apache.org/jira/browse/HIVE-21024 Project: Hive

Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

2018-12-07 Thread Morio Ramdenbourg via Review Board
properties. 2. Performed some manual and sanity tests to ensure that SSL was still configurable to a remote DB. Thanks, Morio Ramdenbourg

[jira] [Created] (HIVE-20992) Split the config "hive.metastore.dbaccess.ssl.properties" into more meaningful configs

2018-11-30 Thread Morio Ramdenbourg (JIRA)
Morio Ramdenbourg created HIVE-20992: Summary: Split the config "hive.metastore.dbaccess.ssl.properties" into more meaningful configs Key: HIVE-20992 URL: https://issues.apache.org/jira/browse/

Disabling Basic Stats on a Per-Session Basis

2018-11-20 Thread Morio Ramdenbourg
ontext. This change should have contained some way to allow the environment context to request to disable this. Does anyone know which commit this is? Thanks, Morio Ramdenbourg