Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

> On March 21, 2019, 10:18 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > > Lines 3153-3155 (patched) > > > > > > My

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

> On March 21, 2019, 10:18 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > > Lines 3153-3155 (patched) > > > > > > My

Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

> On March 20, 2019, 6:41 p.m., Karthik Manamcheri wrote: > > LGTM. get someone else a little more familiar with the tests (vihang, pvary > > or someone) to also do a quick review. thanks. Thanks for the review :) - Morio --- This is

Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70256/ --- Review request for hive, Adam Holley, Karthik Manamcheri, Karen Coppage, and

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 7:59 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

> On Jan. 25, 2019, 7:41 p.m., Vihang Karajgaonkar wrote: > > Some minor comments related to logs. Rest looks good. Thanks for the feedback > On Jan. 25, 2019, 7:41 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

> On Jan. 25, 2019, 5:08 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > > Line 1082 (original) > > > > > > Add a test

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 7:22 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

> On Jan. 24, 2019, 11:21 p.m., Karthik Manamcheri wrote: > > Thanks for the feedback > On Jan. 24, 2019, 11:21 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Line 465 (original), 466

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 1:38 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 25, 2019, 1:38 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 24, 2019, 11:16 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- (Updated Jan. 24, 2019, 11:13 p.m.) Review request for hive, Adam Holley,

Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69834/ --- Review request for hive, Adam Holley, Karthik Manamcheri, Na Li, and Vihang

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 2458 (patched) > > > > > > This

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211446 ---

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 17, 2018, 8:35 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes. Couple of minor comments. Rest looks good to me. Thanks. Will make these minor changes right away. > On Dec. 17, 2018, 8:35 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 17, 2018, 9:17 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 14, 2018, 10:43 p.m., Vihang Karajgaonkar wrote: > > Thanks for the feedback. > On Dec. 14, 2018, 10:43 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 462 (patched) > >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 16, 2018, 3:11 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 14, 2018, 1:25 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 14, 2018, 1:26 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 14, 2018, 1:23 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 12, 2018, 10:54 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 472 (patched) > > > > > > Is this

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:51 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:46 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 8, 2018, 7:49 p.m., Karthik Manamcheri wrote: > > Thanks for the feedback! > On Dec. 8, 2018, 7:49 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 460 (patched) > >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:40 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:39 p.m.) Review request for hive, Adam Holley,

Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- Review request for hive, Adam Holley, Karthik Manamcheri, Peter Vary, and