Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review52006 --- Ship it! Ship It! - Lefty Leverenz On Sept. 1, 2014, 5:14 a.m.,

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Sept. 1, 2014, 5:52 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 1496-1497 > > > > > > Mismatch between default units "1800s" and > > TimeValidator(TimeUni

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51969 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Sept. 1, 2014, 5:14 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 31, 2014, 6:24 a.m., Lefty Leverenz wrote: > > All my bad. I hate meetings. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51951 --

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51951 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51882 --- Ship it! Only minor comments mostly on lines exceeding Checkstyle's

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Aug. 29, 2014, 9:05 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 28, 2014, 7:56 a.m., Lefty Leverenz wrote: > > > > Navis Ryu wrote: > Addressing previous comments, I've revised validator to describe itself > to description. For StringSet validator, the description of the conf will be > started with something like, "Expects one of [textfile, s

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 28, 2014, 7:56 a.m., Lefty Leverenz wrote: > > > > Navis Ryu wrote: > Addressing previous comments, I've revised validator to describe itself > to description. For StringSet validator, the description of the conf will be > started with something like, "Expects one of [textfile, s

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 28, 2014, 7:56 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1523 > > > > > > Please restore "(in seconds)" to description and specify other time > > units

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 28, 2014, 7:56 a.m., Lefty Leverenz wrote: > > > > Navis Ryu wrote: > Addressing previous comments, I've revised validator to describe itself > to description. For StringSet validator, the description of the conf will be > started with something like, "Expects one of [textfile, s

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 28, 2014, 7:56 a.m., Lefty Leverenz wrote: > > Addressing previous comments, I've revised validator to describe itself to description. For StringSet validator, the description of the conf will be started with something like, "Expects one of [textfile, sequencefile, rcfile, orc]." an

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51760 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Aug. 28, 2014, 2:31 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 27, 2014, 2:32 p.m., Lars Francke wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, > > line 112 > > > > > > Hmm... this minimum should be documented in HiveConf and probab

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51654 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Aug. 27, 2014, 8:05 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Aug. 27, 2014, 5:35 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1584 > > > > > > Just curious: for all 3 parameters, if the units are msec by default > > (as

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51637 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Aug. 27, 2014, 4:42 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51449 --- conf/hive-default.xml.template

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated April 3, 2014, 5:35 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Jan. 24, 2014, 12:44 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Jan. 22, 2014, 7:23 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Jan. 22, 2014, 7:02 a.m., Carl Steinbach wrote: > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, > > line 397 > > > > > > I think the name of the method should accurately reflect the

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review32479 --- service/src/java/org/apache/hive/service/cli/session/HiveSessionImp

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Jan. 22, 2014, 4:42 a.m.) Review request for hive. Changes ---

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Nov. 15, 2013, 9:21 a.m., Carl Steinbach wrote: > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, > > line 397 > > > > > > Can we change the name to something like closeExpiredOperati

Re: Review Request 15449: session/operation timeout for hiveserver2

> On Nov. 14, 2013, 2:43 a.m., Thejas Nair wrote: > > conf/hive-default.xml.template, line 891 > > > > > > "Should be a positive value" sounds like 0 will result in an error. I > > think it will be better to rephrase

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Nov. 18, 2013, 2:32 a.m.) Review request for hive. Bugs: HIVE-5799

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28950 --- service/src/java/org/apache/hive/service/cli/session/HiveSessionImp

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28857 --- conf/hive-default.xml.template

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28855 --- conf/hive-default.xml.template

Re: Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- (Updated Nov. 13, 2013, 1:21 a.m.) Review request for hive. Bugs: HIVE-5799

Review Request 15449: session/operation timeout for hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/ --- Review request for hive. Bugs: HIVE-5799 https://issues.apache.org/jira/bro