Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-02 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189945 --- Ship it! Ship It! - Thejas Nair On Nov. 2, 2017, 6:25 p.m.,

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-02 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/ --- (Updated Nov. 2, 2017, 6:25 p.m.) Review request for hive, Sergey Shelukhin

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-02 Thread j . prasanth . j
> On Nov. 2, 2017, 5:01 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > > Lines 477 (patched) > > > > > > Can you also log the key on which limit has been

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-02 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189929 ---

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-02 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/ --- (Updated Nov. 2, 2017, 8:08 a.m.) Review request for hive, Sergey Shelukhin

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-01 Thread j . prasanth . j
> On Nov. 2, 2017, 3:19 a.m., Alexander Kolbasov wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > > Lines 477 (patched) > > > > > > This potentially leak IP addresses of clients

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-01 Thread j . prasanth . j
> On Nov. 2, 2017, 1:34 a.m., Sergey Shelukhin wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2475 (patched) > > > > > > hmm... would it make sense to have 3 limits instead? per

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-01 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189871 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-11-01 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/#review189860 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Review Request 63458: HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user

2017-10-31 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63458/ --- Review request for hive, Sergey Shelukhin and Thejas Nair. Bugs: HIVE-16917