Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review196257 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 3:41 p.m.,

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ --- (Updated Jan. 24, 2018, 3:41 p.m.) Review request for hive, Peter Vary and Adam

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote: > > Thanks for the patch Marta! Only one question below Thanks a lot Peter for the review. - Marta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote: > > Thanks for this patch Marta, it looks good! I've made a few recommendations > > only Thanks a lot Adam for the review. - Marta --- This is an automatically generated e-mail. To reply

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ --- (Updated Jan. 23, 2018, 5:21 p.m.) Review request for hive, Peter Vary and Adam

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > > Lines 218 (patched) > > > > > > Is this ok to have this

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > > Lines 678 (patched) > > > > > > For handling future bug

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195904 --- Thanks for the patch Marta! Only one question below standalone-m

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195900 --- Thanks for this patch Marta, it looks good! I've made a few recomm

Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18496 https: