RE: [Patch] non blocking writes in core

2013-11-18 Thread Plüm , Rüdiger , Vodafone Group
Some comments: @@ -581,6 +564,33 @@ eor_buckets_in_brigade, morphing_bucket_in_brigade); } +/* Handle non blocking writes. If we saw a non blocking bucket, attempt + * a non blocking write. If the non blocking write would have returned + * APR_EGAIN, set

[ANNOUNCEMENT] Apache HTTP Server (httpd) 2.2.26 Released

2013-11-18 Thread Jim Jagielski
Apache HTTP Server 2.2.26 Released The Apache Software Foundation and the Apache HTTP Server Project are pleased to announce the release of version 2.2.26 of the Apache HTTP Server (Apache). This version of Apache is principally a bug fix maintenance release. We

ssl_die() and pool cleanup

2013-11-18 Thread Jeff Trawick
Has anyone looked at making ssl_die() clean up pools on the way out (presumably by calling some function besides exit())? It is rather easy to end up with a bunch of stranded IPC objects while debugging your SSL config. Commentary in ssl_die() suggests a great goal, but that's essentially

Re: svn commit: r1541029 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h modules/loggers/mod_syslog.c server/core.c

2013-11-18 Thread Jeff Trawick
On Tue, Nov 12, 2013 at 7:14 AM, jkal...@apache.org wrote: Author: jkaluza Date: Tue Nov 12 12:14:50 2013 New Revision: 1541029 URL: http://svn.apache.org/r1541029 Log: Add parse_errorlog_arg callback to ap_errorlog_provider to allow providers to check the ErrorLog argument. Implement

Re: Deprecating (and eventually removing) encrypted private key support in mod_ssl?

2013-11-18 Thread Dr Stephen Henson
On 17/11/2013 15:25, Dr Stephen Henson wrote: Evil hack workaround: create a temporary SSL structure from the SSL_CTX of interest after you call SSL_CTX_get_certificate, call SSL_get_certificate on it and then free up the temp SSL structure. That *should* work on all the versions of

Re: Intent to TR 2.4.7

2013-11-18 Thread Jim Jagielski
Okey dokey... I plan to TR 2.4.7 this Tuesday (tomorrow). This allows 72 hours of voting and pushing to mirrors over the weekend. On Nov 13, 2013, at 11:39 AM, Jim Jagielski j...@jagunet.com wrote: Now that APR 1.5 is soon-to-be released, we are good for a release of 2.4.7. I propose a TR

Re: svn commit: r1539988 - /httpd/httpd/trunk/server/log.c

2013-11-18 Thread Jeff Trawick
On Fri, Nov 8, 2013 at 6:41 AM, jkal...@apache.org wrote: Author: jkaluza Date: Fri Nov 8 11:41:08 2013 New Revision: 1539988 URL: http://svn.apache.org/r1539988 Log: Do not lose log messages with NULL server_rec when error log provider is used. - set stderr_log to NULL after it is

Does mod_perl/mod_??? need a hook called when a request/conn leaves the original worker thread?

2013-11-18 Thread Jeff Trawick
For the mod_perl crash with Event that I posted at the URL below, I would suspect that there's some affinity with the original worker thread. Can anyone in mod_perl land confirm?

Re: Does mod_perl/mod_??? need a hook called when a request/conn leaves the original worker thread?

2013-11-18 Thread Eric Covener
On Mon, Nov 18, 2013 at 10:58 AM, Jeff Trawick traw...@gmail.com wrote: For the mod_perl crash with Event that I posted at the URL below, I would suspect that there's some affinity with the original worker thread. Can anyone in mod_perl land confirm?

Re: http_filter.c r1524770 open issue?

2013-11-18 Thread William A. Rowe Jr.
On Thu, 14 Nov 2013 00:22:55 +0100 Yann Ylavic ylavic@gmail.com wrote: On Thu, Nov 14, 2013 at 12:05 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Wed, 13 Nov 2013 17:14:15 -0500 Jim Jagielski j...@jagunet.com wrote: On Nov 13, 2013, at 2:25 AM, William A. Rowe Jr.

Re: Does mod_perl/mod_??? need a hook called when a request/conn leaves the original worker thread?

2013-11-18 Thread Jim Jagielski
On Nov 18, 2013, at 12:15 PM, Eric Covener cove...@gmail.com wrote: On Mon, Nov 18, 2013 at 10:58 AM, Jeff Trawick traw...@gmail.com wrote: For the mod_perl crash with Event that I posted at the URL below, I would suspect that there's some affinity with the original worker thread. Can

Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Bert Huijben
Hi, As I already mentioned I'm re-scripting my build of httpd to work using the new cmake generator. It looks like I have things working now, with about half as many local patches as before..., but I think one problem I had to patch around will be common for everybody using project files

Re: Does mod_perl/mod_??? need a hook called when a request/conn leaves the original worker thread?

2013-11-18 Thread Jeff Trawick
Ouch, I meant to sent this to dev@perl instead of dev@apr... On Mon, Nov 18, 2013 at 10:58 AM, Jeff Trawick traw...@gmail.com wrote: For the mod_perl crash with Event that I posted at the URL below, I would suspect that there's some affinity with the original worker thread. Can anyone in

Re: Deprecating (and eventually removing) encrypted private key support in mod_ssl?

2013-11-18 Thread Kaspar Brand
On 18.11.2013 15:38, Dr Stephen Henson wrote: Erk typo.. I of course meant ...after you call SSL_CTX_use_certificate_file or SSL_CTX_use_certificate_chain_file... Yeah this was obvious... makes me cringe as well but here we go:

Re: RLIMIT_NPROC on Linux?

2013-11-18 Thread Eric Covener
current apachectl: # # Set this variable to a command that increases the maximum # number of file descriptors allowed per child process. This is # critical for configurations that use many file descriptors, # such as mass vhosting, or a multithreaded server. ULIMIT_MAX_FILES=ulimit -S -n `ulimit

Re: Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Jeff Trawick
On Mon, Nov 18, 2013 at 12:37 PM, Bert Huijben b...@qqmail.nl wrote: Hi, As I already mentioned I'm re-scripting my build of httpd to work using the new cmake generator. It looks like I have things working now, with about half as many local patches as before..., but I think one

Re: RLIMIT_NPROC on Linux?

2013-11-18 Thread William A. Rowe Jr.
On Mon, 18 Nov 2013 12:52:26 -0500 Eric Covener cove...@gmail.com wrote: # Set the maximum number of file descriptors allowed per child process. if [ x$ULIMIT_MAX_FILES != x ] ; then $ULIMIT_MAX_FILES fi Should we do the same for threads/processes? I was going to propose this for

Re: Intent to TR 2.4.7

2013-11-18 Thread Daniel Ruggeri
*Finally* ran this through my test cases with three poundings with wrk. Here are the requests/sec: httpd (2.4 + proposed UDS patch) Req/Sec 147.34 28.89 282.00 71.38% Req/Sec 147.48 27.18 250.00 67.75% Req/Sec 147.87 28.17 239.00 70.94% nginx Req/Sec 180.99

Re: Intent to TR 2.4.7

2013-11-18 Thread Daniel Ruggeri
Oops - I copypasta'd the per-thread stats. Total stats for the test follow: httpd: Requests/sec: 4633.17 Requests/sec: 4664.49 Requests/sec: 4657.63 nginx: Requests/sec: 5701.16 Requests/sec: 5798.08 Requests/sec: 5584.60 -- Daniel Ruggeri On 11/18/2013 1:09 PM, Daniel Ruggeri

Re: Intent to TR 2.4.7

2013-11-18 Thread Daniel Ruggeri
And... this is a bit discouraging, but as a comparison to the older UDS patch 2.4.6 + original UDS patch: Requests/sec: 5347.17 Requests/sec: 5102.16 Requests/sec: 5074.15 This is a sizable difference... Note that the current 2.4 backport proposal was applied to 2.4.6 since that is what

Re: Intent to TR 2.4.7

2013-11-18 Thread Jim Jagielski
I can think or see anything in the actual request handling aspect that's any different from the original proposal, certainly nothing that would result in any sort of performance issue. What MPM? Have you tried w/ 2.4.6? On Nov 18, 2013, at 2:39 PM, Daniel Ruggeri drugg...@primary.net wrote:

Re: Intent to TR 2.4.7

2013-11-18 Thread Jim Jagielski
Hmm... maybe a re-use issue? Let me look. On Nov 18, 2013, at 3:36 PM, Jim Jagielski j...@jagunet.com wrote: I can think or see anything in the actual request handling aspect that's any different from the original proposal, certainly nothing that would result in any sort of performance

RE: Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Bert Huijben
Hi Jeff, Thanks for looking into this. I tried the Visual Studio 9 and Visual Studio 11 generators in both standard Win32 and x64 forms. Both of these have similar problems even though the first uses .vcproj files and the late .vcxproj files. The cmake generated code is

Re: Intent to TR 2.4.7

2013-11-18 Thread Jim Jagielski
yeah, I'm thinking /* * Figure out if our passed in proxy_conn_rec has a usable * address cached. * * TODO: Handle this much better... * * XXX: If generic workers are ever address-reusable, we need * to check host and port on the conn and be careful

Re: Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Jeff Trawick
On Mon, Nov 18, 2013 at 4:10 PM, Bert Huijben b...@qqmail.nl wrote: Hi Jeff, Thanks for looking into this. I tried the Visual Studio 9 and Visual Studio 11 generators in both standard Win32 and x64 forms. Both of these have similar problems even though the first uses

Re: Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Jeff Trawick
On Mon, Nov 18, 2013 at 4:14 PM, Jeff Trawick traw...@gmail.com wrote: On Mon, Nov 18, 2013 at 4:10 PM, Bert Huijben b...@qqmail.nl wrote: Hi Jeff, Thanks for looking into this. I tried the Visual Studio 9 and Visual Studio 11 generators in both standard Win32 and x64

UDS Patch

2013-11-18 Thread Jim Jagielski
Can you retry with this applied: https://svn.apache.org/viewvc?view=revisionrevision=1543174 On Nov 18, 2013, at 2:39 PM, Daniel Ruggeri drugg...@primary.net wrote: And... this is a bit discouraging, but as a comparison to the older UDS patch 2.4.6 + original UDS patch:

Re: UDS Patch

2013-11-18 Thread Daniel Ruggeri
On 11/18/2013 3:38 PM, Jim Jagielski wrote: Can you retry with this applied: https://svn.apache.org/viewvc?view=revisionrevision=1543174 Definitely. I'll report back tomorrow so long as the universe wills it... but one last note I failed to mention in my original notes that there

RE: Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Bert Huijben
Hi Jeff, I can confirm that this fixes the LONG_NAME problems :) I have one remaining problem, that I hoped would be fixed by the same fix you applied, but it wasn't. If the httpd build directory contains a '-', such as in my case 'F:\svn-dev\build\httpd', then the

Re: Playing with cmake: LONG_NAME= problems

2013-11-18 Thread Jeff Trawick
On Mon, Nov 18, 2013 at 7:42 PM, Bert Huijben b...@qqmail.nl wrote: Hi Jeff, I can confirm that this fixes the LONG_NAME problems J Great! I have one remaining problem, that I hoped would be fixed by the same fix you applied, but it wasn’t. If the httpd build