Re: ssl_die() and pool cleanup

2013-11-22 Thread Jeff Trawick
On Wed, Nov 20, 2013 at 5:19 AM, Kaspar Brand httpd-dev.2...@velox.chwrote: On 18.11.2013 14:59, Jeff Trawick wrote: Has anyone looked at making ssl_die() clean up pools on the way out (presumably by calling some function besides exit())? It is rather easy to end up with a bunch of

Re: UDS Patch

2013-11-22 Thread Jim Jagielski
Any luck with generating the diff yet? On Nov 19, 2013, at 3:08 PM, Jim Jagielski j...@jagunet.com wrote: The main thing is that it would be interesting to see the diffs between '2.4.6 w the (several) originally proposed UDS patches applied in order' and '2.4.6 w proposed backport'...

[RESULT] Re: [VOTE] Release Apache httpd 2.4.7 as GA

2013-11-22 Thread Jim Jagielski
With +1 votes from jim,covener,trawick,gsmith,breser,noel.butler,hiding,jblond and h.reindl and NO -1 votes, I call the voting closed with the result of Releasing 2.4.7 as GA. Thx to all testers and voters! Will push to mirrors for announcement and release next week. On Nov 19, 2013, at 12:45

Re: ssl_die() and pool cleanup

2013-11-22 Thread Yann Ylavic
Maybe sk_X509_NAME_pop_free(ca_list, X509_NAME_free) should be called too before returning NULL in ssl_init_FindCAList() (so to avoid a leak in case of failure). Regards; Yann. On Fri, Nov 22, 2013 at 4:20 PM, Jeff Trawick traw...@gmail.com wrote: On Wed, Nov 20, 2013 at 5:19 AM, Kaspar Brand

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Sat, Nov 17, 2012 at 6:00 AM, Ruediger Pluem rpl...@apache.org wrote: j...@apache.org wrote: Author: jim Date: Fri Nov 16 16:49:31 2012 New Revision: 1410459 URL: http://svn.apache.org/viewvc?rev=1410459view=rev Log: fdq expects a certain behavior from atomics... ensure that

Re: [VOTE] Release Apache httpd 2.4.7 as GA

2013-11-22 Thread Jeff Trawick
On Wed, Nov 20, 2013 at 2:06 PM, Jeff Trawick traw...@gmail.com wrote: On Tue, Nov 19, 2013 at 12:45 PM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.7 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
On Nov 22, 2013, at 2:22 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 17, 2012 at 6:00 AM, Ruediger Pluem rpl...@apache.org wrote: j...@apache.org wrote: +i = apr_atomic_dec32(foo); +if (i = 0) { Why can we expect i 0? apr_atomic_dec32 returns 0 if the dec

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 2:39 PM, Jim Jagielski j...@jagunet.com wrote: On Nov 22, 2013, at 2:22 PM, Jeff Trawick traw...@gmail.com wrote: On Sat, Nov 17, 2012 at 6:00 AM, Ruediger Pluem rpl...@apache.org wrote: j...@apache.org wrote: +i = apr_atomic_dec32(foo); +

Re: [VOTE] Release Apache httpd 2.4.7 as GA

2013-11-22 Thread Jim Jagielski
Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as required for event... if the check fails, it means that event has been broken on that system, assuming it ever hit blocked idlers, for a *long*

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as required for event... if the check fails, it means that event has been broken on that system, assuming it ever hit blocked idlers, for a *long*

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as required for event... if the check fails, it means that event has

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
On Nov 22, 2013, at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work as

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via https://svn.apache.org/viewvc?view=revisionrevision=1542560) is that event *checks* that atomics work

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note, the only think changed in event now (via

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 3:57 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 2:52 PM, Jim Jagielski j...@jagunet.com wrote: Note,

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
The thing is is not only do we worry about the return code but also that the values we dec32 and inc32 also behave as signed ints. Note below we worry also that queue_info-idlers itself is signed, and can be 0 : apr_status_t ap_queue_info_try_get_idler(fd_queue_info_t * queue_info) { int

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jim Jagielski
Anyone ever try OpenPA? https://trac.mcs.anl.gov/projects/openpa/ It's under MIT, fwiw.

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 4:27 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:57 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:40 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 22, 2013 at 3:24 PM, Jeff Trawick traw...@gmail.com wrote: On

Re: svn commit: r1410459 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c

2013-11-22 Thread Jeff Trawick
On Fri, Nov 22, 2013 at 4:32 PM, Jim Jagielski j...@jagunet.com wrote: The thing is is not only do we worry about the return code but also that the values we dec32 and inc32 also behave as signed ints. Note below we worry also that queue_info-idlers itself is signed, and can be 0 : Okay

Re: UDS Patch

2013-11-22 Thread Daniel Ruggeri
Sorry, I thought the diffs I sent off list were good enough. I'll have to see if I even still have the original build lying around. Effectively, I just took the list of patches in the backport proposal and applied them one at a time to the 2.4.6 sources. If I can't find the build, I'll do the same