Re: C89-ify a recent change to h2_io_set.c

2015-08-19 Thread Jim Jagielski
That's the intent for --enable-maintainer-mode On Aug 19, 2015, at 8:22 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Thanks Jean-Frederic. Is there a way to ./configure - other than CFLAGS - so that all developers can compile with similar subsets of features and warnings? I

Re: C89-ify a recent change to h2_io_set.c

2015-08-19 Thread Stefan Eissing
Thanks Jean-Frederic. Is there a way to ./configure - other than CFLAGS - so that all developers can compile with similar subsets of features and warnings? I would like to write code so that it does not generate warnings for the rest of you... //Stefan Am 19.08.2015 um 14:00 schrieb

Re: C89-ify a recent change to h2_io_set.c

2015-08-19 Thread Stefan Eissing
Am 19.08.2015 um 15:33 schrieb Jim Jagielski j...@jagunet.com: That's the intent for --enable-maintainer-mode Excellent. Thx! green/bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: svn commit: r1696592 - in /httpd/httpd/trunk/modules/http2: h2_alt_svc.c h2_conn.c h2_from_h1.c h2_request.c h2_switch.c

2015-08-19 Thread William A Rowe Jr
On Wed, Aug 19, 2015 at 9:13 AM, ic...@apache.org wrote: Author: icing Date: Wed Aug 19 14:13:49 2015 New Revision: 1696592 URL: http://svn.apache.org/r1696592 Log: mod_h2 compiles warning free in maintainer-mode --- httpd/httpd/trunk/modules/http2/h2_alt_svc.c (original) +++

Re: svn commit: r1696592 - in /httpd/httpd/trunk/modules/http2: h2_alt_svc.c h2_conn.c h2_from_h1.c h2_request.c h2_switch.c

2015-08-19 Thread Stefan Eissing
Am 19.08.2015 um 16:37 schrieb William A Rowe Jr wr...@rowe-clan.net: h2_alt_svc *h2_alt_svc_parse(const char *s, apr_pool_t *pool) { -const char *sep = strchr(s, '='); +const char *sep = strchr((char *)s, '='); We solve these issues with ap_strchr_c, ap_strrchr_c, ap_strstr_c

Re: svn commit: r1696607 - in /httpd/httpd/trunk/modules/http2: h2_alt_svc.c h2_config.c h2_request.c h2_response.c

2015-08-19 Thread Christophe JAILLET
Hi, in the 2 functions below, you could also use apr_pstrcat instead of a hard coded (20) for extra space needed by '[', ']', ... + apr_pcalloc/strlen/strcpy/strcat This is cleaner, IMHO and less verbose (and faster but we don't really care here). CJ Le 19/08/2015 16:55, ic...@apache.org a

C89-ify a recent change to h2_io_set.c

2015-08-19 Thread NormW
G/Evening (Is here) A very small tweak is proposed for: httpd-trunk\modules\http2\h2_io_set.c to keep the C89-ers in their seats. The svn diff looks like: Index: modules/http2/h2_io_set.c === --- modules/http2/h2_io_set.c