Re: Buffer size in mod_session_crypto.c, decrypt_string()

> On 19 Nov 2015, at 10:07, Ewald Dieterich wrote: > > This is from mod_session_crypto.c, decrypt_string(): > >/* strip base64 from the string */ >decoded = apr_palloc(r->pool, apr_base64_decode_len(in)); >decodedlen = apr_base64_decode(decoded, in); >

Buffer size in mod_session_crypto.c, decrypt_string()

This is from mod_session_crypto.c, decrypt_string(): /* strip base64 from the string */ decoded = apr_palloc(r->pool, apr_base64_decode_len(in)); decodedlen = apr_base64_decode(decoded, in); decoded[decodedlen] = '\0'; Shouldn't that be ("+ 1" for the added '\0'): decoded =

H2 stream dependencies

Hi All (and Stefan in particular), As already noted I'm trying to make Subversion work over http/2 via the Apache Serf library. Today I made a few huge steps forward and got most of the Subversion tests working over h2. (Just +- 60 failures left of the +- 2000 tests) One

Re: svn commit: r1715294 - /httpd/httpd/trunk/server/core.c

It wouldn't hurt to change this though, the tokens are generally represented in lowercase, and this could avoid case folding I suppose. How often do we see value tokens as upper case from httpd? Let's be consistent although it isn't strictly required. On Thu, Nov 19, 2015 at 3:54 PM,

Re: Buffer size in mod_session_crypto.c, decrypt_string()

On Thu, Nov 19, 2015 at 10:14 AM, Dirk-Willem van Gulik wrote: > > Alternatively one could use > _decode_binary() in which case above terminator is absolutely needed. There > is no _binary_len(). Or use apr_pbase64_decode(pool, in) for clarity. (Even though it also

Re: svn commit: r1714742 - /httpd/httpd/branches/2.4.x/STATUS

On Wed, Nov 18, 2015 at 6:21 PM, Yann Ylavic wrote: > > The problem was about "HTTP spoken on HTTPS port" handling in > ssl_io_filter_input() not prepared to AP_MODE_INIT from > process_connection() and AP_MODE_SPECULATIVE read for H2Direct. Btw, when http2 tests are

Re: svn commit: r1714742 - /httpd/httpd/branches/2.4.x/STATUS

> Am 19.11.2015 um 13:58 schrieb Yann Ylavic : > > On Thu, Nov 19, 2015 at 1:26 PM, Yann Ylavic wrote: >> >> Am I right to assume "H2Direct off" is the defaut now (in 2.5-dev and >> upcoming 2.4.18, trunk docs seem not updated, and [1] suggests this

Re: svn commit: r1714742 - /httpd/httpd/branches/2.4.x/STATUS

I can check that change on the test setup and meditate about the docs phrasing a bit... > Am 19.11.2015 um 14:11 schrieb Yann Ylavic : > > On Thu, Nov 19, 2015 at 2:04 PM, Stefan Eissing > wrote: >>> >>> Hmm, then r1709587 swithed it back to

Re: svn commit: r1714742 - /httpd/httpd/branches/2.4.x/STATUS

On Thu, Nov 19, 2015 at 1:26 PM, Yann Ylavic wrote: > > Am I right to assume "H2Direct off" is the defaut now (in 2.5-dev and > upcoming 2.4.18, trunk docs seem not updated, and [1] suggests this is > from r1708107)? Hmm, then r1709587 swithed it back to "H2Direct on for

Re: svn commit: r1714742 - /httpd/httpd/branches/2.4.x/STATUS

On Thu, Nov 19, 2015 at 2:04 PM, Stefan Eissing wrote: >> >> Hmm, then r1709587 swithed it back to "H2Direct on for http:, off for >> https: requests", whereas the commit states "H2Direct off, on when h2c >> is in Protocols". >> What's the status exactly? > > The