[PATCH] Prevent possible segv

2002-03-12 Thread Sander Striker
Jeff, Does this resolve the issue you added the comment for? Sander Index: modules/mappers/mod_negotiation.c === RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_negotiation.c,v retrieving revision 1.96 diff -u -r1.96

RE: [PATCH] Prevent possible segv

2002-03-12 Thread Sander Striker
From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 12 March 2002 13:36 Jeff, Does this resolve the issue you added the comment for? Sander Index: modules/mappers/mod_negotiation.c === RCS file: /home/cvs/httpd-2.0

RE: [BUG] Limit test 10 is failing

2002-03-12 Thread Sander Striker
From: Doug MacEachern [mailto:[EMAIL PROTECTED]] Sent: 12 March 2002 17:36 On Tue, 12 Mar 2002, Sander Striker wrote: #User-Agent: libwww-perl/5.53 could be a bug in the client. try 5.64 you can also grab: http://httpd.apache.org/~dougm/httpd-test-bundle-0.02.tar.gz unpack

RE: dumb questions on a couple of the current 2.0 showstoppers

2002-03-12 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 13 March 2002 00:00 Cliff Woolley [EMAIL PROTECTED] writes: The pool allocator change is done AFAIK -- Sander, are there any other changes that need to be made above the ones in the patch you sent me?

Code questions (server/mpm_common.c)

2002-03-11 Thread Sander Striker
Hi, server/mpm_common.c:363 #if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) || defined(TPF) || defined(__TANDEM) || defined(OS2) || defined(WIN32) || defined(NETWARE) Can I break this line into smaller chunks? If so, how? I seem a bit rusty on how the various

Minor(?) style questions

2002-03-11 Thread Sander Striker
Hi, Just checking if people have given this some thought before. And, maybe if there was something decided on this matter. For instance, that this is free when it comes to style rules. As some of you have noticed I am doing style reviews of/ corrections on the current httpd codebase, which has

RE: cvs commit: httpd-2.0/docs/manual/developer filters.html index.html

2002-03-11 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: 11 March 2002 13:04 To: [EMAIL PROTECTED] Subject: cvs commit: httpd-2.0/docs/manual/developer filters.html index.html striker 02/03/11 04:03:44 Modified:docs/manual/developer index.html Added:

Code questions (server/protocol.c)

2002-03-11 Thread Sander Striker
Hi, server/protocol.c:136 if (ap_strcasestr(type, charset=) != NULL) { /* already has parameter, do nothing */ /* XXX we don't check the validity */ ; } Validity checking seems like a good idea, someone want to grab this one? server/protocol.c:658 #if 0 /* XXX

RE: Code questions (server/mpm_common.c)

2002-03-11 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 11 March 2002 15:17 Sander Striker [EMAIL PROTECTED] writes: Hi, server/mpm_common.c:363 #if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) || defined(TPF) || defined(__TANDEM

RE: Copyright year bumping

2002-03-09 Thread Sander Striker
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]] Sent: 09 March 2002 08:57 On Sat, Mar 09, 2002 at 02:54:01AM -0500, Dave Jones wrote: On Sat, Mar 09, 2002 at 12:20:23PM +0800, Stas Bekman wrote: Sander Striker wrote: Hi, Should we bump the copyright year on all the files

More code questions...

2002-03-09 Thread Sander Striker
server/main.c:578 /* This is a hack until we finish the code so that it only reads * the config file once and just operates on the tree already in * memory. rbb */ What's the status on this? Sander

RE: Config path brokenness

2002-03-07 Thread Sander Striker
From: Brian Havard [mailto:[EMAIL PROTECTED]] Sent: 07 March 2002 14:20 With the current HEAD (configured using --prefix=/Apps/apache2), I get the following in my ap_config_auto.h: /* Location of the config file, relative to the Apache root directory */ #define SERVER_CONFIG_FILE

[SEGV] mod_deflate

2002-03-07 Thread Sander Striker
Hi, Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 1024 (LWP 3503)] 0x402e24b3 in strncmp (s1=0x0, s2=0x403fc7c8 text/html, n=9) at ../sysdeps/generic/strncmp.c:42 42c1 = (unsigned char) *s1++; (gdb) bt #0 0x402e24b3 in strncmp (s1=0x0, s2=0x403fc7c8

RE: [SEGV] mod_deflate

2002-03-07 Thread Sander Striker
From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 07 March 2002 13:56 Hi, [...] Can someone tell me if r-content_type is always supposed to be pointing to something? Nevermind, I figured it out by looking at the other modules who test r-content_type. Fix committed. Thanks

RE: Code questions

2002-03-07 Thread Sander Striker
From: Ryan Bloom [mailto:[EMAIL PROTECTED]] Sent: 07 March 2002 19:58 server/config.c:396 return !!(cmd-limited (AP_METHOD_BIT methnum)); ^^ Is that a typo or intentional? It's intentional. This line always sparks a VERY large debate. Then why didn't any one leave a

Copyright year bumping

2002-03-07 Thread Sander Striker
Hi, Should we bump the copyright year on all the files? Anyone have a script handy? Sander

Torching ap_document_root, WAS: RE: Code questions

2002-03-07 Thread Sander Striker
From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 07 March 2002 20:48 server/core.c:661 AP_DECLARE(const char *) ap_document_root(request_rec *r) /* Don't use this! */ If we shouldn't use it, why is it still here? Because people are lazy and most people didn't realize

Torching ap_response_code_string, WAS: RE: Code questions

2002-03-07 Thread Sander Striker
From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 07 March 2002 20:48 server/core.c:691 /* Should probably just get rid of this... the only code that cares is * part of the core anyway (and in fact, it isn't publicised to other * modules). */ Read the comment

RE: Torching ap_document_root, WAS: RE: Code questions

2002-03-07 Thread Sander Striker
From: Ryan Bloom [mailto:[EMAIL PROTECTED]] Sent: 07 March 2002 20:49 server/core.c:661 AP_DECLARE(const char *) ap_document_root(request_rec *r) /* Don't use this! */ If we shouldn't use it, why is it still here? Because people are lazy and most people didn't realize

RE: cvs commit: httpd-2.0/include ap_release.h

2002-03-06 Thread Sander Striker
From: Brian Pane [mailto:[EMAIL PROTECTED]] Sent: 06 March 2002 19:35 Justin Erenkrantz wrote: On Wed, Mar 06, 2002 at 09:48:38AM -0800, Ryan Bloom wrote: Yes, I have tagged 2.0.33. I won't roll the release until Aaron commits the path problem fix. I'll announce when the roll is

[PATCH] Style police work on server/config.c

2002-03-05 Thread Sander Striker
Hi, Patch is attached to prevent line wrapping/munging. I encountered this: Line 396: return !!(cmd-limited (AP_METHOD_BIT methnum)); ^^ Is that a typo or intentional? Sander config.patch Description: Binary data

RE: [PATCH] Style police work on server/config.c

2002-03-05 Thread Sander Striker
From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 05 March 2002 11:42 Hi, Patch is attached to prevent line wrapping/munging. I encountered this: Line 396: return !!(cmd-limited (AP_METHOD_BIT methnum)); ^^ Is that a typo or intentional? I also forgot

[PATCH] server/connection.c detab

2002-03-05 Thread Sander Striker
Hi, More formatting/style/readability stuff. Patch attached yadda yadda yadda. Sander connection.patch Description: Binary data

[PATCH] server/error_bucket.c detab

2002-03-05 Thread Sander Striker
Hi, More detab. Patch attached Sander error_bucket.patch Description: Binary data

[PATCH] server/gen_test_char.c detab

2002-03-05 Thread Sander Striker
Hi, Yet more detab. Patch attached. Sander gen_test_char.patch Description: Binary data

[PATCH] server/listen.c detab

2002-03-05 Thread Sander Striker
Hi, More detab, etc. Can this go? Was there a future purpose to this call, or was it old code commented out? Line 320: /*free(lr);*/ Patch attached. Sander listen.patch Description: Binary data

[PATCH] server/log.c detab

2002-03-05 Thread Sander Striker
Hi, More detab, etc. Patch attached. Sander log.patch Description: Binary data

RE: [PATCH] server/core.c detab

2002-03-05 Thread Sander Striker
The mail with the attachement bounced because it was 100k. If anyone wants it, please holler. It wasn't all simple find-replace, so better not wait until conflicts arise ;) Sander -Original Message- From: Sander Striker [mailto:[EMAIL PROTECTED]] Sent: 05 March 2002 14:00

[PATCH] Pass one of mod_status style cleanup

2002-03-04 Thread Sander Striker
Hi, Still more issues left in the form of lots of long lines. Maybe the html output could use some cleanup aswell. Anyhow, this is the first pass at getting mod_status.c more into the style we all know. Patch attached to prevent line wrapping/munging. Sander mod_status.patch Description:

RE: [BUG] Location /dir doesn't work as expected when there is a /dir in the DocumentRoot

2002-03-04 Thread Sander Striker
Hi, I've reproduced the problem reported by Vlad Skvortsov locally and I'll describe it once more together with some feedback I got. From the config: DocumentRoot /htdocs Location /repos DAV svn SVNPath /htdocs/repos /Location In the /htdocs path, there is a

RE: [PATCH] fix alignment on shared memory

2002-03-01 Thread Sander Striker
[mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 01 March 2002 20:08 Cliff Woolley [EMAIL PROTECTED] writes: On Fri, 1 Mar 2002, Aaron Bannert wrote: Can we put that alignment macro in a common place in APR, since it is not useful to apps and internals? but where :)

RE: daemontools/foreground support in 1.3.*

2002-02-28 Thread Sander Striker
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]] Sent: 28 February 2002 10:30 To: Michael Handler Cc: [EMAIL PROTECTED] Subject: Re: daemontools/foreground support in 1.3.* On Thu, Feb 28, 2002 at 04:00:34AM -0500, Michael Handler wrote: I completely understand the desire to not to

[PATCH] Fix configure.in for autoconf 2.52 WAS: RE: cvs commit: httpd-2.0 configure.in acinclude.m4

2002-02-28 Thread Sander Striker
rebuilding configure configure.in:8: error: m4_defn: undefined macro: _m4_divert_diversion acgeneral.m4:616: AC_PREFIX_DEFAULT is expanded from... configure.in:8: the top level Sander Striker spotted this one. Patch attached to move it back, and add the warning back in. Cheers, -Thom

RE: [BUG] Location /dir doesn't work as expected when there is a /dir in the DocumentRoot

2002-02-28 Thread Sander Striker
From: Joshua Slive [mailto:[EMAIL PROTECTED]] Sent: 28 February 2002 16:54 To: [EMAIL PROTECTED] Subject: RE: [BUG] Location /dir doesn't work as expected when there is a /dir in the DocumentRoot From: Sander Striker [mailto:[EMAIL PROTECTED]] Today Vlad Skvortsov [EMAIL PROTECTED

[PATCH] mod_deflate, style cleanup

2002-02-17 Thread Sander Striker
Hi, This is a style cleanup only patch. It removes trailing spaces. Corrects some identation. Minor style nits, no code changes. Patch is attached, because the mailer can't cope with trailing spaces very well, so it seems. Sander deflate.patch Description: Binary data

RE: [PATCH] mod_deflate

2002-02-16 Thread Sander Striker
From: Zvi Har'El [mailto:[EMAIL PROTECTED]] Sent: 16 February 2002 08:37 On Fri, 15 Feb 2002 09:44:19 -0800, Ian Holsman wrote about Re: [PATCH] mod_deflate: I'm still not very happy about compressing EVERYTHING and excluding certain browsers as you would have to exclude IE

RE: [PATCH] mod_deflate

2002-02-16 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Ian Holsman [EMAIL PROTECTED] writes: In my mod_deflate module (for Apache 1.3.x) I'd enabled by default text/html only. You can add or remove another type with DeflateTypes directive. Here are some

[PATCH] mod_deflate

2002-02-15 Thread Sander Striker
Hi, This patch gets us working with subversion ;) This removes some checks that go against the spec. If we have broken browsers out there, we can BrowserMatch for them. But by default we want to get everything through this filter. Justin identified a problem with the Content-Length header

RE: [PATCH] mod_deflate

2002-02-15 Thread Sander Striker
Sander Striker wrote: @@ -297,6 +287,7 @@ apr_table_setn(r-headers_out, Content-Encoding, gzip); apr_table_setn(r-headers_out, Vary, Accept-Encoding); +apr_table_unset(r-headers_out, Content-Length); } APR_BRIGADE_FOREACH(e, bb) { Do you

Deflate question for our spec specialists

2002-02-15 Thread Sander Striker
Hi, Can we compress requests aswell? Is that part of the deflate spec? Can someone give me some details on how this would work (I could ofcourse read the spec...)? Thanks, Sander

RE: [PATCH] mod_deflate

2002-02-15 Thread Sander Striker
From: Ian Holsman [mailto:[EMAIL PROTECTED]] Sent: 15 February 2002 18:44 Hi, I'm still not very happy about compressing EVERYTHING and excluding certain browsers as you would have to exclude IE Netscape. so this is a -1 for this patch. in order to change this checks need to be there

RE: prefork segfaults under load

2002-02-11 Thread Sander Striker
From: Adam Sussman [mailto:[EMAIL PROTECTED]] Sent: 12 February 2002 03:36 I agree that disabling threads is covering up a problem, but I suspect that the problem is in glibc and not in Apache. Some rather lame debug suggestions: 1) make sure you have the latest glibc... maybe

Windows is able to listen on the same port with multiple servers ?! WAS: RE: cvs commit: httpd-2.0/server listen.c

2002-02-05 Thread Sander Striker
Hi, Stupid question time: how does windows hand of something to the right server? I thought that the port/ip combination was supposed to be unique. [EMAIL PROTECTED] writes: rbb 02/02/04 22:16:04 Modified:.STATUS server listen.c Log:

RE: Members of dev@httpd.apache.org

2002-01-24 Thread Sander Striker
From: Gunter Knauf [mailto:[EMAIL PROTECTED]] Hi Gunter, if you don't get feedback, ask why and if nobody answers or somebody says the change isn't appropriate make sure you understand why (but sometimes there is no good reason... collectively we're not perfect communicators I'm afraid)

RE: mod_cgid pipe leak

2002-01-24 Thread Sander Striker
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 24 January 2002 13:44 To: [EMAIL PROTECTED] Cc: Aaron Bannert; Bill Stoddard; [EMAIL PROTECTED] Subject: Re: mod_cgid pipe leak Jeff Trawick [EMAIL PROTECTED] writes: I'll

RE: mod_cgid pipe leak

2002-01-24 Thread Sander Striker
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 24 January 2002 13:44 To: [EMAIL PROTECTED] Cc: Aaron Bannert; Bill Stoddard; [EMAIL PROTECTED] Subject: Re: mod_cgid pipe leak Jeff Trawick [EMAIL PROTECTED] writes:

RE: Current CVS on Win32

2002-01-24 Thread Sander Striker
From: Sebastian Bergmann [mailto:[EMAIL PROTECTED]] Sent: 24 January 2002 14:21 To: [EMAIL PROTECTED] Subject: Current CVS on Win32 ... does not build: apr_pools.c c:\home\apache\httpd-2.0\srclib\apr\memory\unix\apr_pools.c(73): fatal error C1083: include file not found:

RE: PHP Apache2Filter

2002-01-20 Thread Sander Striker
Ian Holsman wrote: no changes to apxs for a long time. Never mind, it turned out to be a probelm solved by 'make clean'. Sorry for bothering with this one. Now I'm getting sapi_apache2.c: In function `php_input_filter': sapi_apache2.c:252: incompatible type for argument 4 of

APR_POOL_DEBUG is functioning again WAS: RE: Don't use APR_POOL_DEBUG

2002-01-15 Thread Sander Striker
Hi, As of a recent commit the apr pools debug code is functioning again. I tested it with httpd-2.0 HEAD and it works (both tried worker and prefork to see if everything goes to the log ok). Some hints (that probably change when we move to a numbered system for selecting the debug mode): If

RE: HEAD dumps core with APR_POOL_DEBUG

2002-01-14 Thread Sander Striker
Hi, I've fixed the integrity check now. If you are still seeing aborts, then we have a serious lifetime problem*. If this is the case, try running with APR_POOL_DEBUG_VERBOSE. When you hit an abort, it will print: INVALID address You can then scan back through the output for the address to see

RE: HEAD dumps core with APR_POOL_DEBUG

2002-01-14 Thread Sander Striker
To: [EMAIL PROTECTED] Subject: Re: HEAD dumps core with APR_POOL_DEBUG Sander Striker [EMAIL PROTECTED] writes: Hi, I've fixed the integrity check now. If you are still seeing aborts, then we have a serious lifetime problem*. If this is the case, try running

RE: HEAD dumps core with APR_POOL_DEBUG

2002-01-14 Thread Sander Striker
Okay, cvs HEAD, fresh build starting with extraclean, just plain APR_POOL_DEBUG: #0 0xff34c70c in pool_is_child_of (pool=0x1b3fb0, parent=0x6174652c, mutex=0x0) at apr_pools.c:900 ^ So, the parent of 'parent' is a pool which doesn't need a lock. It was created by an

Don't use APR_POOL_DEBUG

2002-01-14 Thread Sander Striker
Hi, Please don't use APR_POOL_DEBUG today. There is a logic error* in there which I will fix tomorrow. Thanks for your patience. Sander *) Rendering it totally useless since it also aborts on correct usage.

RE: pool problems with HEAD??

2002-01-10 Thread Sander Striker
Jeff, I'm going over the pools code right now. I'm wondering if something slipped in when I checked in the APR_POOL_DEBUG code (*grunt*) Could you do me a favor and try with one rev earlier to see if it has the same problem? In the mean time I'll try and track it down. Sander -Original

RE: pool problems with HEAD??

2002-01-10 Thread Sander Striker
[...] (2) revert plog/pconf patch and see what happens I applied this patch: Index: server/core.c === RCS file: /cvs/apache/httpd-2.0/server/core.c,v retrieving revision 1.128 diff -u -r1.128 core.c --- core.c

RE: pool problems with HEAD??

2002-01-10 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 10 January 2002 19:57 To: Ian Holsman Cc: [EMAIL PROTECTED] Subject: Re: pool problems with HEAD?? Ian Holsman [EMAIL PROTECTED] writes: can you run it with efence/purify on ? this should catch the

RE: cvs commit: httpd-2.0/modules/loggers mod_log_config.c

2002-01-06 Thread Sander Striker
-Original Message- From: Brian Pane [mailto:[EMAIL PROTECTED]] Sent: 06 January 2002 21:49 To: [EMAIL PROTECTED] Subject: Re: cvs commit: httpd-2.0/modules/loggers mod_log_config.c Ben Laurie wrote: [EMAIL PROTECTED] wrote: brianp 02/01/06 00:01:34 Modified:

[PATCH] Allow DocumentRoot within Location blocks

2002-01-05 Thread Sander Striker
Hi, I've tried to tackle this issue in STATUS: * Allow the DocumentRoot directive within Location scopes? This allows the beloved (crusty) Alias /foo/ /somepath/foo/ followed by a Directory /somepath/foo to become simply Location /foo/ DocumentRoot /somefile/foo (IMHO a

[PATCH] Don't register methods twice

2002-01-04 Thread Sander Striker
Hi, It is not uncommon for modules to register the same method. Therefor it is better to return the already registered method number, instead of allowing the registration twice. Sander PS. I split this out of the mod_dav patch I sent in earlier, because it affects more than just mod_dav.

Bitfields in core_dir_config

2002-01-04 Thread Sander Striker
Hi, Why are we using bitfields in core_dir_config? Do we really care about a few bits? Not to mention it is inconsistent: /* Hostname resolution etc */ #define HOSTNAME_LOOKUP_OFF 0 #define HOSTNAME_LOOKUP_ON 1 #define HOSTNAME_LOOKUP_DOUBLE 2 #define HOSTNAME_LOOKUP_UNSET 3

RE: Benchmark: 29 vs 30

2001-12-22 Thread Sander Striker
From: David Reid [mailto:[EMAIL PROTECTED]] Sent: 22 December 2001 13:57 The transaction stats were what jumped out at me - 7% increase in failed connections doesn't sound good to me :( But, then maybe I'm reading that wrong? Which is what I saw first too. But when I talked to Ian over

[PATCH] Get mod_dav to dynamically register its methods

2001-12-22 Thread Sander Striker
This patch gets mod_dav to register its methods dynamically. Instead of relying on the fact that a method isn't registered and comparing method strings, it now registers and compares method numbers. Sander Index: modules/dav/main/mod_dav.c

[PATCH] Get mod_dav to dynamically register its methods [2]

2001-12-22 Thread Sander Striker
Hi, Like Greg announced previously: here is a new patch. I changed a variable name in ap_method_register, because it is more appropiate with the patch in. Sander Index: modules/dav/main/mod_dav.c === RCS file:

RE: Apache2Filter crashes on Windows

2001-12-17 Thread Sander Striker
From: Sebastian Bergmann [mailto:[EMAIL PROTECTED]] Sent: 17 December 2001 11:10 Daniel Stone wrote: Please provide a full gdb backtrace of the problem; just the last call on the stack won't help the developers much. How do I generate a backtrace with MSVC? :-/ Look at the call

[PATCH] Make the worker mpm use the new pools code

2001-12-14 Thread Sander Striker
[sent to the wrong list the first time, sorry] Hi, This patch will make worker use the new features of the pools code. It also adds a convenient line for debugging purposes (resolves to a NOOP if APR_POOL_DEBUG is not defined). Sander Index: server/mpm/worker/worker.c

RE: cvs commit: httpd-2.0/build instdso.sh

2001-12-14 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: 14 December 2001 13:30 trawick 01/12/14 04:29:37 Modified:buildinstdso.sh Log: take over DSO installation from libtool on all platforms, for both make install and apxs -i since we don't link with Apache

RE: cvs commit: httpd-2.0/build instdso.sh

2001-12-14 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jeff Trawick Sent: 14 December 2001 15:23 Sander Striker [EMAIL PROTECTED] writes: [...] Wouldn't it be better to try and get libtool to behave on AIX (one of the platforms it doesn't work on)? Currently, someone is trying

RE: cvs commit: httpd-2.0 ROADMAP

2001-12-07 Thread Sander Striker
From: Ryan Bloom [mailto:[EMAIL PROTECTED]] Sent: 07 December 2001 17:22 To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: cvs commit: httpd-2.0 ROADMAP +* Add a string class that combines a char* with a length + and a reference count. This will

RE: cvs commit: httpd-2.0 ROADMAP

2001-12-07 Thread Sander Striker
From: Karl Fogel [mailto:[EMAIL PROTECTED]] Sent: 07 December 2001 19:42 Sander Striker [EMAIL PROTECTED] writes: +* Add a string class that combines a char* with a length + and a reference count. This will help reduce the number + of strlen and strdup

RE: Some Benchmark Numbers

2001-11-26 Thread Sander Striker
-Original Message- From: Ian Holsman [mailto:[EMAIL PROTECTED]] Sent: 26 November 2001 23:44 To: [EMAIL PROTECTED] Subject: Some Benchmark Numbers Here are some benchmark numbers showing the performance of 3 pages. (included in the results) 1. the performance of 2.0 against

RE: [PATCH] Remove the Port directive - affects SSL vhost config

2001-10-04 Thread Sander Striker
From: MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) Sent: 04 October 2001 22:40 The patch just affects SSL configurations also.. The ServerName directive specified within a Virtual Host configuration HAS to be accompanied by the SSL port, or else, the server assumes the port 80 by default :-(..

RE: warnings on sol 2.6

2001-09-30 Thread Sander Striker
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]] Sent: 30 September 2001 06:30 On Sun, Sep 30, 2001 at 12:24:08AM -0400, Cliff Woolley wrote: A few warnings that have shown up on Solaris 2.6 sometime within the last few weeks: thread.c: In function `apr_thread_once_init':

RE: proxy - a return.

2001-09-26 Thread Sander Striker
From: Greg Stein [mailto:[EMAIL PROTECTED]] Sent: 26 September 2001 09:35 On Tue, Sep 25, 2001 at 05:45:40PM -0700, Ryan Bloom wrote: On Tuesday 25 September 2001 04:13 pm, Graham Leggett wrote: ... Right now, what is the best way of returning mod_proxy to the tree? Is it a)

[PROPOSAL] apr-client

2001-09-26 Thread Sander Striker
Hi all, I wish to propose a new library: apr-client. It is basically a http client library. I see a direct use for at least three projects: - mod_proxy (which has most of the code in it), - flood (to do more flexible testing, for example with authentication, or even ssl client

RE: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Sander Striker
From: Greg Stein [mailto:[EMAIL PROTECTED]] Sent: 21 September 2001 09:35 On Thu, Sep 20, 2001 at 07:54:22PM -0700, Ryan Bloom wrote: On Thursday 20 September 2001 05:48 pm, Greg Stein wrote: Calling pop_cleanup() on every iteration is a bit much. Consider the following patch:

RE: Optimizing dir_merge() AND RE: [BUG] mod_ssl broken

2001-09-21 Thread Sander Striker
From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]] Sent: 21 September 2001 08:38 From: Sander Striker [EMAIL PROTECTED] Sent: Thursday, September 13, 2001 7:30 AM Ok, now I have a repro recipe that doesn't require mod_dav and mod_dav_svn. The last commit should have fixed

[BUG] mod_ssl

2001-09-21 Thread Sander Striker
Hi, Sorry to bring this up, but I tripped over a segfault in mod_ssl while trying to add client authentication to subversion. I can't reproduce this with openssl s_client, which makes the issue harder. There probably is a bug somewhere in svn or neon (or my usage of that), but that doesn't

RE: Fix broken cleanups model

2001-09-21 Thread Sander Striker
From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]] Sent: 21 September 2001 16:42 - Original Message - From: Ben Hyde [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 21, 2001 9:12 AM I also think it's a long standing mistake that the subpools aren't unwound

RE: UUIDs in 2.0

2001-09-14 Thread Sander Striker
From: dean gaudet [mailto:[EMAIL PROTECTED]] Sent: 14 September 2001 12:45 On Fri, 14 Sep 2001, Sander Striker wrote: Isn't there an apr_get_current_time() that is thread safe? apr_time_now()? that's not the point. i'm guessing you haven't read the code i'm referring to. -dean

RE: Optimizing dir_merge() AND RE: [BUG] mod_ssl broken

2001-09-13 Thread Sander Striker
Hi, I can reproduce the problem easily now with openssl s_client. If anyone is interested to hunt this bug down (I am personally not familiar enough with the location_walk code to find it (without spending more time on it than I have at the moment)), I can give an account on my box to observe

RE: Optimizing dir_merge() AND RE: [BUG] mod_ssl broken

2001-09-11 Thread Sander Striker
From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]] My location_walk optimization (which suffers a potential bug, per our svn friends) takes an entirely different tact, which renders that whole idea DOA. Ok, to rule out the possibility it is in the optimization code I reverted to

RE: mod_ssl broken

2001-09-10 Thread Sander Striker
From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]] From: Ben Laurie [EMAIL PROTECTED] Sent: Sunday, September 09, 2001 3:50 PM Sander Striker wrote: [...] The problem is that basev == NULL, which causes apr_array_append to barf. I'll be looking into this next week (or someone working

RE: Authentication and Authorization

2001-09-10 Thread Sander Striker
using a file/db/whatever is tied in with the authz phase. I'd like to be able to reuse the check if a user (belonging to a certain group) is authorized to access a certain url. On Fri, 7 Sep 2001, Sander Striker wrote: Hi, I've been going through the modules/aaa directory and found

RE: mod_ssl broken

2001-09-10 Thread Sander Striker
[dropped dev@subversion] From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]] Sent: 10 September 2001 14:37 From: Sander Striker [EMAIL PROTECTED] Sent: Monday, September 10, 2001 3:24 AM I've looked into this slightly, and the underlying problem is that ap_merge_per_dir_configs

RE: merge macros (was: Re: mod_ssl broken)

2001-09-10 Thread Sander Striker
From: Greg Stein [mailto:[EMAIL PROTECTED]] Sent: 10 September 2001 22:08 On Mon, Sep 10, 2001 at 09:23:59AM -0500, William A. Rowe, Jr. wrote: From: Ryan Bloom [EMAIL PROTECTED] Sent: Monday, September 10, 2001 8:39 AM I don't mind putting a patch together that does this (and to

Authentication and Authorization

2001-09-07 Thread Sander Striker
Hi, I've been going through the modules/aaa directory and found that modules there seem to implement both authentication and authorization. IMO this should be split. Auth and authz are completely different things and it would be nice to have different modules to do authentication in a

RE: Authentication and Authorization

2001-09-07 Thread Sander Striker
Sander Striker wrote: IMO this should be split. Auth and authz are completely different things and it would be nice to have different modules to do authentication in a different way, but still utilize the same authorization method. I'm not sure if splitting them will accomplish

RE: Authentication and Authorization

2001-09-07 Thread Sander Striker
[replying to my own msg] Sander Striker wrote: IMO this should be split. Auth and authz are completely different things and it would be nice to have different modules to do authentication in a different way, but still utilize the same authorization method. I'm not sure if splitting

mod_include.c WAS: RE: remaining CPU bottlenecks in 2.0

2001-09-05 Thread Sander Striker
* find_start_sequence() is the main scanning function within mod_include. There's some research in progress to try to speed this up significantly. Based on the patches you submitted (and my quasi-errant formatting patch), I had to read most of the code in mod_include, so I'm more

RE: [PATCH] Potential replacement for find_start_sequence...

2001-09-05 Thread Sander Striker
I'm not totally sure I'm sold on this approach being better. But, I'm not sure that it is any worse either. Don't have time to benchmark this right now. I'm going to throw it to the wolves and see what you think. Me neither. Rabin-Karp introduces a lot of * and %. I'll try Boyer-Moore

RE: [PATCH] Add mod_gz to httpd-2.0

2001-09-02 Thread Sander Striker
Hi, From what I have seen on the list I am on the +1 side of adding mod_gz(ip) to the distribution. Ofcourse, my vote doesn't count since I don't have httpd commit. I find the following arguments convincing (summarized): - The gzip content encoding is part of the HTTP spec. - Most clients

RE: Review of possible replacement for pools

2001-08-25 Thread Sander Striker
Why are we spending time trying to optimize pools when we haven't eliminated the malloc/frees in the bucket brigade calls? The miniscule performance improvements you -might- get optimizing pools will be completely obscured by the overhead of the malloc/frees. Bill Because it also

RE: Review of possible replacement for pools

2001-08-25 Thread Sander Striker
Why are we spending time trying to optimize pools when we haven't eliminated the malloc/frees in the bucket brigade calls? The miniscule performance improvements you -might- get optimizing pools will be completely obscured by the overhead of the malloc/frees. Bill

<    1   2   3   4   5