[PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Brad Nicholes
This patch adds the directives LogRotateDaily and LogRotateInterval to the mod_log_config modules. These directives allow all of the custom logs to be automatically rotated on either a daily basis or at a specific interval. This patch is based on a previous patch that was submitted by

Re: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Marc Slemko
On Wed, 27 Feb 2002, Brad Nicholes wrote: This patch adds the directives LogRotateDaily and LogRotateInterval to the mod_log_config modules. These directives allow all of the custom logs to be automatically rotated on either a daily basis or at a specific interval. This patch is based

Re: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Brad Nicholes
Since I am not a Unix developer, can this security problem be overcome somehow or does this mean that I should #ifdef the code as NETWARE only? Brad Brad Nicholes Senior Software Engineer Novell, Inc., a leading provider of Net business solutions http://www.novell.com [EMAIL PROTECTED]

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Ryan Bloom
Do we really want Apache rotating logs? Apache is a web server it serves web pages really well. If you want log rotation, use either a piped log or a cron job that restarts the server. Ryan Since I am not a Unix developer, can this security problem be overcome somehow or does this mean that

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Brad Nicholes
Like I mentioned before, on NetWare we can't use a piped log because the NetWare OS doesn't support pipes. A cron job is also a problem because we don't have that either. Since Apache created the log file, writes to the log file, formats the output and closes the log file, is it that big of a

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Ryan Bloom
Like I mentioned before, on NetWare we can't use a piped log because the NetWare OS doesn't support pipes. A cron job is also a problem because we don't have that either. Since Apache created the log file, writes to the log file, formats the output and closes the log file, is it that big

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Brad Nicholes
Is is enough for us to simply #ifdef these changes in mod_log_config.c or would you rather see a separate logging module? Except for the addition of these two directives, everything else works for us. Brad Brad Nicholes Senior Software Engineer Novell, Inc., a leading provider of Net business

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Ryan Bloom
Is is enough for us to simply #ifdef these changes in mod_log_config.c or would you rather see a separate logging module? Except for the addition of these two directives, everything else works for us. I would personally like to see a separate logging module, because it makes it less likely

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Brad Nicholes
Isn't that the whole cross platform point here? If another platform decided that it was better for them to have log rotation in Apache, isn't it better to share code rather than reinvent or duplicate the wheel? I don't have a problem with separating the code into another module, but I would

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Ryan Bloom
Isn't that the whole cross platform point here? If another platform decided that it was better for them to have log rotation in Apache, isn't it better to share code rather than reinvent or duplicate the wheel? I don't have a problem with separating the code into another module, but I would

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread William A. Rowe, Jr.
At 04:56 PM 2/27/2002, you wrote: Isn't that the whole cross platform point here? If another platform decided that it was better for them to have log rotation in Apache, isn't it better to share code rather than reinvent or duplicate the wheel? I don't have a problem with separating the code

RE: [PATCH] Apache 1.3 built in log rotation...

2002-02-27 Thread Brad Nicholes
Hopefully for NetWare this will be an Apache 1.3 issue only. It is a long story, but Apache 1.3 was built on our old CLib libraries which do not support functionality like pipes. Apache 2.0 and beyond is based on LibC which is a ground up rewrite of the standard library functionality and