Re: [PATCH] Introducing mod_brotli

2016-10-20 Thread Jim Jagielski
Ahh... that's... interesting. > On Oct 19, 2016, at 8:37 PM, Jacob Champion wrote: > > On 09/16/2016 05:32 AM, Evgeny Kotkov wrote: >> This patch adds a module for dynamic Brotli (RFC 7932) compression in httpd. > > Just in case someone else runs into this: I gave

Re: [PATCH] Introducing mod_brotli

2016-10-19 Thread Jacob Champion
On 10/19/2016 06:13 PM, William A Rowe Jr wrote: enum boolval { false = 0; is not that challenging. Yeah, but I tend to turn up my nose at enums in ABIs too, because the question "how big is an enum?" has a more complicated answer than the question "how big is an int?". Ah well, it's

Re: [PATCH] Introducing mod_brotli

2016-10-19 Thread William A Rowe Jr
enum boolval { false = 0; is not that challenging. On Oct 19, 2016 7:38 PM, "Jacob Champion" wrote: > On 09/16/2016 05:32 AM, Evgeny Kotkov wrote: > >> This patch adds a module for dynamic Brotli (RFC 7932) compression in >> httpd. >> > > Just in case someone else runs

Re: [PATCH] Introducing mod_brotli

2016-10-19 Thread Jacob Champion
On 09/16/2016 05:32 AM, Evgeny Kotkov wrote: This patch adds a module for dynamic Brotli (RFC 7932) compression in httpd. Just in case someone else runs into this: I gave mod_brotli a shot after a user on #httpd-dev asked about Brotli compression, and it immediately ran my test server out of

Re: [PATCH] Introducing mod_brotli

2016-09-20 Thread Evgeny Kotkov
Evgeny Kotkov writes: >>> Wow! This is great stuff. Brotli support has been in my TODO >>> queue for awhile. >>> >>> Thanks! >> >> +1, cool stuff and thanks! > > Glad to hear that, thanks everyone. > > I would be happy to continue the work on this module, for

Re: [PATCH] Introducing mod_brotli

2016-09-20 Thread Evgeny Kotkov
Reindl Harald writes: > agreed - however, below some configs where my brain rumours how have that > identically behavior by just use "brotli" compression in case the cient > supports it - maybe someone with deeper insights as my pure adiminstrator > view has a idea by

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Reindl Harald
Am 19.09.2016 um 19:56 schrieb Jacob Champion: On 09/19/2016 10:12 AM, Eric Covener wrote: I would prefer to keep them separate even if we have to teach something to coordinate them (a module, some new support in mod_filter, some kind of hook?) +1. (If it proves difficult to make separate

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Jacob Champion
On 09/19/2016 10:12 AM, Eric Covener wrote: I would prefer to keep them separate even if we have to teach something to coordinate them (a module, some new support in mod_filter, some kind of hook?) +1. (If it proves difficult to make separate compression modules play well together, that's a

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Eric Covener
On Mon, Sep 19, 2016 at 11:35 AM, Reindl Harald wrote: > just an idea - wouldn't it make sense to add 'br' support for mod_deflate > and have it preferred when the client says in it's request headers that it > supports the encoding instead having two modules for the same

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Reindl Harald
Am 19.09.2016 um 16:14 schrieb Evgeny Kotkov: Eric Covener writes: Wow! This is great stuff. Brotli support has been in my TODO queue for awhile. Thanks! +1, cool stuff and thanks! Glad to hear that, thanks everyone. I would be happy to continue the work on this

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Evgeny Kotkov
Eric Covener writes: >> Wow! This is great stuff. Brotli support has been in my TODO >> queue for awhile. >> >> Thanks! > > +1, cool stuff and thanks! Glad to hear that, thanks everyone. I would be happy to continue the work on this module, for instance, by adding the

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Eric Covener
On Mon, Sep 19, 2016 at 9:55 AM, Jim Jagielski wrote: > Wow! This is great stuff. Brotli support has been in my TODO > queue for awhile. > > Thanks! +1, cool stuff and thanks! -- Eric Covener cove...@gmail.com

Re: [PATCH] Introducing mod_brotli

2016-09-19 Thread Jim Jagielski
Wow! This is great stuff. Brotli support has been in my TODO queue for awhile. Thanks! > On Sep 16, 2016, at 8:32 AM, Evgeny Kotkov > wrote: > > Hi all, > > This patch adds a module for dynamic Brotli (RFC 7932) compression in httpd. > > The new compression

Re: [PATCH] Introducing mod_brotli

2016-09-16 Thread Evgeny Kotkov
Reindl Harald writes: > how is the ordering? > defined by SetOutputFilter or client? Currently, the order is defined by SetOutputFilter, because AFAIK there is no centralized way to handle Accept-Encoding priorities (like ;q=0.7). > does it also support

Re: [PATCH] Introducing mod_brotli

2016-09-16 Thread Reindl Harald
Am 16.09.2016 um 14:59 schrieb Stefan Eissing: Sweet! Am 16.09.2016 um 14:32 schrieb Evgeny Kotkov : Hi all, This patch adds a module for dynamic Brotli (RFC 7932) compression in httpd. The new compression format is supported by Mozilla Firefox since 44.0 and

[PATCH] Introducing mod_brotli

2016-09-16 Thread Evgeny Kotkov
Hi all, This patch adds a module for dynamic Brotli (RFC 7932) compression in httpd. The new compression format is supported by Mozilla Firefox since 44.0 and by Google Chrome since 50.0 [1, 2], and both nginx and IIS have modules that offer Brotli compression. With the new module, existing