Re: [PATCH] mod_dbd with more than one pool

Nick, any news? On Fri, Mar 13, 2009 at 3:54 PM, Nick Kew n...@webthing.com wrote: Thanks.  I'll test-drive today. -- Marko Kevac

Re: [PATCH] mod_dbd with more than one pool

On Tue, Mar 24, 2009 at 10:03 PM, Ronald Park rkpar...@gmail.com wrote: A user might presume that the order of commands listed in the config file would be preserved when the commands are run.  By using a hash table, you'll likely get a random order causing problems.  For example, perhaps the

Re: [PATCH] mod_dbd with more than one pool

Ronald Park wrote: I did have one minor nit to pick with the implementation of the DBDInitSQL command. A user might presume that the order of commands listed in the config file would be preserved when the commands are run. By using a hash table, you'll likely get a random order causing

Re: [PATCH] mod_dbd with more than one pool

Sorry for coming into this discussion late. I think this is an excellent set of patches. I had developed a similar enhancement to allow mod_dbd to connect with multiple databases at my last job but never had a chance to make it available here. Your version is far more clever and configurable.

Re: [PATCH] mod_dbd with more than one pool

On Fri, Mar 13, 2009 at 2:54 PM, Nick Kew n...@webthing.com wrote: Thanks.  I'll test-drive today. Succeeded? -- Marko Kevac

Re: [PATCH] mod_dbd with more than one pool

On Tue, Mar 10, 2009 at 10:45 PM, Nick Kew n...@webthing.com wrote: Can I throw an alternative suggestion into the ring. Instead of running dbd_init_sql_init at the end of dbd_construct, run a hook there.  Your function then runs on that hook, but it enables other modules to do their own

Re: [PATCH] mod_dbd with more than one pool

On 13 Mar 2009, at 10:21, Kevac Marko wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=46827 Implemented. Patch added. Comments? Thanks. I'll test-drive today. -- Nick Kew

Re: [PATCH] mod_dbd with more than one pool

Nick Kew wrote: Kevac Marko wrote: Ok, here is sql init statement only patch against trunk: https://issues.apache.org/bugzilla/show_bug.cgi?id=46827 Thanks for the patch! Can I throw an alternative suggestion into the ring. [ ... ] Thoughts? A further thought. I had in mind PR#45407 -

Re: [PATCH] mod_dbd with more than one pool

Ok, here is sql init statement only patch against trunk: https://issues.apache.org/bugzilla/show_bug.cgi?id=46827 P.S. Thanks http://jukka.zitting.name/git/ for git mirrors. I am happy :-) P.P.S. Probably I should wait for sql init statement only patch inclusion before posting everything else?

Re: [PATCH] mod_dbd with more than one pool

On Fri, Mar 6, 2009 at 7:58 PM, Chris Darroch chr...@pearsoncmg.com wrote:  One thought I had overnight is that you might, if you like, want to tackle the init SQL patch first, which seems unrelated to the multiple pools idea and significantly simpler, easier to review, and probably easier to

Re: [PATCH] mod_dbd with more than one pool

On Thu, Mar 5, 2009 at 10:05 PM, Chris Darroch chr...@pearsoncmg.com wrote:  One difference, I think -- again, after only a quick review -- is that what I was trying to solve with the notion of a DBDGroup container and then a DBDGroup directive was to minimize the number of distinct

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: Prepared statements are not executed, just parsed (simplified), so no, it is not important for initialization statement to be before prepared statements. Right; what I wondered was whether you needed to execute some sort of magic initialization statement which would then

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: It's great idea. But are you sure that it is good idea to change both main httpd.conf and VirtualHost for new DB connection to be added? These are separate things... It will introduce problems if, for example, httpd.conf is root writable and virtualhost-blabla.conf is user

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: Ok, here is sql init statement only patch against trunk: https://issues.apache.org/bugzilla/show_bug.cgi?id=46827 Thanks for the patch! Can I throw an alternative suggestion into the ring. Instead of running dbd_init_sql_init at the end of dbd_construct, run a hook there.

Re: [PATCH] mod_dbd with more than one pool

There are some bugs in non-threaded build. I am fixing them right now. -- Marko Kevac

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: There are some bugs in non-threaded build. I am fixing them right now. Another quick request: is it possible to update the apr_dbd end user documentation to show the additional container directive, and to explain how the module should work? Regards, Graham --

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: I'm not experienced in commiting patches to open source projects, so I am very thankful for your comments. No problem -- thanks for pushing this patch along! One thought I had overnight is that you might, if you like, want to tackle the init SQL patch first, which

Re: [PATCH] mod_dbd with more than one pool

On Thu, Feb 12, 2009 at 12:56 AM, Nick Kew n...@webthing.com wrote: Sounds OK in principle for trunk.  If you want to post a patch against trunk, I'll try and find the time to review it. Here I am again. The patch works well for us. Is there something else that I can do for now? -- Marko

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: Here I am again. The patch works well for us. Is there something else that I can do for now? I'm going to try to find some time to take a look -- thanks for the patch; it's good to see the DBDGroup idea being taken further than my initial notions. On an initial quick

Re: [PATCH] mod_dbd with more than one pool

Chris, thank you. I am impressed. I'm not experienced in commiting patches to open source projects, so I am very thankful for your comments. I'll try to fix things up very soon. 80 columns is a little bit ancient requirement in the world of 22 LCDs, but ok, i'll fix that too. -- Marko Kevac

Re: [PATCH] mod_dbd with more than one pool

Chris Darroch wrote: Over in mod_dbd.h, Nick's old copyright statement is removed. That's definitely something which, if needed, should be dealt with separately -- I'm not sure if it should be there or not, but it's a legal issue not a coding one. OK, guess it's best if I deal with that

Re: [PATCH] mod_dbd with more than one pool

On Mar 5, 2009, at 4:52 PM, Kevac Marko wrote: 80 columns is a little bit ancient requirement in the world of 22 LCDs, but ok, i'll fix that too. Not when you have 4 code branches side by side... Also, netbooks are pretty popular as well. Most of my coding is done on a 15 laptop screen.

Re: [PATCH] mod_dbd with more than one pool

Now for every exported function we have pair of functions that accepts pool_name and old one, which is just wrapper: DBD_DECLARE_NONSTD(ap_dbd_t*) ap_dbd_open_pool(apr_pool_t *pool, server_rec *s, const char *pool_name); DBD_DECLARE_NONSTD(ap_dbd_t*) ap_dbd_open(apr_pool_t *pool,

Re: [PATCH] mod_dbd with more than one pool

On 2/11/09 4:29 PM, Kevac Marko ma...@kevac.org wrote: What so you think? Patch is ready, but it needs some testing before posting. +1 I was looking to do the same thing to mod_memcache (which should be imported into trunk, IMO...)

Re: [PATCH] mod_dbd with more than one pool

On Thu, Feb 12, 2009 at 12:43 AM, Brian Akins br...@akins.org wrote: I was looking to do the same thing to mod_memcache (which should be imported into trunk, IMO...) kni...@juffin:~/micex/git/apache$ tree modules/memcache/ modules/memcache/ |-- SConscript |-- mod_memcache.c `-- mod_memcache.h

Re: [PATCH] mod_dbd with more than one pool

On Thu, 12 Feb 2009 00:29:59 +0300 Kevac Marko ma...@kevac.org wrote: In httpd.conf you can create named pool inside DBDPool pool_name or without. In second case pool_name is DBD_DEFAULT_POOL_NAME. Thus old functions and old configuration is preserved. What so you think? Patch is

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: Thus old functions and old configuration is preserved. What so you think? That sounds to me like it would be safe to backport such a thing to v2.2. +1. Regards, Graham -- smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH] mod_dbd with more than one pool

Brian Akins wrote: I was looking to do the same thing to mod_memcache (which should be imported into trunk, IMO...) Would it make sense for mod_memcache to become a provider beneath mod_socache, or am I missing something? Regards, Graham -- smime.p7s Description: S/MIME Cryptographic

Re: [PATCH] mod_dbd with more than one pool

On Feb 11, 2009, at 6:22 PM, Graham Leggett wrote: Would it make sense for mod_memcache to become a provider beneath mod_socache, or am I missing something? mod_memcache really just provides the config glue for apr_memcache so that every module that wants to use apr_memcache doesn't have

Re: [PATCH] mod_dbd with more than one pool

I am in favor of this for 2.3/2.4 as well -- it is functionality that I have wanted (not enough to do, though...) for a while now. -Brian On Fri, Jan 30, 2009 at 6:20 PM, Graham Leggett minf...@sharp.fm wrote: Kevac Marko wrote: Once again I want to propose patch for mod_dbd module. This

Re: [PATCH] mod_dbd with more than one pool

Kevac Marko wrote: Once again I want to propose patch for mod_dbd module. This patch make possible to use more than one database pool. One of the things I needed to do earlier today was determine whether mod_dbd could support more than one database pool, this patch answers that question.