RE: finish connection hook (WAS: RE: [PATCH] SSL not sending close alert message)

2004-02-26 Thread Justin Erenkrantz
--On Wednesday, February 25, 2004 1:20 PM -0800 Mathihalli, Madhusudan [EMAIL PROTECTED] wrote: Hooking the cleanups to the connection pool may be a little too late for some modules (Example SSL shutdown/SSL Alert). For filters like SSL, the EOC logic would probably be just fine - I can't think

Re: [PATCH] SSL not sending close alert message

2004-02-25 Thread Sander Striker
On Wed, 2004-02-25 at 00:15, Cliff Woolley wrote: On Tue, 24 Feb 2004, Joe Orton wrote: I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header added to the new file. I say

Re: finish connection hook (WAS: RE: [PATCH] SSL not sending close alert message)

2004-02-25 Thread Justin Erenkrantz
--On Tuesday, February 24, 2004 4:49 PM -0800 Mathihalli, Madhusudan [EMAIL PROTECTED] wrote: ... brings up the question : do you still want the finish_connection hook OR should the modules be content with the EOC bucket ? I don't think we'd need a new hook. -- justin

Re: finish connection hook (WAS: RE: [PATCH] SSL not sending close alert message)

2004-02-25 Thread Greg Stein
On Wed, Feb 25, 2004 at 09:16:04AM -0800, Justin Erenkrantz wrote: --On Tuesday, February 24, 2004 4:49 PM -0800 Mathihalli, Madhusudan [EMAIL PROTECTED] wrote: ... brings up the question : do you still want the finish_connection hook OR should the modules be content with the EOC bucket ?

RE: finish connection hook (WAS: RE: [PATCH] SSL not sending close alert message)

2004-02-25 Thread Mathihalli, Madhusudan
-Original Message- From: Greg Stein [mailto:[EMAIL PROTECTED] [SNIP] On Wed, Feb 25, 2004 at 09:16:04AM -0800, Justin Erenkrantz wrote: --On Tuesday, February 24, 2004 4:49 PM -0800 Mathihalli, Madhusudan wrote: ... brings up the question : do you still want the finish_connection

RE: [PATCH] SSL not sending close alert message

2004-02-24 Thread Mathihalli, Madhusudan
-Original Message- From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] This is just back to what we had patches for already: doing an SSL shutdown on any EOF bucket, right? Which is not right since you get an EOS after each HTTP response, not at the end of the connection. Hence the need

Re: [PATCH] SSL not sending close alert message

2004-02-24 Thread Joe Orton
On Tue, Feb 24, 2004 at 09:59:00AM -0800, Mathihalli, Madhusudan wrote: -Original Message- From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] This is just back to what we had patches for already: doing an SSL shutdown on any EOF bucket, right? Which is not right since you get an EOS

Re: [PATCH] SSL not sending close alert message

2004-02-24 Thread Cliff Woolley
On Tue, 24 Feb 2004, Joe Orton wrote: I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header added to the new file. I say httpd. --Cliff

RE: [PATCH] SSL not sending close alert message

2004-02-24 Thread Mathihalli, Madhusudan
-Original Message- From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header added to the new file. Since the EOC bucket is

Re: [PATCH] SSL not sending close alert message

2004-02-24 Thread Greg Stein
On Tue, Feb 24, 2004 at 06:15:20PM -0500, Cliff Woolley wrote: On Tue, 24 Feb 2004, Joe Orton wrote: I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header added to the new

RE: [PATCH] SSL not sending close alert message

2004-02-24 Thread Mathihalli, Madhusudan
Argh.. stupid e-mail client.. -Original Message- From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header added to the new

RE: [PATCH] SSL not sending close alert message

2004-02-24 Thread Mathihalli, Madhusudan
-Original Message- From: Cliff Woolley [mailto:[EMAIL PROTECTED] [SNIP] On Tue, 24 Feb 2004, Joe Orton wrote: I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header

Re: [PATCH] SSL not sending close alert message

2004-02-24 Thread Jim Jagielski
Cliff Woolley wrote: On Tue, 24 Feb 2004, Joe Orton wrote: I wasn't sure whether or not this EOC bucket type should go in APR-util or httpd. Filtering gurus, what say ye? That bit looks OK to me otherwise with a licence header added to the new file. I say httpd. +1 --

finish connection hook (WAS: RE: [PATCH] SSL not sending close alert message)

2004-02-24 Thread Mathihalli, Madhusudan
-Original Message- From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] mod_ssl-side I'd just use the changes in the most recent patch I posted with the CLOSE bucket test replaced with the EOC bucket test in the output filter: in my testing you needed to turn off buffering in

RE: [PATCH] SSL not sending close alert message

2004-02-23 Thread Mathihalli, Madhusudan
Oops.. A typo (in the second block - line 951,6...) during the cut-and-paste operation. This mail has the corrected version. -Madhu -Original Message- From: Mathihalli, Madhusudan Sent: Monday, February 23, 2004 1:22 PM To: '[EMAIL PROTECTED]' Subject: [PATCH] SSL not sending close

Re: [PATCH] SSL not sending close alert message

2004-02-23 Thread Joe Orton
On Mon, Feb 23, 2004 at 01:22:05PM -0800, Mathihalli, Madhusudan wrote: Hi, I started working on Justin's idea of creating a EOC bucket - to do a SSL shutdown before the socket close(). But since the ap_flush_conn is called just before closing the socket - I thought of

RE: [PATCH] SSL not sending close alert message

2004-02-23 Thread Mathihalli, Madhusudan
Orton [mailto:[EMAIL PROTECTED] Sent: Monday, February 23, 2004 2:07 PM To: [EMAIL PROTECTED] Subject: Re: [PATCH] SSL not sending close alert message On Mon, Feb 23, 2004 at 01:22:05PM -0800, Mathihalli, Madhusudan wrote: Hi, I started working on Justin's idea of creating a EOC bucket

RE: [PATCH] SSL not sending close alert message

2004-02-23 Thread Mathihalli, Madhusudan
Oh.. forget it - it was some setting in my browser :( Thanks -Madhu From: Mathihalli, Madhusudan Sent: Mon 2/23/2004 3:16 PM To: [EMAIL PROTECTED] Subject: RE: [PATCH] SSL not sending close alert message When I did a ssldump to analyze the default index.html

Re: [PATCH] SSL not sending close alert message

2004-02-23 Thread William A. Rowe, Jr.
At 04:07 PM 2/23/2004, Joe Orton wrote: On Mon, Feb 23, 2004 at 01:22:05PM -0800, Mathihalli, Madhusudan wrote: Hi, I started working on Justin's idea of creating a EOC bucket - to do a SSL shutdown before the socket close(). But since the ap_flush_conn is called just before

Re: [PATCH] SSL not sending close alert message

2004-02-23 Thread Cliff Woolley
On Tue, 24 Feb 2004, William A. Rowe, Jr. wrote: I suspect that if the http protocol filter knew the difference between keep alive and connection close requests, it should eat non-terminal EOS marks (and pass flush instead?) while still passing a final EOS to the network stack layer? That