Re: Skipped tests marked as failed?

2001-11-10 Thread Stas Bekman
Rodent of Unusual Size wrote: Doug MacEachern wrote: On Fri, 9 Nov 2001, Rodent of Unusual Size wrote: I thought skipped subtests were supposed to be treated as qualified successes? And Doug, didn't you say the output displayed by the skip sub would say 'skipped'? looks like you've fixed the

Re: [PATCH] repost - read request timeout

2001-11-10 Thread Jeff Trawick
Tom Gilbert [EMAIL PROTECTED] writes: * Roy T. Fielding ([EMAIL PROTECTED]) wrote: Hi Tom, It wasn't lost in the traffic. We can't use this change in 1.3.x because it would break binary compatibility due to the structure changes. We can try to do something like it in 2.0.x, but

ap_cgi_var_lookup()

2001-11-10 Thread Doug MacEachern
i would like to avoid calling ap_add_{common,cgi}_vars() in mod_perl and just tie Perl's %ENV to a lookup function. i cooked up some generated code based logic in Perl's ExtUtils::Constant module. the generated code will probably explain itself better than i can, but here is a comment from the

Re: cvs commit: httpd-2.0 STATUS

2001-11-10 Thread Justin Erenkrantz
On Sat, Nov 10, 2001 at 08:49:27PM -0500, Jeff Trawick wrote: How many people really give a shit? I'm truly curious. I do. =) I believe that our code is also a way to teach people. We are espousing our code as a reference implementation - to me, that means it must be clean, precise, and the

Two apache/2.0.29-dev problems

2001-11-10 Thread Dale Ghent
I'm running HEAD as of earlier this afternoon on Solaris 8+sendfile, with the worker mpm. I'm seeing two problems: one, is that the httpd process (one, sometimes both of the children I have started) will spin up, eating CPU. A truss of these busy processes shows that there are some threads

coding style cleanup Re: cvs commit: httpd-2.0 STATUS

2001-11-10 Thread Brian Pane
Justin Erenkrantz wrote: On Sun, Nov 11, 2001 at 01:04:44AM -, [EMAIL PROTECTED] wrote: + +* Source code should follow style guidelines. +This can't wait until we have a 2.0-gold release because then +style corrections will conflict with bug fixes found after +

Re: Two apache/2.0.29-dev problems

2001-11-10 Thread Brian Pane
Justin Erenkrantz wrote: On Sat, Nov 10, 2001 at 09:21:48PM -0500, Dale Ghent wrote: On Sat, 10 Nov 2001, Justin Erenkrantz wrote: | Can you reproduce this? Would it be possible to attach to this via | gdb and get a backtrace? -- justin I tried that, but gdb is showing me only the main

Re: coding style cleanup Re: cvs commit: httpd-2.0 STATUS

2001-11-10 Thread Justin Erenkrantz
On Sat, Nov 10, 2001 at 06:21:18PM -0800, Brian Pane wrote: While I'm not opposed in principle to doing a code cleanup before GA, I'd feel much more comfortable if it either: * didn't delay the release, or * added some quantifiable, incremental value for users. I think it adds some

mmap_setaside?

2001-11-10 Thread Brian Pane
Is anybody working on modifying mmap_setaside so that it doesn't have to memcpy the file contents? (I recall this being an issue a while ago.) This could yield a small but measurable improvement on requests that aren't handled using sendfile --Brian

mod_include vs file descriptors

2001-11-10 Thread Brian Pane
This bit of mod_include's includes_filter() is likely to be a problem for servers with a lot of connections from slow clients: if ((parent = ap_get_module_config(r-request_config, include_module))) { /* Kludge --- for nested includes, we want to keep the subprocess *

Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c

2001-11-10 Thread Jeff Trawick
[EMAIL PROTECTED] writes: trawick 01/11/10 20:37:11 Modified:server/mpm/prefork prefork.c Log: in prefork, listensocks[0] doesn't have a pod this fixes FREQUENT segfaults in prefork when you have more than one listening socket I just noticed a couple of minor nits in the

Re: mod_include vs file descriptors

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 09:09 pm, Brian Pane wrote: This bit of mod_include's includes_filter() is likely to be a problem for servers with a lot of connections from slow clients: if ((parent = ap_get_module_config(r-request_config, include_module))) { /* Kludge --- for

Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 09:17 pm, [EMAIL PROTECTED] wrote: trawick 01/11/10 21:17:51 Modified:server/mpm/prefork prefork.c Log: minor tweaks to pass a parm of the right type to apr_poll() and to use i for an iterator in both listensocks[] loops Sorry about that. All

Re: mod_include vs file descriptors

2001-11-10 Thread Brian Pane
Ryan Bloom wrote: [...] apr_pool_join is a no-op unless APR_POOL_DEBUG is enabled. If it isn't enabled, which it shouldn't be on production servers, there will be no performance penalty for that function. Sorry, I blamed the wrong part of the code, but the core problem still remains: we

Re: [PATCH] syncing up

2001-11-10 Thread Justin Erenkrantz
On Wed, Nov 07, 2001 at 09:07:41PM +1100, Daniel Stone wrote: Hi guys, Here's a quick sync up of all the patches that I have in my Debian package that probably should go upstream. If you're in the top src dir of HEAD, apply with -p2 (they're +++ apache2-version.diffed.against/apache2/).

Re: [PATCH] syncing up

2001-11-10 Thread Justin Erenkrantz
On Sun, Nov 11, 2001 at 06:31:43PM +1100, Daniel Stone wrote: On Sat, Nov 10, 2001 at 11:25:16PM -0800, Justin Erenkrantz wrote: On Wed, Nov 07, 2001 at 09:07:41PM +1100, Daniel Stone wrote: 003_program_build: Contributed by Thom May, does autoconf substitutions on support/*. Not

Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 12:00 am, [EMAIL PROTECTED] wrote: rbb 01/11/10 00:00:41 Modified:server/mpm/prefork prefork.c Log: Move prefork to the same API as the rest of the MPMs for setting up listeners. This has been on my plate for a few months now, but I had to

Re: cvs commit: httpd-docs-1.3/htdocs/manual/mod mod_rewrite.html

2001-11-10 Thread David Reid
Guess you got your key sorted out then! Welcome back :) david rbowen 01/11/09 18:24:41

[PATCH] http2env optimization

2001-11-10 Thread Brian Pane
When using modules that call ap_add_common_vars, like mod_include or mod_cgi, the function http2env gets called a lot. This patch cuts the function's work roughly in half. --Brian Index: server/util_script.c === RCS file:

jakarta.apache.org not responding

2001-11-10 Thread Graham Leggett
Hi all, I can't seem to get through to http://jakarta.apache.org/ - is there a problem with daedelus? (Or is it me...?) Regards, Graham -- - [EMAIL PROTECTED]There's a moon over Bourbon Street

1.3.22 binaries _are_ available for i686

2001-11-10 Thread Stipe Tolj
This is repost. I mentioned already a couple of times that i686-whatever-cygwin no Stipe Tolj should be set to yes for the current [STATUS](apache-1.3) Regards, Stipe [EMAIL PROTECTED] --- Wapme Systems AG

Is 2.0 out?

2001-11-10 Thread jlwpc1
Covalent Technologies decides version 2.0 is ready for prime time and sets the release of the long-awaited server software ahead of software from the larger Apache project itself. http://news.cnet.com/news/0-1003-200-7832173.html?tag=mn_hd JLW

Re: [PATCH] http2env optimization

2001-11-10 Thread Brian Pane
Ryan Bloom wrote: [...] { -char *res = apr_pstrcat(a, HTTP_, w, NULL); +char *res = (char *)apr_palloc(a, 6 + strlen(w)); Pleaes don't use a magic number 6. Can we just make that strlen(HTTP_) + 1, any compiler worth its salt will convert that at compile time. I prefer

Re: Something I learned, today

2001-11-10 Thread Ian Holsman
On 11/9/01 11:21 PM, Brian Pane [EMAIL PROTECTED] wrote: Commited.. Thanks Brian -if (modi-name != NULL strcmp(modi-name, modname) == 0) +if (modi-name != NULL strcmp(modi-name, modname) == 0) { +ap_log_perror(APLOG_MARK, APLOG_WARNING|APLOG_NOERRNO, 0, +

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread Cliff Woolley
On Fri, 9 Nov 2001, Brian Pane wrote: This patch zero-fills just the integer and pointer fields in the structure, plus the first byte of each of the string buffers. With the patch, I'm seeing a 19% improvement in SSI throughput in informal testing (ab running a single request at a time,

Re: [PATCH] http2env optimization

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 09:54 am, Brian Pane wrote: Ryan Bloom wrote: [...] { -char *res = apr_pstrcat(a, HTTP_, w, NULL); +char *res = (char *)apr_palloc(a, 6 + strlen(w)); Pleaes don't use a magic number 6. Can we just make that strlen(HTTP_) + 1, any compiler worth

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread William A. Rowe, Jr.
From: Ryan Bloom [EMAIL PROTECTED] Sent: Saturday, November 10, 2001 12:38 PM On Saturday 10 November 2001 10:34 am, Cliff Woolley wrote: memset(f-ctx, 0, (size_t)((char *)(ctx-error_str) - (char *)ctx)); No offense, but that is an ugly line of code. :-) Guys, look at the mod_mime

Re: daedalus is on 2_0_28

2001-11-10 Thread William A. Rowe, Jr.
From: Chuck Murcko [EMAIL PROTECTED] Sent: Saturday, November 10, 2001 12:53 PM I've got 2.0.28 (the original tarball) running on OS X now. The regex warnings are not fatal but I need to dig in to that later: Who plans on getting HFS right on OS X in apr/file_io/unix ??? That is a really

[PATCH 2] performance fix for mod_include

2001-11-10 Thread Brian Pane
This updated version of the patch doesn't allocate space for the error_str and time_str buffers in the mod_include filter context until/unless they're actually needed. --Brian Index: modules/filters/mod_include.h === RCS file:

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2001-11-10 Thread Bill Stoddard
Ryan, I understand the motivation for this, but it breaks Windows. In some cases we do not want to close the socket on Windows; it can be reused for a big performance boost. Bill - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, November 10, 2001 1:26

Re: 1.3.22 binaries _are_ available for i686

2001-11-10 Thread Jeff Trawick
Stipe Tolj [EMAIL PROTECTED] writes: This is repost. I mentioned already a couple of times that i686-whatever-cygwin no Stipe Tolj should be set to yes for the current [STATUS](apache-1.3) fixed -- Jeff Trawick | [EMAIL PROTECTED] | PGP public key at web site:

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 10:51 am, Brian Pane wrote: Ryan Bloom wrote: [...] memset(f-ctx, 0, (size_t)((char *)(ctx-error_str) - (char *)ctx)); No offense, but that is an ugly line of code. :-) I really think that error_str and time_str can just be removed from that structure. That

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread Brian Pane
Ryan Bloom wrote: [...] Later today I'll post a new patch that turns error_str and time_str into char*. Just remove them from the structure all together. They aren't necessary in that structure. Where else would you put them? If they move out of the filter context struct, they'll have to

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2001-11-10 Thread Bill Stoddard
Sorry, my last message wasn't a very useful... ap_lingering_close() should be conditionally called based on a feature macro. Something like: HAVE_REUSE_ACCEPT_SOCKET. If the OS supports reusing the accept socket, conditionally issue ap_lingering_close() if the socket has not been disconnected.

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 12:37 pm, Bill Stoddard wrote: Ryan, I understand the motivation for this, but it breaks Windows. In some cases we do not want to close the socket on Windows; it can be reused for a big performance boost. I'm fixing it. This is going to require me to re-export

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 12:51 pm, Brian Pane wrote: Ryan Bloom wrote: [...] Later today I'll post a new patch that turns error_str and time_str into char*. Just remove them from the structure all together. They aren't necessary in that structure. Where else would you put them?

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 12:58 pm, Bill Stoddard wrote: Sorry, my last message wasn't a very useful... ap_lingering_close() should be conditionally called based on a feature macro. Something like: HAVE_REUSE_ACCEPT_SOCKET. If the OS supports reusing the accept socket, conditionally

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread Ryan Bloom
On Saturday 10 November 2001 01:03 pm, Ryan Bloom wrote: On Saturday 10 November 2001 12:51 pm, Brian Pane wrote: Ryan Bloom wrote: [...] Later today I'll post a new patch that turns error_str and time_str into char*. Just remove them from the structure all together. They aren't

Re: [PATCH] performance fix for mod_include

2001-11-10 Thread Brian Pane
Ryan Bloom wrote: On Saturday 10 November 2001 12:51 pm, Brian Pane wrote: Ryan Bloom wrote: [...] Later today I'll post a new patch that turns error_str and time_str into char*. Just remove them from the structure all together. They aren't necessary in that structure. Where else would you

Re: Is 2.0 out?

2001-11-10 Thread Daniel Stone
On Sat, Nov 10, 2001 at 11:27:32AM -0600, jlwpc1 wrote: Covalent Technologies decides version 2.0 is ready for prime time and sets the release of the long-awaited server software ahead of software from the larger Apache project itself. Covalent are not the Apache Software Foundation