Re: svn commit: r1913028 - /httpd/httpd/tags/2.4.58-rc2-candidate/

2023-10-16 Thread Ruediger Pluem
Windows 64 bit is fine? Regards Rüdiger On 10/16/23 3:52 PM, SteffenAL wrote: > No go. All other modules fine, only mod_http2 error. > > Recap: > > On windows 32: > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';' b

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

2023-10-16 Thread Ruediger Pluem
On 10/16/23 3:18 PM, Stefan Eissing via dev wrote: > >> Am 16.10.2023 um 15:12 schrieb SteffenAL : >> >> checkout. >> >> Looks like h2_ws.h : >> >> Generating Code... >> h2_ws.h >> C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax >> error: missing ';' before '*' >> C:\V

Re: [VOTE] Release httpd-2.4.58-rc2 as httpd-2.4.58

2023-10-16 Thread Ruediger Pluem
I am sorry, but #include "apr_encode.h" is still unconditional in h2_ws.c in 2.4.x. Fixed in r1913027. Regards Rüdiger On 10/16/23 3:31 PM, Stefan Eissing via dev wrote: > Hi all, > > after some hickups with getting the new WebSockets support to > compile on Joe's old computers, we try again!

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

2023-10-16 Thread Ruediger Pluem
On 10/16/23 2:38 PM, Stefan Eissing via dev wrote: > > >> Am 16.10.2023 um 14:28 schrieb jor...@apache.org: >> >> Author: jorton >> Date: Mon Oct 16 12:28:13 2023 >> New Revision: 1913019 >> >> URL: http://svn.apache.org/viewvc?rev=1913019&view=rev >> Log: >> Further h2 compile fixes: >> >> *

Re: [PATCH] fix mod_h2 with older nghttp2

2023-10-16 Thread Ruediger Pluem
On 10/16/23 2:38 PM, Joe Orton wrote: > BTW is modules/http2 really CTR for 2.4.x? STATUS says only > mod_proxy_http2 is. > > Anyway: I am +1 for r1913005 and r1913019 for 2.4.x, latter was > sufficient to get 2.4 building on RHEL8 again (if only we had a CI to do > this, oh...). I am also

Re: [PATCH] fix mod_h2 with older nghttp2

2023-10-16 Thread Ruediger Pluem
I will do. Regards Rüdiger On 10/16/23 1:13 PM, Stefan Eissing via dev wrote: > I added that patch to trunk and merged it into 2.4.x. > > I'll make another release candidate soonish. Someone wants to merge the back > ports idling in STATUS? > > Cheers, > Stefan > >> Am 16.10.2023 um 12:55 sc

Re: [VOTE] Release httpd-2.4.58-rc1 as httpd-2.4.58

2023-10-16 Thread Ruediger Pluem
First of all thanks for RM. It looks to me that we have 2 accepted backports in the STATUS that have not been merged. This seems unfortunate. Regards Rüdiger On 10/16/23 12:07 PM, Stefan Eissing via dev wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > ht

Re: svn commit: r1912459 - in /httpd/httpd/trunk: include/ modules/proxy/

2023-09-30 Thread Ruediger Pluem
On 9/21/23 3:15 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Sep 21 13:15:35 2023 > New Revision: 1912459 > > URL: http://svn.apache.org/viewvc?rev=1912459&view=rev > Log: > mod_proxy: Handle backend address renewal with address_ttl= parameter. > > Define a new proxy_address struc

Re: svn commit: r1912181 - /httpd/httpd/branches/2.4.x/STATUS

2023-09-08 Thread Ruediger Pluem
On 9/8/23 9:43 AM, ic...@apache.org wrote: > Author: icing > Date: Fri Sep 8 07:43:17 2023 > New Revision: 1912181 > > URL: http://svn.apache.org/viewvc?rev=1912181&view=rev > Log: > back port proposal > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches/2

Re: svn commit: r1911908 - /httpd/httpd/branches/2.4.x/STATUS

2023-08-25 Thread Ruediger Pluem
On 8/25/23 9:52 AM, jor...@apache.org wrote: > Author: jorton > Date: Fri Aug 25 07:52:31 2023 > New Revision: 1911908 > > URL: http://svn.apache.org/viewvc?rev=1911908&view=rev > Log: > Update and reset. > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches

Re: release?

2023-08-23 Thread Ruediger Pluem
On 8/17/23 1:42 PM, Stefan Eissing via dev wrote: > How are people feeling about another release? > > Since I have tons of bugfixes in 2.4.x and some pending features to port > back, I offer to RM this. > > We have 5 items in 2.4.x/STATUS which lack votes. Would be nice if people > could fi

Re: 2.4.x fails to compile

2023-08-22 Thread Ruediger Pluem
On 8/22/23 1:48 PM, Stefan Eissing via dev wrote: > I believe we can add that to the backport proposal without resetting the > votes. Add what to which backport proposal? Regards Rüdiger

2.4.x fails to compile

2023-08-22 Thread Ruediger Pluem
Currently 2.4.x fails to compile for me with the following error: In file included from h2_c1_io.c:24: h2_c1_io.c: In function ‘pass_output’: /usr/src/apache/httpd-2.4.x/include/http_log.h:495:14: warning: ‘rv’ may be used uninitialized in this function [-Wmaybe-uninitialized] ap_lo

Re: svn commit: r1911068 - /httpd/httpd/patches/2.4.x/alias-preserve-path.diff

2023-08-22 Thread Ruediger Pluem
On 7/17/23 5:52 PM, minf...@apache.org wrote: > Author: minfrin > Date: Mon Jul 17 15:52:33 2023 > New Revision: 1911068 > > URL: http://svn.apache.org/viewvc?rev=1911068&view=rev > Log: > Add patch proposal. > > Added: > httpd/httpd/patches/2.4.x/alias-preserve-path.diff > > Added: httpd

Re: new HTTPProtocolOption for C-L+chunked?

2023-08-16 Thread Ruediger Pluem
On 8/16/23 1:32 PM, Eric Covener wrote: >>> So a few questions: >>> >>> - Is it reasonable as a standalone additional HTTPProtocolOption to >>> decide the behavior? >>> - Thoughts on behavior change in 2.4.x? >>> - 400 as a status code? >>> >>> https://httpwg.org/specs/rfc9112.html#rfc.section.6

Re: new HTTPProtocolOption for C-L+chunked?

2023-08-16 Thread Ruediger Pluem
On 8/2/23 1:29 PM, Eric Covener wrote: > Hi, at $bigco I am seeing more and more scanners reporting HTTP > request smuggling but the byte stream is really just two pipelined > requests. They are costly to debunk. I guess I just miss the point, but how is the above related to the lower? > > S

Re: svn commit: r1909401 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-07-10 Thread Ruediger Pluem
On 7/5/23 2:31 PM, Yann Ylavic wrote: > On Fri, Jun 30, 2023 at 4:08 PM Yann Ylavic wrote: >> >> On Fri, Jun 30, 2023 at 2:35 PM Ruediger Pluem wrote: >>> >>> On 6/29/23 5:08 PM, Yann Ylavic wrote: >>>> On Tue, Apr 25, 2023 at 1:57 PM wrote: &g

Re: svn commit: r1910861 - /httpd/httpd/trunk/support/ab.c

2023-07-10 Thread Ruediger Pluem
On 7/10/23 10:11 AM, Joe Orton wrote: > On Fri, Jul 07, 2023 at 03:52:46PM -, yla...@apache.org wrote: >> Author: ylavic >> Date: Fri Jul 7 15:52:45 2023 >> New Revision: 1910861 >> >> URL: http://svn.apache.org/viewvc?rev=1910861&view=rev >> Log: >> ab: Fix accounting of started connection

Re: svn commit: r1910846 - /httpd/httpd/trunk/server/util_filter.c

2023-07-10 Thread Ruediger Pluem
On 7/7/23 1:00 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Jul 7 11:00:34 2023 > New Revision: 1910846 > > URL: http://svn.apache.org/viewvc?rev=1910846&view=rev > Log: > util_filter: More useful logging for brigade setaside/reinstate/adopt. > > > Modified: > httpd/httpd/tr

Re: svn commit: r1910704 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-07-03 Thread Ruediger Pluem
On 7/3/23 10:17 AM, Stefan Eissing via dev wrote: > > >> Am 30.06.2023 um 17:22 schrieb Stefan Eissing via dev : >> >> >> >>> Am 30.06.2023 um 16:45 schrieb Ruediger Pluem : >>> >>> >>> >>> On 6/30/23 4:15 PM, Stefan

Re: svn commit: r1910704 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-06-30 Thread Ruediger Pluem
On 6/30/23 4:15 PM, Stefan Eissing via dev wrote: > > >> Am 30.06.2023 um 15:56 schrieb Yann Ylavic : >> >> On Fri, Jun 30, 2023 at 2:44 PM Ruediger Pluem wrote: >>> >>> On 6/30/23 11:08 AM, ic...@apache.org wrote: >>>> Author: icing

Re: svn commit: r1910704 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-06-30 Thread Ruediger Pluem
On 6/30/23 11:08 AM, ic...@apache.org wrote: > Author: icing > Date: Fri Jun 30 09:08:23 2023 > New Revision: 1910704 > > URL: http://svn.apache.org/viewvc?rev=1910704&view=rev > Log: > proxy: in proxy tunnels, use the smaller timeout value of >client and origin as timeout for polling t

Re: svn commit: r1909401 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-06-30 Thread Ruediger Pluem
On 6/29/23 5:08 PM, Yann Ylavic wrote: > On Tue, Apr 25, 2023 at 1:57 PM wrote: >> >> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original) >> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Apr 25 11:57:22 2023 >> @@ -2790,7 +2790,11 @@ ap_proxy_determine_connection(apr_pool_t >>

Re: svn commit: r1910662 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2023-06-28 Thread Ruediger Pluem
On 6/28/23 3:55 PM, Eric Covener wrote: > On Wed, Jun 28, 2023 at 9:08 AM Ruediger Pluem wrote: >> >> >> >> On 6/28/23 2:37 PM, cove...@apache.org wrote: >>> Author: covener >>> Date: Wed Jun 28 12:37:50 2023 >>> New Revision: 1910662 >

Re: svn commit: r1910662 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2023-06-28 Thread Ruediger Pluem
On 6/28/23 2:37 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 28 12:37:50 2023 > New Revision: 1910662 > > URL: http://svn.apache.org/viewvc?rev=1910662&view=rev > Log: > back to original patch in PR66672 > > Since QSNONE will skip splitoutqueryargs, it's where we should fixu

Re: svn commit: r1910650 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2023-06-28 Thread Ruediger Pluem
On 6/28/23 12:38 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 28 10:38:27 2023 > New Revision: 1910650 > > URL: http://svn.apache.org/viewvc?rev=1910650&view=rev > Log: > act more like pre-r1908097 with rewrite > > - be more conservative with setting QSNONE > - allow the que

Re: svn commit: r1910327 - /httpd/httpd/branches/2.4.x/STATUS

2023-06-09 Thread Ruediger Pluem
On 6/9/23 6:28 PM, jean-frederic clere wrote: > On 6/9/23 14:58, rpl...@apache.org wrote: >> Author: rpluem >> Date: Fri Jun  9 12:58:55 2023 >> New Revision: 1910327 >> >> URL: http://svn.apache.org/viewvc?rev=1910327&view=rev >> Log: >> * Vote and comment [skip ci] >> >> Modified: >> http

Re: svn commit: r1909411 - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/aaa/

2023-06-09 Thread Ruediger Pluem
Any feedback on my comments below? Regards Rüdiger On 5/5/23 7:37 PM, Ruediger Pluem wrote: > > > On 4/25/23 7:52 PM, minf...@apache.org wrote: >> Author: minfrin >> Date: Tue Apr 25 17:52:18 2023 >> New Revision: 1909411 >> >> URL: http://svn.apache

Re: svn commit: r1909409 - in /httpd/httpd/trunk: CHANGES docs/manual/developer/new_api_2_6.xml include/ap_mmn.h include/http_request.h include/mod_auth.h server/request.c

2023-06-09 Thread Ruediger Pluem
On 5/5/23 12:28 PM, Ruediger Pluem wrote: > > > On 4/25/23 7:35 PM, minf...@apache.org wrote: >> Author: minfrin >> Date: Tue Apr 25 17:35:08 2023 >> New Revision: 1909409 >> >> URL: http://svn.apache.org/viewvc?rev=1909409&view=rev >> Log:

Re: svn commit: r1910267 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/filters/mod_ext_filter.c

2023-06-07 Thread Ruediger Pluem
On 6/7/23 1:56 PM, Yann Ylavic wrote: > Hi Giovanni; > > On Wed, Jun 7, 2023 at 12:02 AM wrote: >> >> Author: gbechis >> Date: Tue Jun 6 22:02:37 2023 >> New Revision: 1910267 >> >> URL: http://svn.apache.org/viewvc?rev=1910267&view=rev >> Log: >> mod_ext_filter: check exit status of filter p

Re: svn commit: r1910161 - in /httpd/httpd/trunk: changes-entries/ include/ modules/http/ test/modules/http2/

2023-06-01 Thread Ruediger Pluem
On 6/1/23 3:30 PM, Stefan Eissing via dev wrote: >>> Modified: httpd/httpd/trunk/modules/http/http_request.c >>> URL: >>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=1910161&r1=1910160&r2=1910161&view=diff >>> =

Re: svn commit: r1910161 - in /httpd/httpd/trunk: changes-entries/ include/ modules/http/ test/modules/http2/

2023-06-01 Thread Ruediger Pluem
On 6/1/23 2:21 PM, ic...@apache.org wrote: > Author: icing > Date: Thu Jun 1 12:21:03 2023 > New Revision: 1910161 > > URL: http://svn.apache.org/viewvc?rev=1910161&view=rev > Log: > *) core: add `final_resp_passed` flag to request_rec to allow > ap_die() to judge if it can send out a r

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-18 Thread Ruediger Pluem
On 5/18/23 1:55 PM, Eric Covener wrote: > On Thu, May 18, 2023 at 6:40 AM Ruediger Pluem wrote: >> >> >> >> On 5/18/23 3:17 AM, Eric Covener wrote: >>> bump? Just was reminded by a thread on reddit (config unclear but >>> probably not non-cfgi

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-18 Thread Ruediger Pluem
the fix, can we let spaces > through mod_rewrite? Any reason why we should not encode the spaces as proposed below? > > On Tue, May 9, 2023 at 6:18 PM Eric Covener wrote: >> >> On Tue, May 9, 2023 at 3:14 PM Ruediger Pluem wrote: >>> >>> >>> >&

Re: Apache2 chroot problem: towards a solution

2023-05-18 Thread Ruediger Pluem
On 5/18/23 6:45 AM, Benjamin Godfrey wrote: > Hi, I'm working on the problem of Apache2 ignoring requests to any command in > the chroot environment.  I have seen complaints > about this posted on a couple of websites, and I have not seen any solution.  >  I seem to have narrowed the problem d

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2023-05-11 Thread Ruediger Pluem
On 5/11/23 5:40 PM, Daniel Gruno wrote: > On 2023-05-11 10:33, Ruediger Pluem wrote: >> >> >> On 5/11/23 12:27 PM, Ruediger Pluem wrote: >>> >>> >>> On 5/4/23 10:34 AM, Ruediger Pluem wrote: >>>> This is a formal vote on whether we sh

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2023-05-11 Thread Ruediger Pluem
On 5/11/23 12:27 PM, Ruediger Pluem wrote: > > > On 5/4/23 10:34 AM, Ruediger Pluem wrote: >> This is a formal vote on whether we should move our read/write repository >> from Subversion to Git. >> This means that our latest read/write repository will be

[VOTE CLOSED] Switch read/write repository from Subversion to Git

2023-05-11 Thread Ruediger Pluem
On 5/4/23 10:34 AM, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-09 Thread Ruediger Pluem
On 5/9/23 8:01 PM, Eric Covener wrote: > On Tue, May 9, 2023 at 11:51 AM Ruediger Pluem wrote: >> >> >> >> On 5/9/23 4:33 PM, Yann Ylavic wrote: >>> On Tue, May 9, 2023 at 2:10 PM Yann Ylavic wrote: >>>> >>>> On Tue, May 9, 2023 at

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-09 Thread Ruediger Pluem
On 5/9/23 4:33 PM, Yann Ylavic wrote: > On Tue, May 9, 2023 at 2:10 PM Yann Ylavic wrote: >> >> On Tue, May 9, 2023 at 12:55 PM Ruediger Pluem wrote: >>> >>> On 5/9/23 12:16 PM, Eric Covener wrote: >>>> Still getting feedback in the PR about break

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-09 Thread Ruediger Pluem
On 5/9/23 12:16 PM, Eric Covener wrote: > Still getting feedback in the PR about breakage. Any thoughts on options > here, like allowing spaces or encoding rather than failing? Allowing spaces is out of question for me as it creates an invalid request and opens the door to response splitting.

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-09 Thread Ruediger Pluem
On 5/8/23 9:16 AM, Greg Stein wrote: > I might suggest another day or two because of the weekend and because it is > so high-impact. Maybe an extra post to private@ in > case some PMC members aren't tracking dev@ very closely. > > I intend to close this vote in about 48 hours. It has been op

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-08 Thread Ruediger Pluem
On 5/9/23 12:00 AM, Daniel Gruno wrote: > > VHS vs BetaMax anyone? :) Video 2000 (https://en.wikipedia.org/wiki/Video_2000) rules :-) Regards Rüdiger

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-07 Thread Ruediger Pluem
On 5/4/23 10:34 AM, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via

Re: svn commit: r1909411 - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/aaa/

2023-05-05 Thread Ruediger Pluem
On 4/25/23 7:52 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Apr 25 17:52:18 2023 > New Revision: 1909411 > > URL: http://svn.apache.org/viewvc?rev=1909411&view=rev > Log: > *) mod_autht_jwt: New module to handle RFC 7519 JWT tokens within > bearer tokens, both as part of

Re: svn commit: r1909409 - in /httpd/httpd/trunk: CHANGES docs/manual/developer/new_api_2_6.xml include/ap_mmn.h include/http_request.h include/mod_auth.h server/request.c

2023-05-05 Thread Ruediger Pluem
On 4/25/23 7:35 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Apr 25 17:35:08 2023 > New Revision: 1909409 > > URL: http://svn.apache.org/viewvc?rev=1909409&view=rev > Log: > core: Add the token_checker hook, that allows authentication to take > place using mechanisms other than u

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-04 Thread Ruediger Pluem
On 5/4/23 10:34 AM, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread Ruediger Pluem
On 5/5/23 2:37 AM, Greg Stein wrote: > Down-thread, Giovanni asks about security patch handling. We can continue to > use repos/private/pmc/httpd/ for that. That area will > not go away. If people want to go "all git", then Infra can provide projects > with a single, private repository that w

[VOTE] Switch read/write repository from Subversion to Git

2023-05-04 Thread Ruediger Pluem
This is a formal vote on whether we should move our read/write repository from Subversion to Git. This means that our latest read/write repository will be no longer available via svn.apache.org. It will be available via Git at https://gitbox.apache.org/repos/asf/httpd-site.git and https://github

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-24 Thread Ruediger Pluem
On 4/12/23 2:02 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 1:31 PM Eric Covener wrote: >> >> On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: >>> >>> On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > @ylavic appro

Re: build trunk in windows

2023-04-24 Thread Ruediger Pluem
I am not a Windows guy, but I guess the best way to build trunk on Windows is to use cmake which is integrated in later versions of Visual studio. Regards Rüdiger On 4/24/23 1:05 PM, jean-frederic clere wrote: > Hi, > > I am trying to build httpd on windoze... > > "The .dsp project files are

Re: svn commit: r1909137 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_alias.c

2023-04-18 Thread Ruediger Pluem
On 4/17/23 1:07 PM, Yann Ylavic wrote: > On Mon, Apr 17, 2023 at 9:08 AM Ruediger Pluem wrote: >> >> On 4/16/23 12:20 PM, Graham Leggett via dev wrote: >>> On 14 Apr 2023, at 17:18, Ruediger Pluem >> <mailto:rpl...@apache.org>> wrote:

Re: svn commit: r1909137 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_alias.c

2023-04-17 Thread Ruediger Pluem
On 4/16/23 12:20 PM, Graham Leggett via dev wrote: > On 14 Apr 2023, at 17:18, Ruediger Pluem <mailto:rpl...@apache.org>> wrote: > >> Would that break configs like >> >> >> >> Alias /filesystemprefix/%{HTTP:X-example-header} >> >&

Re: svn commit: r1909137 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_alias.c

2023-04-14 Thread Ruediger Pluem
On 4/14/23 4:07 PM, minf...@apache.org wrote: > Author: minfrin > Date: Fri Apr 14 14:07:49 2023 > New Revision: 1909137 > > URL: http://svn.apache.org/viewvc?rev=1909137&view=rev > Log: > mod_alias: When an alias is declared inside a Location, make sure > the balance of the URL is preserved to

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Ruediger Pluem
On 4/12/23 12:35 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: >> >> On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: >>> >>> @ylavic approved this pull request. >>> >>> Three approvals to get ci started? >> >> Nope.. It seems that gh actions don't run for PRs what

Re: svn commit: r1909073 - in /httpd/httpd/trunk/docs/manual: mod/mod_rewrite.xml rewrite/flags.xml

2023-04-11 Thread Ruediger Pluem
On 4/11/23 11:36 PM, cove...@apache.org wrote: > Author: covener > Date: Tue Apr 11 21:36:55 2023 > New Revision: 1909073 > > URL: http://svn.apache.org/viewvc?rev=1909073&view=rev > Log: > PR66563: escaping of url releated server vars > > Modified: > httpd/httpd/trunk/docs/manual/mod/mod_

Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57

2023-04-10 Thread Ruediger Pluem
On 4/10/23 11:37 PM, BUSH Steve wrote: > I just downloaded the apache 2.4.57 source code and attempting to compile on > Windows, mod_rewrite.c fails with this error: > > > I fixed it for my local build by editing modules/mapper/mod_rewrite.mak and > updating the CPP_PROJ= lines to include t

Re: svn commit: r1908972 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2023-04-04 Thread Ruediger Pluem
On 4/4/23 11:43 PM, gbec...@apache.org wrote: > Author: gbechis > Date: Tue Apr 4 21:43:46 2023 > New Revision: 1908972 > > URL: http://svn.apache.org/viewvc?rev=1908972&view=rev > Log: > Fix a possible NULL pointer dereference of ap_runtime_dir_relative() > > ap_runtime_dir_relative() will r

Re: svn commit: r1908971 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/ssl/ssl_engine_kernel.c

2023-04-04 Thread Ruediger Pluem

Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57

2023-04-03 Thread Ruediger Pluem
Rüdiger >   > On Monday 03/04/2023 at 11:26, Ruediger Pluem wrote: >> How do you build it? Via cmake or via the mak files? >> >> Regards >> >> Rüdiger >> >> On 4/3/23 10:51 AM, SteffenAL wrote: >>> Build no go: >>> >>> >>>

Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57

2023-04-03 Thread Ruediger Pluem
How do you build it? Via cmake or via the mak files? Regards Rüdiger On 4/3/23 10:51 AM, SteffenAL wrote: > Build no go: > > > ErrorC1083Cannot open include file: 'test_char.h': No such file or > directorymod_rewriteC:\VS17\Win64\httpd-2.4\modules\mappers\mod_rewrite.c109 > > Is it ok that I

Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57

2023-04-03 Thread Ruediger Pluem
On 4/2/23 6:10 PM, Eric Covener wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: > [X] +1

Re: svn commit: r1908805 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2023-04-03 Thread Ruediger Pluem
On 4/3/23 8:45 AM, Ruediger Pluem wrote: > > > On 4/3/23 8:37 AM, giova...@paclan.it wrote: >> On 3/30/23 19:28, Ruediger Pluem wrote: >>> >>> >>> On 3/30/23 7:19 PM, Ruediger Pluem wrote: >>>> >>>> >>>> On 3/30/23 7:0

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Ruediger Pluem
On 3/31/23 10:25 AM, Yann Ylavic wrote: > On Fri, Mar 31, 2023 at 10:15 AM Ruediger Pluem wrote: >> >> On 3/31/23 9:56 AM, Yann Ylavic wrote: >>> On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: >>>> >>>> On 3/31/23 2:11 AM, yla...@apache

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-31 Thread Ruediger Pluem
On 3/31/23 9:56 AM, Yann Ylavic wrote: > On Fri, Mar 31, 2023 at 8:28 AM Ruediger Pluem wrote: >> >> On 3/31/23 2:11 AM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Fri Mar 31 00:11:02 2023 >>> New Revision: 1908827 >>> >>

Re: svn commit: r1908835 - /httpd/httpd/trunk/.github/workflows/linux.yml

2023-03-31 Thread Ruediger Pluem
On 3/31/23 10:04 AM, Joe Orton wrote: > On Fri, Mar 31, 2023 at 09:47:05AM +0200, Yann Ylavic wrote: >> On Fri, Mar 31, 2023 at 9:22 AM wrote: >>> >>> Author: jorton >>> Date: Fri Mar 31 07:21:37 2023 >>> New Revision: 1908835 >>> >>> URL: http://svn.apache.org/viewvc?rev=1908835&view=rev >>> L

Re: I plan to RM some time this weekend

2023-03-30 Thread Ruediger Pluem
On 3/30/23 11:29 PM, Eric Covener wrote: > Primarily to pick up PR66547 and the rewrite improvements, but I also > seen an h2 crash addressed. > Great. Can you please have a look at the two proposals from Yann and me in STATUS that just lack one vote? I would like to see them in this release

Re: svn commit: r1908827 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_uwsgi.c

2023-03-30 Thread Ruediger Pluem
On 3/31/23 2:11 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Mar 31 00:11:02 2023 > New Revision: 1908827 > > URL: http://svn.apache.org/viewvc?rev=1908827&view=rev > Log: > mod_proxy: Check for space/ctrls in nocanon path/urls before forwarding. Can this really happen? Wouldn't t

Re: svn commit: r1908805 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2023-03-30 Thread Ruediger Pluem
On 3/30/23 7:19 PM, Ruediger Pluem wrote: > > > On 3/30/23 7:09 PM, gbec...@apache.org wrote: >> Author: gbechis >> Date: Thu Mar 30 17:09:09 2023 >> New Revision: 1908805 >> >> URL: http://svn.apache.org/viewvc?rev=1908805&view=rev >> Log: >

Re: svn commit: r1908805 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2023-03-30 Thread Ruediger Pluem
On 3/30/23 7:09 PM, gbec...@apache.org wrote: > Author: gbechis > Date: Thu Mar 30 17:09:09 2023 > New Revision: 1908805 > > URL: http://svn.apache.org/viewvc?rev=1908805&view=rev > Log: > check for more possible SSL failures > bz #66225 > > Modified: > httpd/httpd/trunk/modules/ssl/ssl_en

Re: svn commit: r1908380 - in /httpd/httpd/trunk: changes-entries/errorlogformat.txt include/util_time.h server/log.c server/util_time.c

2023-03-17 Thread Ruediger Pluem
On 3/14/23 12:11 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Mar 14 11:11:24 2023 > New Revision: 1908380 > > URL: http://svn.apache.org/viewvc?rev=1908380&view=rev > Log: > core: Add formats %{z} and %{strftime-format} to ErrorLogFormat. PR 62161. > > %{z} prints the timezone o

Re: svn commit: r1908380 - in /httpd/httpd/trunk: changes-entries/errorlogformat.txt include/util_time.h server/log.c server/util_time.c

2023-03-17 Thread Ruediger Pluem
On 3/14/23 4:56 PM, Yann Ylavic wrote: > On Tue, Mar 14, 2023 at 1:30 PM Ruediger Pluem wrote: >> >> On 3/14/23 12:11 PM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Tue Mar 14 11:11:24 2023 >>> New Revision: 1908380 >>> >>

Re: svn commit: r1908388 - in /httpd/httpd/trunk/server: core.c log.c

2023-03-14 Thread Ruediger Pluem
On 3/14/23 3:37 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Mar 14 14:37:00 2023 > New Revision: 1908388 > > URL: http://svn.apache.org/viewvc?rev=1908388&view=rev > Log: > core: Use the main ErrorLogFormat for ap_log_perror() and while loading > vhosts. > > * server/core.c(crea

Re: svn commit: r1908380 - in /httpd/httpd/trunk: changes-entries/errorlogformat.txt include/util_time.h server/log.c server/util_time.c

2023-03-14 Thread Ruediger Pluem
On 3/14/23 12:11 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Mar 14 11:11:24 2023 > New Revision: 1908380 > > URL: http://svn.apache.org/viewvc?rev=1908380&view=rev > Log: > core: Add formats %{z} and %{strftime-format} to ErrorLogFormat. PR 62161. > > %{z} prints the timezone o

Re: svn commit: r1908358 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

2023-03-14 Thread Ruediger Pluem
On 3/14/23 10:32 AM, Yann Ylavic wrote: > On Tue, Mar 14, 2023 at 10:14 AM Ruediger Pluem wrote: >> >> On 3/14/23 10:06 AM, Yann Ylavic wrote: >>> On Tue, Mar 14, 2023 at 9:21 AM Ruediger Pluem wrote: >>>> >>>> >>>> On 3/13/23 10:17

Re: svn commit: r1908358 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

2023-03-14 Thread Ruediger Pluem
On 3/14/23 10:06 AM, Yann Ylavic wrote: > On Tue, Mar 14, 2023 at 9:21 AM Ruediger Pluem wrote: >> >> >> On 3/13/23 10:17 PM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Mon Mar 13 21:17:08 2023 >>> New Revision: 1908358 >>> &

Re: svn commit: r1908358 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

2023-03-14 Thread Ruediger Pluem
On 3/13/23 10:17 PM, yla...@apache.org wrote: > Author: ylavic > Date: Mon Mar 13 21:17:08 2023 > New Revision: 1908358 > > URL: http://svn.apache.org/viewvc?rev=1908358&view=rev > Log: > BNEG replaced by BNE= in mod_rewrite. > > Modified: > httpd/test/framework/trunk/t/conf/extra.conf.in >

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

2023-03-13 Thread Ruediger Pluem
On 3/13/23 4:04 PM, Eric Covener wrote: > On Mon, Mar 13, 2023 at 10:59 AM Ruediger Pluem wrote: >> >> >> >> On 3/13/23 3:23 PM, Eric Covener wrote: >>> Yann, can you check out the failure I committed and see if it's me or >>> unintended? Ever

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

2023-03-13 Thread Ruediger Pluem
On 3/13/23 3:23 PM, Eric Covener wrote: > Yann, can you check out the failure I committed and see if it's me or > unintended? Everything else went pretty smooth and looks useful in a > bind. > > # Check /modules/rewrite/escaping/local_bctls_nospace/foo/bar/%20baz/%0d > for foo/bar/ baz%0d > #

Re: svn commit: r1908301 - in /httpd/httpd/trunk: changes-entries/rewrite-bctls docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

2023-03-13 Thread Ruediger Pluem
On 3/13/23 2:57 PM, Yann Ylavic wrote: > On Mon, Mar 13, 2023 at 2:32 PM Eric Covener wrote: >> >> On Mon, Mar 13, 2023 at 8:31 AM Yann Ylavic wrote: >>> >>> Maybe we could make [B=] and [BTCLS] not mutually exclusive (encode >>> both controls and whatever in B=). >>> I was thinking of a [BNEG

Re: svn commit: r1908300 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

2023-03-13 Thread Ruediger Pluem
On 3/11/23 10:31 PM, cove...@apache.org wrote: > Author: covener > Date: Sat Mar 11 21:31:14 2023 > New Revision: 1908300 > > URL: http://svn.apache.org/viewvc?rev=1908300&view=rev > Log: > test [P] flag > > Modified: > httpd/test/framework/trunk/t/conf/extra.conf.in > httpd/test/frame

Re: Current pytest failures

2023-03-09 Thread Ruediger Pluem
On 3/8/23 10:44 PM, Rainer Jung wrote: > Hi there, > > I currently get three consistent pytest failures: Do A) and B) work if you do the requests via HTTP/1.1? Regards Rüdiger

Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy

2023-03-08 Thread Ruediger Pluem
On 3/2/23 3:30 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Mar 2 14:30:20 2023 > New Revision: 1907972 > > URL: http://svn.apache.org/viewvc?rev=1907972&view=rev > Log: > mod_proxy: Don't decode r->uri and reencode in r->filename for > mapping=encoded. > > Decoding was not done

Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/

2023-03-07 Thread Ruediger Pluem
On 3/7/23 11:04 AM, Joe Orton wrote: > On Tue, Mar 07, 2023 at 09:15:59AM +0100, Stefan Eissing via dev wrote: >> >> >>> Am 06.03.2023 um 17:53 schrieb Joe Orton : >>> >>> [resent to dev@] >>> >>> On Sat, Mar 04, 2023 at 01:40:39PM -, ic...@apache.org wrote: Author: icing Date: Sat

Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/

2023-03-07 Thread Ruediger Pluem
On 3/7/23 9:15 AM, Stefan Eissing via dev wrote: > > >> Am 06.03.2023 um 17:53 schrieb Joe Orton : >> >> [resent to dev@] >> >> On Sat, Mar 04, 2023 at 01:40:39PM -, ic...@apache.org wrote: >>> Author: icing >>> Date: Sat Mar 4 13:40:38 2023 >>> New Revision: 1908060 >>> >>> URL: http://s

Re: [VOTE] [VOTE] Release httpd-2.4.56-rc1 as httpd-2.4.56

2023-03-07 Thread Ruediger Pluem
On 3/5/23 10:31 PM, Eric Covener wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.56-rc1 as 2.4.56: > [X] +

Re: svn commit: r1908132 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_engine_vars.c

2023-03-06 Thread Ruediger Pluem
On 3/6/23 6:46 PM, di...@apache.org wrote: > Author: dirkx > Date: Mon Mar 6 17:46:04 2023 > New Revision: 1908132 > > URL: http://svn.apache.org/viewvc?rev=1908132&view=rev > Log: > Add SSL_SHARED_CIPHER environment variable > > Modified: > httpd/httpd/trunk/CHANGES > httpd/httpd/tru

Re: expose SSL_SHARED_CIPHERs from SSL/TLS

2023-03-06 Thread Ruediger Pluem
On 3/6/23 12:35 PM, Dirk-Willem van Gulik wrote: > I was cleaning up some of our private code - and came across the patch below > - exposing the SHARED_CHIPHERs. > > We scratch this itch in a few places to help force (or prevent) the forcing > of a protocol upgrade from application land. > >

Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c

2023-03-06 Thread Ruediger Pluem
On 3/6/23 10:24 AM, jor...@apache.org wrote: > Author: jorton > Date: Mon Mar 6 09:24:44 2023 > New Revision: 1908116 > > URL: http://svn.apache.org/viewvc?rev=1908116&view=rev > Log: > * modules/http2/mod_proxy_http2.c: Fix missing APLOGNO. > > Modified: > httpd/httpd/trunk/docs/log-mess

Re: svn commit: r1907984 - /httpd/httpd/trunk/modules/dav/fs/quota.c

2023-03-06 Thread Ruediger Pluem
On 3/2/23 4:46 PM, m...@apache.org wrote: > Author: manu > Date: Thu Mar 2 15:46:12 2023 > New Revision: 1907984 > > URL: http://svn.apache.org/viewvc?rev=1907984&view=rev > Log: > Add RFC4331 quotas for mod_dav_fs > > Address forgotten svn add in previous commit > > Added: > httpd/httpd

Re: svn commit: r1907980 - in /httpd/httpd/trunk: changes-entries/proxy_uwsgi_response_validation.txt modules/proxy/mod_proxy_uwsgi.c

2023-03-02 Thread Ruediger Pluem
On 3/2/23 7:21 PM, Christophe JAILLET wrote: > Le 02/03/2023 à 16:10, yla...@apache.org a écrit : >> Author: ylavic >> Date: Thu Mar  2 15:10:30 2023 >> New Revision: 1907980 >> >> URL: http://svn.apache.org/viewvc?rev=1907980&view=rev >> Log: >> mod_proxy_uwsgi: Stricter backend HTTP response p

Re: [VOTE] broader RTC exception for 2.4.x CI changes

2023-02-15 Thread Ruediger Pluem
On 2/15/23 2:48 PM, Joe Orton wrote: > Per my previous Travis is dead, long live GitHub actions. > > I propose to broaden the RTC exception in 2.4.x/STATUS to allow CI > config changes and scripts to be merged from trunk: > > Index: STATUS > ===

Re: CI status update: Travis out, GitHub Actions in

2023-02-15 Thread Ruediger Pluem
On 2/15/23 11:43 AM, Joe Orton wrote: > Support for Travis has now been dropped, so we are relying only on > GitHub Actions for CI from today. > > There are some gaps in the GHA configuration compared to what we had > running in Travis: notably, we're currently only testing on the latest > U

Re: svn commit: r1907608 - in /httpd/httpd/trunk: CMakeLists.txt modules/dav/main/NWGNUmakefile modules/dav/main/config5.m4 modules/dav/main/mod_dav.c modules/dav/main/mod_dav.dsp modules/dav/main/mod

2023-02-14 Thread Ruediger Pluem
On 2/13/23 5:48 PM, m...@apache.org wrote: > Author: manu > Date: Mon Feb 13 16:48:35 2023 > New Revision: 1907608 > > URL: http://svn.apache.org/viewvc?rev=1907608&view=rev > Log: > Add MS-WDV support > > MS-WDV specification: > https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms

Re: svn commit: r1907608 - in /httpd/httpd/trunk: CMakeLists.txt modules/dav/main/NWGNUmakefile modules/dav/main/config5.m4 modules/dav/main/mod_dav.c modules/dav/main/mod_dav.dsp modules/dav/main/mod

2023-02-14 Thread Ruediger Pluem
On 2/13/23 5:48 PM, m...@apache.org wrote: > Author: manu > Date: Mon Feb 13 16:48:35 2023 > New Revision: 1907608 > > URL: http://svn.apache.org/viewvc?rev=1907608&view=rev > Log: > Add MS-WDV support > > MS-WDV specification: > https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms

Re: MS-WDV and other MS extensions

2023-02-10 Thread Ruediger Pluem
On 2/10/23 4:22 PM, Emmanuel Dreyfus wrote: > On Fri, Feb 10, 2023 at 04:15:16PM +0100, Ruediger Pluem wrote: >>> Do you suggests adding values to Options, or to create a DAVoptions >>> directive? >> >> I think DAVMSextis fine, but with an Options lik

Re: MS-WDV and other MS extensions

2023-02-10 Thread Ruediger Pluem
On 2/10/23 4:06 PM, Emmanuel Dreyfus wrote: > On Fri, Feb 10, 2023 at 09:53:47AM -0500, Eric Covener wrote: >> I like the third case with an all/on option. If it will need to be >> per-directory, maybe an Options like syntax would make sense? > > Do you suggests adding values to Options, or to

Re: MS-WDV and other MS extensions

2023-02-10 Thread Ruediger Pluem
On 2/10/23 3:53 PM, Eric Covener wrote: > On Fri, Feb 10, 2023 at 9:17 AM Emmanuel Dreyfus wrote: >> >> Hello >> >> I am ready to commit MS-WDV support for mod_dav. There are many other >> MS extensions, and I just wonder if we should prepare to configure MS >> extensions one by one or as a wh

Re: sporadic 500 errors with 2.4.55

2023-01-18 Thread Ruediger Pluem
On 1/18/23 10:05 AM, Andreas S. Kerber wrote: > Am Wed, Jan 18, 2023 at 03:15:43AM -0500 schrieb Helmut K. C. Tessarek: >>> 2. As you see the 500 errors only in the access log are they only for >>> HTTP/2.0 or also for other protocol versions? > > I can confirm this too. I have a bunch of h2 s

Re: sporadic 500 errors with 2.4.55

2023-01-17 Thread Ruediger Pluem
On 1/18/23 7:01 AM, Helmut K. C. Tessarek wrote: > Additional info: > > I reverted back to 2.4.54 and the errors are gone. It also seems that the > responses are snappier. The perf observation is > subjective of course. > > Without any proof I suspect that there is some sort of contention/loc

<    1   2   3   4   5   6   7   8   9   10   >