Re: svn commit: r1908835 - /httpd/httpd/trunk/.github/workflows/linux.yml

On Fri, Mar 31, 2023 at 9:22 AM wrote: > > Author: jorton > Date: Fri Mar 31 07:21:37 2023 > New Revision: 1908835 > > URL: http://svn.apache.org/viewvc?rev=1908835=rev > Log: > Try running CI for 2.* tags. [skip ci] It seems that gh actions are not triggered anymore for trunk and 2.4.x, but I

Re: Shared memory - data between threads

Hello; On Thu, Mar 23, 2023 at 11:48 AM Bob Weeks wrote: > > I created a little test module to just increment a value in this code > block each time I called the page and printout the next time it passed. > > ap_log_error(APLOG_MARK, APLOG_INFO,0,r->server,"Config = >

Re: svn commit: r1908380 - in /httpd/httpd/trunk: changes-entries/errorlogformat.txt include/util_time.h server/log.c server/util_time.c

On Fri, Mar 17, 2023 at 9:37 AM Ruediger Pluem wrote: > > On 3/14/23 12:11 PM, yla...@apache.org wrote: > > > > +++ httpd/httpd/trunk/include/util_time.h Tue Mar 14 11:11:24 2023 > > @@ -47,6 +47,8 @@ extern "C" { > > #define AP_CTIME_OPTION_USEC0x1 > > /* Use more compact ISO 8601 format

Re: svn commit: r1908380 - in /httpd/httpd/trunk: changes-entries/errorlogformat.txt include/util_time.h server/log.c server/util_time.c

On Fri, Mar 17, 2023 at 9:36 AM Ruediger Pluem wrote: > > I guess the > > #include "apr_strings.h" > > added in r1908380 is no longer needed as well? Yep, removed in r1908556. Regards; Yann.

Re: mod_watchdog.c looping for mutex?

On Sun, Mar 19, 2023 at 9:53 AM jean-frederic clere wrote: > > Hi, > > While debugging I noted something in mod_watchdog.c > https://github.com/apache/httpd/blob/trunk/modules/core/mod_watchdog.c#L115 > > Shouldn't we have a else { } with a apr_sleep()? > Basically the thread is looping there :-(

Re: svn commit: r1908359 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

On Wed, Mar 15, 2023 at 9:41 PM Eric Covener wrote: > > This is looking very useful compared to B/B= and int:escape, anything > outstanding? I'd like to backport it. Nothing on my side, +1 Regards; Yann.

Re: svn commit: r1908380 - in /httpd/httpd/trunk: changes-entries/errorlogformat.txt include/util_time.h server/log.c server/util_time.c

On Tue, Mar 14, 2023 at 1:30 PM Ruediger Pluem wrote: > > On 3/14/23 12:11 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Tue Mar 14 11:11:24 2023 > > New Revision: 1908380 > > > > URL: http://svn.apache.org/viewvc?rev=1908380=rev > > Log: > > core: Add formats %{z} and

Re: svn commit: r1908388 - in /httpd/httpd/trunk/server: core.c log.c

On Tue, Mar 14, 2023 at 4:06 PM Ruediger Pluem wrote: > > On 3/14/23 3:37 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Tue Mar 14 14:37:00 2023 > > New Revision: 1908388 > > > > URL: http://svn.apache.org/viewvc?rev=1908388=rev > > Log: > > core: Use the main ErrorLogFormat for

Re: svn commit: r1908358 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Tue, Mar 14, 2023 at 10:14 AM Ruediger Pluem wrote: > > On 3/14/23 10:06 AM, Yann Ylavic wrote: > > On Tue, Mar 14, 2023 at 9:21 AM Ruediger Pluem wrote: > >> > >> > >> On 3/13/23 10:17 PM, yla...@apache.org wrote: > >>> Author: ylavic >

Re: svn commit: r1908358 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Tue, Mar 14, 2023 at 9:21 AM Ruediger Pluem wrote: > > > On 3/13/23 10:17 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Mon Mar 13 21:17:08 2023 > > New Revision: 1908358 > > > > URL: http://svn.apache.org/viewvc?rev=1908358=rev > > Log: > > BNEG replaced by BNE= in mod_rewrite. >

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Mon, Mar 13, 2023 at 8:02 PM Eric Covener wrote: > > On Mon, Mar 13, 2023 at 2:01 PM Yann Ylavic wrote: > > > > On Mon, Mar 13, 2023 at 5:48 PM Yann Ylavic wrote: > > > > > > On Mon, Mar 13, 2023 at 5:42 PM Eric Covener wrote: > > > > >

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Mon, Mar 13, 2023 at 5:48 PM Yann Ylavic wrote: > > On Mon, Mar 13, 2023 at 5:42 PM Eric Covener wrote: > > > > On Mon, Mar 13, 2023 at 12:31 PM Yann Ylavic wrote: > > > > > > On Mon, Mar 13, 2023 at 5:25 PM Eric Covener wrote: > > > > >

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Mon, Mar 13, 2023 at 5:42 PM Eric Covener wrote: > > On Mon, Mar 13, 2023 at 12:31 PM Yann Ylavic wrote: > > > > On Mon, Mar 13, 2023 at 5:25 PM Eric Covener wrote: > > > > > > On Mon, Mar 13, 2023 at 12:05 PM Yann Ylavic wrote: > &

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Mon, Mar 13, 2023 at 5:25 PM Eric Covener wrote: > > On Mon, Mar 13, 2023 at 12:05 PM Yann Ylavic wrote: > > > > I could get where you want to with the attached patch (before you > > disabled the test in r1908350). > > It makes so that anything BNEG'ed overri

Re: svn commit: r1908349 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/rewrite.t

On Mon, Mar 13, 2023 at 4:13 PM Ruediger Pluem wrote: > > On 3/13/23 4:04 PM, Eric Covener wrote: > > On Mon, Mar 13, 2023 at 10:59 AM Ruediger Pluem wrote: > >> > >> > >> > >> On 3/13/23 3:23 PM, Eric Covener wrote: > >>> Yann, can you check out the failure I committed and see if it's me or >

Re: svn commit: r1908301 - in /httpd/httpd/trunk: changes-entries/rewrite-bctls docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

On Mon, Mar 13, 2023 at 2:57 PM Yann Ylavic wrote: > > On Mon, Mar 13, 2023 at 2:32 PM Eric Covener wrote: > > > > On Mon, Mar 13, 2023 at 8:31 AM Yann Ylavic wrote: > > > > > > Maybe we could make [B=] and [BTCLS] not mutually exclusive (encode > > &g

Re: svn commit: r1908301 - in /httpd/httpd/trunk: changes-entries/rewrite-bctls docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

On Mon, Mar 13, 2023 at 2:32 PM Eric Covener wrote: > > On Mon, Mar 13, 2023 at 8:31 AM Yann Ylavic wrote: > > > > Maybe we could make [B=] and [BTCLS] not mutually exclusive (encode > > both controls and whatever in B=). > > I was thinking of a [BNEG] flag too

Re: svn commit: r1908301 - in /httpd/httpd/trunk: changes-entries/rewrite-bctls docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

On Sat, Mar 11, 2023 at 11:10 PM wrote: > > Author: covener > Date: Sat Mar 11 22:10:09 2023 > New Revision: 1908301 > > URL: http://svn.apache.org/viewvc?rev=1908301=rev > Log: > add [BCTLS] alternative to [B] for 2.4.56 problems Nice, that was the missing bit I think. Would have been great if

Re: [VOTE] [VOTE] Release httpd-2.4.56-rc1 as httpd-2.4.56

On Fri, Mar 10, 2023 at 4:34 PM Eric Covener wrote: > > Saw another report on users@ > > Any thoughts on something like this to just allow spaces? > http://people.apache.org/~covener/patches/rewrite-lax.diff What about: Index: modules/mappers/mod_rewrite.c

Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy

On Wed, Mar 8, 2023 at 1:24 PM Ruediger Pluem wrote: > > On 3/2/23 3:30 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Thu Mar 2 14:30:20 2023 > > New Revision: 1907972 > > > > URL: http://svn.apache.org/viewvc?rev=1907972=rev > > Log: > > mod_proxy: Don't decode r->uri and reencode

Re: [VOTE] [VOTE] Release httpd-2.4.56-rc1 as httpd-2.4.56

On Sun, Mar 5, 2023 at 10:31 PM Eric Covener wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.56-rc1 as 2.4.56: +1: It's not just good, it's good enough! All checksums/sigs and tests pass (Debian 11 & 12), thanks Eric for RMing.

Re: svn commit: r1908116 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/http2/mod_proxy_http2.c

On Mon, Mar 6, 2023 at 10:28 AM Ruediger Pluem wrote: > > Thanks. Should we roll a new rc with this being backported and included? I don't think so, the ci failure is caused by an explicit script/check but the build works fine while runtime will only log an empty "AH" number, not a show stopper

Re: svn commit: r1907980 - in /httpd/httpd/trunk: changes-entries/proxy_uwsgi_response_validation.txt modules/proxy/mod_proxy_uwsgi.c

On Thu, Mar 2, 2023 at 8:22 PM Ruediger Pluem wrote: > > On 3/2/23 7:21 PM, Christophe JAILLET wrote: > > Le 02/03/2023 à 16:10, yla...@apache.org a écrit : > >> @@ -313,18 +313,16 @@ static int uwsgi_response(request_rec *r > >> pass_bb = apr_brigade_create(r->pool, c->bucket_alloc); > >>

Re: svn commit: r1907989 - /httpd/httpd/trunk/modules/dav/fs/quota.c

On Thu, Mar 2, 2023 at 5:09 PM wrote: > > Author: manu > Date: Thu Mar 2 16:09:50 2023 > New Revision: 1907989 > > URL: http://svn.apache.org/viewvc?rev=1907989=rev > Log: > Add RFC4331 quotas for mod_dav_fs > > Fix warnings Thanks! All good now. Regards; Yann.

Re: svn commit: r1907984 - /httpd/httpd/trunk/modules/dav/fs/quota.c

Hi Emmanuel, On Thu, Mar 2, 2023 at 4:46 PM wrote: > > Author: manu > Date: Thu Mar 2 15:46:12 2023 > New Revision: 1907984 > > URL: http://svn.apache.org/viewvc?rev=1907984=rev > Log: > Add RFC4331 quotas for mod_dav_fs > > Address forgotten svn add in previous commit > > Added: >

Re: [apache/httpd] Event wip (PR #294)

Hi Eric, I'm back from vacation and see your message, though not on gh anymore so not sure if you figured out something.. In any case I'm interested in discussing this (and see if I'm making good use of AsyncRequestWorkerFactor in this PR), plus it allows me to come back to this PR (and hopefully

Re: [VOTE] broader RTC exception for 2.4.x CI changes

On Wed, Feb 15, 2023 at 2:49 PM Joe Orton wrote: > > Per my previous Travis is dead, long live GitHub actions. > > I propose to broaden the RTC exception in 2.4.x/STATUS to allow CI > config changes and scripts to be merged from trunk: > > Index: STATUS >

Re: svn commit: r1907031 - /httpd/httpd/trunk/docs/manual/mod/mod_proxy.xml

On Fri, Jan 27, 2023 at 4:41 PM Eric Covener wrote: > > maybe we can duplicate that in the "basic examples" at the top of the page? Good point, did that in r1907035 (and linking to it in the note rather than copying the same example). I also added a deprecation warning to mod_proxy_wstunnel

Re: [VOTE] Release httpd-2.4.55-rc1 as httpd-2.4.55

On Wed, Jan 11, 2023 at 10:10 AM Stefan Eissing via dev wrote: > > > Am 10.01.2023 um 22:39 schrieb Christophe JAILLET > > : > > > > 1 issue with pytest: > > test/modules/http2/test_600_h2proxy.py .F > > (details at the end of the mail) > > > > Don't know if expected or not. Some

Re: [VOTE] Release httpd-2.4.55-rc1 as httpd-2.4.55

On Tue, Jan 10, 2023 at 2:41 PM Eric Covener wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.55-rc1 as 2.4.55: +1 on Debian 11 & 12, thanks Eric for RMing. Regards; Yann.

Re: New committer: Emmanuel Dreyfus

Welcome Emmanuel, glad to have you on the team! On Tue, Nov 8, 2022 at 11:15 AM Joe Orton wrote: > > The Project Management Committee (PMC) for the Apache HTTP Server has > invited Emmanuel Dreyfus to become a committer and we are pleased to > announce that they have accepted. > > Welcome,

Re: [libapreq2] nits to pick about the patches to util.c over the past few years

On Mon, Oct 31, 2022 at 7:44 PM Joe Schaefer wrote: > > The reason this took so long for the community to diagnose isn't because of > ill-intent, but because it constituted > a change of behavior in the parser logic that wasn't surfaced in the Changes > file. Please review r1905018 (with a

Re: [libapreq2] nits to pick about the patches to util.c over the past few years

Hi Joe, here comes the "goofer". On Fri, Oct 28, 2022 at 9:05 PM wrote: > > Long time fan, not a first time caller. Yet what a crappy thread (and comments on [1]). All top posting, unreplyable. > > Libapreq2 was intended to be a safe,fast, standards compliant library- > primarily *safe*

Re: svn commit: r1904638 - in /httpd/httpd/trunk: changes-entries/DAVLockDiscovery.txt modules/dav/main/mod_dav.c modules/dav/main/mod_dav.h modules/dav/main/props.c

On Mon, Oct 17, 2022 at 12:05 PM Ruediger Pluem wrote: > > On 10/17/22 11:48 AM, yla...@apache.org wrote: > > > > Add a DAVLockDiscovery configuration directive that allows lockdiscovery to > > be > > disabled. Its argument is an Apache expression so that flexible > > configuration > > are

Re: svn commit: r1904638 - in /httpd/httpd/trunk: changes-entries/DAVLockDiscovery.txt modules/dav/main/mod_dav.c modules/dav/main/mod_dav.h modules/dav/main/props.c

On Mon, Oct 17, 2022 at 12:39 PM Greg Stein wrote: > > Did you run any tests to observe the alleged contention? No I didn't (not a user of mod_dav myself), but Emmanuel (CCed) who submitted the patch seems to encounter issues in some environment(s), per PR 66313. > > The dbm database is very

Re: mod_dav_fs performances

On Mon, Oct 17, 2022 at 9:20 AM Emmanuel Dreyfus wrote: > > I submitted a proposed fix in > https://bz.apache.org/bugzilla/show_bug.cgi?id=66313 I Thanks for this, checked in trunk (r1904638). Regards; Yann.

Re: [RESULT: PASS] Re: [VOTE] Release libapreq2-2.17

On Thu, Sep 29, 2022 at 1:16 PM Steve Hay wrote: > > On Thu, 25 Aug 2022 at 09:58, Joe Orton wrote: > > > > Thanks for testing. The release is approved: > > > > PMC votes: +1 from ylavic, jfclere, jorton > > > > I will promote the release and announce it. > > > > Thanks for this release. I

Re: friends of mod_proxy

On Tue, Oct 11, 2022 at 9:47 AM Stefan Eissing via dev wrote: > > > Am 10.10.2022 um 20:39 schrieb Ruediger Pluem : > > > > On 10/10/22 6:35 PM, Eric Covener wrote: > >> On Mon, Oct 10, 2022 at 11:55 AM Yann Ylavic wrote: > >>> > >>> How a

Re: friends of mod_proxy

On Fri, Oct 7, 2022 at 9:14 PM Ruediger Pluem wrote: > > On 10/7/22 7:11 PM, Stefan Eissing via dev wrote: > > > > > >> Am 07.10.2022 um 18:45 schrieb Yann Ylavic : > >> > > > > Thanks, Yann, for the detailed explanation on how this works and that

Re: friends of mod_proxy

On Thu, Oct 6, 2022 at 5:32 PM Eric Covener wrote: > > On Thu, Oct 6, 2022 at 10:21 AM Stefan Eissing via dev > wrote: > > > > Friends of mod_proxy, I have a question: > > > > In someone reported wrong > > connection reuse for a config like: > > > >

Re: [VOTE] Release libapreq2-2.17

On Mon, Aug 22, 2022 at 11:32 AM Yann Ylavic wrote: > > On Thu, Aug 18, 2022 at 1:32 PM Joe Orton wrote: > > > > I would like to call a VOTE over the next week to release this candidate > > tarball as v2.17: > > +1 on Debian(s). Not really related to apreq, but s

Re: [VOTE] Release libapreq2-2.17

On Thu, Aug 18, 2022 at 1:32 PM Joe Orton wrote: > > I would like to call a VOTE over the next week to release this candidate > tarball as v2.17: +1 on Debian(s). Thanks Joe for RMIng!

Re: svn commit: r1902909 - /httpd/httpd/trunk/server/util.c

On Thu, Jul 28, 2022 at 4:02 PM Ruediger Pluem wrote: > > On 7/21/22 1:21 PM, yla...@apache.org wrote: > > > --- httpd/httpd/trunk/server/util.c (original) > > +++ httpd/httpd/trunk/server/util.c Thu Jul 21 11:21:30 2022 > > > @@ -3355,19 +3355,6 @@ AP_DECLARE(apr_status_t) ap_thread_main_ > >

Re: svn commit: r1894982 - /httpd/apreq/trunk/library/util.c

On Wed, Aug 17, 2022 at 3:40 PM Joe Orton wrote: > > On Wed, Aug 17, 2022 at 02:05:09PM +0100, Joe Orton wrote: > > On Fri, Nov 12, 2021 at 06:12:58PM -, yla...@apache.org wrote: > > > Author: ylavic > > > Date: Fri Nov 12 18:12:58 2021 > > > New Revision: 1894982 > > > > > > URL:

Re: svn commit: r1894982 - /httpd/apreq/trunk/library/util.c

On Wed, Aug 17, 2022 at 3:05 PM Joe Orton wrote: > > This is an infinite loop. The libapreq test suite is spinning here, > "make test" from apreq trunk. Indeed, should be fixed in r1903495. Thanks; Yann.

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Tue, Aug 2, 2022 at 2:59 PM Ruediger Pluem wrote: > > On 8/2/22 2:31 PM, Yann Ylavic wrote: > > On Mon, Aug 1, 2022 at 8:15 PM Ruediger Pluem wrote: > >> > >> On 8/1/22 5:05 PM, Ivan Zhakov wrote: > >>> > >>> My overall co

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Mon, Aug 1, 2022 at 8:15 PM Ruediger Pluem wrote: > > On 8/1/22 5:05 PM, Ivan Zhakov wrote: > > > > My overall concern is that with the current solution as of r1902858, there > > are valid and > > reasonable allocation patterns that will cause an unbounded memory usage. > > > > For example,

Re: problems with proxy worker and name_ex

On Wed, Jul 20, 2022 at 10:43 AM jean-frederic clere wrote: > > Hi, > > I think we have something wrong: > https://github.com/apache/httpd/blob/trunk/include/ap_mmn.h#L719 > and > https://github.com/apache/httpd/blob/2.4.x/include/ap_mmn.h#L601 > > How external modules can detect that 2.4.x has

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Sat, Jul 16, 2022 at 10:29 AM Ivan Zhakov wrote: > > On Wed, 13 Jul 2022 at 18:06, Yann Ylavic wrote: >> >> The flexible way for pcre2 users (and httpd maintainers) would be to >> let them opt-out (at runtime) of stack allocation from pcre2_match(), >> which i

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Wed, Jul 13, 2022 at 1:38 PM Ivan Zhakov wrote: > > On Sun, 10 Jul 2022 at 19:52, Yann Ylavic wrote: > > > > Let me explain (maybe), I thought that PCRE2's match_data were not > > only containing the captures vector but also all the frames needed for > > ma

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

On Tue, Jul 12, 2022 at 12:46 PM Ivan Zhakov wrote: > > On Wed, 29 Jun 2022 at 01:28, Yann Ylavic wrote: > > > > On Tue, Jun 28, 2022 at 6:08 PM Ivan Zhakov wrote: > > > > > > > I meant a memory leak for native threads. For example, with an MPM &g

Re: svn commit: r1897460 - in /httpd/httpd/trunk: include/ modules/core/ modules/http2/ modules/ssl/ server/ server/mpm/event/ server/mpm/prefork/ server/mpm/winnt/ server/mpm/worker/

On Fri, Jul 8, 2022 at 7:08 PM Ivan Zhakov wrote: > > On Tue, 25 Jan 2022 at 20:34, wrote: > > > > -child_handles[i] = CreateThread(NULL, ap_thread_stacksize, > > -worker_main, (void *) i, > > -

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Fri, Jul 8, 2022 at 7:15 PM Ivan Zhakov wrote: > > On Fri, 8 Jul 2022 at 19:58, Yann Ylavic wrote: > > > > The main downside is: > > > > > +#ifndef AP_PCRE_STACKBUF_SIZE > > > +#define AP_PCRE_STACKBUF_SIZE (256) > > > #endif > > []

Re: svn commit: r1902572 - /httpd/httpd/trunk/server/util_pcre.c

On Fri, Jul 8, 2022 at 5:07 PM wrote: > > Author: ivan > Date: Fri Jul 8 15:07:00 2022 > New Revision: 1902572 > > URL: http://svn.apache.org/viewvc?rev=1902572=rev > Log: > Rewrite ap_regexec() without a thread-local storage context for allocations. > > Provide custom malloc() and free()

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

On Tue, Jun 28, 2022 at 6:08 PM Ivan Zhakov wrote: > > On Tue, 28 Jun 2022 at 00:24, Yann Ylavic wrote: > > > > Hi Ivan, > > > > On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > > > > > For the longer version, let me first outline a few pro

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

Hi Ivan, On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > For the longer version, let me first outline a few problems with the current > apr_thread_current() API: > > 1) apr_thread_current_create() leaks the memory allocated in alloc_thread() > after the thread exits. Hm, alloc_thread()

Re: svn commit: r1902005 - in /httpd/httpd/trunk/modules/http2: h2_c1.c h2_config.c h2_config.h h2_mplx.c h2_mplx.h h2_workers.c h2_workers.h mod_http2.c

On Mon, Jun 20, 2022 at 1:23 PM Stefan Eissing wrote: > > > Am 20.06.2022 um 13:08 schrieb Yann Ylavic : > > > > On Fri, Jun 17, 2022 at 11:24 AM wrote: > >> > >> --- httpd/httpd/trunk/modules/http2/h2_workers.h (original) > >> +++ httpd/httpd/trun

Re: svn commit: r1902005 - in /httpd/httpd/trunk/modules/http2: h2_c1.c h2_config.c h2_config.h h2_mplx.c h2_mplx.h h2_workers.c h2_workers.h mod_http2.c

On Fri, Jun 17, 2022 at 11:24 AM wrote: > > --- httpd/httpd/trunk/modules/http2/h2_workers.h (original) > +++ httpd/httpd/trunk/modules/http2/h2_workers.h Fri Jun 17 09:24:57 2022 > @@ -28,59 +28,94 @@ struct h2_mplx; > struct h2_request; > struct h2_fifo; > > -struct h2_slot; > - > typedef

Re: [VOTE] Release httpd-2.4.54-rc3 as httpd-2.4.54

On Mon, Jun 6, 2022 at 4:25 PM Stefan Eissing wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.54-rc3 as 2.4.54: [X] +1: It's not just good, it's good enough! All good on Linux Debian(s). Thanks Stefan for RMing!

Re: svn commit: r1901554 - /httpd/test/framework/trunk/t/modules/sed.t

On Thu, Jun 2, 2022 at 1:04 PM wrote: > > Author: rpluem > Date: Thu Jun 2 11:04:13 2022 > New Revision: 1901554 > > URL: http://svn.apache.org/viewvc?rev=1901554=rev > Log: > * Test returns 200, but content is !!!ERROR!!! On my machine it returns 400 (hitting the mem limit) with html content..

Re: svn commit: r1901485 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

On Wed, Jun 1, 2022 at 12:39 PM Ruediger Pluem wrote: > > On 6/1/22 11:56 AM, yla...@apache.org wrote: > > > > +/* Compute Host header */ > > if (dconf->preserve_host == 0) { > > if (ap_strchr_c(uri->hostname, ':')) { /* if literal IPv6 address > > */ > > if

Re: svn commit: r1901460 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

On Wed, Jun 1, 2022 at 11:21 AM Ruediger Pluem wrote: > > On 6/1/22 11:10 AM, Yann Ylavic wrote: > > On Wed, Jun 1, 2022 at 8:29 AM Ruediger Pluem wrote: > >> > >> On 5/31/22 5:06 PM, yla...@apache.org wrote: > > >>> } > >>> +

Re: svn commit: r1901460 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

On Wed, Jun 1, 2022 at 8:29 AM Ruediger Pluem wrote: > > On 5/31/22 5:06 PM, yla...@apache.org wrote: > > > > /* We used to send `Host: ` always first, so let's keep it that > > * way. No telling which legacy backend is relying no this. > > */ > > if (dconf->preserve_host ==

Re: tcp send buffering and keepalive races

On Fri, May 27, 2022 at 7:34 PM Eric Covener wrote: > > These types of investigations can be really painful. Is there any > harm in allowing the server to act like "KeepAliveTimeout 5" is e.g. > "KeepAliveTimeout 5200ms". > > If this fudge buffer existed as an addl directive (rather than a trick

Re: release anyone?

On Wed, May 25, 2022 at 2:15 PM Stefan Eissing wrote: > > Anyone feeling release vibes in the air? +1 thanks for proposing!

Re: travis CI failing in 2.4.x

Hi, > > We have the CI for 2.4.x failing for some time in endless log messages for > "Linux Ubuntu Focal, ASan, pool-debug" > > [Mon May 16 14:36:38.939810 2022] [optional_hook_import:error] [pid 64983:tid > 140667614734080] AH01866: Optional hook test said: GET >

Re: svn commit: r1899609 - in /httpd/httpd/trunk: changes-entries/core_ap_escape_quotes.txt server/util.c test/unit/util.c

On Fri, Apr 15, 2022 at 6:19 PM Yann Ylavic wrote: > > On Fri, Apr 15, 2022 at 4:21 PM Stefan Eissing wrote: > > > > > Am 15.04.2022 um 15:24 schrieb Yann Ylavic : > > > > > > On Wed, Apr 6, 2022 at 11:17 AM wrote: > > >> > > >> Mod

Re: svn commit: r1899609 - in /httpd/httpd/trunk: changes-entries/core_ap_escape_quotes.txt server/util.c test/unit/util.c

On Fri, Apr 15, 2022 at 4:21 PM Stefan Eissing wrote: > > > Am 15.04.2022 um 15:24 schrieb Yann Ylavic : > > > > On Wed, Apr 6, 2022 at 11:17 AM wrote: > >> > >> Modified: httpd/httpd/trunk/server/util.c > >> URL: > >> http://svn.apac

Re: svn commit: r1899609 - in /httpd/httpd/trunk: changes-entries/core_ap_escape_quotes.txt server/util.c test/unit/util.c

On Wed, Apr 6, 2022 at 11:17 AM wrote: > > Modified: httpd/httpd/trunk/server/util.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util.c?rev=1899609=1899608=1899609=diff > == > ---

Re: svn commit: r1899858 - /httpd/httpd/trunk/server/mpm/event/event.c

On Thu, Apr 14, 2022 at 6:11 PM Ruediger Pluem wrote: > > On 4/14/22 4:38 PM, yla...@apache.org wrote: > > > > +if (++successive_signals >= 3) { > > +if (successive_signals % 10 == 3) { > > +ap_log_error(APLOG_MARK, APLOG_WARNING, 0, > > +

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

On Thu, Apr 14, 2022 at 1:43 PM Stefan Eissing wrote: > > > In test/modules/core/test_002_restarts.py there is now a start of this. > Invoked > specifically with: > > trunk> STRESS_TEST=1 pytest -vvv -k test_core_002 Thanks for writing this! > > this uses the config given and runs h2load with

Re: Faster start children after fatal signals?

On Thu, Apr 14, 2022 at 4:00 PM Ruediger Pluem wrote: > > On 4/14/22 3:43 PM, Yann Ylavic wrote: > > > > I have not tested it yet but possibly without this if many children > > segfault successively we might enter a busy fork() loop. Tested and it seems to work.. >

Re: Faster start children after fatal signals?

On Thu, Apr 14, 2022 at 1:44 PM Ruediger Pluem wrote: > > On 4/14/22 1:16 PM, Yann Ylavic wrote: > > On Thu, Apr 14, 2022 at 12:09 PM Ruediger Pluem wrote: > >> > >> On 4/14/22 11:52 AM, Yann Ylavic wrote: > >>> > >>> Any signal t

Re: Faster start children after fatal signals?

On Thu, Apr 14, 2022 at 12:09 PM Ruediger Pluem wrote: > > On 4/14/22 11:52 AM, Yann Ylavic wrote: > > > > Any signal that killed the process would mean something unexpected > > happened since we clean_child_exit() otherwise? > > Hm. You mean that the cas

Re: Faster start children after fatal signals?

On Thu, Apr 14, 2022 at 11:21 AM Ruediger Pluem wrote: > > On 4/13/22 5:41 PM, Yann Ylavic wrote: > > On Wed, Apr 13, 2022 at 4:30 PM Ruediger Pluem wrote: > >> > >> While looking at PR65769 I stumbled across the below in event.c (same in > >> worker.c)

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

On Thu, Apr 14, 2022 at 9:12 AM Stefan Eissing wrote: > > I have the feeling we are in need of some sort of stress tests on > the overall child management scenarios. Offering my help. Thanks Stefan for offering! Say we have a MPM event configuration like this: StartServers 1

Re: Faster start children after fatal signals?

On Wed, Apr 13, 2022 at 4:30 PM Ruediger Pluem wrote: > > While looking at PR65769 I stumbled across the below in event.c (same in > worker.c) > > 3460/* Don't perform idle maintenance when a child dies, > 3461 * only do it when there's a timeout. Remember only a

Re: svn commit: r1899777 - /httpd/httpd/trunk/server/mpm/event/event.c

On Wed, Apr 13, 2022 at 4:22 PM Ruediger Pluem wrote: > > On 4/12/22 2:08 PM, yla...@apache.org wrote: > > > @@ -3447,9 +3480,11 @@ static void server_main_loop(int remaini > > continue; > > } > > > > +max_daemon_used = 0; > > for (i = 0; i < num_buckets;

Re: [VOTE] Release httpd-2.4.53-rc2 as httpd-2.4.53

On Wed, Mar 9, 2022 at 5:20 PM Stefan Eissing wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.53-rc2 as 2.4.53: [X] +1: It's not just good, it's good enough! All good on Debian 10, 11 & 12. Thanks Stefan for RMing, now we know that

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

On Wed, Mar 9, 2022 at 2:45 PM Stefan Eissing wrote: > > > Am 09.03.2022 um 14:25 schrieb Yann Ylavic : > > > > On Tue, Mar 8, 2022 at 6:22 PM Rainer Jung wrote: > >> > >> - configure for APR in the dependency tarball still fails for me due to >

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

On Wed, Mar 9, 2022 at 3:21 PM Jim Jagielski wrote: > > I've found make extraclean works a bit better Ah yes great hint, it avoids removing the configure files manually. Thanks!

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

On Wed, Mar 9, 2022 at 2:45 PM Stefan Eissing wrote: > > > Am 09.03.2022 um 14:25 schrieb Yann Ylavic : > > > > On Tue, Mar 8, 2022 at 6:22 PM Rainer Jung wrote: > >> > >> - configure for APR in the dependency tarball still fails for me due to >

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

On Tue, Mar 8, 2022 at 6:22 PM Rainer Jung wrote: > > - configure for APR in the dependency tarball still fails for me due to > a bug in autoconf 2.71 used to create the configure script. That problem > was already reported by me during another release vote. I replaced the > changed three files

Re: backports

On Tue, Mar 8, 2022 at 2:34 PM Jim Jagielski wrote: > >> On Mar 8, 2022, at 7:58 AM, Graham Leggett wrote: >> >> I would far rather the empty APLOGNO check was part of the build. >> >> Vastly simpler. > > > I agree w/ that... I for one prefer post processing of APLOGNO()s, if `make` started to

Re: backports

On Tue, Mar 8, 2022 at 1:59 PM Graham Leggett wrote: > > Using Github/Travis should inform us on the status of a proposal. Good, so having it run on every branch is fine by you right? > > Github/Travis should definitely not be invited onto our PMC and given a veto > vote on backports and

Re: backports

On Sat, Mar 5, 2022 at 12:17 PM Stefan Eissing wrote: > > > Am 04.03.2022 um 18:40 schrieb Roy T. Fielding : > > > >> On Mar 4, 2022, at 6:17 AM, Eric Covener wrote: > >> > >> On Fri, Mar 4, 2022 at 9:05 AM Jim Jagielski wrote: > >>> > >>> A question: Would it be easier for all this if we moved

Re: svn commit: r1898181 - /httpd/httpd/branches/2.4.x/STATUS

On Fri, Feb 18, 2022 at 2:14 PM wrote: > > Author: covener > Date: Fri Feb 18 13:14:13 2022 > New Revision: 1898181 > > URL: http://svn.apache.org/viewvc?rev=1898181=rev > Log: > vote/promote > > + *) Support PCRE2 with buffers reuse through Thread Local Storage. > + trunk patches: > +

Re: mpm event assertion failures

On Wed, Feb 9, 2022 at 4:43 PM Yann Ylavic wrote: > > With PR #294 this specific case shouldn't happen anymore (thanks to > https://github.com/apache/httpd/pull/294/commits/7089813e13bba0f25bd34df4c643cf5878e6e043). That link broke with my rebases.. It's currently https://github.c

Re: mpm event assertion failures

On Wed, Feb 9, 2022 at 2:09 PM Ruediger Pluem wrote: > > On 2/9/22 1:25 PM, Graham Leggett wrote: > > On 08 Feb 2022, at 19:01, Yann Ylavic > <mailto:ylavic@gmail.com>> wrote: > > > >>> The most concurrent requests I can get out of MacOS appears to

Re: svn commit: r1897872 - in /httpd/httpd/trunk: changes-entries/http2_request_scheme.txt modules/http2/h2_stream.c test/modules/http2/test_003_get.py

On Wed, Feb 9, 2022 at 11:28 AM Ruediger Pluem wrote: > > On 2/9/22 10:28 AM, Stefan Eissing wrote: > > > >> Am 09.02.2022 um 10:15 schrieb Ruediger Pluem : > >> > >> On 2/8/22 7:10 PM, Roy T. Fielding wrote: > >>> As noted in > >>> > >>>

Re: mpm event assertion failures

On Tue, Feb 8, 2022 at 2:15 PM Graham Leggett wrote: > > On 07 Feb 2022, at 18:13, Yann Ylavic wrote: > > All green: https://app.travis-ci.com/github/apache/httpd/builds/246021482 \o/ > > > I’ve been load testing these changes with the fixed trunk version of ab Thanks!

Re: svn commit: r1897858 - in /httpd/httpd/trunk: ./ changes-entries/

On Tue, Feb 8, 2022 at 1:31 PM Stefan Eissing wrote: > > > > > Am 08.02.2022 um 13:14 schrieb Yann Ylavic : > > > > On Tue, Feb 8, 2022 at 12:47 PM Rainer Jung wrote: > >> > >> Small typo below ... > >> > >> Am 08.02.2022 um 12:0

Re: svn commit: r1897858 - in /httpd/httpd/trunk: ./ changes-entries/

On Tue, Feb 8, 2022 at 12:47 PM Rainer Jung wrote: > > Small typo below ... > > Am 08.02.2022 um 12:04 schrieb yla...@apache.org: > > + > > + *) mom_reqtimeout: Fix missing handshake= timeout enforcement. [Yann > > Ylavic] > > s/mom_/mod_/ Was a spe

Re: mpm event assertion failures

On Mon, Feb 7, 2022 at 3:41 PM Stefan Eissing wrote: > > > > > Am 07.02.2022 um 14:44 schrieb Stefan Eissing : > > > > > > > >> Am 07.02.2022 um 13:47 schrieb Yann Ylavic : > >> > >> On Mon, Feb 7, 2022 at 1:29 PM Yann Ylavic wrot

Re: mpm event assertion failures

On Mon, Feb 7, 2022 at 1:29 PM Yann Ylavic wrote: > > On Mon, Feb 7, 2022 at 1:01 PM Stefan Eissing wrote: > > [] > > there are still failures for > mod_md still I haven't looked at (I think I don't have all the mod_md > dependencies to test on my machine).. Na

Re: mpm event assertion failures

On Mon, Feb 7, 2022 at 1:01 PM Stefan Eissing wrote: > > > Am 07.02.2022 um 12:46 schrieb Yann Ylavic : > >> > >> The assertion failure is due to mpm_event closing all the workers' > >> sockets forcibly [1] on ungraceful shutdown/restart, while the socket >

Re: mpm event assertion failures

On Mon, Feb 7, 2022 at 12:41 PM Yann Ylavic wrote: > > On Tue, Jan 25, 2022 at 1:12 PM Stefan Eissing wrote: > > > > Also, while running the http2 test suite, I get repeated assert failures in > > event.c:1230 > > > > if (rv != APR_SUCCESS && !APR_STA

Re: mpm event assertion failures

On Tue, Jan 25, 2022 at 1:12 PM Stefan Eissing wrote: > > Also, while running the http2 test suite, I get repeated assert failures in > event.c:1230 > > if (rv != APR_SUCCESS && !APR_STATUS_IS_EEXIST(rv)) { > -> AP_DEBUG_ASSERT(0); > TO_QUEUE_REMOVE(cs->sc->wc_q, cs); >

Re: svn commit: r1897760 - in /httpd/httpd/trunk: ./ changes-entries/ include/ modules/generators/ modules/ssl/ server/mpm/event/ support/ test/modules/http2/

On Fri, Feb 4, 2022 at 3:49 PM Yann Ylavic wrote: > > On Fri, Feb 4, 2022 at 1:22 PM wrote: > > > > Author: icing > > Date: Fri Feb 4 12:22:26 2022 > > New Revision: 1897760 > > > > URL: http://svn.apache.org/viewvc?rev=1897760=rev > > Log: &g

Re: svn commit: r1897760 - in /httpd/httpd/trunk: ./ changes-entries/ include/ modules/generators/ modules/ssl/ server/mpm/event/ support/ test/modules/http2/

On Fri, Feb 4, 2022 at 1:22 PM wrote: > > Modified: httpd/httpd/trunk/modules/ssl/mod_ssl.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/mod_ssl.c?rev=1897760=1897759=1897760=diff > == > ---

<    1   2   3   4   5   6   7   8   9   10   >