Re: apreq release

2016-11-16 Thread Brian J. France
This is just merging the perl stuff into mod_perl, right? Not merging mod_apreq2 and all the request cache/re-play bucket, POST reading, file uploading, etc stuff, right? I really don't want to have to include mod_perl so my C modules can read POST data and handle file uploads. Cheers, Brian

Re: apreq release

2016-11-16 Thread Brian J. France
This is just merging the perl stuff into mod_perl, right? Not merging mod_apreq2 and all the request cache/re-play bucket, POST reading, file uploading, etc stuff, right? I really don't want to have to include mod_perl so my C modules can read POST data and handle file uploads. Cheers, Brian

Re: "httpd -X" segfaults with 2.4.17

2016-02-09 Thread Brian J. France
This hasn't made it into the 2.4.x branch yet, what is the status of getting this in the .19 release? http://svn.apache.org/viewvc?view=revision=1711479 Thanks, Brian > On Oct 16, 2015, at 8:06 AM, Yann Ylavic wrote: > > Hi Jan, > > On Fri, Oct 16, 2015 at 1:58 PM,

Re: Looking ahead to 2.4.13 / 2.2.30

2015-05-04 Thread Brian J. France
While you are in mod_dav, could you review these patches and see if it makes sense to add them? httpd-2.2.x : http://www.brianfrance.com/software/apache/dav/mod_dav_fs.diff.22 httpd-2.4.x : http://www.brianfrance.com/software/apache/dav/mod_dav_fs.diff.24 We have been running these for a while

Re: apr_socket_opt_set always sets TCP_DEFER_ACCEPT to 1 (was @apr)

2014-04-30 Thread Brian J. France
...@apr.apache.org On Tue, Apr 29, 2014 at 5:41 PM, Jim Jagielski j...@jagunet.com wrote: On Apr 22, 2014, at 9:43 AM, Brian J. France br...@brianfrance.com wrote: For some reason I completely missed that. APR is fine, but httpd needs updated as it is hard coded to 1: rv = apr_socket_opt_set(s

Re: apreq_parse_generic example

2013-11-09 Thread Brian J. France
: Been a while since I thought about this, but apreq is really only suited for table-based data structures. JSON is a little too generic for that unless you know the data is restricted to only key-value pairs. On Nov 8, 2013, at 12:45 PM, Brian J. France br...@brianfrance.com wrote: Does

apreq_parse_generic example

2013-11-08 Thread Brian J. France
Does anybody have example code of how to use apreq_parse_generic in an httpd module hook (non-handler)? Need to use apreq2 and mod_apreq2 to read json data and not having any luck. Thanks, Brian

apreq_parse_generic example

2013-11-08 Thread Brian J. France
Does anybody have example code of how to use apreq_parse_generic in an httpd module hook (non-handler)? Need to use apreq2 and mod_apreq2 to read json data and not having any luck. Thanks, Brian - Please keep me looped into any reply, not subscribed.

Re: apreq_parse_generic example

2013-11-08 Thread Brian J. France
, Brian J. France br...@brianfrance.com wrote: Does anybody have example code of how to use apreq_parse_generic in an httpd module hook (non-handler)? Need to use apreq2 and mod_apreq2 to read json data and not having any luck. Thanks, Brian - Please keep me looped into any reply

Re: [DISCUSS] CMS site migration

2012-05-07 Thread Brian J. France
Do you have details on the on the new CMS, format, conversions, etc? We us the httpd current format at work for our internal modules and might want to transition to the CMS as well. Thanks, Brian On May 6, 2012, at 5:39 PM, Joe Schaefer wrote: Over on docs@ one of the recent conversations

Re: mod_dav_fs does not check for return value on stream_close

2012-04-04 Thread Brian J. France
Yes, you are correct. Looks like my merge from work code to httpd svn didn't fully work. We have been running this patch for a week or so with no issues. Brian On Apr 4, 2012, at 6:24 PM, Graham Leggett wrote: On 15 Mar 2012, at 3:56 PM, Brian J. France wrote: Could somebody review

mod_dav_fs does not check for return value on stream_close

2012-03-15 Thread Brian J. France
Could somebody review the patch below for 2.2, 2.4, and trunk? A better error message could be sent, but I am more worried about how the return will effect the code after it. I am thinking the file needs to be removed either via a apr_file_remove call or: apr_pool_cleanup_kill(stream-p,

Re: WebDAV and ACL (RFC3744), status?

2012-02-01 Thread Brian J. France
I had started breaking up the patches from mod_dav_acl into smaller chunks and getting them imported into the trunk. My goal was to get a mod_dav_acl like module added. I say like because mod_dav_acl currently requires xfs and stores the auth information in the xfs attributes and I wanted to

Re: httpd should be able to reopen log files without a restart.

2011-10-11 Thread Brian J. France
? Will it be documented? On Tue, Oct 11, 2011 at 10:28 AM, Brian J. France br...@brianfrance.com wrote: apr trunk has APR_FOPEN_ROTATING support (stat checking and re-open), which is based on a patch we use at work. This allows us to move the log file, wait 90 seconds and then compress the moved

Re: httpd should be able to reopen log files without a restart.

2011-10-10 Thread Brian J. France
apr trunk has APR_FOPEN_ROTATING support (stat checking and re-open), which is based on a patch we use at work. This allows us to move the log file, wait 90 seconds and then compress the moved log file, all without touch the server as it will stat the log ever 60 and re-open it if needed

Filter Scoreboard Entries

2010-11-07 Thread Brian J. France
$DAY job requires filtering the scoreboard for things like username, passwords, credit card numbers (don't ask) and other sensitive information. Currently I just added a patch to our build that adds a option function that I set in our filtering module. While at ApacheCon I talked with Paul

Re: Log file rotation patch

2010-11-05 Thread Brian J. France
On Nov 5, 2010, at 12:13 PM, Dirk-Willem van Gulik wrote: On 4 Nov 2010, at 21:26, Brian J. France wrote: With the current patch, see link below, it changes the syntax to ErrorLog to this: ErrorLog file-path|syslog[:facility] [rotating[:interval]] Nice! There is one security

Log file rotation patch

2010-11-04 Thread Brian J. France
While at ApacheCon I am working on getting a patch for log file rotation and would like to get some feed back. With the current patch, see link below, it changes the syntax to ErrorLog to this: ErrorLog file-path|syslog[:facility] [rotating[:interval]] examples: ErrorLog logs/error_log

Re: HTTP trailers?

2010-04-23 Thread Brian J. France
it with: ASCII_ZERO ASCII_CRLF tailer string ASCII_CRLF and you have chunked encoding with a trailer. Brian On Apr 22, 2010, at 10:39 PM, Brian J. France wrote: On Apr 22, 2010, at 8:40 PM, Mark Nottingham wrote: I couldn't find any obvious way to set HTTP trailers in Apache 2.x without taking over

Re: HTTP trailers?

2010-04-23 Thread Brian J. France
On Apr 23, 2010, at 10:08 AM, William A. Rowe Jr. wrote: On 4/23/2010 9:03 AM, Brian J. France wrote: You can build a module that is able to insert a trailer by adding a filter and ap_hook_create_request call. But doesn't this defeat the purpose of using a modular server architecture

Re: HTTP trailers?

2010-04-22 Thread Brian J. France
On Apr 22, 2010, at 8:40 PM, Mark Nottingham wrote: I couldn't find any obvious way to set HTTP trailers in Apache 2.x without taking over all response processing (a la nph). Did I miss something? I started hacking on this at work, but got the point where I can't insert a filter in the

Re: AW: ACL changes in mod_dav

2010-02-24 Thread Brian J. France
On Feb 23, 2010, at 11:02 PM, markus.l...@dlr.de markus.l...@dlr.de wrote: I think this is a little misunderstanding. Yes I mean the WebDAV ACL spec features, but I we don't have implemented this into mod_dav. We implemented it into our own module (Catacomb) and therefore we need to extent

DAV ETag Patch

2010-02-22 Thread Brian J. France
Hello, It has been a while since my last patch, but this is the last supporting patch to mod_dav and httpd that is required before adding acl hooks into mod_dav for mod_dav_acl[1] http://www.brianfrance.com/software/apache/dav/dav-etag.diff This patch adds a new directive for mod_dav:

Re: ACL changes in mod_dav

2010-02-22 Thread Brian J. France
On Feb 20, 2010, at 11:23 PM, markus.l...@dlr.de markus.l...@dlr.de wrote: I have added ACL features to the mod_dav module. Could you tell me the correct way to get this changes reviewed and into to official mod_dav-source? Did you use any of the public available mod_dav_acl[1] code? I

Re: reopening of logs without restarting

2010-01-22 Thread Brian J. France
On Jan 22, 2010, at 1:43 PM, Mikhail T. wrote: Hello! Some of our web-servers take a while to restart (because some custom modules need to login to database backends, etc.) This makes it undesirable for us to use the SIGUSR1 (for graceful restart) and we currently log to stdin of an easier

Re: reopening of logs without restarting

2010-01-22 Thread Brian J. France
On Jan 22, 2010, at 3:15 PM, Mikhail Teterin wrote: 22.01.2010 14:50, Brian J. France ???(??): I was going to bring up the patch during the Monday/Tuesday hack days along with a few others. Can you send me the patch directly /today/? Thanks! Here is the patch: http

Re: httpd meetup/hackathon, January?

2009-12-08 Thread Brian J. France
On Dec 8, 2009, at 7:49 PM, Paul Querna wrote: On Mon, Dec 7, 2009 at 11:50 AM, Paul Querna p...@querna.org wrote: Hi Everyone, Over on TraffiicServer, there is rough talk of doing some kind of meetup/hackathon the week of January 27th 2010, in Silicon Valley. Alternative is the week of

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-27 Thread Brian J. France
Ya, I have been trying to get somebody to commit this fixup patch: http://www.brianfrance.com/software/apache/dav/fixup.diff It fixes comments of the new function pointers (so they match others), moves the function to static to remove compile time warnings and fixes the order in the

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-22 Thread Brian J. France
On Oct 16, 2009, at 8:01 AM, Graham Leggett wrote: Brian J. France wrote: mod_dav_acl would use the filename to validate the acls. Like I said, I don't know if get_pathname is needed or we should just use r- filename and make sure a mod_dav_fs_db module updated it. As Joe points out

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-12 Thread Brian J. France
On Oct 10, 2009, at 4:04 AM, Ruediger Pluem wrote: On 10/09/2009 11:41 PM, minf...@apache.org wrote: Author: minfrin Date: Fri Oct 9 21:41:31 2009 New Revision: 823703 URL: http://svn.apache.org/viewvc?rev=823703view=rev Log: mod_dav: Provide a mechanism to obtain the request_rec and

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-12 Thread Brian J. France
On Oct 12, 2009, at 3:58 AM, Joe Orton wrote: On Sat, Oct 10, 2009 at 10:04:57AM +0200, Ruediger Pluem wrote: On 10/09/2009 11:41 PM, minf...@apache.org wrote: = = = = = = = = = = ---

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-12 Thread Brian J. France
On Oct 12, 2009, at 3:57 AM, Joe Orton wrote: On Fri, Oct 09, 2009 at 09:41:32PM -, Graham Leggett wrote: --- httpd/httpd/trunk/modules/dav/main/mod_dav.h (original) +++ httpd/httpd/trunk/modules/dav/main/mod_dav.h Fri Oct 9 21:41:31 2009 @@ -1940,6 +1940,12 @@ ** then this field

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-12 Thread Brian J. France
On Oct 12, 2009, at 4:38 PM, Joe Orton wrote: On Mon, Oct 12, 2009 at 04:23:59PM -0400, Brian J. France wrote: On Oct 12, 2009, at 3:57 AM, Joe Orton wrote: On Fri, Oct 09, 2009 at 09:41:32PM -, Graham Leggett wrote: --- httpd/httpd/trunk/modules/dav/main/mod_dav.h (original) +++ httpd

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-12 Thread Brian J. France
On Oct 12, 2009, at 4:39 PM, Joe Orton wrote: On Mon, Oct 12, 2009 at 04:17:00PM -0400, Brian J. France wrote: On Oct 12, 2009, at 3:58 AM, Joe Orton wrote: On Sat, Oct 10, 2009 at 10:04:57AM +0200, Ruediger Pluem wrote: This creates the following warning: repos.c:1827: warning

Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h

2009-10-12 Thread Brian J. France
On Oct 12, 2009, at 5:15 PM, Brian J. France wrote: On Oct 12, 2009, at 4:39 PM, Joe Orton wrote: On Mon, Oct 12, 2009 at 04:17:00PM -0400, Brian J. France wrote: On Oct 12, 2009, at 3:58 AM, Joe Orton wrote: On Sat, Oct 10, 2009 at 10:04:57AM +0200, Ruediger Pluem wrote: This creates

Re: DAV Provider Patch

2009-10-07 Thread Brian J. France
On Oct 7, 2009, at 5:37 PM, Graham Leggett wrote: Brian J. France wrote: Sorry for the delay in response to this, life got in the way. I have updated the patch here: http://www.brianfrance.com/software/apache/dav/dav-provider-3.diff This patch doesn't break binary compatibility (adds

Re: DAV Provider Patch

2009-10-06 Thread Brian J. France
: DAV Provider Patch Brian J. France br...@brianfrance.com writes: On Sep 21, 2009, at 10:15 AM, Graham Leggett wrote: Brian J. France wrote: I believe this is the first patch that will break binary compatibility because it adds a function pointer to the middle of the struct. I believe binary

Re: DAV Provider Patch

2009-10-06 Thread Brian J. France
On Oct 6, 2009, at 7:40 PM, Nick Kew wrote: On 6 Oct 2009, at 22:15, Brian J. France wrote: Sorry for the delay in response to this, life got in the way. I have updated the patch here: http://www.brianfrance.com/software/apache/dav/dav-provider-3.diff This patch doesn't break binary

DAV Provider Patch

2009-09-21 Thread Brian J. France
Next up is the dav providers patch. Currently there is no way for dav modules to get access to the filename or the the request_rec. A dav module would need to check the filename to see if needs to enable acls or other options. A dav module would also need the request_rec for checking

Re: DAV Provider Patch

2009-09-21 Thread Brian J. France
On Sep 21, 2009, at 10:15 AM, Graham Leggett wrote: Brian J. France wrote: I believe this is the first patch that will break binary compatibility because it adds a function pointer to the middle of the struct. I believe binary compatibility could be retained if we add the function

DAV Resource Type Patch

2009-09-18 Thread Brian J. France
Next up is the dav resource provider patch. Currently there is no way to add additional resource type responses to mod_dav. We are stuck with hard coded list from DAV_PROPID_resourcetype: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/main/std_liveprop.c?annotate=420983#l58

DAV Option Patch

2009-09-14 Thread Brian J. France
I would like to get some form of mod_dav_acl[1] added to httpd. My end goal with all of this is to get a mod_caldav and mod_cardav accepted down the line or at least be able to build the module with out hacking the core httpd source. I am going to start by splitting up the Jari's

Re: DAV Option Patch

2009-09-14 Thread Brian J. France
On Sep 14, 2009, at 10:23 AM, Graham Leggett wrote: Brian J. France wrote: These patches are based off of 2.2.13, but if you would rather have patch against a branch or head, please let me know. Creating patches off head is the place to start, and once the patches have been committed

Re: DAV Option Patch

2009-09-14 Thread Brian J. France
On Sep 14, 2009, at 12:04 PM, Dan Poirier wrote: One suggestion - using hook in the names could be confusing since this isn't using the built-in hook mechanism. Since it is using the provider mechanism, maybe names like dav_options_provider would be clearer. I have updated the patches:

Re: DAV Option Patch

2009-09-14 Thread Brian J. France
On Sep 14, 2009, at 04:32 PM, Graham Leggett wrote: Brian J. France wrote: I have updated the patches: http://www.brianfrance.com/software/apache/dav/dav-option-provider.diff Committed in r814832, can you verify that I have attributed the patch correctly in CHANGES? Thanks! Can you

Re: DAV Option Patch

2009-09-14 Thread Brian J. France
On Sep 14, 2009, at 05:23 PM, Graham Leggett wrote: Brian J. France wrote: Can you credit Jari Urpalainen (jari.urpalainen nokia.com) as well as these are all based on his patches for his mod_dav_acl. Done in 814860. More patches tomorrow. I see the example module that you asked

Re: DAV Option Patch

2009-09-14 Thread Brian J. France
On Sep 14, 2009, at 05:02 PM, Joe Orton wrote: On Mon, Sep 14, 2009 at 10:11:24AM -0400, Brian J. France wrote: I would like to get some form of mod_dav_acl[1] added to httpd. My end goal with all of this is to get a mod_caldav and mod_cardav accepted down the line or at least be able

Re: incubator proposal for (what was once) Inktomi Traffic Server

2009-06-16 Thread Brian J. France
On Jun 16, 2009, at 10:02 AM, howard chen wrote: On Mon, Jun 15, 2009 at 12:25 PM, Roy T. Fieldingfield...@gbiv.com wrote: I think this is an interesting opportunity to compare different implementations and share code where desirable. I haven't seen anyone comment on the proposal yet. Just

Re: incubator proposal for (what was once) Inktomi Traffic Server

2009-06-16 Thread Brian J. France
On Jun 15, 2009, at 12:39 PM, Pranav Desai wrote: On Sun, Jun 14, 2009 at 9:25 PM, Roy T. Fieldingfield...@gbiv.com wrote: I think this is an interesting opportunity to compare different implementations and share code where desirable. I haven't seen anyone comment on the proposal yet.

Re: hook before receiving HTTP request

2009-03-16 Thread Brian J. France
On Mar 16, 2009, at 9:13 AM, Andrej van der Zee wrote: I am looking for a hook function that I can call to initialize some structures before it accepts a connections. Similar like ap_log_transaction() is called after the HTTP reply is sent to the client, I need a hook that is called before a

Re: Static compilation of a module

2008-07-31 Thread Brian J. France
On Jul 31, 2008, at 11:16 AM, lusob wrote: Ok, I'm going to try it, thanks!! At work we have moved away from using static libraries to shared libraries because of duplicate symbols issues. If your client loads your module as well as some module that uses apreq (say mod_perl or something

Re: ap_custom_response content type 'text/xml'

2008-06-27 Thread Brian J. France
+1 to -1 and it should keep the \n\r at the end of the header. Brian On Thu, 2008-06-26 at 10:29 -0400, Brian J. France wrote: On Jun 26, 2008, at 9:48 AM, Kiffin Gish wrote: Thanks Brian, I've tried what you suggested but it doesn't seem to work. Could you be more specific? Here's

Re: ap_custom_response content type 'text/xml'

2008-06-27 Thread Brian J. France
standalone=no ? ... Thanks in advance for your help. Looks like you need to look for ; and do the -1 or make you insert string text/xml; charset=iso-8859-1 and still do the -1. Biran On Fri, 2008-06-27 at 09:02 -0400, Brian J. France wrote: On Jun 27, 2008, at 4:00 AM, Kiffin Gish

Re: ap_custom_response content type 'text/xml'

2008-06-27 Thread Brian J. France
On Jun 27, 2008, at 11:04 AM, Kiffin Gish wrote: Sorry to keep bugging you, but where does this -1 belong? In my example there was this line: /* split off after value */ apr_bucket_split(b, end - ct_header + 14 + 1); + 14 is to skip the Content-Type: + 1 is to skip the \r This is where

Re: ap_custom_response content type 'text/xml'

2008-06-26 Thread Brian J. France
On Jun 26, 2008, at 3:33 AM, Kiffin Gish wrote: In order to reply with my own xml error, I want to use ap_custom_response(r, HTTP_INTERNAL_SERVER_ERROR, xml); However, default content type is text/html. If I try to change it by using ap_set_content_type(r, text/xml), this has no effect. Is

Re: ap_custom_response content type 'text/xml'

2008-06-26 Thread Brian J. France
(apr_pool_t *p) { ap_register_output_filter(WMSERROR_OUTPUT_FILTER, wmserror_output_filter, NULL, AP_FTYPE_PROTOCOL); ap_hook_insert_filter(wmserror_insert_output_filter, NULL, NULL, APR_HOOK_REALLY_LAST); } On Thu, 2008-06-26 at 08:35 -0400, Brian J. France wrote: On Jun 26, 2008

Re: buildconf and apr source

2008-06-13 Thread Brian J. France
On Jun 13, 2008, at 9:14 AM, Nick Kew wrote: If you try building from svn, buildconf complains of no apr/apr-util source. Why does buildconf actually need the sources? Shouldn't an installed version be sufficient? Glad to see I am not the only one confused by this. I have been working on

mod_deflate Vary header tweak

2008-04-28 Thread Brian J. France
I would like to propose a change to mod_deflate that would still send the Vary header if the request is flagged with no-gzip or gzip-only- text/html. I think the checks for Content-Range and Content-Encoding should be done, then the Vary header should be set and then the checks for no-

internal_internal_redirect and ap_run_create_request bug?

2008-02-29 Thread Brian J. France
Could somebody else review when ap_run_create_request is called in both internal_internal_redirect (modules/http/http_request.c) and ap_read_request (server/protocol.c)? I think a few more things need to be setup before calling ap_run_create_request in internal_internal_redirect. What I

Re: Passing parameters to PHP

2007-08-15 Thread Brian J. France
On Aug 15, 2007, at 3:46 PM, Sam Carleton wrote: Is there any way for my apache module to pass parameters in such a way that my php code can get at them? Stick the data in r-subprocess_env and PHP can access them via $_SERVER (or apache_getenv if $_SERVER is disabled). Or you can put them

-X and SIGTERM

2007-06-28 Thread Brian J. France
Here is a patch that will allow SIGTERM to work with -X http://www.brianfrance.com/software/apache/httpd.signal.diff Without the patch running httpd on the command line with -X and trying to stop it can only be done by backgrounding it and then kill -9'ing it (ctrl-c doesn't work). Brian

Re: Patch for implementing ap_document_root as a hook

2007-04-26 Thread Brian J. France
On Apr 26, 2007, at 8:35 AM, Jim Jagielski wrote: We currently hack the doc root in the post read hook in 1.3, would like to be able to do it with out hacking the core and screwing around with internal structs at runtime. VERY doubtful that 1.3 will be updated to do this. I don't need it

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Brian J. France
On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the translation. I can

Re: mod_authn_dbd and apr_password_validate

2007-01-06 Thread Brian J. France
On Jan 6, 2007, at 1:48 PM, Patrick Welche wrote: /* * Validate a plaintext password against a smashed one. Uses either * crypt() (if available) or apr_md5_encode() or apr_sha1_base64(), depending * upon the format of the smashed input password. Returns APR_SUCCESS if * they match, or

Re: [PATCH 40026] ServerTokens Off

2006-08-02 Thread Brian J. France
On Aug 2, 2006, at 3:57 AM, William A. Rowe, Jr. wrote: Sebastian Nohn wrote: please take the time to read it before voting against the proposal :) I am all for this patch (I know my vote means nothing)! I've read your comments, agree it's 17 bytes (that you can just as well remove, as

Re: Re[2]: apache 2.2 crashes at the start time in mod_dbd.c then preparing AuthDBDUserPWQuery

2006-07-20 Thread Brian J. France
I think this is the same issue I had: http://www.mail-archive.com/dev@httpd.apache.org/msg31299.html Not sure if there was a fix committed into the code tree or not. Brian On Jul 20, 2006, at 3:52 PM, Anton Golubev wrote: Hello Nick, Here is here the minimal complete config, which crashes

mod_deflate patch

2006-04-18 Thread Brian J. France
This was talked about a few weeks back but I don't think anything ever came of it. The patch below would allow mod_deflate to compress internal redirects while still skipping sub requests. I have been running this on my personal server for a few weeks now with no issues. Let the voting

Re: mod_deflate patch

2006-04-18 Thread Brian J. France
On Apr 18, 2006, at 2:52 PM, William A. Rowe, Jr. wrote: @@ -240,7 +240,7 @@ const char *encoding; /* only work on main request/no subrequests */ -if (!ap_is_initial_req(r)) { +if (r-main != NULL) { ap_remove_output_filter(f); Actually, explain

mod_deflate and internal redirects

2006-03-31 Thread Brian J. France
I was digging into why mod_deflate wasn't compressing some pages and found that any internal redirects (rewriterule) don't get compress. That is because of this code: /* only work on main request/no subrequests */ if (!ap_is_initial_req(r)) {

mod_dbd crash

2006-03-17 Thread Brian J. France
In a virtual host block if you forget to add DBDriver or DBDParams in the main section, but add a AuthBasicProvider dbd and AuthDBDUserPWQuery in a Location block it will core dump while processing AuthDBDUserPWQuery (see below). This is with 2.2.0 and trunk (core dump from trunk). The

Re: mod_dbd crash

2006-03-17 Thread Brian J. France
On Mar 17, 2006, at 11:42 AM, Nick Kew wrote: On Friday 17 March 2006 16:03, Brian J. France wrote: Here is a patch to mod_dbd.c and mod_authn_dbd.c (not sure if anything else uses that function) that returns a status code: http://www.brianfrance.com/software/apache/2006.03.17.diff

Re: [mod_smtpd] patch need for the SIZE extension

2006-02-08 Thread Brian J. France
On Feb 8, 2006, at 12:42 AM, Rian Hunter wrote: On Feb 7, 2006, at 8:15 PM, Brian J. France wrote: Before I started converting my other modules to the new code I figured I would start with writing a new module to handle the SIZE extension. I needed to apply the following patch (link below

Re: [mod_smtpd] patch need for the SIZE extension

2006-02-08 Thread Brian J. France
On Feb 8, 2006, at 9:28 PM, Rian Hunter wrote: On Feb 8, 2006, at 10:56 AM, Brian J. France wrote: +1, I like the idea of the storing the setting in the per connection instance. Leaving the default in the core and copying it to an per connection struct would allow modules to tweak

[mod_smtpd] patch need for the SIZE extension

2006-02-07 Thread Brian J. France
Hi Rian, Before I started converting my other modules to the new code I figured I would start with writing a new module to handle the SIZE extension. I needed to apply the following patch (link below) to the mod_smtpd code to get access at the max data size. I hooked the mail from

Re: mod_smtpd changes

2005-12-31 Thread Brian J. France
On Dec 31, 2005, at 1:23 PM, Rian Hunter wrote: Any comments, ideas and criticisms are highly welcomed! Thanks! Any changes on how recipients and queue/deliver is handled? I started implementing my proposal from a while back and got stuck on how to handle errors. If a transaction has

Re: svn commit: r307031 - in /httpd/httpd/branches/2.2.x: CHANGES include/ap_mmn.h include/http_core.h modules/http/http_core.c server/core.c server/core_filters.c server/protocol.c

2005-10-07 Thread Brian J. France
Will this patch allow the removal of this code from mod_ftp ftp_ssl_init function: /* This is handled in the NET_TIME filter, which unfortunately * ignores the timeout for the purpose of AP_MODE_INIT. * Fix a timeout so the core read filter will behave. */ client_socket

mod_smtpd: handling rctp addresses

2005-10-04 Thread Brian J. France
I would like to propose a change on how rcpt to addresses are validated and messages are handled (expanded) and how queue modules know it needs to process this message. I would like to change rcpt_to in smtpd_trans_rec to apr_table_t. The key for the table will be the address sent to rcpt

new/update mod_smtpd modules

2005-09-30 Thread Brian J. France
Here are some new or update mod_smtpd modules: http://www.brianfrance.com/software/apache/ mod_smtpd_auth.tar.gz: mod_smtpd_auth - core auth module mod_smtpd_authm_plain - auth method plain mod_smtpd_authm_login - auth method login mod_smtpd_authm_crammd5 - auth

Re: dbd connections tied to conn_rec

2005-09-30 Thread Brian J. France
Thanks for the work! I am having problems with it on the second connection, first connection works with multiple calls to ap_dbd_cacquire. I think it might have to do with allocating a dbd from the connection pool when it needs to be from the server pool for persist connections.

mod_smtpd_auth and mod_smtpd_auth_dbd

2005-09-27 Thread Brian J. France
Here are two modules I worked on last week while on a trip and ready for some discussion. mod_smtpd_auth mod_smtpd_auth_dbd http://www.brianfrance.com/software/apache/ mod_smtpd.patch will be needed which adds the auth hooks and info into the smtp rec. This patch also does a dns look up of

Re: mod_smtpd_access_dbd code review, mod_smtpd_auth plan

2005-09-14 Thread Brian J. France
On Sep 14, 2005, at 12:27 PM, Nick Kew wrote: But I see you're using ap_dbd_open and ap_dbd_close over the lifetime of a connection. This looks like a good reason to update mod_dbd to support a connection-lifetime variant on ap_dbd_acquire (which has request-lifetime). Ya, I wanted to use

mod_dbd

2005-09-09 Thread Brian J. France
Any reason why this patch couldn't be applied to allow the option of building mod_dbd? The title might need a little tweaking. Thanks, Brian - with no commit access Index: modules/experimental/config.m4 === ---

Re: mod_smtpd filter support

2005-08-30 Thread Brian J. France
I needed the following patch to get one of my modules to build: --- /usr/local/asf/include/mod_smtpd.h.orig Mon Aug 29 16:03:40 2005 +++ /usr/local/asf/include/mod_smtpd.h Mon Aug 29 16:03:55 2005 @@ -20,6 +20,7 @@ #include apr_pools.h #include apr_hash.h #include apr_file_io.h +#include

mod_smtpd module review

2005-08-30 Thread Brian J. France
This past week I have finished up a few modules and ready for review. http://www.brianfrance.com/software/apache/mod_smtpd_load.tar.gz mod_smtpd_load: This module allows rejecting connection (temporarily) based on server load It is not very cross platform (any os with getloadavg), but I am

Re: mod_smtpd overhaul

2005-08-23 Thread Brian J. France
On Aug 23, 2005, at 12:18 AM, Jem Berkes wrote: I noticed a couple posts about examples, there is now one as I have committed all the RBL stuff I wrote. See: https://svn.apache.org/repos/asf/httpd/mod_smtpd/trunk/mod_smtpd_rbl/ This hooks into mod_smtpd in two places and returns various data

Re: mod_smtpd overhaul

2005-08-22 Thread Brian J. France
Trying to build build a smtpd module, but having a problem. I added a line like this: smtpd_hook_connect( smtpd_access_dbi_connect, NULL, NULL, APR_HOOK_MIDDLE ); in the register_hooks function, but when I load the module I get undefined function _smtpd_hook_connect. Is this the right