On Thu, 18 Jan 2007, Giuliano Gavazzi wrote:
Actually I don't. Either you or me have misunderstood how buckets work,
since the rest of the code should syntactically be equivalent. Or I'm
missing some fine detail somewhere.
Perhaps I do not understand buckets fully (and brigades), but this see
On 17 Jan 2007, at 17:32, Niklas Edmundsson wrote:
patches! And I suppose now you agree that the extra indentation on
my patch stemmed from the broken nature of the original code!
Actually I don't. Either you or me have misunderstood how buckets
work, since the rest of the code should synt
On Wed, 17 Jan 2007, Giuliano Gavazzi wrote:
Is this in trunk or in 2.2.4 proper? You should probably ignore
mod_disk_cache on trunk until that situation is settled.
I could work on mod_disk_cache from 2.2.4 proper, and find what causes the
bug with SSI pages, but I do not see why I should
On 17 Jan 2007, at 16:06, Niklas Edmundsson wrote:
On Wed, 17 Jan 2007, Giuliano Gavazzi wrote:
rv = apr_file_seek(dobj->hfd, APR_SET, &off);
does not rewind if the file has been opened with
APR_FOPEN_BUFFERED. Now, I
This is an APR bug, I submitted a bug report for it a while
On Wed, 17 Jan 2007, Giuliano Gavazzi wrote:
rv = apr_file_seek(dobj->hfd, APR_SET, &off);
does not rewind if the file has been opened with APR_FOPEN_BUFFERED. Now, I
This is an APR bug, I submitted a bug report for it a while ago. I
worked around it by not using buffering at all a
On 17 Jan 2007, at 12:15, Giuliano Gavazzi wrote:
note that I am still calling store_headers, for it has side effects
(presumably the stuff you say it should do). But store_disk_headers
should not, unless it overwrites the headers when called again with
the correct size. But this is not th
On 17 Jan 2007, at 10:36, Niklas Edmundsson wrote:
On Wed, 17 Jan 2007, Giuliano Gavazzi wrote:
I have a solution for the r470455 mod_disk_cache not caching SSI.
There are two points where the module seems incorrect to me,
changing those makes it work:
[...]
First, don't reindent code when
On Wed, 17 Jan 2007, Giuliano Gavazzi wrote:
I have a solution for the r470455 mod_disk_cache not caching SSI.
There are two points where the module seems incorrect to me, changing those
makes it work:
Since you're talking about the code on trunk, you should be warned
that the current state
Here is the patch against r470455:
mod_disk_cache.c.r470455.patch
Description: Binary data
g
I have a solution for the r470455 mod_disk_cache not caching SSI.
There are two points where the module seems incorrect to me, changing
those makes it work:
1) in store_body the condition (!APR_BUCKET_IS_EOS(APR_BRIGADE_LAST
(bb))) was incorrectly stopping the flow from ever going past (for
10 matches
Mail list logo
