Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread William A Rowe Jr
On Fri, Jun 12, 2015 at 8:36 AM, Rainer Jung wrote: > Am 12.06.2015 um 13:49 schrieb Yann Ylavic: > >> Hi Christophe, >> >> On Fri, Jun 12, 2015 at 1:26 PM, Christophe JAILLET >> wrote: >> >>> >>> should this warning at startup be an issue, why not just remove it in >>> 2.4.x >>> and keep it in

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Rainer Jung
Am 12.06.2015 um 13:49 schrieb Yann Ylavic: Hi Christophe, On Fri, Jun 12, 2015 at 1:26 PM, Christophe JAILLET wrote: should this warning at startup be an issue, why not just remove it in 2.4.x and keep it in trunk? Having the depreciation written in doc (and in migration note for 2.4 -> 2.6/

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Yann Ylavic
On Fri, Jun 12, 2015 at 2:11 PM, Jeff Trawick wrote: > > IMHO the ap_retained_data_get/create APIs make this "nicer" than this older > pattern. Ah yes, good catch, I just did not think about it. > > retained = ap_retained_data_get(userdata_key); > if (!retained) { > retained = a

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 5:07 AM, wrote: > Author: ylavic > Date: Fri Jun 12 09:07:34 2015 > New Revision: 1685052 > > URL: http://svn.apache.org/r1685052 > Log: > mod_ssl: Warn about deprecated SSLCertificateChainFile once at startup, > on first usage only. > > Modified: > httpd/httpd/trunk/C

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Yann Ylavic
Hi Christophe, On Fri, Jun 12, 2015 at 1:26 PM, Christophe JAILLET wrote: > > should this warning at startup be an issue, why not just remove it in 2.4.x > and keep it in trunk? > Having the depreciation written in doc (and in migration note for 2.4 -> > 2.6/3.0 one day) could be enough, no? Pro

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Christophe JAILLET
Hi, should this warning at startup be an issue, why not just remove it in 2.4.x and keep it in trunk? Having the depreciation written in doc (and in migration note for 2.4 -> 2.6/3.0 one day) could be enough, no? BTW, the apr_pstrdup(ap_pglobal, "1") could be just "1". CJ Le 12/06/2015 11: