hi all
I was just in garrett's APR talk here at oscon and he was mentioning the
APR_STATUS_IS_SUCCESS macro, which I found interesting since httpd only uses
it in a few places, opting for a direct comparison to APR_SUCCESS instead.
should we move to APR_STATUS_IS_SUCCESS in all places? can
Geoffrey Young wrote:
hi all
I was just in garrett's APR talk here at oscon and he was mentioning the
APR_STATUS_IS_SUCCESS macro, which I found interesting since httpd only uses
it in a few places, opting for a direct comparison to APR_SUCCESS instead.
should we move to APR_STATUS_IS_SUCCESS in
cross-posted to [EMAIL PROTECTED]
Garrett Rooney wrote:
Geoffrey Young wrote:
hi all
I was just in garrett's APR talk here at oscon and he was mentioning the
APR_STATUS_IS_SUCCESS macro, which I found interesting since httpd
only uses
it in a few places, opting for a direct comparison to
The initial thought was you might have LDAP success, OS status success,
and possibly multiple return codes that were considered successes.
Nothing was ever done with this.
Bill
At 02:40 PM 7/28/2004, Garrett Rooney wrote:
Geoffrey Young wrote:
hi all
I was just in garrett's APR talk here at
William A. Rowe, Jr. wrote:
The initial thought was you might have LDAP success, OS status success,
and possibly multiple return codes that were considered successes.
Nothing was ever done with this.
What about the win32 definition of the macro:
#define APR_STATUS_IS_SUCCESS(s) ((s) ==
On Wed, Jul 28, 2004 at 08:08:05PM -0400, Ryan Bloom wrote:
Basically, the macro is wrong and needs to be removed. The contract
that _all_ APR API's live up to is that on a successful result, they
must return APR_SUCCESS. The reason we chose to use 0 as success is
simple:
Yup. The contract
Greg Stein wrote:
On Wed, Jul 28, 2004 at 08:08:05PM -0400, Ryan Bloom wrote:
Basically, the macro is wrong and needs to be removed. The contract
that _all_ APR API's live up to is that on a successful result, they
must return APR_SUCCESS. The reason we chose to use 0 as success is
simple:
Yup.
Basically, the macro is wrong and needs to be removed. The contract
that _all_ APR API's live up to is that on a successful result, they
must return APR_SUCCESS. The reason we chose to use 0 as success is
simple:
1) Most platforms can check for equality with 0 faster than they can
check for
