Re: [DISCUSS] Confuse default inspections.

2021-07-23 Thread Alex Plehanov
-0 for both proposals I agree with Ivan Daschinsky, we should not mix both approaches (interfaces with "public" keyword and without "public" keyword), but I see no big difference between "require public keyword in interfaces" rule and "prohibit public keyword in interfaces" rule. To switch from

Re: [DISCUSS] Confuse default inspections.

2021-07-21 Thread ткаленко кирилл
+1 20.07.2021, 23:06, "Юрий" : > I totally agree. > Let's get rid of them. > > вт, 20 июл. 2021 г. в 18:11, Konstantin Orlov : > >>  + for both >> >>  -- >>  Regards, >>  Konstantin Orlov >> >>  > On 20 Jul 2021, at 16:32, Pavel Tupitsyn wrote: >>  > >>  > Agree with for both points >>  > >>  >

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Юрий
I totally agree. Let's get rid of them. вт, 20 июл. 2021 г. в 18:11, Konstantin Orlov : > + for both > > -- > Regards, > Konstantin Orlov > > > > On 20 Jul 2021, at 16:32, Pavel Tupitsyn wrote: > > > > Agree with for both points > > > > On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev < >

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Konstantin Orlov
+ for both -- Regards, Konstantin Orlov > On 20 Jul 2021, at 16:32, Pavel Tupitsyn wrote: > > Agree with for both points > > On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev > wrote: > >> this is a very welcome change for me >> >> On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin >>

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Pavel Tupitsyn
Agree with for both points On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev wrote: > this is a very welcome change for me > > On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin > wrote: > > > + for both points. > > > > 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > > > Hi! > > > > > > Firstly,

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Alexander Polovtcev
this is a very welcome change for me On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin wrote: > + for both points. > > 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > > Hi! > > > > Firstly, lets talk about interfaces. > > > > 1. First of all, do we have an automatic inspection for it? AFAIK we >

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Ivan Pavlukhin
+ for both points. 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > Hi! > > Firstly, lets talk about interfaces. > > 1. First of all, do we have an automatic inspection for it? AFAIK we don't > 2. I am for consistency. At least for production code. Nothing worse is > when someone mixes both

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Ivan Daschinsky
Hi! Firstly, lets talk about interfaces. 1. First of all, do we have an automatic inspection for it? AFAIK we don't 2. I am for consistency. At least for production code. Nothing worse is when someone mixes both approaches. About a prohibition of curly brackets around one line -- I am strongly

[DISCUSS] Confuse default inspections.

2021-07-20 Thread Zhenya Stanilovsky
Igniters, i understand that this is very long and fundamental story. but …  still want to rise up this discussion, we have 2 very strange inspections: * «public» modifier in interface methods. * Illegal ‘{}’ for one line statement. — i found it harmful. I don`t want to link additional