Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-27 Thread Aleksandr Pakhomov
Roman, Thank you, that makes sense. > On 27 May 2022, at 14:26, Roman Puchkovskiy > wrote: > > Aleksandr, > > The thing is that `cluster init` is not just for setting some kind of > a configuration, it's more about doing cluster initialization > described in [1]. This init process

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-27 Thread Roman Puchkovskiy
Aleksandr, The thing is that `cluster init` is not just for setting some kind of a configuration, it's more about doing cluster initialization described in [1]. This init process transitions the cluster from 'empty' state to 'initialized state'; this can be only made once per cluster, and it has

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-27 Thread Aleksandr Pakhomov
Hi Roman, That is a good point. In the proposal I mean the analogue for existing ‘cluster init’. Maybe “distributed configuration” confuses you and probably I have to name it like “meta-storage” configuration or something like this. As for 'ignite init’ I think it would be more clearer if we

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-27 Thread Roman Puchkovskiy
Hi Aleksandr. There is a command named 'init' in your proposal. According to its description, it initializes the cluster with a distributed configuration. I'm not sure how it's mapped to the existing commands. The thing is that currently, there is `ignite init` command that initializes (actually,

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-25 Thread Andrey Gura
Aleksandr, Both proposed options look good to me because both cases assume that a user must express their intent explicitly. On Thu, May 19, 2022 at 10:53 AM Aleksandr Pakhomov wrote: > > I got it. What do you think about this proposal: > > - “ignite” prints help > - “ignite shell” enters

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-20 Thread Aleksandr Pakhomov
Hi Ilya, Thanks for the python usage example. AWS cli does not support interactive mode at all. Google too. Even Google Big query cli [1] executes sql queries without interactive shell. For REPL-first tools like Reql [2], ksqlDB CLI [3], or SnowSQL [4] it is common thing to enter the REPL

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-19 Thread Ilya Korol
From my perspective we should move towards existing UX approaches. For example: python - enters shell python --help  - prints help python -c - executes command What about other CLI tools that works with remote services? I can't remember properly but do AWS, openshift or maybe GCP CLIs also

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-19 Thread Aleksandr Pakhomov
I got it. What do you think about this proposal: - “ignite” prints help - “ignite shell” enters REPL Or - “ignite” prints help - “ignite-shell” enters REPL and it is a separate application I prefer the first varian but I would like to hear opinions of other community members. > On 19

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-18 Thread Andrey Gura
> 1. Does “Ignite shell” sounds better? I don't know. It could be Ignite REPL, IGnite Shell or something else. Just an idea. > But I did not get your point about scripting. What do you mean by saying “it > will just hang”? What kind of error is going to be the cause of such > behaviour? I

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-18 Thread Aleksandr Pakhomov
Hi, Andrey Thanks for comments. 1. Does “Ignite shell” sounds better? 2. Yes, you are right. Most tools print help if they are executed without arguments. But I did not get your point about scripting. What do you mean by saying “it will just hang”? What kind of error is going to be

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-18 Thread Andrey Gura
Hi, My two cents: 1. CLI Tool - looks like not the best name :) Shell? 2. The description says: "REPL mode is used by default and is activated if the ignite command is executed without parameters." I think it is a bad idea. Firstly, it is usual CLI's behaviour to print a help for a user. An

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-13 Thread Aleksandr Pakhomov
Hi Misha. Thank you for your valid points. I accept your suggestion about "ignite cli config get/set" naming. As for default commands, I think "clear" and "exit" are only for REPL mode and I'll add them to the description of the commands. "ignite help" is already defined there. > On 13 May

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-13 Thread Aleksandr Pakhomov
Hi Maxim. Thank you for your comments. - Yes, the non-interactive mode is supported for all commands except "connect", "disconnect", "status". - Benefits of using REST as a communication realization between CLI and Ignite 3 cluster: 1) This approach seems to be the de-facto standard for

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-13 Thread Mikhail Pochatkin
Hello, Sasha. The description looks good to me, only a few comments. 1. I would suggest renaming the CLI configuration command. Currently "ignite default get" and "ignite default set" look not informative. I understand that "ignite config" is already used for the Ignite configuration command and

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-13 Thread Maxim Muzafarov
Hello Aleksanrd, The description looks good. A few questions below: - Can the CLI also be run in non-interactive mode to support scripts execution (like the WildFly it does [1])? Will it be possible though the REST it used? - What is the benefits and drawbacks of using REST for this tool? Are

[DISCUSSION] IEP-88: CLI Tool

2022-05-12 Thread Aleksandr Pakhomov
Hello, Igniters. I’d like to start a discussion about Ignite 3 Command Line Tool [1]. The main value is to develop a user-friendly command-line tool with advanced completions and SQL REPL mode. The set of commands and parameters can be discussed. Questions and comments are welcomed. [1]