Re: Check Ignite code base with Findbugs.

On Mon, Nov 30, 2015 at 9:00 AM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > I think this is a great idea, however this exercise only makes sense if > FindBugs profile is plugged to CI and provides continuous checks for the > new code being committed. > … > Hopefully, somebody from

Re: Check Ignite code base with Findbugs.

I think this is a great idea, however this exercise only makes sense if FindBugs profile is plugged to CI and provides continuous checks for the new code being committed. Since Alexey K. already has some feedback for the first run, I will cooperate with him to create a minimal set of checks that

Re: Check Ignite code base with Findbugs.

On Tue, Nov 24, 2015 at 10:50AM, Alexey Kuznetsov wrote: > Igniters, > > I've installed FindBugs plugin for Idea and run it on ignite-core module. > > Well it found a lot... 1331 items... Better than 100500, eh? :) > Some of them are false-positive of course, but this plugin has quite handy >

Re: Check Ignite code base with Findbugs.

Cos, that was only ONE module checked :) And who knows what FindBugs will find when I start it over whole project. :) On Thu, Nov 26, 2015 at 9:31 AM, Konstantin Boudnik wrote: > On Tue, Nov 24, 2015 at 10:50AM, Alexey Kuznetsov wrote: > > Igniters, > > > > I've installed

Re: Check Ignite code base with Findbugs.

Ok, I will fix trivial issues and prepare report for most suspicious code. On Tue, Nov 24, 2015 at 4:34 PM, Yakov Zhdanov wrote: > Alex, if you have already run this test, can you please share the report > or, even more, fix vivid trivial issues right away and let us

Re: Check Ignite code base with Findbugs.

Igniters, I've installed FindBugs plugin for Idea and run it on ignite-core module. Well it found a lot... 1331 items... Some of them are false-positive of course, but this plugin has quite handy grouping and we could only check important groups like "Multithreading". Also FindBugs found a

Re: Check Ignite code base with Findbugs.

It absolutely does make sense. Of course it will not find complex bugs but it is pretty good at spotting stupid mistakes. Time ago I used to run Eclipse plugin for FindBugs, I believe something alike should exist for Idea as well. Sergi 2015-11-13 17:49 GMT+03:00 Alexey Kuznetsov

Re: Check Ignite code base with Findbugs.

I'd prefer to plug it into the Maven build: https://gleclaire.github.io/findbugs-maven-plugin/. *Raúl Kripalani* PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and Messaging Engineer http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani

Check Ignite code base with Findbugs.

Igniters, What do you think about checking Ignite code base with Findbugs ( http://findbugs.sourceforge.net)? Does it make sense? Maybe someone will try? Thoughts? -- Alexey Kuznetsov