Github user voipp closed the pull request at:
https://github.com/apache/ignite/pull/1545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Aleksey,
Thanks for your contribution! I've merged this PR into master branch.
See JIRA issue comment for details.
On Fri, Mar 10, 2017 at 2:58 PM, Andrey Gura wrote:
> Aleksey,
>
> I don't see any new changes. So I'll check TC and merge changes today.
>
> On Fri, Mar 10, 2017 at 10:20 AM, ALEKS
Aleksey,
I don't see any new changes. So I'll check TC and merge changes today.
On Fri, Mar 10, 2017 at 10:20 AM, ALEKSEY KUZNETSOV
wrote:
> Hi! Can u plz review ticket once more
>
> вт, 7 мар. 2017 г. в 18:52, Andrey Gura :
>
>> Aleksey, thanks a lot!
>>
>> Answered in JIRA ticket.
>>
>> On Tue
Hi! Can u plz review ticket once more
вт, 7 мар. 2017 г. в 18:52, Andrey Gura :
> Aleksey, thanks a lot!
>
> Answered in JIRA ticket.
>
> On Tue, Mar 7, 2017 at 1:27 PM, ALEKSEY KUZNETSOV
> wrote:
> > Hi! I have fixed all sources. Plz, review it again
> >
> > пн, 6 мар. 2017 г. в 15:43, Andrey G
Aleksey, thanks a lot!
Answered in JIRA ticket.
On Tue, Mar 7, 2017 at 1:27 PM, ALEKSEY KUZNETSOV
wrote:
> Hi! I have fixed all sources. Plz, review it again
>
> пн, 6 мар. 2017 г. в 15:43, Andrey Gura :
>
>> Aleksey, thanks!
>>
>> I answered in JIRA ticket.
>>
>> On Mon, Mar 6, 2017 at 10:56 AM
Hi! I have fixed all sources. Plz, review it again
пн, 6 мар. 2017 г. в 15:43, Andrey Gura :
> Aleksey, thanks!
>
> I answered in JIRA ticket.
>
> On Mon, Mar 6, 2017 at 10:56 AM, ALEKSEY KUZNETSOV
> wrote:
> > I've fixed the comments.
> > http://reviews.ignite.apache.org/ignite/review/IGNT-CR-9
Aleksey, thanks!
I answered in JIRA ticket.
On Mon, Mar 6, 2017 at 10:56 AM, ALEKSEY KUZNETSOV
wrote:
> I've fixed the comments.
> http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98
>
> пт, 3 мар. 2017 г. в 19:23, Andrey Gura :
>
>> Aleksey,
>>
>> GitHub isn't official review tool in Apac
I've fixed the comments.
http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98
пт, 3 мар. 2017 г. в 19:23, Andrey Gura :
> Aleksey,
>
> GitHub isn't official review tool in Apache Ignite community. There
> are two ways for code review: upsource and comments in JIRA tickets.
> So, I think, we
Aleksey,
GitHub isn't official review tool in Apache Ignite community. There
are two ways for code review: upsource and comments in JIRA tickets.
So, I think, we should finish review of this ticket in upsource.
On Thu, Mar 2, 2017 at 11:30 AM, ALEKSEY KUZNETSOV
wrote:
> lets review code at githu
Hi, Andrey! Have fixed the comments. Plz, Look up
чт, 2 мар. 2017 г. в 11:29, ALEKSEY KUZNETSOV :
> lets review code at github rather than upsource later on. Because, the
> later is too slow and bring no substantial benefits compared github
>
> ср, 1 мар. 2017 г. в 18:04, Andrey Gura :
>
> Hi, Al
lets review code at github rather than upsource later on. Because, the
later is too slow and bring no substantial benefits compared github
ср, 1 мар. 2017 г. в 18:04, Andrey Gura :
> Hi, Aleksey!
>
> Thank you for contribution!
>
> I've reviewed your changes and have some comments (mostly cosmeti
Hi, Aleksey!
Thank you for contribution!
I've reviewed your changes and have some comments (mostly cosmetic).
Could you please fix this comment? See review in Upsource for details.
On Tue, Feb 28, 2017 at 2:17 PM, ALEKSEY KUZNETSOV
wrote:
> Plz, review my PR :
> http://reviews.ignite.apache.org
Plz, review my PR :
http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98
or https://github.com/apache/ignite/pull/1545
--
*Best Regards,*
*Kuznetsov Aleksey*
Plz, review my PR :
http://reviews.ignite.apache.org/ignite/review/IGNT-CR-98
or https://github.com/apache/ignite/pull/1545
--
*Best Regards,*
*Kuznetsov Aleksey*
GitHub user voipp opened a pull request:
https://github.com/apache/ignite/pull/1545
IGNITE-2552 EvictionPolicies refactored, logic changed
tests are in subclasses of EvictionAbstractTest
You can merge this pull request into a Git repository by running:
$ git pull https
will take https://issues.apache.org/jira/browse/IGNITE-2552 if you dont mind
--
*Best Regards,*
*Kuznetsov Aleksey*
Denis Magda created IGNITE-2552:
---
Summary: Eviction policy must consider either max size or max
entries count
Key: IGNITE-2552
URL: https://issues.apache.org/jira/browse/IGNITE-2552
Project: Ignite
17 matches
Mail list logo
