Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-25 Thread Sergey Kozlov
> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > I value strict compatibility rules very highly, and would be > > > happy > > > > if > > > > > > we >

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-24 Thread Sergey
> in a minor release. > > > > > > > Unfortunately, Ignite is far from that place for now. We don’t > > have > > > > any > > > > > > > distinction between API and internal classes, don’t have > > > > > > > p

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-24 Thread Denis Magda
don’t have > > > > > > plugin-only APIs, etc. All classes are public, everything is > > > accessible > > > > > to > > > > > > user code. We even refer to internal classes in public Javadoc > > > > > > (e.g. I recall

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-24 Thread Sergey Kozlov
d there). > > > > > Considering this, moving CommandHandler from ignite-core to > > > > > ignite-control-utility > > > > > doesn't look that bad. It doesn’t differ to much from any other > > change > > > > > that

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-24 Thread Sergey Antonov
ing this, moving CommandHandler from ignite-core to > > > > ignite-control-utility > > > > doesn't look that bad. It doesn’t differ to much from any other > change > > > > that removes or renames a class. > > > > There could be required changes with a

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-24 Thread Alexey Kuznetsov
doesn’t differ to much from any other change > > > that removes or renames a class. > > > There could be required changes with a higher compatibility impact but > I > > > don’t see them after a superficial glance. > > > > > > Stan > > > > >

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-23 Thread Denis Magda
required changes with a higher compatibility impact but I > > don’t see them after a superficial glance. > > > > Stan > > > > From: Sergey Antonov > > Sent: 23 января 2019 г. 19:15 > > To: dev@ignite.apache.org > > Subject: Re: [DISCUSSION] Control.sh glo

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-23 Thread Sergey Kozlov
; From: Sergey Antonov > Sent: 23 января 2019 г. 19:15 > To: dev@ignite.apache.org > Subject: Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0 > > Stan, thank you for response! > > I my view we shouldn't make incompatible changes and switch extendable > classes (i.e.

RE: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-23 Thread Stanislav Lukyanov
Subject: Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0 Stan, thank you for response! I my view we shouldn't make incompatible changes and switch extendable classes (i.e. VisorDataTransferObject -> IgniteDataTransferObject) between minor releases. Therefore we couldn't rework util

Re: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-23 Thread Sergey Antonov
Stan, thank you for response! I my view we shouldn't make incompatible changes and switch extendable classes (i.e. VisorDataTransferObject -> IgniteDataTransferObject) between minor releases. Therefore we couldn't rework utility in 2.8 release. ср, 23 янв. 2019 г. в 18:48, Stanislav Lukyanov :

RE: [DISCUSSION] Control.sh global rework in apache ignite 3.0

2019-01-23 Thread Stanislav Lukyanov
Hi, Sounds good. I agree with all points so far. I don’t really see why to wait for 3.0 though. As long as the old commands work I think it’s fine to do all of that in a minor release. Even moving the code to a separate module is fine as all the classes are internal and unlikely to be used in