Re: Metrics for MVCC caches

2018-08-08 Thread Павлухин Иван
; discussion started? > > D. > > On Tue, Aug 7, 2018 at 9:17 AM, Павлухин Иван wrote: > > > Hi Igniters, > > > > I am working on cache metrics support for caches with enabled MVCC. As > you > > may know, during MVCC transaction execution entry versions are writ

Re: Ticket review checklist

2018-08-16 Thread Павлухин Иван
Vladimir, First of all, statements in Java 8 section [1] looks kind of prohibitive for me. When a new contributor see words "preferred" and "avoided in most cases" he most likely will not use such features (like I did). If a statement is not prohibitive in practice it could be at least rephrased.

Re: Metrics for MVCC caches

2018-08-16 Thread Павлухин Иван
are no matching keys in the > first remove() call should be found, remove() should return false and > "cache removals" metric should not be affected. > > 2018-08-10 12:56 GMT+03:00 Павлухин Иван : > > > Hi, > > > > Dmitriy thanks for note, I will keep

Metrics for MVCC caches

2018-08-07 Thread Павлухин Иван
Hi Igniters, I am working on cache metrics support for caches with enabled MVCC. As you may know, during MVCC transaction execution entry versions are written to storage right away (without deferring until commit). So, it is not obvious for me if we should update writes count right away or defer

Re: Metrics for MVCC caches

2018-08-10 Thread Павлухин Иван
is dirty writes as additional metrics. > > > > Also additional metrics concerning MVCC could be: > > > > - Average count of the active transactions per snapshot > > > > - Average quantity of versions per key > > > > > > -- > > > &

Re: Metrics for MVCC caches

2018-08-17 Thread Павлухин Иван
Hi team, I need you opinion again. I wrote some tests for metrics and felt a confusion with metrics count for the same key update during transaction. Imagine following case: BEGIN; INSERT INTO person(id, name) VALUES(1, 'ivan'); UPDATE person SET name = 'vanya' WHERE id = 1; COMMIT; My

Re: Ticket review checklist

2018-08-20 Thread Павлухин Иван
Sincerely, > Dmitriy Pavlov > > чт, 16 авг. 2018 г. в 12:09, Павлухин Иван : > > > Vladimir, > > > > First of all, statements in Java 8 section [1] looks kind of prohibitive > > for me. When a new contributor see words "preferred" and "avoided in

Re: Class field ThreadLocal. Why not static?

2018-09-11 Thread Павлухин Иван
Dmitriy, Could you point to some piece of code implementing described pattern? 2018-09-11 13:02 GMT+03:00 Павлухин Иван : > Alex, > > ThreadLocal subclass is used in IgniteH2Indexing for simple access to H2 > Connection from current thread. Such subclass has a capability to create

Re: Class field ThreadLocal. Why not static?

2018-09-11 Thread Павлухин Иван
Guys, As we know ThreadLocal is an instrument which should be used with great care. And I recently faced with problems related to proper cleanup of ThreadLocal which is not needed anymore. In my opinion the best thing (in ideal world) is to get rid of ThreadLocal where possible, but I guess that

Re: Class field ThreadLocal. Why not static?

2018-09-11 Thread Павлухин Иван
, 11 сент. 2018 г. в 9:13, Павлухин Иван : > > > Guys, > > > > As we know ThreadLocal is an instrument which should be used with great > > care. And I recently faced with problems related to proper cleanup of > > ThreadLocal which is not needed anymore. In my opini

Subscription

2018-07-10 Thread Павлухин Иван
Hi, Please subscribe me. -- Best regards, Ivan Pavlukhin

Re: MVCC and IgniteDataStreamer

2018-07-13 Thread Павлухин Иван
Hi Igniters, I had a look into IgniteDataStreamer. As far as I understand, currently it just works incorrectly for MVCC tables. It appears as a blocker for releasing MVCC. The simplest thing is to refuse creating streamer for MVCC tables. Next step could be hair splitting of related use cases.

Contribution

2018-07-12 Thread Павлухин Иван
Hi Igniters, I would like to start working on https://issues.apache.org/jira/browse/IGNITE-8581 My name in Jira is Pavlukhin -- Best regards, Ivan Pavlukhin

Re: Contribution

2018-07-12 Thread Павлухин Иван
://cwiki.apache.org/confluence/display/IGNITE/Development+Process > > Instructions on how to contribute can be found here: > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > > Project setup in Intellij IDEA: > https://cwiki.apache.org/confluence/display/IGNIT

Re: I want to contribute | Help Needed

2018-10-15 Thread Павлухин Иван
Hi Snigdhadeb, Welcome to Apache Ignite Community! Usually each contribution is related to a ticket in Jira https://issues.apache.org/jira/projects/IGNITE. Do you have such ticket already? To start working on a ticket you need to get a contributor rights to assign ticket to yourself. Please

Re: Applicability of term 'cache' to Apache Ignite

2018-10-18 Thread Павлухин Иван
HI all, +1 for "table" from me. For me "table" has several benefits: 1. It's common and consequently easy to explain and understand. 2. It's quite universal. One can worry that "table" does not describes key-value storage well. I don't see any problem here, because Hash Table data structure

Re: New TC builds adding process

2018-10-22 Thread Павлухин Иван
> > > > So we don't need to approve any change by discussion, but keeping > community > > member posted seems to be really helpful here. > > > > Currently, I don't know why and which suites were added. > > > > Sincerely, > > Dmitriy Pavlov > > >

Re: Abbreviation code-style requirement.

2018-10-22 Thread Павлухин Иван
Hi all, I also think that abbreviations should not be mandatory (point 3). But what I am worrying about is a conflict resolution between a patch submitter and a reviewer. How to come to an agreement when one side is strictly for and another side is strictly against using abbreviations in some

Re: [MTCGA]: new failures in builds [2123440] needs to be handled

2018-10-20 Thread Павлухин Иван
Hi Anton, I ran a problematic build against my contribution [1] and it seems to pass fine. Then I ran the build against your PR branch and it hanged [2]. There is nothing surprising that it fired only in master because the build was added to RunAll after your PR runs. Could you please take a

New TC builds adding process

2018-10-20 Thread Павлухин Иван
Hi Igniters, On Friday I felt a real inconvenience (pain in ass) with running builds for a ticked I worked on [1]. There were two the most frustrating moments: 1. Estimated build completion time was 11 hours after the start. 2. There are newly added suites which are failing constantly in recent

Re: Apache Ignite 2.7. Last Mile

2018-10-17 Thread Павлухин Иван
Hi NIkolay, Thank you for keeping everybody focused! Regarding to my ticket IGNITE-5935. It is in final stage now. Tests look good. I believe that it will be merged in couple of days (at most). ср, 17 окт. 2018 г. в 11:39, Nikolay Izhikov : > Hello, Igniters. > > 9 tickets to go! > > Alexey

Re: Pre-touch for Ignite off-heap memory

2018-10-24 Thread Павлухин Иван
Hi Alex, I wonder what problem you wish to solve. Pre-touching memory looks like a solution. But what is the problem? Am I getting it right that it is desired to avoid OOM (of some kind) in unpredictable moment of Ignite process execution? If so there could be number of ways to tackle it. I am

Re: Pre-touch for Ignite off-heap memory

2018-10-30 Thread Павлухин Иван
Hi guys, I am not aware that it is possible to run JVM in "allocation-free" fashion. If you know that it is possible please share it. As I know JVM allocates memory out of garbage collectable area for internal purposes like JIT, GC itself. Also native built-it code can request memory allocation

Re: Abbreviation code-style requirement.

2018-11-01 Thread Павлухин Иван
Hi Yakov and all, Recently I went through abbreviations list [1] to find items which are not clear for me. After the list was shortened by Yakov and others most of them have gone. But pay attention to "lic -> license". I cannot find usages of it in Ignite codebase? Could it be removed as well?

Re: Pre-touch for Ignite off-heap memory

2018-10-31 Thread Павлухин Иван
to observe JVM OOM-killed. [1] https://github.com/apache/ignite/pull/5220 [2] https://gist.github.com/pavlukhin/e5e6605e9b4366627ba8d1aab42f#file-hs_err_pid5763-log [3] https://gist.github.com/pavlukhin/e5e6605e9b4366627ba8d1aab42f#file-hs_err_pid6411-log вт, 30 окт. 2018 г. в 9:19, Павлухин

Re: Abbreviation code-style requirement.

2018-11-02 Thread Павлухин Иван
; to some project, it's ok to adopt that project rules. Moreover, reviewing > > committer can silently fix minor code style issues himself upon merge. > > > > пт, 2 нояб. 2018 г. в 10:08, Павлухин Иван : > > > > > Andrey, Yakov, > > > > > >

Re: Abbreviation code-style requirement.

2018-11-02 Thread Павлухин Иван
Andrey, Yakov, Actually my concert is more about one-time contributions. I imagine the following. Someone finds a bug a decides to contribute a fix. I think it is quite common scenario in Open Source. He creates a PR and awaits a review. I think that a smooth and fast review process will

Re: Is it time to move forward to JUnit4 (5)?

2018-11-08 Thread Павлухин Иван
Hi Oleg, Migrating to Junit 4 sounds as great idea. I believe everybody is quite surprised when finds Junit 3 in Ignite. But for me personally it is good to understand what problem we are trying to solve? What benefits will Junit 4 give us? What are the most painful moments with current testing

Re: Is it time to move forward to JUnit4 (5)?

2018-11-11 Thread Павлухин Иван
нояб. 2018 г. в 17:30, Павлухин Иван : > > Hi Oleg, > > I can outline some motivating ideas. There is no agreed solutions yet, > but junit4 might help us in reusing existing tests for improving MVCC > coverage. Another area is managing RunAll execution time with help >

Re: Time to remove automated messages from the devlist?

2018-11-15 Thread Павлухин Иван
Hi, In my opinion there should be only development discussions and important notifications on dev list. But I must say that I started to look through Jira and even GitHub notifications from time to time. And I find that it sometimes gives me a useful information like "contributor A is doing B".

Re: Time to remove automated messages from the devlist?

2018-11-16 Thread Павлухин Иван
Oleg, I join to Dmitriy. I found your summary quite interesting. пт, 16 нояб. 2018 г. в 13:12, Dmitriy Pavlov : > > Oleg, > > excellent research! It allows me to avoid bothering community developers > once again. > > Thank you for your efforts and for contributing to this discussion. > >

Re: Suggestion to improve deadlock detection

2018-11-14 Thread Павлухин Иван
Hi, Next part as promised. A working item for me is a deadlock detector for MVCC transactions [1]. The message is structured in 2 parts. First is an analysis of the current state of affairs and possible options to go. Second is a proposed option. First part is going to be not so short so some

Re: [DISCUSSION] The process of creating an Ignite Enhancement Proposal

2018-11-08 Thread Павлухин Иван
Hi Maxim, Single IEP per a major change looks desirable for me. But I have doubts that it is always feasible. Regarding naming. Could you please provide a couple of examples of inaccurate names and how they might have been improved? чт, 8 нояб. 2018 г. в 21:19, Maxim Muzafarov : > Vladimir, >

Re: Is it time to move forward to JUnit4 (5)?

2018-11-09 Thread Павлухин Иван
e how much > effort > could be involved in maintaining "twin" classes in sync (you are absolutely > right pointing that this is concerning). If it turns out too complicated to > sync we would probably switch to something like you have done in pull/5354 > > regards, Oleg &g

Re: [Discussion] revert of commit MVCC, ignite-9320

2018-09-28 Thread Павлухин Иван
Hi guys! By the way, is it practically feasible to revert a single commit without making harm? If I am getting it right in current case reverting commit will lead to compilation errors for commits depending on commit in question. 2018-09-28 14:22 GMT+03:00 Dmitriy Pavlov : > Hi Dmitriy S., > >

IgniteEvents for MVCC caches

2018-09-21 Thread Павлухин Иван
Hi Igniters, As you might know MVCC was introduced in Apache Ignite. We started IgniteEvents implementation for MVCC caches and faced some obstacles. I would like to start a discussion about next steps which should be done to deal with current problems. -- Best regards, Ivan Pavlukhin

Re: IgniteEvents for MVCC caches

2018-09-21 Thread Павлухин Иван
ently I do not see options how to overcome it. Also, I hardly imagine current use cases for cache events. I think that understanding them is the best way for developing working solution for MVCC. I need your opinions. 2018-09-21 12:54 GMT+03:00 Павлухин Иван : > Hi Igniters, > > As

Re: IgniteEvents for MVCC caches

2018-09-24 Thread Павлухин Иван
ittle value nowadays. Does anyone have something against deprecating > > > them? > > > > > > > > > These events are used in a pure caching or in-memory data grid use > cases > > > where key-value is a primary access pattern. I personally know s

Re: Suggestion to improve deadlock detection

2018-11-17 Thread Павлухин Иван
a is already researched throughly enough, so we should > be able to find an answer quickly. > > Vladimir. > > [1] http://www.cse.scu.edu/~jholliday/dd_9_16.htm > [2] https://www.cs.uic.edu/~ajayk/Chapter10.pdf > [3] > https://www.cs.utexas.edu/users/misra/scannedPdf.dir/D

Re: Time to remove automated messages from the devlist?

2018-11-16 Thread Павлухин Иван
hould never be redirected. Hopefully, it will not > > > generate any alerts. > > > > > > I hardly understand goal: is our target metric - message count to be as > > > less as possible? (extreme - 0 emails, let's not write here at all, we > > can

Re: Some problem with execution ignite.bat in master

2018-12-29 Thread Павлухин Иван
icket for version prior to 11? > > > > -- > > Denis > > > > On Fri, Dec 28, 2018 at 12:30 AM Павлухин Иван > > wrote: > > > > > AFAIK, "-J" is also a common way used by developers of the java > > > platform for passing JVM sys

Re: Suggestion to improve deadlock detection

2019-01-16 Thread Павлухин Иван
/IGNITE-9322 [2] https://dev.mysql.com/doc/refman/8.0/en/innodb-parameters.html#sysvar_innodb_lock_wait_timeout ср, 9 янв. 2019 г. в 09:47, Павлухин Иван : > > Hi, > > In continuation of discussion summarized in [1] I would like to > highlight some points related to avoidance of non-deadlocked > transac

Re: Is it time to move forward to JUnit4 (5)?

2019-01-23 Thread Павлухин Иван
Cheers! вт, 22 янв. 2019 г. в 20:19, oignatenko : > > ...sort of a follow-up. I gave folks a bit more leeway than originally > planned week or two. > > It's been about a month since master was changed in a way that wouldn't > allow JUnit 3 tests execute anymore (per IGNITE-10177) and I just

Re: Pre-touch for Ignite off-heap memory

2018-12-12 Thread Павлухин Иван
use > > off-heap as well as heap. > > So, we can implement a similar feature for Ignite – and make sure the users > > can get all the memory pre-touch benefits if they want. > > Of course, it impacts startup time so we should enable it by a > > configuration property (I’

Re: CONTRIBUTING.md first version

2018-12-12 Thread Павлухин Иван
Dmitriy, Thank you for your efforts! For me it looks exactly what is needed. Screenshot will tell everything for me (see hint at right) [1]. [1] https://gist.githubusercontent.com/pavlukhin/c8c7c6266eeab56048c31f5cdfb31d20/raw/a9af17d920a6eda4328c301023229c2ba6332d58/contr.png чт, 13 дек. 2018

Re: CONTRIBUTING.md first version

2018-12-12 Thread Павлухин Иван
(the link "contributing guidelines" on the screenshot refers to CONTRIBUTING.md) чт, 13 дек. 2018 г. в 08:50, Павлухин Иван : > > Dmitriy, > > Thank you for your efforts! For me it looks exactly what is needed. > Screenshot will tell everything for me (see hint at rig

Re: Is it time to move forward to JUnit4 (5)?

2018-12-12 Thread Павлухин Иван
re gives them a reason to prefer > other JUnit annotations over something else. It works about the same as I > described above for beforeTestsStarted in GridAbstractTest and how it > inhibited use of JUnit 3 methods: after you picked one part of some API it > naturally becomes mo

Re: Is it time to move forward to JUnit4 (5)?

2018-12-17 Thread Павлухин Иван
job. > > If a developer writing new test or reworking an old one follows the > deprecation recommendations they will use JUnit 4 way instead of deprecated > methods and you can see from the code that in this case LegacySupport will > just transparently pass-through the test code without in

Re: Pre-touch for Ignite off-heap memory

2018-12-18 Thread Павлухин Иван
stanlukya...@gmail.com > Subject: Re: Pre-touch for Ignite off-heap memory > > > > Bump. > > > > Stanislav, Ivan, can you answer my questions? > > Let's discuss these improvements. > > > > ср, 12 дек. 2018 г. в 22:14, Павлухин Иван : > > > > >

Re: Suggestion to improve deadlock detection

2018-12-18 Thread Павлухин Иван
ser messages but in big-O terms both approaches have the same complexity. Both correctness and complexity impact unfortunately have hardly predictable impact for real workflows. In ideal world thorough testing could give the answers. Please, share your vision. [1] https://issues.apache.org/jira/b

Re: Abbreviation code-style requirement.

2018-12-17 Thread Павлухин Иван
please check. > > I still feel we need to migrate code to ASF repo. I will try to do > something for that. > > Sincerely, > Dmitriy Pavlov > > пн, 17 дек. 2018 г. в 13:44, Павлухин Иван : > > > Hi, > > > > I did some investigation regarding scala support a

Re: Suggestion to improve deadlock detection

2018-12-20 Thread Павлухин Иван
8 г. в 15:51, Павлухин Иван : > > Igor, > > I see your points. And I agree to start with "lightweight > implementation". Today we have 2PL and there is no activity on > implementing rollback to savepoint. And if we do it in the future we > will have to return to the

Re: Clean up of our PRs and IEPs before 2019

2018-12-10 Thread Павлухин Иван
Nikolay, I must say that when I first saw 1K+ open PRs my first thought was that something was wrong with a review process. In my mind in not very big project open PR list can reflect very well the real work in progress. For bigger projects things become more complicated. Dmitriy, Do you have

Re: Clean up of our PRs and IEPs before 2019

2018-12-11 Thread Павлухин Иван
opened. > > > Apache Spark - 484 PR opened. > > > Apache Flink - 430 PR opened. > > > > > > В Вт, 11/12/2018 в 09:24 +0300, Pavel Tupitsyn пишет: > > > > Agree with Dmitriy. > > > > > > > > We use GitHub PRs in our workflow,

Re: Is it time to move forward to JUnit4 (5)?

2018-12-11 Thread Павлухин Иван
t; >> 2. Add @RunWith(JUnit4.class) annotation on test class. > > >> 3. Add @Before, @After on methods which should run before, after a > > >> test (setUp, tearDown in current approach). > > >> 4. Add your test-class to a suite using suite.addTest(new > > &g

Re: Is it time to move forward to JUnit4 (5)?

2018-12-17 Thread Павлухин Иван
> > Also, I used ML testsuite to debug the changes I made, because it contains > convenient mix of usecases and runs fast. > > Your feedback is much appreciated. > > regards, Oleg > > > Павлухин Иван wrote > > Hi guys, > > > > I started writing a junit4

Re: Page eviction for in-memory mode with enabled MVCC

2018-12-16 Thread Павлухин Иван
Roman, Thank you for pointing out usage as an in-memory cache. I will try to describe how do I see the use case. First of all our MVCC caches provides transactions. And a user will choose MVCC if his workflow is transactional. If a use case is a caching layer then some backing storage is

Re: Page eviction for in-memory mode with enabled MVCC

2018-12-14 Thread Павлухин Иван
Hi folks, I did not quite get what user problem we are trying to solve so far. The simplest thing which comes to my mind is to prohibit MVCC caches creation in a data region with eviction configured. What am I missing? Why do we need this feature today? чт, 13 дек. 2018 г. в 22:33, Vladimir

Re: Abbreviation code-style requirement.

2018-12-17 Thread Павлухин Иван
, Павлухин Иван : > > Vyacheslav, > > > PR looks good to me in general, but I've noticed a possible typo in > > the PR and Wiki: > > 'lable' -> 'label' > > Good catch! I updated a PR [1]. Could someone fix it on wiki or give > me rights to edit wiki? (my logi

Broken layout of Ignite javadoc on web

2018-12-17 Thread Павлухин Иван
Hi, I noticed that Ignite javadoc layout on web for latest versions has some problems. For example, I see no links near the "Class" at heading of the page [1]. Here is a screenshot [2]. Do you see the same? I was able to build javadoc on my machine. With current configuration I see the same

Re: Broken layout of Ignite javadoc on web

2018-12-17 Thread Павлухин Иван
e. I guess it is not a layout > is broken, but a style missing. > > Unfortunately, I don't know how to fix. Probably we should start research > from ignite/pom.xml:191 > > ${basedir}/assembly/docfiles/javadoc.css > > > пн, 17 дек. 2018 г. в 14:32, Павлухин Иван : > >

Re: Broken layout of Ignite javadoc on web

2018-12-24 Thread Павлухин Иван
/resources пн, 17 дек. 2018 г. в 16:38, Павлухин Иван : > > Dmitriy, > > Yep, it looks like the problem is inside assembly/docfiles/javadoc.css > > I will try to dig into some time later on a spare time. Of course, if > nobody fixes the problem earlier. > пн, 17 дек. 2018 г.

Re: Suggestion to improve deadlock detection

2018-12-24 Thread Павлухин Иван
ility to > change the behavior while development phase. > > [1] https://issues.apache.org/jira/browse/IGNITE-7966 > > Regards, > Igor > > чт, 20 дек. 2018 г. в 16:29, Павлухин Иван : > > > Hi, > > > > I prepared a patch with deadlock detection algorit

Re: Is it time to move forward to JUnit4 (5)?

2018-12-14 Thread Павлухин Иван
t method (overriding GridAbstractTest framework method) annotated with @Before annotation (I believe accidentally)! It means that migrating such test to junit4 will lead to calling beforeTest twice. Ouch! ср, 12 дек. 2018 г. в 13:21, Павлухин Иван : > > Hi Oleg, > > Thanks your for detailed

Async debugging in IDEA

2018-12-14 Thread Павлухин Иван
Hi Igniters, I would like to share with you that now it is possible to use IDEA async debugger for debugging Ignite futures. And we should thank Ivan Bessonov for that awesome contribution [1]. Most of your might be already familiar with async debugger in IDEA. For the rest I prepared two

Re: Abbreviation code-style requirement.

2018-12-15 Thread Павлухин Иван
Hi Dmitriy, Vyacheslav, I created a ticket [1] and PR [2] for updating a list of abbreviations used by the plugin. The changes in the plugin itself looks trivial. But some extra build and publish steps are required (see the ticket). Also if I understand it correctly plugin should be build with

Re: Abbreviation code-style requirement.

2018-12-15 Thread Павлухин Иван
the PR and Wiki: > 'lable' -> 'label' > > Also, according to the wiki, the following rules should be added: > 'topologyVersion' -> 'topVer' > 'regularExpression' -> 'regex' > > Am I miss something? > > On Sat, Dec 15, 2018 at 11:17 AM Павлухин Иван wrote: >> >&

Re: Abbreviation code-style requirement.

2018-12-20 Thread Павлухин Иван
Hi, I uploaded updated version of the plugin to community wiki [1]. [1] https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules пн, 17 дек. 2018 г. в 19:47, Павлухин Иван : > > Dmirity, > > Thank you! Permissions works for me. > > I will spend a while using a

Re: [NOTICE] List created: notificati...@ignite.apache.org

2018-11-30 Thread Павлухин Иван
Meanwhile some of us can subscribe for this list. пт, 30 нояб. 2018 г. в 19:09, Denis Magda : > > Yes, the messages have to be redirected. Talk to INFRA please. > > -- > Denis > > On Fri, Nov 30, 2018 at 7:12 AM Dmitriy Pavlov wrote: > > > Hi Eduard, > > > > could you please issue ticket similar

Re: Historical rebalance

2018-11-28 Thread Павлухин Иван
Hi, Regarding Vladimir's new idea. > We assume that transaction can be represented as a set of independent > operations, which are applied in the same order on both primary and backup > nodes. I have not got why we can assume that reordering is not possible. What have I missed? вт, 27 нояб.

Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)

2018-11-29 Thread Павлухин Иван
Hi Oleg, Thank you for the story. Now I see the concerns better. чт, 29 нояб. 2018 г. в 18:45, oignatenko : > > Hi Ivan, > > > Павлухин Иван wrote > > P.S. Did not really get what was the main problem related to > > IGNITE-10399 [1]. I suppose it should go: simple pr

Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)

2018-11-28 Thread Павлухин Иван
Hi Oleg, I am not ultimately sure that it will not do any harm. Red error highlights are designed to attract attention very well. I can imagine that I will be distracted by every unused import. While usually I rely on "Optimize imports" enabled in the commit dialog in IDEA. But I think that we

Re: Default failure handler was changed for tests

2018-12-05 Thread Павлухин Иван
better, just commit further improvements. And I will > be happy if you contribute some improvements later. > > If you would like to revert by veto, please justify your intent. If you > would discuss it with all community, please feel free to convince me and > others. > > ср, 5 дек

Re: Default failure handler was changed for tests

2018-12-05 Thread Павлухин Иван
Hi Anton, Could you please summarize what does aforementioned patch made really worse? As I see, the patch added a very good thing -- meaningful failure handler in tests. And I think it is really important. But was is the harm and does it overweight positive result? And why? ср, 5 дек. 2018 г. в

Re: JDBC thin driver: support connection timeout

2018-12-02 Thread Павлухин Иван
Hi Alexander, I have 2 points. 1. According to the jdbc spec [1] setNetworkTimeout method is optional. What user problem we are going to solve by implementing that method? 2. Also I checked another quite popular jdbc driver provided by MariaDB [2]. They ignore an executor argument as well and

Re: Is it time to move forward to JUnit4 (5)?

2018-12-03 Thread Павлухин Иван
Hi Oleg, I noticed that GridAbstractTest is now capable to run junit4 tests. What are the current recommendations for writing new tests? Can we use junit4 annotation for new tests? пн, 12 нояб. 2018 г. в 19:58, oignatenko : > > Hi Ivan, > > I am currently testing approach you used in pull/5354 in

Re: JDBC thin driver: support connection timeout

2018-12-02 Thread Павлухин Иван
Missing ref: [2] https://mvnrepository.com/artifact/org.mariadb.jdbc/mariadb-java-client/2.3.0 2018-12-02 18:31 GMT+03:00, Павлухин Иван : > Hi Alexander, > > I have 2 points. > > 1. According to the jdbc spec [1] setNetworkTimeout method is > optional. What user problem we

Re: Default failure handler was changed for tests

2018-12-05 Thread Павлухин Иван
; > >> > > > wrote: > >> > > > > > > > >> > > > > > > > Dmitriy, > >> > > > > > > > > >> > > > > > > > It's ok in case someone ready to do this (get rid of all > >> no-op > >>

Re: Default failure handler was changed for tests

2018-12-06 Thread Павлухин Иван
ks like a cheap refactoring. > > > > > > I don't agree with your term "cheap". > > > Do you think reducing copy paste code not worth it? > > > > > > I see a hundreds issues that bring copypasted code in the product(Ignite > > > and

Re: Default failure handler was changed for tests

2018-12-06 Thread Павлухин Иван
research. > > I'm ok with Nikolay approach in case that's not a final step. > > > > On Thu, Dec 6, 2018 at 12:11 PM Павлухин Иван wrote: > > > > > Nikolay, > > > > > > I meant "not expensive" by "cheap". And I meant that it i

Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)

2018-11-29 Thread Павлухин Иван
Hi Oleg, First of all I am not against giving it a try. Let's try it. P.S. Did not really get what was the main problem related to IGNITE-10399 [1]. I suppose it should go: simple problem -- fast fix. [1] https://issues.apache.org/jira/browse/IGNITE-10399 чт, 29 нояб. 2018 г. в 16:04,

Re: Partition Loss Policies issues

2018-11-30 Thread Павлухин Иван
Hi Stan, Thank you for revealing (at least for me) one more dark corner in Ignite. As I see from your analysis it looks like a partition loss policy should be taken into account in many places (persistence, different query types, different cache modes). And it seems that with multiple options to

Re: [VOTE] Apache Ignite 2.7.0 RC1

2018-11-30 Thread Павлухин Иван
+1 (accept Apache Ignite 2.7.0-RC1) пт, 30 нояб. 2018 г. в 13:43, Юрий : > > +1 > > пт, 30 нояб. 2018 г. в 13:25, Anton Vinogradov : > > > +1 > > > > пт, 30 нояб. 2018 г. в 10:05, Seliverstov Igor : > > > > > +1 > > > > > > пт, 30 нояб. 2018 г., 9:59 Nikolay Izhikov nizhi...@apache.org: > > > > >

Re: Brainstorm: Make TC Run All faster

2018-11-23 Thread Павлухин Иван
нояб. 2018 г. в 14:34, Павлухин Иван : > > Hi, > > I would like to understand following. We are going to make TC green. > We are going to make TC fast. Are we going to do it in parallel? > пн, 19 нояб. 2018 г. в 08:39, Petr Ivanov : > > > > Concerning current TeamCity

Re: Rename "cache group" to "tablespace"?

2018-11-22 Thread Павлухин Иван
Hi Vladimir, How do you see a default tablespace configuration in the "bright" future? Is it going to be a single file for an Ignite instance? In what cases will be there benefits to explicitly configure additional tablespaces? By the way was the name "tablespace" hand-crafted or it was it

Re: Suggestion to improve deadlock detection

2018-11-24 Thread Павлухин Иван
ed. May be something else. > > On Sun, Nov 18, 2018 at 10:21 AM Павлухин Иван wrote: > > > Vladimir, > > > > Thanks for the articles! I studied them and a couple of others. And I > > would like to shar

Re: [ANNOUNCE] Welcome Igor Seliverstov as a new committer

2018-11-20 Thread Павлухин Иван
Igor my congratulations! Keep going! 2018-11-20 9:01 GMT+01:00, Vladimir Ozerov : > The Apache Ignite Project Management Committee (PMC) has invited Igor > Seliverstov to become a new committer and are happy to announce that he has > accepted. > > Igor contributed a lot to "Transactional SQL"

Re: Time to remove automated messages from the devlist?

2018-11-21 Thread Павлухин Иван
> to receive these emails. > >> This is much more convenient and more flexible than filtering emails from > >> a > >> bot. > >> > >> So, most people ignore JIRA messages, and the ones who want to track new > >> tickets, > >>

Re: Ignite web console on kubernetes with ingress

2018-11-21 Thread Павлухин Иван
Hi Vishwas, Are you going to do some contribution related to your question? If not then you could ask the same question on u...@ignite.apache.org User list exists exactly for asking questions related to usability problems and most likely you will get an answer there. ср, 21 нояб. 2018 г. в 10:26,

Re: Historical rebalance

2018-11-26 Thread Павлухин Иван
Igor, Could you please clarify some points? > 1) preserve list of active txs, sorted by the time of their first update > (using WAL ptr of first WAL record in tx) Is this list maintained per transaction or per checkpoint (or per something else)? Why can't we track only oldest active

Re: [ANNOUNCE] Welcome Ilya Kasnacheev as a new committer

2018-11-27 Thread Павлухин Иван
Ilya, my congratulations! вт, 27 нояб. 2018 г. в 13:56, Dmitriy Pavlov : > > Dear Igniters, > > > > It is last but not least announce. The Apache Ignite Project Management > Committee (PMC) has invited Ilya Kasnacheev to become a new committer and > are happy to announce that he has accepted. > >

Re: proposed realization KILL QUERY command

2018-11-22 Thread Павлухин Иван
Hi, May be I am a little bit late with my thoughts about a command syntax. How do I see it is going to be used: 1. A user is able to kill a query by unique id belonging only to this query. 2. A user is able to kill all queries started by a specific node. For killing a single query we must

Re: Brainstorm: Make TC Run All faster

2018-11-19 Thread Павлухин Иван
Hi, I would like to understand following. We are going to make TC green. We are going to make TC fast. Are we going to do it in parallel? пн, 19 нояб. 2018 г. в 08:39, Petr Ivanov : > > Concerning current TeamCity compute capacity — I think we should invest into > it’s stability at first: there

Re: proposed realization KILL QUERY command

2018-11-26 Thread Павлухин Иван
3, 2018 at 9:32 AM Павлухин Иван wrote: > > > Hi, > > > > May be I am a little bit late with my thoughts about a command syntax. > > How do I see it is going to be used: > > 1. A user is able to kill a query by unique id belonging only to this > > query. > &

Re: [VOTE] Creation dedicated list for github notifiacations

2018-11-26 Thread Павлухин Иван
+1 вт, 27 нояб. 2018 г. в 09:22, Dmitrii Ryabov : > > 0 > вт, 27 нояб. 2018 г. в 02:33, Alexey Kuznetsov : > > > > +1 > > Do not forget notification from GitBox too! > > > > On Tue, Nov 27, 2018 at 2:20 AM Zhenya wrote: > > > > > +1, already make it by filers. > > > > > > > This was discussed

Re: Suggestion to improve deadlock detection

2018-11-26 Thread Павлухин Иван
request for the given pair (NODE_ID, COUNTER) should be requested at most > once. This way, even if specific deadlock check request is lost due to node > failure, and another deadlock has formed, then some other node will > re-trigger deadlock change request sooner or later, as it's counter >

Re: Brainstorm: Make TC Run All faster

2018-11-27 Thread Павлухин Иван
Roman, Do you have some expectations how faster "correlated" tests elimination will make Run All? Also do you have a vision how can we determine such "correlated" tests, can we do it relatively fast? But all in all, I am not sure that reducing a group of correlated tests to only one test can

Re: Historical rebalance

2018-11-28 Thread Павлухин Иван
ср, 28 нояб. 2018 г. в 13:26, Павлухин Иван : > > Hi, > > Regarding Vladimir's new idea. > > We assume that transaction can be represented as a set of independent > > operations, which are applied in the same order on both primary and backup > > nodes. &

Re: Historical rebalance

2018-11-28 Thread Павлухин Иван
to separate facilities providing transactions and durability. And it seems to me that those facilities are in different dimensions. ср, 28 нояб. 2018 г. в 16:26, Павлухин Иван : > > Sorry, if it was stated that a SINGLE transaction updates are applied > in a same order on all replicas th

Re: lost partition recovery with native persistence

2018-11-28 Thread Павлухин Иван
Hi Roman, Also you could check if your problem is mentioned in another discussion related to lost partitions [1]. [1] http://apache-ignite-developers.2346864.n4.nabble.com/Partition-Loss-Policies-issues-td37304.html ср, 28 нояб. 2018 г. в 19:31, novicr : > > Resending this to bubble up to the

  1   2   3   4   >