Re: IGNITE-6879

I agree that increasing complexity isn't good idea. Roman, can you document the migration guide? 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin : > Roman, Dmitry, > > I also reviewed the fix and the code looks OK to me. But the fix has > significant implication - Ignite

Re: IGNITE-6879

Hi! No, it wasn't a joke) 2018-04-04 11:22 GMT+03:00 Роман Меерсон <homich1...@gmail.com>: > Hi all! > I suppose Dmity`s message wasn`t april 1st joke) > So what about my PR? Would it be merged? > > вс, 1 апр. 2018 г. в 12:40, Дмитрий Рябов <somefire...@gmail.com>

Re: IGNITE-6879

gt;> HI Dmitriy, thank you! >> >> Roman, could you please address Dmitriy's comments? >> >> чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов <somefire...@gmail.com>: >> >>> Hi Dmitriy, >>> >>> I took a look for PR, it needs codestyle fixes. &g

Re: Transparent Data Encryption (TDE) in Apache Ignite

supported? > > > > > > > > > > > > > > > > Yes. > > > > > > > > > > > > > > > > TDE shouldn't broke any of existing Ignite features. > > > > > > > > It adds some encrypt/decrypt level when we writing and

Test 150 clients migrated to `Cache [6]` suite

Hello Igniters! I migrated test `IgniteCache150ClientsTest` from `150 Clients` suite to ` Cache [6]`, because `150 Clients` contains only one test class and makes ~6min excess Ignite build. So, test suites `150 Clients` and `~[Obsolete] 150 Clients` will be deleted soon.

Re: IGNITE-6879

Hi Dmitriy, I took a look for PR, it needs codestyle fixes. 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov : > Hi Alexey, > > Did you find the patch is looking good and is ready to be merged? > > Sincerely, > Dmitriy Pavlov > > чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin

Re: Ignite contibutors page

Hi Igniters! I'm not mentioned too. Dmitriy Ryabov. 2018-03-05 23:39 GMT+03:00 Denis Magda : > Hi Dmitriy, > > Thanks for kicking off the discussion. I'll wait for a couple of days for > other response and update the page in bulk. > > -- > Denis > > On Mon, Mar 5, 2018 at

Re: Transparent Data Encryption (TDE) in Apache Ignite

Hello, Igniters! I investigated the issue and wrote some details in a draft document [1]. I think we should made IEP for TDE because it is a big change and should be described in a single place, but not in a message conversation. Please, look it and write your thoughts. What is not

Re: Author in header of class

For the first profit you should see maintainer table [1]. [1] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers 2018-02-14 11:42 GMT+03:00 Vyacheslav Daradur : > Hi Anton, > > Apache Ignite is licensed under the

Re: Abandoned Patch Available JIRA tickets

Dmitry, there are 103 tickets for Cassandra [1] and 120 for Zookeeper [2]. [1] https://issues.apache.org/jira/browse/CASSANDRA-14132?jql=project%3Dcassandra%20AND%20status%3D"Patch%20Available"%20AND%20updated%20<%20-30d [2]

Re: Transparent Data Encryption (TDE) in Apache Ignite

Hi, Igniters! I think it would be nice to implement encryption in Ignite. Even SQLite and H2 have encryption so why Ignite don't have it? I'd like to propose a design for discussion. Configurations: IgniteConfiguration: - KeyStore tdeKeyStore - contain encryption keys. - Encryptor encryptor -

Re: [Review] IGNITE-4188: Savepoints support inside of Ignite Transactions

RA ticket: https://issues.apache.org/jira/browse/IGNITE-4188 GitHub PR: https://github.com/apache/ignite/pull/1815 Upsource PR: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-186 2017-05-24 11:08 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > Can anyone review it? > > Upsource

IGNITE-6826 is ready for review (Change default DiscoverySpi ipFinder type for examples)

Hello Igniters! I’ve changed default ipFinder in examples from multicast to static, so examples will run faster. Please, review. JIRA: https://issues.apache.org/jira/browse/IGNITE-6826 GitHub: https://github.com/apache/ignite/pull/3362 Upsource:

IGNITE-5136 is ready for review (GridLogThrottle memory leak)

Hello, igniters! I've done with this ticket, tests are ok. Can you review? JIRA: https://issues.apache.org/jira/browse/IGNITE-5136 PR: https://github.com/apache/ignite/pull/3236 Upsource (old changes): https://reviews.ignite.apache.org/ignite/review/IGNT-CR-344 Upsource (new changes):

Re: Switching Java language level to 8

+1 Agree, I think changes will be less difficult if we go through 7/8 -> 8 -> 8/9 than 7/8 -> 7/8/9 ( -> possible 7/8/9/10 huh?) -> 8/9. 2017-12-14 14:18 GMT+03:00 Anton Vinogradov : > +1 > Can we switch to Java8 right now and then support Java9? > That's the easiest way I think.

Re: IGNITE-4447 ready for review

Hello. Semyon, test passed. PR (squashed and merged with master): https://github.com/apache/ignite/pull/3204 CI tests: https://ci.ignite.apache.org/viewLog.html?buildId=993439=buildResultsDiv=Ignite20Tests_IgniteCache5 2017-05-19 4:46 GMT+03:00 Вадим Опольский : > Hi

IGNITE-6802 is ready for review (NullPointerException when WAL store and WAL archive paths are same )

Hello, Igniters! Please review. JIRA: https://issues.apache.org/jira/browse/IGNITE-6802 PR: https://github.com/apache/ignite/pull/3021/files Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-396 CI tests:

Re: Refactoring of IgniteKernal ack methods

IgniteKernal and some other classes have more places to refactor. At least for better readable form or to remove inner class [1]. May be create some tickets for refactoring such complex places? I mean to create main ticket like [2] or [3], and when someone see something complex *and* the way to

Re: Set default cache synchronization mode to FULL_SYNC

I mean "set readFromBackup = false" (copy-paste was bad idea). 2017-08-04 14:21 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > +1 to change PRIMARY_SYNC to FULL_SYNC. > > I think it is not reasonable to set readFromBackup=true by default, > especially for repli

Re: Set default cache synchronization mode to FULL_SYNC

+1 to change PRIMARY_SYNC to FULL_SYNC. I think it is not reasonable to set readFromBackup=true by default, especially for replicated caches, but FULL_SYNCE will keep cache in consistent state. 2017-08-04 13:23 GMT+03:00 Anton Vinogradov : > +1 to change PRIMARY_SYNC

Prepare works as it should work in JTA

Hi, guys. I've done IGNITE-4648, the idea was to improve prepare implementations, because async calls could hangs or fail if transaction state changes were not finished [1]. I modified internal transaction's prepare implementation, so now it wait for unfinished futures in transaction and added

Re: [Review] IGNITE-4648: IgniteInternalTx.prepare() does not wait for async operations to complete

:04 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > Hello, igniters, please review. > > JIRA: https://issues.apache.org/jira/browse/IGNITE-4648 > > PR: https://github.com/apache/ignite/pull/1876/files > > CI: http://ci.ignite.apache.org/viewLog.html?buildI

Re: daemon nodes

? > > Best Regards, > Dmitry Pavlov > > ср, 28 июн. 2017 г. в 12:19, Dmitriy Govorukhin < > dmitriy.govoruk...@gmail.com>: > > > What kind of messages are you talking about? Please, provide example. > > > > On Wed, Jun 28, 2017 at 11:54 AM, Дмитрий Рябов <some

Re: daemon nodes

Some messages don't go through clients. May be some daemon realization will need them? 2017-06-28 11:22 GMT+03:00 Dmitriy Govorukhin : > Dmitriy, > > Why daemon node may be server or client? Why it is not just daemon? I > guess if daemon " do not store data or >

Ready for review - IGNITE-2313 (fail atomic operations within a transaction)

Hello, please review. PR: https://github.com/apache/ignite/pull/1709/files JIRA: https://issues.apache.org/jira/browse/IGNITE-2313 CI: http://ci.ignite.apache.org/viewLog.html?buildId=675135=buildResultsDiv=Ignite20Tests_RunAll

Re: waiting for partition release question

May be let second node to finish join and enter the ring, but start rebalance after all lock will be released. 2017-05-19 12:30 GMT+03:00 ALEKSEY KUZNETSOV : > If we acquired a lock and a new node is joining cluster, should it wait for > lock release? > May be it could

[Review] IGNITE-4648: IgniteInternalTx.prepare() does not wait for async operations to complete

Hello, igniters, please review. JIRA: https://issues.apache.org/jira/browse/IGNITE-4648 PR: https://github.com/apache/ignite/pull/1876/files CI: http://ci.ignite.apache.org/viewLog.html?buildId=590583=buildResultsDiv=IgniteTests_RunAllTemp

Re: "Apache Ignite University”

Yep, we need it. 2017-04-20 23:48 GMT+03:00 Prachi Garg : > Great idea! +1 > > -P > > On Thu, Apr 20, 2017 at 1:35 PM, Tom Diederich > > wrote: > > > I’d also like to propose an enhancement to the community that I believe > > would be helpful to

[Review] IGNITE-4188: Savepoints support inside of Ignite Transactions

Hello, igniters. Can you look it? My solution is to save a snapshot of txState when user calls tx.savepoint("id") and replace current txState with saved state when user calls tx.rollbackToSavepoint("id"). JIRA: https://issues.apache.org/jira/browse/IGNITE-4188 PR:

When cache topology can be null?

One case is when node is down. Is there other cases?

Re: Question about cache and transaction on different nodes

on > another node "grid(1)". > So, technically, it is not nested transactions, right? > > On Wed, Apr 12, 2017 at 7:32 PM, Дмитрий Рябов <somefire...@gmail.com> > wrote: > > > Hello, igniters. I start the node and create a transactional cache on it, > > on

Question about cache and transaction on different nodes

Hello, igniters. I start the node and create a transactional cache on it, on the other node I start the transaction and "put" in previously created cache and rollback transaction. So what should I get? Value stored before transaction or inside rolled transaction? public void testRollback() throws

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

g>: > Dmitry, > > this review is in progress. But I'm confused about PR number because > in JIRA ticket we discussed PR 1631. What is actual PR number for > latest changes? > > On Mon, Apr 10, 2017 at 11:38 AM, Дмитрий Рябов <somefire...@gmail.com> > wrote: > >

GNITE-2313 - ready for review (fail atomic operations within a transaction)

Hello, igniters. Can you review it? We should finish it before 2.0. PR: https://github.com/apache/ignite/pull/1709/files JIRA: https://issues.apache.org/jira/browse/IGNITE-2313

Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

Hello, igniters. Please, review. PR: https://github.com/apache/ignite/pull/1630/files JIRA: https://issues.apache.org/jira/browse/IGNITE-4795

Re: IGNITE-4188, savepoints with atomic cache?

GMT+03:00 Denis Magda <dma...@apache.org>: > Sorry, I get lost in tickets. > > Yes, IGNITE-2313 has to be completed in 2.0 if we want to makes this > change. > > — > Denis > > > On Mar 29, 2017, at 2:12 AM, Дмитрий Рябов <somefire...@gmail.com> > wrote:

Re: IGNITE-2313 - ready for review

ode to fail atomic > operations within a transaction”. Please review it. > > Dmitriy R., there was a relevant discussion around the ticket. Would you > paste a link to it there? > > — > Denis > > > > On Apr 5, 2017, at 4:12 AM, Дмитрий Рябов <somefire...@gmail.com> wrot

IGNITE-2313 - ready for review

Hello, please review. PR: https://github.com/apache/ignite/pull/1709/files JIRA: https://issues.apache.org/jira/browse/IGNITE-2313 CI: http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_RatJavadoc_IgniteTests=pull%2F1709%2Fhead=buildTypeStatusDiv

Re: Ignite-4795 - ready for review

have a look at your changes soon. > Sorry for the delay. > > > > — > > Denis > > > >> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <somefire...@gmail.com> > wrote: > >> > >> Hello, can anyone review this issue? > >> > >> 201

IGNITE-4188: Savepoints support inside of Ignite Transactions, thoughts about realisation

Hello, community. Sam, Yakov, Alex G., can you look my decision? try (Transaction tx = ignite.transactions().txStart()) { c.put(1, 1); tx.savepoint("mysavepoint"); c.put(2, 2); tx.rollbackToSavepoint("mysavepoint"); c.put(3, 3); tx.commit(); } I want to make it in

IGNITE-4188, thoughts about realisation

Hello, community. try (Transaction tx = ignite.transactions().txStart()) { c.put(1, 1); tx.savepoint("mysavepoint"); c.put(2, 2); tx.rollbackToSavepoint("mysavepoint"); c.put(3, 3); tx.commit(); } I want to make it in such way: When user calls tx.savepoint(""),

Re: IGNITE-4188, savepoints with atomic cache?

Savepoints marked for 2.1, exceptions for 2.0. Do you want me to make exceptions first? 2017-03-29 11:24 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > Finish savepoints or flag for atomic operations? > Not sure about savepoints. Exceptions - yes. https://issues.apache. >

Re: IGNITE-4188, savepoints with atomic cache?

Finish savepoints or flag for atomic operations? Not sure about savepoints. Exceptions - yes. https://issues.apache.org/jira/browse/IGNITE-2313 isn't it? 2017-03-29 2:12 GMT+03:00 Denis Magda : > If we want to make the exception based approach the default one then the > task

Re: IGNITE-4188, savepoints with atomic cache?

I mean ignore it in savepoints and rollbacks to savepoints becouse transaction rollbacks already ignore it. 2017-03-28 18:10 GMT+03:00 Yakov Zhdanov : > Ignore atomicCache.put(k, v) if it is called inside transaction? This is > very counter intuitive. I am strongly against

IGNITE-4188, savepoints with atomic cache?

Hello, community. How should savepoint and rollback to savepoint react to the atomic caches inside transaction? I think they should ignore such entries, but I want to know opinion of more competent igniters. https://issues.apache.org/jira/browse/IGNITE-4188

Re: IgniteFuture adapters

e. > > On Mon, Mar 27, 2017 at 1:41 PM Дмитрий Рябов <somefire...@gmail.com> > wrote: > > > IgniteFuture have method > > > > public IgniteFuture chain(IgniteClosure, > T> > > doneCb); > > > > which do this. > > > > 2017-03-27

Re: IgniteFuture adapters

IgniteFuture have method public IgniteFuture chain(IgniteClosure, T> doneCb); which do this. 2017-03-27 13:30 GMT+03:00 Sergei Egorov : > Hi! > > Would be nice if igniteFuture would provide a small but very usable method: > > public R to(Function

Re: Ignite-4795 - ready for review

Hello, can anyone review this issue? 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > Done. > > 2017-03-20 16:30 GMT+03:00 Антон Чураев <churaev...@gmail.com>: > >> Dmitry, thank you! >> >> Could you please also change issue status to

Re: strange GridCacheReturn

Object with value and success flag. It is used in futures to understand what is result of asyncronious action. 2017-03-23 13:26 GMT+03:00 ALEKSEY KUZNETSOV : > Hi all! what is the use of GridCacheReturn ? > -- > > *Best Regards,* > > *Kuznetsov Aleksey* >

Re: Ignite-4795 - ready for review

Done. 2017-03-20 16:30 GMT+03:00 Антон Чураев <churaev...@gmail.com>: > Dmitry, thank you! > > Could you please also change issue status to "Patch available". > > 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > > > Hello, comm

Ignite-4795 - ready for review

Hello, community. Please, review and/or suggest something about javadocs of transactions. PR: https://github.com/apache/ignite/pull/1630/files JIRA: https://issues.apache.org/jira/browse/IGNITE-4795

Re: distributed transaction of non-single coordinator

ill > not call commit() and rollback() simultaneously? > - How do you make sure that either commit() or rollback() is called if an > originator failed? > > 2017-03-10 15:38 GMT+03:00 Дмитрий Рябов <somefire...@gmail.com>: > > > Alexey Goncharuk, heh, my initial understanding wa

Re: distributed transaction of non-single coordinator

Alexey Goncharuk, heh, my initial understanding was that transferring of tx ownership from one node to another will be happened automatically when originating node is gone down. 2017-03-10 15:36 GMT+03:00 ALEKSEY KUZNETSOV : > Im aiming to span transaction on multiple

IGNITE-1393 - ready for review

Hello. Please, review. https://issues.apache.org/jira/browse/IGNITE-1393 [Test] AssertionError when stop node executing transaction - GridCacheStopSelfTest

Re: [jira] [Created] (IGNITE-4794) Reconsider CachePeekMode.ONHEAP

Onheap will be changed? Where I can read plans about future versions? Is there anything except tickets? 2017-03-06 23:31 GMT+03:00 Denis Magda (JIRA) : > Denis Magda created IGNITE-4794: > --- > > Summary: Reconsider

IGNITE-1393 futures crash ignite when trying to get lock for stopped cache

The problem appears when future tries to finish itself and it trying to get lock when cache is already stopped. The only way to solve this issue is catching such assertion errors. At least, we are already catching some exceptions in the test. But what about real situation? Should I add catch

Re: IGNITE-4404 long running test refactoring - how to refactor?

I think we can keep this numbers for atomic behavior and decrease for transactional. But which tests can be replaced with mocks if they all use node's cache? 2017-02-22 12:47 GMT+03:00 Константин Дудков : > Answered to ticket. It's more about testing process than real refactoring

IGNITE-602 - ready for review

Hello. Please, review. https://issues.apache.org/jira/browse/IGNITE-602 [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion CI tests: http://ci.ignite.apache.org/project.html?projectId=IgniteTes ts_IgniteTests=pull%2F1558%2Fhead

IGNITE-4404 long running test refactoring - how to refactor?

Hello, community. Ticket description: in testTransform final int THREADS = 5; final int ITERATIONS_PER_THREAD = 10_000; So, what should I change? Other methods have final int THREADS = 5; final int ITERATIONS_PER_THREAD = iterations(); where iterations() {return 10_000;} Should I use

Re: IGNITE-602

; GridToStringBuilder, as we definitely do not want output to be flooded with > hashes, which are useless in common case. May be it makes sense to object's > position in already printed string. > > Vladimir. > > > On Wed, Feb 15, 2017 at 3:07 PM, Дмитрий Рябов <somefire...@gmail

IGNITE-602

Hello, can you answer me a simple question? We have 2 looping lists: ArrayList list1 = new ArrayList<>(); ArrayList list2 = new ArrayList<>(); list2.add(list1); list1.add(list2); Class GridToStringBuilder represent them into string. Simple public static String toString(Class cls, T obj)

Hello

Hello, I want to work with you. Can you give me access to contribute? My username in JIRA is SomeFire.