Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Den, Mentioned enum is removed in PR for IGNITE-4587 issue. This PR isn't merged into master branch yet. On Thu, Mar 30, 2017 at 1:40 PM, Denis Magda wrote: > Do we need to merge anything else to the master branch or you mean the enum > was removed with the rest of the

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Do we need to merge anything else to the master branch or you mean the enum was removed with the rest of the changes before and merged by Andrey G? — Denis > On Mar 30, 2017, at 5:16 AM, Kozlov Maxim wrote: > > + Denis > >> 30 марта 2017 г., в 12:14, Kozlov Maxim

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

+ Denis > 30 марта 2017 г., в 12:14, Kozlov Maxim написал(а): > > Denis, > > CacheAtomicWriteOrderMode enum already removed. > >> 30 марта 2017 г., в 7:38, Denis Magda написал(а): >> >> Maxim, Andrey G., Igniters, >> >> What if go further and

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Denis, CacheAtomicWriteOrderMode enum already removed. > 30 марта 2017 г., в 7:38, Denis Magda написал(а): > > Maxim, Andrey G., Igniters, > > What if go further and remove CacheAtomicWriteOrderMode enum from the public > API at all? I see no sense to keep it for the only

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, Andrey G., Igniters, What if go further and remove CacheAtomicWriteOrderMode enum from the public API at all? I see no sense to keep it for the only one option left - PRIMARY. Any objections? — Denis > On Feb 27, 2017, at 8:09 AM, Kozlov Maxim wrote: > > Hi

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Hi igniters, GridDhtAtomicCache class isFastMap method always returns false now. Do you think you need to remove it? > 14 марта 2017 г., в 14:30, Andrey Gura написал(а): > > I've added comments about IgniteConfiguration to JIRA ticket. > > On Tue, Mar 14, 2017 at 2:06

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

I've added comments about IgniteConfiguration to JIRA ticket. On Tue, Mar 14, 2017 at 2:06 PM, Alexey Kuznetsov wrote: > Maxim, > > I managed to review Web Console part in your PR. > Looks good for me. > > But it seems that you also should delete following properties on

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, Could you merge master to your PR? I failed to review Web Console files due to conflicts. Thanks. On Fri, Mar 10, 2017 at 3:06 PM, Kozlov Maxim wrote: > Andrey, Alexey, please review > PR - https://github.com/apache/ignite/pull/1521 < >

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Well, looks like only committers can edit the pages. Could you prepare the content and paste it here? I’ll update the migration guide for you. — Denis > On Mar 13, 2017, at 9:59 AM, Kozlov Maxim wrote: > > No, I can not edit other pages. > > Screenshots menu: >

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

No, I can not edit other pages. Screenshots menu: https://www.dropbox.com/s/hbhuk3tci7k77qr/%D0%A1%D0%BA%D1%80%D0%B8%D0%BD%D1%88%D0%BE%D1%82%202017-03-13%2019.51.30.png?dl=0 https://www.dropbox.com/s/43nr384icfb6xwp/%D0%A1%D0%BA%D1%80%D0%B8%D0%BD%D1%88%D0%BE%D1%82%202017-03-13%2019.50.24.png?dl=0

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Weird, can you edit any other page? I can’t find any configuration parameters that should prevent you from editing. — Denis > On Mar 13, 2017, at 9:14 AM, Kozlov Maxim wrote: > > Denis, I can not edit this page. > > confluence username: dreamx > >> 13 марта 2017 г., в

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Denis, I can not edit this page. confluence username: dreamx > 13 марта 2017 г., в 19:01, Kozlov Maxim написал(а): > > Denis, > > ok > >> 13 марта 2017 г., в 18:59, Denis Magda > > написал(а): >> >> Maxim, >> >> Please

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Denis, ok > 13 марта 2017 г., в 18:59, Denis Magda написал(а): > > Maxim, > > Please update Apache Ignite 2.0 migration guide: > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide > >

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, Please update Apache Ignite 2.0 migration guide: https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide You need to say that the parameter has been discontinued and the

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

I took a look at .NET and C++ parts. Looks good to me. Best Regards, Igor On Mon, Mar 13, 2017 at 2:35 PM, Alexey Kuznetsov wrote: > I will also take a look for Web Console changes tomorrow. > > On Fri, Mar 10, 2017 at 5:00 PM, Andrey Gura wrote: > >

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

I will also take a look for Web Console changes tomorrow. On Fri, Mar 10, 2017 at 5:00 PM, Andrey Gura wrote: > Maxim, > > I'll take a look today. > > 10 марта 2017 г. 11:06 AM пользователь "Kozlov Maxim" < > dreamx@gmail.com> > написал: > > > Andrey, Alexey, please

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, I'll take a look today. 10 марта 2017 г. 11:06 AM пользователь "Kozlov Maxim" написал: > Andrey, Alexey, please review > PR - https://github.com/apache/ignite/pull/1521 < > https://github.com/apache/ignite/pull/1521> > tests -

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, all GridClockSyncProcessor related code should be remove (objects, messages, etc) On Tue, Mar 7, 2017 at 12:23 PM, Kozlov Maxim wrote: > Andrey, or better remove GridTimeSyncProcessorSelfTest class? > >> 7 марта 2017 г., в 12:21, Kozlov Maxim

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Andrey, or better remove GridTimeSyncProcessorSelfTest class? > 7 марта 2017 г., в 12:21, Kozlov Maxim написал(а): > > Andrey, in GridTimeSyncProcessorSelfTest class methods: testTimeSync() and > testTimeSyncChangeCoordinator() also removed? > > >> 6 марта 2017 г., в

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, About SER_VER_COMPARATOR. You can use code branch that executes when times are equal: int nodeOrder1 = ver1.nodeOrder(); int nodeOrder2 = ver2.nodeOrder(); if (nodeOrder1 == nodeOrder2) { long order1 = ver1.order(); long order2 = ver2.order(); assert order1 != order2;

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

ok, in GridCacheAtomicVersionComparator class, method compare(GridCacheVersion one, GridCacheVersion other, boolean ignoreTime) if (globalTime == otherGlobalTime || ignoreTime) { // => if (ignoreTime) { . } else return globalTime > otherGlobalTime ? 1 : -1; // => return -1; and,

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, updateTime() method should be removed. On Mon, Mar 6, 2017 at 12:12 PM, Kozlov Maxim wrote: > In CacheEntryImplEx class use ver.globalTime() in > > @Override public long updateTime() { > return ver.globalTime(); > } > > Than is better to replace this variable? >

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

In CacheEntryImplEx class use ver.globalTime() in @Override public long updateTime() { return ver.globalTime(); } Than is better to replace this variable? > 3 марта 2017 г., в 19:19, Andrey Gura написал(а): > > Maxim, > > I think the next implementation will be good

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, I think the next implementation will be good enough: public IgniteUuid asGridUuid() { return new IgniteUuid(new UUID(nodeOrderDrId, topVer), order); } Serialization/deserialization of GridCacheVersion.globalTime field should be removed. On Fri, Mar 3, 2017 at 5:57 PM, Kozlov Maxim

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Alexey, public IgniteUuid asGridUuid() { return new IgniteUuid(new UUID(nodeOrderDrId << 32, topVer << 32), order); } So you want to change or not? And - GridCacheVersion.writeTo(ByteBuffer buf, MessageWriter writer) - GridCacheVersion.readFrom(ByteBuffer buf, MessageReader reader) use

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

+1 Removing of asGridUuid() method can lead to much code changes but it should be avoided on this step. On Thu, Mar 2, 2017 at 4:56 PM, Alexey Goncharuk wrote: > Maxim, > > I see several usages of asGridUuid() method, so I would just remove global > time and use

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, I see several usages of asGridUuid() method, so I would just remove global time and use nodeOrderDrId and topVer as different parts of high and low parts of the embedded UUID. --AG 2017-03-02 12:39 GMT+03:00 Kozlov Maxim : > Andrey, > > When removed parameter

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Andrey, When removed parameter globalTime, in method: public IgniteUuid asGridUuid() { return new IgniteUuid(new UUID(((long)topVer << 32) | nodeOrderDrId, globalTime), order); } globalTime parameter replaced by something or remove this method? > 2 марта 2017 г., в 12:07, Kozlov Maxim

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Andrey, Please review PR again. > 1 марта 2017 г., в 18:47, Andrey Gura написал(а): > > I think that it is ok. > > On Wed, Mar 1, 2017 at 6:34 PM, Kozlov Maxim wrote: >> Ok. What do you say for the rest? >> >>> 1 марта 2017 г., в 18:15, Andrey Gura

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

I think that it is ok. On Wed, Mar 1, 2017 at 6:34 PM, Kozlov Maxim wrote: > Ok. What do you say for the rest? > >> 1 марта 2017 г., в 18:15, Andrey Gura написал(а): >> >> Maxim, >> >> I think that during renaming we should not lose "Atomic" prefix. >> >>

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, I think that during renaming we should not lose "Atomic" prefix. On Wed, Mar 1, 2017 at 5:16 PM, Kozlov Maxim wrote: > Andrey, ok. > > Also remove in the modules/platform/dotnet CacheAtomicWriteOrderMode.cs? > > Rename classes: > >

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

No, it should be removed. If somebody use entry last update time (e.g. for conflict resolving) they should store this time as entry field. On Wed, Mar 1, 2017 at 12:57 AM, Dmitriy Setrakyan wrote: > Do we still need GridClockSyncProcessor? > > On Tue, Feb 28, 2017 at 5:26

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Do we still need GridClockSyncProcessor? On Tue, Feb 28, 2017 at 5:26 AM, Andrey Gura wrote: > Maxim, > > Yes, this setting doesn't make sense anymore. So we need remove all > related methods. > > Also there is component called GridClockSyncProcessor that also should > be

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Maxim, Yes, this setting doesn't make sense anymore. So we need remove all related methods. Also there is component called GridClockSyncProcessor that also should be removed. It will lead to removing globalTime field from GridCacheVersion class and some related methods. On Tue, Feb 28, 2017 at

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Valentin, Then there is no need for setting CacheConfiguration.atomicWriteOrderMode. What do you think, remove it and and related methods? > 28 февр. 2017 г., в 2:49, Valentin Kulichenko > написал(а): > > Hi Max, > > In case we remove the CLOCK mode, I think

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

Hi Max, In case we remove the CLOCK mode, I think we should remove the enum too, as well as configuration properties and other code using this enum. Having enum with one value doesn't make sense to me. -Val On Mon, Feb 27, 2017 at 5:09 AM, Kozlov Maxim wrote: > Hi

Remove CacheAtomicWriteOrderMode.CLOCK mode.

Hi Igniters, After remove CLOCK mode, CacheAtomicWriteOrderMode enum contains now only one value PRIMARY. Andrey Gura, proposition remove CacheAtomicWriteOrderMode enum. Will there be something special for this purpose is enum? jira: https://issues.apache.org/jira/browse/IGNITE-4587

[jira] [Created] (IGNITE-4587) Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode

Denis Magda created IGNITE-4587: --- Summary: Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode Key: IGNITE-4587 URL: https://issues.apache.org/jira/browse/IGNITE-4587 Project: Ignite