Re: Using Gerrit drafts

I haven't looked at your edits. I was responding to Phil's comment that I quoted. On Thu, Oct 19, 2017 at 1:08 PM, Jim Apple wrote: > I'm surprised my edits gave you the impression that I think people should > not review their code before asking for peer review. > > On Thu,

Re: Using Gerrit drafts

I'm surprised my edits gave you the impression that I think people should not review their code before asking for peer review. On Thu, Oct 19, 2017 at 1:06 PM, Daniel Hecht wrote: > I think it's a good idea for everyone to review their own code before > asking for a peer

Re: Using Gerrit drafts

I think it's a good idea for everyone to review their own code before asking for a peer review. A lot of style nits, etc can be addressed before the first peer review iteration that way. On Thu, Oct 19, 2017 at 11:44 AM, Philip Zeyliger wrote: > I think it's a good idea

Re: Using Gerrit drafts

Sorry, didn't mean "workflow", mean "repo". On Thu, Oct 19, 2017 at 11:54 AM, Jim Apple wrote: > In between when I saw the edit and when I saw this email, I re-edited. > Please fell free to re-edit again. Mostly I didn't want "Publish" to sound > like it was going to be

Re: Using Gerrit drafts

In between when I saw the edit and when I saw this email, I re-edited. Please fell free to re-edit again. Mostly I didn't want "Publish" to sound like it was going to be part of the workflow, but I also made drafts the second suggestion, because I would expect gerrit newbies to publish there too

Re: Using Gerrit drafts

On Thu, Oct 19, 2017 at 10:50 AM, Daniel Hecht wrote: > Add this info to > https://cwiki.apache.org/confluence/display/IMPALA/ > Using+Gerrit+to+submit+and+review+patches > if not already there? Thanks for the suggestion. I updated

Re: Using Gerrit drafts

Gerrit is replacing them with something called "private changes". https://gerrit-review.googlesource.com/Documentation/intro-user.html#private-changes. They look equivalent to me, with slightly different syntax. On Thu, Oct 19, 2017 at 11:26 AM, John Russell wrote: > I

Re: Using Gerrit drafts

I had a problem accessing my existing drafts after a recent upgrade to gerrit. Somehow after the upgrade, it became much more important to use the ‘ssh’ method instead of ‘http’ in that pulldown where you see the Download / Pull / etc. commands. In the course of resolving that problem, I

Re: Using Gerrit drafts

Add this info to https://cwiki.apache.org/confluence/display/IMPALA/Using+Gerrit+to+submit+and+review+patches if not already there? On Thu, Oct 19, 2017 at 10:41 AM, Tim Armstrong wrote: > I thought subsequent drafts were only visible to reviewers (in general > drafts

Re: Using Gerrit drafts

I thought subsequent drafts were only visible to reviewers (in general drafts are visible to any reviewers you add to the patch). At least on older versions of gerrit if you pushed out a draft to a published patchset, a notification email was sent out but the updated patchset was invisible to

Re: Using Gerrit drafts

Note, that publishing cannot be undone. In particular, after you published a change, subsequent pushes to refs/drafts will be public patch sets, too. On Oct 19, 2017 09:34, "Philip Zeyliger" wrote: Hey folks, This wasn't obvious for me, so I figured I'd share it. If you

Using Gerrit drafts

Hey folks, This wasn't obvious for me, so I figured I'd share it. If you want to review your Gerrit changes on the Gerrit UI before sending e-mail to the community, you can run something like: git push asf-gerrit HEAD:refs/drafts/master This will give you a URL that you can browse to, and you

New Impala contributors: IMPALA-5314

If you'd like to contribute a patch to Impala, but aren't sure what you want to work on, you can look at Impala's newbie issues: https://issues.apache.org/jira/issues/?filter=12341668. You can find detailed instructions on submitting patches at

Re: New Impala contributors: outreach

I am going to also start adding to https://helpwanted.apache.org/, now that https://issues.apache.org/jira/browse/COMDEV-225 is fixed. Here is the first one: https://helpwanted.apache.org/task.html?3cb146d3a253d0dd1f951c151b37f7e8e8fc97c7 On Wed, Sep 6, 2017 at 3:01 PM, Jim Apple