Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Willem Jiang
Hi Xiangdong, I think it's quite import of the PPMC to run some tests or sample code on the release kit to make sure the kit is in good shape. It can give the IPMC some confidence when them send out their vote. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 7, 2019 at 9:34 PM Xia

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Christofer Dutz
I consider it even less than minor ... no worries ;-) Am 07.08.19, 15:59 schrieb "Julian Feinauer" : Hi, I myself consider this "minor" so I suggest to keep that for the next release (we can always do a 0.8.1, if we feel like). From my perspective, we fixed a lot of stuff and a

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Boris Zhu
Hi, I agree with Julian Feinauer, it's just a minor change. Boris On Wed, Aug 7, 2019 at 9:59 PM Julian Feinauer wrote: > Hi, > > I myself consider this "minor" so I suggest to keep that for the next > release (we can always do a 0.8.1, if we feel like). > From my perspective, we fixed a lot o

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Julian Feinauer
Hi, I myself consider this "minor" so I suggest to keep that for the next release (we can always do a 0.8.1, if we feel like). From my perspective, we fixed a lot of stuff and are "pretty mature" (with regards to how we started) but theres still a way to go. But of course, its up to everybody t

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Christofer Dutz
I was referring to the README in the last RC to be the one of the source distribution. I was suggesting to create a README-binary with instructions on how to use the binary and to include that instead of the source one in the binary distribution. By the way ... we could also move the NOTICE-bina

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Xiangdong Huang
Hi Zhu, Thanks for your PR! I address a minor change request for the PR. After fixing that, I think the PR can be merged :D Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Xiangdong Huang 于2019年8月7日周三 下午9:02写道: > Hi, > > Thanks

Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Xiangdong Huang
Hi, +1 PPMC vote I checked: - Build source bundle (mvn clean package) - Checked the zip file in distribution/target, server/target, client/target, grafana/target. All generated bin files work well. - checked bin.zip file. Minor issue: - do we need to remove LICENSE-binary and NOTICE-binary fi

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Julian Feinauer
Hi Boris, thanks fort he comment. I think there is an important subtility in there. As we as ASF only provide source releases, the README should still point to that instruction. But on the homepage (where we'll have to place a download link) we can also write how to run the binaries. For every

Re: [DISCUSS] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Boris Zhu
After this PR, https://github.com/apache/incubator-iotdb/pull/332, I think we should rewrite some documents as Chris Dutz suggests, especially readme.md and quickstart. I remember quickstart requires users to compile source code then use it instead of using binary dire

Re: [VOTE] Apache IoTDB (Incubating) 0.8.0 RC3

2019-08-07 Thread Julian Feinauer
Hi, my vote is +1 (non-binding) PPMC Vote but also +1 (binding) IPMC Vote (as I think the best practice is nowadays to also report IPMC Votes that where cast during PPMC Vote). I checked: - Downloaded staged artefacts - Validated Hases and Signatures - Build source bundle (mvn clean verify) -