db.apache.org"
> 抄送:
> 主题: Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
>
> Hi Justin,
>
> Sure, we could do that, but I just wanted to point out that your -1 for that
> wasn't justified ;-)
> If the file is replaced, it would need to be mentioned.
>
Hi Justin,
Sure, we could do that, but I just wanted to point out that your -1 for that
wasn't justified ;-)
If the file is replaced, it would need to be mentioned.
Chris
Am 20.11.19, 09:38 schrieb "Justin Mclean" :
Hi,
> But thanks for pointing that out ... I should fix at
Hi,
> But thanks for pointing that out ... I should fix at least the typos ... and
> update to the latest Maven-Wrapper version ;-)
Why not use their latest? It’s already listed in LICENSE so all you would need
to do is replace the file with the latest.
Thanks,
Justin
Hi Justin,
If you compare the two you will see that none of the changes applied to the
file in the original one are contained in the version I put there.
So it IS the original file I put there.
But thanks for pointing that out ... I should fix at least the typos ... and
update to the latest
Hi,
> Given that I wrote every line of that code, I'm allowed to stick whatever
> header I want on it.
Are you 100% sure about that for this version of the file? if it was copied
from here [1] and it’s the latest then there are 4 contributors to that file
over 20 odd commits.
Thanks,
Justin
Hi Justin,
Given that I wrote every line of that code, I'm allowed to stick whatever
header I want on it.
Please let me be clear: I'm only talking about the Java file.
Chris
Am 19.11.19, 10:57 schrieb "Justin Mclean" :
Hi,
Given the priject is not an ASF one why would it have
Hi,
Given the priject is not an ASF one why would it have an ASF header?
Thanks,
Justin
On Tue, 19 Nov 2019, 19:52 Christofer Dutz,
wrote:
> Hi Justin,
>
> this is a file I personally wrote and submitted to the maven-wrapper
> project.
> So technically it could have the Apache header ...
Hi Chris,
So, sounds that we need to remove the declaration in the LICENSE file?
```
The following class is modified from Maven Wrapper, which is under Apache
License 2.0:
./.mvn/wrapper/MavenWrapperDownloader.java
```
Best,
---
Xiangdong Huang
School of
Hi Justin,
this is a file I personally wrote and submitted to the maven-wrapper project.
So technically it could have the Apache header ... after all, I put it there.
So I think the Apache header doesn't have to be replaced.
Chris
Am 18.11.19, 21:21 schrieb "Justin Mclean" :
HI,
Hi,
So, remove the current header, put its original header back, and exclude
the file from apache-rat-plugin. (The file has been claimed in iotdb's
LICENSE file)
Is that ok?
Best,
---
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
HI,
I’m -1 on this as the maven wrapper [1] is still not being handled correctly,
please read my previous comments. This is a 3rd party file and should not have
an ASF header, you can't alter the header of a 3rd party file without
permission. Thanks for fixing the other issues.
Thanks,
Justin
The PR link: https://github.com/apache/incubator-iotdb/pull/565/commits.
>
>
> > -原始邮件-
> > 发件人: suyue
> > 发送时间: 2019-11-18 19:41:56 (星期一)
> > 收件人: dev@iotdb.apache.org
> > 抄送:
> > 主题: [VOTE] Apache IoTD
大学 软件学院
> -原始邮件-
> 发件人: "勾王敏浩"
> 发送时间: 2019-11-18 20:51:51 (星期一)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
>
> Hi,
> My vote is -1 .
> Because the upgrade module has a bug when upgrading a o
19:41:56 (星期一)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
>
> Hi,
>
> +1 (PPMC vote)
>
> I checked:
>
> Binary distribution:
> 1. verify ASC
> 2. verify hash
> 3. verity rat
> 4.start iotdb server
>
Hi,
+1 (PPMC vote)
I checked:
Binary distribution:
1. verify ASC
2. verify hash
3. verity rat
4.start iotdb server
5.start client and execute some sqls
6. python client
Source release:
1. NOTICE, LICENSE and RELEASE_NOTES
2. rat
3. mvn clean test install
4. start iotdb server
5. start
Hi,
+1 (PPMC vote)
I have checked following items:
Source release:
1. Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the
extracted source bundle (Correct)
2. Compile and build code with command: mvn clean package. (Correct)
3. Verifying the signature (ASC) (Correct)
4.
Hi,
+1 (PPMC vote)
The followings are successfully verified:
Source release:
1. ASC sinature
2. Hashes
3. LICENSE, NOTICE, README, RELEASE_NOTES
4. RAT
5. mvn clean package
6. start server and client
7. execute basic operations and reboot
8. python client
Binary distribution:
1. ASC
Hi all,
Now I open a new ticket for Apache IoTDB (incubating) 0.9.0 RC2, which fixs
some issues comparing with RC1. You can find the details at the end of this
email.
Apache IoTDB (incubating) 0.9.0 is a major version with many exciting features.
You can get the release notes in [5].
Apache
18 matches
Mail list logo
