Re: ASF Headers including Year ...

2019-01-19 Thread Christofer Dutz
Hi Xiangdong, I think it's just dangerous as people tend to be lazy. So as soon as the build fails cause rat is complainng, it's easier to just call license:format than to fix thngs and then you could also overwrite headers you didn't want to overwrite. I would opt for removing it ... it will

Re: ASF Headers including Year ...

2019-01-19 Thread Xiangdong Huang
Hi Chris, The license-maven-plugin is not attached on any phase of Maven, so the plugin does not add headers automatically until some user calls `mvn license:format`. The plugin is just for adding hundreds of files in one breath. We can remove the plugin now if most of you think it is needless.

Re: ASF Headers including Year ...

2019-01-19 Thread Christofer Dutz
Hi all, In general I think it's problematic to have headers automatically changed, especially by an automated tool.. Think of such a tool like a device that stamps "This is the property of XYZ" on everything in your house ... now you borrow something from a friend and as soon as you bring it

Re: ASF Headers including Year ...

2019-01-19 Thread Xiangdong Huang
Hi all, I have modify the header of all files 1. Now the header is totally the same with https://www.apache.org/legal/src-headers.html#headers 2. apache-rat-plugin is enabled, and `mvn apache-rat:check` is passed. If anyone wants to create a new java file, I suggest you modify your IDE

Re: ASF Headers including Year ...

2019-01-18 Thread Justin Mclean
Hi, I think you can solve that by just adding “.git" to RAT exclusions. [1] Thanks, Justin 1. http://creadur.apache.org/rat/apache-rat/

Re: ASF Headers including Year ...

2019-01-18 Thread 徐毅
g Subject: Re: ASF Headers including Year ... Hi, Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin

Re: ASF Headers including Year ...

2019-01-18 Thread 徐毅
and use that. And probably replace the header plugin with the rat-Maven-plugin. Chris Outlook for Android<https://aka.ms/ghei36> herunterladen From: Justin Mclean Sent: Friday, January 18, 2019 5:50:49 PM To: dev@iotdb.apache.org Subject: Re: ASF Headers inc

Re: ASF Headers including Year ...

2019-01-18 Thread Christofer Dutz
rladen From: Justin Mclean Sent: Friday, January 18, 2019 5:50:49 PM To: dev@iotdb.apache.org Subject: Re: ASF Headers including Year ... Hi, > Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers,

Re: ASF Headers including Year ...

2019-01-18 Thread Justin Mclean
Hi, > Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin

Re: ASF Headers including Year ...

2019-01-18 Thread 徐毅
Hi Does maven provide some plugins to append header? I used the following plugin before, but it will add line break character which cannot pass code style check. com.mycila license-maven-plugin 3.0 | | 徐毅 | | xuyith...@126.com | 签名由网易邮箱大师定制 On 1/19/2019 00:30,Justin Mclean wrote: HI,

Re: ASF Headers including Year ...

2019-01-18 Thread Justin Mclean
HI, That the wrong header. You need to use this header[1], it explicitly doesn't contain a copyright line. Thanks, Justin 1. https://www.apache.org/legal/src-headers.html#headers

Re: ASF Headers including Year ...

2019-01-18 Thread Kevin A. McGrail
Yeah, that's for lawyers.  :-) On 1/18/2019 9:30 AM, Christofer Dutz wrote: > Hi Kevin, > > Well if you set the Inception-Year in the pom, > maven generates this line in the generated artifacts. > I have never seen the year appear in every file header. > > Chris > > > > Am 18.01.19, 15:28

Re: ASF Headers including Year ...

2019-01-18 Thread Christofer Dutz
I just had a look at PLC4X. So we have the inception.year set in the pom and every artifact maven builds and hereby every artifact we release contains a META-INF/NOTICE file with this content: -- PLC4J: Utils: WireShark Utils Copyright 2017-2019 The Apache Software Foundation This

Re: ASF Headers including Year ...

2019-01-18 Thread Christofer Dutz
Hi Kevin, Well if you set the Inception-Year in the pom, maven generates this line in the generated artifacts. I have never seen the year appear in every file header. Chris Am 18.01.19, 15:28 schrieb "Kevin A. McGrail" : On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, >

Re: ASF Headers including Year ...

2019-01-18 Thread Kevin A. McGrail
On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, > > as I was setting up things so Jenkins will build the project, I noticed that > you have some strange plugin in the build that enforces headers quite > strictly. > I don’t have any objections to that, however it marked my usual ASF

Re: ASF Headers including Year ...

2019-01-18 Thread 徐毅
Hi, We have a asf.header file in our project, we use this as asf header in codes. Maybe we omit some files to use header like "Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)". Are there many files use old header? I can help to delete them. Thanks Xu Yi On 1/18/2019

ASF Headers including Year ...

2019-01-18 Thread Christofer Dutz
Hi all, as I was setting up things so Jenkins will build the project, I noticed that you have some strange plugin in the build that enforces headers quite strictly. I don’t have any objections to that, however it marked my usual ASF headers as invalid because they didn’t have the first line in