[jira] [Closed] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1852.


Closing this issue, since it's branch was merged into master.

> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-1852:
-
Affects Version/s: 1.16.0
Fix Version/s: (was: 1.16.1)

> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1636) Support for Java 8 Time API

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1636.


Closing this issue, since it's branch was merged into master.

> Support for Java 8 Time API
> ---
>
> Key: ISIS-1636
> URL: https://issues.apache.org/jira/browse/ISIS-1636
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
>  Labels: Ready-for-Merge
> Fix For: 2.0.0-M1
>
>
> ISIS should support domain object properties of type
> * java.time.LocalDate
> * java.time.LocalDateTime
> * java.time.OffsetDateTime
> Sooner or later the new Java 8 time API will conquer the developers minds and 
> those using ISIS will demand ISIS built-in support for these basic types.
> Note: JDO support for the types listed above is already there (via plugin). 
> So the persistence part of the problem is solved, only the UI part is missing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1818) new config property: max navigable parent chain length

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1818.


Closing this task, since 'where-am-I' branch was merged into master.

> new config property: max navigable parent chain length
> --
>
> Key: ISIS-1818
> URL: https://issues.apache.org/jira/browse/ISIS-1818
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> * new Isis config property: max navigable parent chain length
> * infinite loop detection on the navigable parent chain
> ... and reflect that behavior in code
> do this in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.util.pchain.ParentChain
> {code}
> .. and/or implementing classes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1817) new config property that allows to disable the where-am-i feature

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1817.


Closing this task, since 'where-am-I' branch was merged into master.

> new config property that allows to disable the where-am-i feature
> -
>
> Key: ISIS-1817
> URL: https://issues.apache.org/jira/browse/ISIS-1817
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core: Viewer: Wicket
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> new Isis config property: allow to disable this feature ... and reflect that 
> behavior in code
> Do this in viewer-wicket-model's
> {code:java}
> org.apache.isis.viewer.wicket.model.models.whereami.WhereAmIModelDefault
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1816) Specify framework's behavior if multiple @Parent annotations or parent() methods are resolved in the object's hierarchy

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1816.


Closing this task, since 'where-am-I' branch was merged into master.

> Specify framework's behavior if multiple @Parent annotations or parent() 
> methods are resolved in the object's hierarchy
> ---
>
> Key: ISIS-1816
> URL: https://issues.apache.org/jira/browse/ISIS-1816
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> We need a clear specification on how the framework behaves if multiple 
> @Parent annotations or parent() methods are resolved in the object's 
> hierarchy.
> And reflect this with code in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.facets.object.navparent.annotation.NavigableParentAnnotationFacetFactory
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1762) Java 8+ Miscellaneous Utilities

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1762.


Closing this issue, since it's merged into master. (Was superseded by ISIS-1846 
... Internal API)

> Java 8+ Miscellaneous Utilities
> ---
>
> Key: ISIS-1762
> URL: https://issues.apache.org/jira/browse/ISIS-1762
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> Introducing a collection of utility classes not meant to be public API. The 
> goal is to simplify recurring code idioms within Isis' code base.
> Such idioms are null-checks, lazy values and exception handling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ISIS-1846) Code deduplication (new Internal API)

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1846.


Closing this tasks, since it's merged into master.

This merge allows further refactoring of isis-core-applib and other modules.

> Code deduplication (new Internal API)
> -
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1846) Code deduplication (new Internal API)

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-1846:
-
Summary: Code deduplication (new Internal API)  (was: API Cleanup: code 
deduplication)

> Code deduplication (new Internal API)
> -
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-1846) API Cleanup: code deduplication

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber resolved ISIS-1846.
--
Resolution: Fixed

merged with master

> API Cleanup: code deduplication
> ---
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1775) Auto-Configure SwaggerServiceDefault if Web-App has a Context-Path

[Andi Huber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-1775:
-
Fix Version/s: (was: 2.0.0-M1)
   2.0.0-M2

> Auto-Configure SwaggerServiceDefault if Web-App has a Context-Path
> --
>
> Key: ISIS-1775
> URL: https://issues.apache.org/jira/browse/ISIS-1775
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M2
>
>
> Let's say we deploy a web-app that has e.g. context path '/simple'.
> Then we would need to configure the IsisConfiguration property 
> 'isis.services.swagger.restfulBasePath' (default = '/restful') to 
> '/simple/restful', in order for the swagger-ui to work properly.
> We can instead implement o.a.i.c.m.services.SwaggerServiceDefault such that 
> it automatically prefixes the swaggerBasePath with the app's context path (if 
> present).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364316#comment-16364316
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit 6551c428b131248aeab10a1b766b7d3421bbe86f in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6551c42 ]

Merge branch 'ISIS-1744-update-to-dn-515' into dev/2.0.0-M2


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364314#comment-16364314
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit 66c4a7de037ade5f9c9881053137b7d59be6cfcd in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=66c4a7d ]

ISIS-1744: updates to DN 5.1.5


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1744) Update DataNucleus to the latest version (5.1.5 or later)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364315#comment-16364315
 ] 

ASF subversion and git services commented on ISIS-1744:
---

Commit df035130f4b1bc10fe5101dd775ffa5939f67f55 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=df03513 ]

ISIS-1744: removes work-around code for prior to DN 5.1.5


> Update DataNucleus to the latest version (5.1.5 or later)
> -
>
> Key: ISIS-1744
> URL: https://issues.apache.org/jira/browse/ISIS-1744
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Sergey Sverdlov
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Please update dependencies to DataNucleus to the latest available versions:
> org.datanucleus:datanucleus-core .. 4.1.7 -> 5.1.6
> org.datanucleus:datanucleus-api-jdo ...4.1.1 -> 5.1.4
> org.datanucleus:datanucleus-jdo-query ...4.0.5 -> 5.0.4
> org.datanucleus:datanucleus-jodatime 4.1.0-release -> 
> 5.1.0-release
> org.datanucleus:datanucleus-rdbms 4.1.9 -> 5.1.6



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1779) Transition to JAX-RS 2.0 Client API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364318#comment-16364318
 ] 

ASF subversion and git services commented on ISIS-1779:
---

Commit 72f34526c4880bca27376178b22c9aed4939ca54 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=72f3452 ]

ISIS-1779 Transition to JAX-RS 2.0 Client API
removed dependency on deprecated resteasy client api

> Transition to JAX-RS 2.0 Client API
> ---
>
> Key: ISIS-1779
> URL: https://issues.apache.org/jira/browse/ISIS-1779
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: RestfulObjects
>Affects Versions: 1.15.1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Dedicated Branch
> dev/2.0.0/ISIS-1779-jax-rs-2
> It seems JEE 8 servers (compliant with JAX-RS 2.1 API) conflict with 
> deployment of resteasy-jaxrs.version 3.x (which is JAX-RS 2.0 API) 
> and JEE 7 servers (compliant with JAX-RS 2.0 API) conflict with deployment of 
> resteasy-jaxrs.version 4.x (which is JAX-RS 2.1 API).
> So by now there is no easy way to package a war file with resteasy included, 
> that will run on both JEE 7 and 8.
> I've successfully tested 
> 4.0.0.Beta1 on glassfish 5,
> 3.0.17.Final on glassfish 4,
> 3.1.4.Final on glassfish 4.
> Note: transitioning resteasy-jaxrs from 3.0.x to any higher version involves 
> removal of deprecated classes in
> org.jboss.resteasy.client.*, which we are using it in 
> core/viewer-resfulobjects-applib.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1811) Release tasks for 2.0.0-M2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364317#comment-16364317
 ] 

ASF subversion and git services commented on ISIS-1811:
---

Commit 3a07319074edecd36b44bed204b7a12a238aa6ef in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3a07319 ]

ISIS-1811: updates versions to 2.0.0-M2-SNAPSHOT


> Release tasks for 2.0.0-M2
> --
>
> Key: ISIS-1811
> URL: https://issues.apache.org/jira/browse/ISIS-1811
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1767) JEE 7+ Support

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364312#comment-16364312
 ] 

ASF subversion and git services commented on ISIS-1767:
---

Commit fe41a1dc138066c12836f4bc811bf0a4c5c3cb1a in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fe41a1d ]

Merge branch 'ISIS-1767-jee-7' into dev/2.0.0-M2


> JEE 7+ Support
> --
>
> Key: ISIS-1767
> URL: https://issues.apache.org/jira/browse/ISIS-1767
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Collective tasks for Java EE 7+ support.
> Designated branch ...
> {code}dev/2.0.0/ISIS-1767-jee-7{code}
> +Tests+
> * *Server*: JEE 7+ implementation (or similar), launched with JDK8 (Version 
> 1.8.0_152); for deployment we use the HelloWorld artifact 1.15.1 with minor 
> modifications
> * *fat-war*: deploy all dependencies with single war (hsqldb in memory)
> * *skinny-war*: prepare container with shared libraries and shared domain 
> objects, deploy only a subset of domain classes with single war (hsqldb in 
> memory)
> * *restEasy*: check whether restEasy responds
> * managed connection pool (*con.pool*): use mysql db connection pool managed 
> by the JEE container and provided via JNDI
> * domain events (*dom.events*): test whether domain events are emitted and 
> handled using AxonFramework's SimpleEventBus
> * *swagger-ui*: test whether the static index.html from swagger-ui is served 
> and verify that a request for '//restful/swagger/private' 
> returns a JSON, that has the 'basePath' set to '//restful'
> * *redeploy*: test whether all previous tests succeed if we do a 
> deploy-undeploy-deploy process
> ||Server  ||fat-war ||skinny-war  
>||restEasy   ||con.pool   ||dom.events 
>   ||swagger-ui||redeploy||
> |Payara (full 4.1.2.173)  |{color:green}*OK*{color} 
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Payara (web 4.1.2.173)   |{color:green}*OK*{color} 
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Glassfish (full 4.1.2)   |*OK*(1)  |*OK*(1)  
>|{color:green}*OK*{color}|todo
> |{color:green}*OK*{color}|{color:green}*OK*{color}|{color:green}*OK*{color}(6)|
> |Glassfish (web 5.0.1 beta)|{color:green}*OK*{color}
> |{color:green}*OK*{color}|*OK*(5)|todo   
> |{color:green}*OK*{color}|{color:green}*OK*{color}|todo|
> |Glassfish (full 5.0) |{color:red}*FAILED*(2){color}|todo 
>|todo|todo|todo
> |todo|todo|
> |Wildfly (full 11.0.0)|{color:red}*FAILED*(3){color}|todo 
>|todo|todo|todo
> |todo|todo|
> |TomEE (plume 7.0.4)  |*OK*(4)  |todo 
>|{color:green}*OK*{color}|todo|todo
> |todo|todo|
> Notes:
> (1) 
> Guava version conflict: GF 4.2.1 has Guava-13, Isis has Guava-19; 
> WORKAROUND modify your glassfish installation ...
> * in glassfish/modules/ replace guava.jar with that which comes packaged with 
> Payara-4.1.2.173 (Guava-19)
> * you need to clear the OSGI cache: delete the folder 
> glassfish/domains/domainXXX/osgi-cache/felix
> (2)
> ON-HOLD waiting for GF 5.0.1 release!
> class-loading issues with Hibernate Validator, though library is included in 
> war ... java.lang.ClassNotFoundException: org.joda.time.ReadableInstant;
> using patch https://github.com/hibernate/hibernate-validator/pull/857/files 
> does not help: introduces new class-loading issues;
> (3)
> class-loading issues, though library is included in war ... 
> javax.persistence.PersistenceException: WFLYJPA0057: PersistenceProvider 
> 'org.apache.isis.core.webapp.jee.PersistenceUnitNoopProvider' not found;
> (4) 
> requires CXF to be disabled, see 
> https://stackoverflow.com/questions/41496204/tomee-7-0-2-how-to-disable-cxf-rs
>  
> throws exceptions on undeploy
> (5)
> JAX-RS API version clash
> requires 4.0.0.Beta1
> see https://issues.apache.org/jira/browse/ISIS-1779
> (6)   
> successfully tested against DN-5.1.5-SNAPSHOT (dedicated issue 
> https://issues.apache.org/jira/browse/ISIS-1754)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364311#comment-16364311
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit 4b89ae76f1e52fb7cec066bb4bc8dcd4b9b4e732 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4b89ae7 ]

ISIS-1756 remove reflective access to DN's EnhancementHelper since we've
got a dedicated method instead

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Sub-task
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1755) JEE Support - dummy bean as workaround for CDI

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364309#comment-16364309
 ] 

ASF subversion and git services commented on ISIS-1755:
---

Commit 14f99d6d5fe121ca4c343b9011dbe2ddde237513 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=14f99d6 ]

ISIS-1755 veto ExceptionRecognizer on CDI scan

> JEE Support - dummy bean as workaround for CDI
> --
>
> Key: ISIS-1755
> URL: https://issues.apache.org/jira/browse/ISIS-1755
> Project: Isis
>  Issue Type: Sub-task
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> During JEE-Application bootstrapping the JEE container identifies a 
> list of Isis classes it feels responsible for, but does not know how to 
> instantiate; so errors are thrown. For me it was sufficient to provide a 
> single stateless JEE bean that states, that it produces all these 
> classes. As long as you deploy your Isis application including this 
> dummy-bean, CDI does not complain.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364310#comment-16364310
 ] 

ASF subversion and git services commented on ISIS-1756:
---

Commit b72a01c31644df7c4e251597617c0c4de3f89d58 in isis's branch 
refs/heads/ISIS-1779-jax-rs-2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b72a01c ]

ISIS-1756 on shutdown purge any state associated with the current
web-app classloader

> JEE Support - IsisContext requires proper lifecycling.
> --
>
> Key: ISIS-1756
> URL: https://issues.apache.org/jira/browse/ISIS-1756
> Project: Isis
>  Issue Type: Sub-task
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> as per 
> https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E
> The isis-context needs a proper lifecycling, meaning a  deploy/undeploy cycle 
> should properly invalidate any state. (e.g meta model validation is currently 
> not cleared after an undeploy, in my case after calling 
> IsisContext.testReset())



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Apache EU Roadshow CFP Closing Soon (23 February)

[Sharan F]

Hello Everyone

This is an initial reminder to let you all know that we are holding an 
Apache EU Roadshow co-located with FOSS Backstage in Berlin on 13^th and 
14^th June 2018. https://s.apache.org/tCHx


The Call for Proposals (CFP) for the Apache EU Roadshow is currently 
open and will close at the end of next week, so if you have been 
delaying making a submission because the closing date seemed a long way 
off, then it's time to start getting your proposals submitted.


So what are we looking for?
We will have 2 Apache Devrooms available during the 2 day Roadshow so 
are looking for projects including incubating ones, to submit 
presentations, panel discussions, BoFs, or workshop proposals. The main 
focus of the Roadshow will be IoT, Cloud, Httpd and Tomcat so if your 
project is involved in or around any of these technologies at Apache 
then we are very interested in hearing from you.


Community and collaboration is important at Apache so if your project is 
interested in organising a project sprint, meetup or hackathon during 
the Roadshow, then please submit it inthe CFP as we do have some space 
available to allocate for these.


If you are wanting to submit a talk on open source community related 
topics such as the Apache Way, governance or legal aspects then please 
submit these to the CFP for FOSS Backstage.


Tickets for the Apache EU Roadshow are included as part of the 
registration for FOSS Backstage, so to attend the Roadshow you will need 
to register for FOSS Backstage. Early Bird tickets are still available 
until the 21^st February 2018.


Please see below for important URLs to remember:

-  To submit a CFP for the Apache EU Roadshow 
:http://apachecon.com/euroadshow18/ 


-  To submit a CFP for FOSS Backstage : 
https://foss-backstage.de/call-papers


-  To register to attend the Apache EU Roadshow and/or FOSS Backstage : 
https://foss-backstage.de/tickets


For further updates and information about the Apache EU Roadshowplease 
check http://apachecon.com/euroadshow18/


Thanks
Sharan Foga, VP Apache Community Development

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364244#comment-16364244
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit fb552d3523e11c6383b93401c5a744e064411f85 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fb552d3 ]

Merge branch 'ISIS-1852_parallel_stream_patch'


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1817) new config property that allows to disable the where-am-i feature

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364233#comment-16364233
 ] 

ASF subversion and git services commented on ISIS-1817:
---

Commit 08ce1a64f305287be398f610db5f734c685fda29 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=08ce1a6 ]

ISIS-1817 + ISIS-1818 allow configuration of where-am-i feature

> new config property that allows to disable the where-am-i feature
> -
>
> Key: ISIS-1817
> URL: https://issues.apache.org/jira/browse/ISIS-1817
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core: Viewer: Wicket
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> new Isis config property: allow to disable this feature ... and reflect that 
> behavior in code
> Do this in viewer-wicket-model's
> {code:java}
> org.apache.isis.viewer.wicket.model.models.whereami.WhereAmIModelDefault
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364243#comment-16364243
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 3e3ad2bb1b8abb605abf71e66ace47ed7b30605c in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3e3ad2b ]

ISIS-1852: reworks unit test, again


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1740) New Feature: Where am I

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364239#comment-16364239
 ] 

ASF subversion and git services commented on ISIS-1740:
---

Commit 2fc93a23eff85b8f5530bbf6dee0e0f7d07a19f6 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2fc93a2 ]

ISIS-1740 Refactoring and consolidating invocation exception handling
+ introducing MethodHandles to speed up reflective invocation

> New Feature: Where am I
> ---
>
> Key: ISIS-1740
> URL: https://issues.apache.org/jira/browse/ISIS-1740
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
> Attachments: Clipboard01.png, Clipboard02.png, Clipboard03.png, 
> Clipboard04.png
>
>
> Its common practice to display a navigation hint somewhere at top of an 
> application's page or below the main menu, indicating where the user 
> currently has navigated to. (Typically within a navigable tree-structure.) 
> Let's call this the *WhereAmI hint*. We could integrate such a feature into 
> ISIS.
> +Examples+
> [^Clipboard01.png]
> [^Clipboard02.png]
> [^Clipboard03.png]
> Note: we could optionally include the DomainObject's icons
> +Proposal+
> For any DomainObject/View currently displayed ISIS would need to know its 
> corresponding
> navigable tree-structure. Let's call this the DomainObject's *WhereAmI tree*.
> All the framework needs to known to build the relevant sub-tree, is to know 
> the parent node of any DomainObject/View that 'takes part' in the tree.
> We could provide this 'who is your parent' meta information similar to the 
> existing 'what is your title' mechanism:
> {code:java}
> // Who is your parent? if null there is none
> public AnyDomainObjectOrView parent()
> {
> return foo;
> }
> {code}
> or
> {code:java}
> // Who is your parent? if null there is none
> @Parent
> public AnyDomainObjectOrView anyMethodName()
> {
> return foo;
> }
> {code}
> The typical layout.xml could look like this:
> {code:xml}
> 
> 
> 
> 
> 
> ...
> 
> 
>  ...
> 
> {code}
> +Implementation Notes+
> # The framework needs to ensure that the chain of parent references starting 
> at the current DomainObject/View is finite. (No circular or self references.) 
> If it detects a circle, be nice and just stop the 'tree-up' traversal there.
> # For standalone Collection Views we could display a WhereAmI hint that 
> allows back navigation to the DomainObject/View that had produced the 
> collection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1818) new config property: max navigable parent chain length

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364236#comment-16364236
 ] 

ASF subversion and git services commented on ISIS-1818:
---

Commit 1155e89564761b6a94e2f02637f0044d9e9cabc8 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1155e89 ]

ISIS-1817 + ISIS-1818 added missing assignment + clarify comments

> new config property: max navigable parent chain length
> --
>
> Key: ISIS-1818
> URL: https://issues.apache.org/jira/browse/ISIS-1818
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> * new Isis config property: max navigable parent chain length
> * infinite loop detection on the navigable parent chain
> ... and reflect that behavior in code
> do this in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.util.pchain.ParentChain
> {code}
> .. and/or implementing classes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1740) New Feature: Where am I

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364242#comment-16364242
 ] 

ASF subversion and git services commented on ISIS-1740:
---

Commit 6ee4202247019250c000dc2bf6faded9c4ea2fb2 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6ee4202 ]

Merge branch 'ISIS-1740-where-am-i'


> New Feature: Where am I
> ---
>
> Key: ISIS-1740
> URL: https://issues.apache.org/jira/browse/ISIS-1740
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
> Attachments: Clipboard01.png, Clipboard02.png, Clipboard03.png, 
> Clipboard04.png
>
>
> Its common practice to display a navigation hint somewhere at top of an 
> application's page or below the main menu, indicating where the user 
> currently has navigated to. (Typically within a navigable tree-structure.) 
> Let's call this the *WhereAmI hint*. We could integrate such a feature into 
> ISIS.
> +Examples+
> [^Clipboard01.png]
> [^Clipboard02.png]
> [^Clipboard03.png]
> Note: we could optionally include the DomainObject's icons
> +Proposal+
> For any DomainObject/View currently displayed ISIS would need to know its 
> corresponding
> navigable tree-structure. Let's call this the DomainObject's *WhereAmI tree*.
> All the framework needs to known to build the relevant sub-tree, is to know 
> the parent node of any DomainObject/View that 'takes part' in the tree.
> We could provide this 'who is your parent' meta information similar to the 
> existing 'what is your title' mechanism:
> {code:java}
> // Who is your parent? if null there is none
> public AnyDomainObjectOrView parent()
> {
> return foo;
> }
> {code}
> or
> {code:java}
> // Who is your parent? if null there is none
> @Parent
> public AnyDomainObjectOrView anyMethodName()
> {
> return foo;
> }
> {code}
> The typical layout.xml could look like this:
> {code:xml}
> 
> 
> 
> 
> 
> ...
> 
> 
>  ...
> 
> {code}
> +Implementation Notes+
> # The framework needs to ensure that the chain of parent references starting 
> at the current DomainObject/View is finite. (No circular or self references.) 
> If it detects a circle, be nice and just stop the 'tree-up' traversal there.
> # For standalone Collection Views we could display a WhereAmI hint that 
> allows back navigation to the DomainObject/View that had produced the 
> collection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1740) New Feature: Where am I

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364241#comment-16364241
 ] 

ASF subversion and git services commented on ISIS-1740:
---

Commit cc2f5d0736d1db38b189397dbb35a1f14e964712 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cc2f5d0 ]

ISIS-1740: fixes merge issues (NullSafe moved to applib and renamed)


> New Feature: Where am I
> ---
>
> Key: ISIS-1740
> URL: https://issues.apache.org/jira/browse/ISIS-1740
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
> Attachments: Clipboard01.png, Clipboard02.png, Clipboard03.png, 
> Clipboard04.png
>
>
> Its common practice to display a navigation hint somewhere at top of an 
> application's page or below the main menu, indicating where the user 
> currently has navigated to. (Typically within a navigable tree-structure.) 
> Let's call this the *WhereAmI hint*. We could integrate such a feature into 
> ISIS.
> +Examples+
> [^Clipboard01.png]
> [^Clipboard02.png]
> [^Clipboard03.png]
> Note: we could optionally include the DomainObject's icons
> +Proposal+
> For any DomainObject/View currently displayed ISIS would need to know its 
> corresponding
> navigable tree-structure. Let's call this the DomainObject's *WhereAmI tree*.
> All the framework needs to known to build the relevant sub-tree, is to know 
> the parent node of any DomainObject/View that 'takes part' in the tree.
> We could provide this 'who is your parent' meta information similar to the 
> existing 'what is your title' mechanism:
> {code:java}
> // Who is your parent? if null there is none
> public AnyDomainObjectOrView parent()
> {
> return foo;
> }
> {code}
> or
> {code:java}
> // Who is your parent? if null there is none
> @Parent
> public AnyDomainObjectOrView anyMethodName()
> {
> return foo;
> }
> {code}
> The typical layout.xml could look like this:
> {code:xml}
> 
> 
> 
> 
> 
> ...
> 
> 
>  ...
> 
> {code}
> +Implementation Notes+
> # The framework needs to ensure that the chain of parent references starting 
> at the current DomainObject/View is finite. (No circular or self references.) 
> If it detects a circle, be nice and just stop the 'tree-up' traversal there.
> # For standalone Collection Views we could display a WhereAmI hint that 
> allows back navigation to the DomainObject/View that had produced the 
> collection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1816) Specify framework's behavior if multiple @Parent annotations or parent() methods are resolved in the object's hierarchy

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364237#comment-16364237
 ] 

ASF subversion and git services commented on ISIS-1816:
---

Commit 0645ecde12e94d416bf858387eeca960cb0bc60a in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0645ecd ]

ISIS-1816 refactoring Annotations + implement hierarchy search

> Specify framework's behavior if multiple @Parent annotations or parent() 
> methods are resolved in the object's hierarchy
> ---
>
> Key: ISIS-1816
> URL: https://issues.apache.org/jira/browse/ISIS-1816
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> We need a clear specification on how the framework behaves if multiple 
> @Parent annotations or parent() methods are resolved in the object's 
> hierarchy.
> And reflect this with code in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.facets.object.navparent.annotation.NavigableParentAnnotationFacetFactory
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1816) Specify framework's behavior if multiple @Parent annotations or parent() methods are resolved in the object's hierarchy

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364238#comment-16364238
 ] 

ASF subversion and git services commented on ISIS-1816:
---

Commit f338b8b0a907f3581041644abe2f093542b09c88 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f338b8b ]

ISIS-1816 impl. navigable parent resolving behavior according to spec

> Specify framework's behavior if multiple @Parent annotations or parent() 
> methods are resolved in the object's hierarchy
> ---
>
> Key: ISIS-1816
> URL: https://issues.apache.org/jira/browse/ISIS-1816
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> We need a clear specification on how the framework behaves if multiple 
> @Parent annotations or parent() methods are resolved in the object's 
> hierarchy.
> And reflect this with code in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.facets.object.navparent.annotation.NavigableParentAnnotationFacetFactory
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1818) new config property: max navigable parent chain length

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364234#comment-16364234
 ] 

ASF subversion and git services commented on ISIS-1818:
---

Commit 08ce1a64f305287be398f610db5f734c685fda29 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=08ce1a6 ]

ISIS-1817 + ISIS-1818 allow configuration of where-am-i feature

> new config property: max navigable parent chain length
> --
>
> Key: ISIS-1818
> URL: https://issues.apache.org/jira/browse/ISIS-1818
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> * new Isis config property: max navigable parent chain length
> * infinite loop detection on the navigable parent chain
> ... and reflect that behavior in code
> do this in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.util.pchain.ParentChain
> {code}
> .. and/or implementing classes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1817) new config property that allows to disable the where-am-i feature

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364235#comment-16364235
 ] 

ASF subversion and git services commented on ISIS-1817:
---

Commit 1155e89564761b6a94e2f02637f0044d9e9cabc8 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1155e89 ]

ISIS-1817 + ISIS-1818 added missing assignment + clarify comments

> new config property that allows to disable the where-am-i feature
> -
>
> Key: ISIS-1817
> URL: https://issues.apache.org/jira/browse/ISIS-1817
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core: Viewer: Wicket
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> new Isis config property: allow to disable this feature ... and reflect that 
> behavior in code
> Do this in viewer-wicket-model's
> {code:java}
> org.apache.isis.viewer.wicket.model.models.whereami.WhereAmIModelDefault
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1816) Specify framework's behavior if multiple @Parent annotations or parent() methods are resolved in the object's hierarchy

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364240#comment-16364240
 ] 

ASF subversion and git services commented on ISIS-1816:
---

Commit 412606959ec63729a5d6451a519d86a3ad2708c7 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4126069 ]

ISIS-1816 Refactoring names + simplify

> Specify framework's behavior if multiple @Parent annotations or parent() 
> methods are resolved in the object's hierarchy
> ---
>
> Key: ISIS-1816
> URL: https://issues.apache.org/jira/browse/ISIS-1816
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Affects Versions: 2.0.0-M1
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> We need a clear specification on how the framework behaves if multiple 
> @Parent annotations or parent() methods are resolved in the object's 
> hierarchy.
> And reflect this with code in metamodel's
> {code:java}
> org.apache.isis.core.metamodel.facets.object.navparent.annotation.NavigableParentAnnotationFacetFactory
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364155#comment-16364155
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 39a60398a58190433fb2e1ca57ea94ad095b7e7c in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=39a6039 ]

ISIS-1852: removes debug System.out.println


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364154#comment-16364154
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 0d749cec1c964b903150988d5e1457bda65f185e in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0d749ce ]

ISIS-1852: fixes unit test

the algorithm was wrong, I think


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364147#comment-16364147
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit c05e5ca8ea8b49d67a2be4209b4208151a64ef19 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c05e5ca ]

Merge branch 'ISIS-1852_parallel_stream_patch'


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364146#comment-16364146
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 39a60398a58190433fb2e1ca57ea94ad095b7e7c in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=39a6039 ]

ISIS-1852: removes debug System.out.println


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364144#comment-16364144
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 96a2a78533369b9f8cc2e8eb63a32e3420336ef1 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=96a2a78 ]

ISIS-1852: removes debug System.out.println


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364141#comment-16364141
 ] 

ASF subversion and git services commented on ISIS-1846:
---

Commit e989ad937057a074023042691a0b65df036740b1 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e989ad9 ]

Merge remote-tracking branch 'origin/ISIS-1846_internal_utils'

# Conflicts:
#   
core/applib/src/main/java/org/apache/isis/applib/services/eventbus/AbstractDomainEvent.java
#   
core/applib/src/main/java/org/apache/isis/schema/utils/CommonDtoUtils.java
#   
core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java


> API Cleanup: code deduplication
> ---
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364142#comment-16364142
 ] 

ASF subversion and git services commented on ISIS-1846:
---

Commit c1d0732604857ebf0d9496914e737d824617e1e0 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c1d0732 ]

ISIS-1846: fixes unit test (had accidentally changed contract)


> API Cleanup: code deduplication
> ---
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364143#comment-16364143
 ] 

ASF subversion and git services commented on ISIS-1846:
---

Commit e0cb0853671a803c5356ef5ea8e1a884ddfebe78 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e0cb085 ]

ISIS-1846: reinstates reflections as a non-optional compile-time dependency, 
since required for both compile and runtime.


> API Cleanup: code deduplication
> ---
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364137#comment-16364137
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit e29b26f535079e051b3d84f6a148dfff9c4bd7bc in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e29b26f ]

ISIS-1852 allow local thread variable propagation to any child threads

> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364135#comment-16364135
 ] 

ASF subversion and git services commented on ISIS-1846:
---

Commit 62725eb3dfd7cf5c995eb5d943781437bd37e274 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=62725eb ]

ISIS-1846 added reviewer notes and questions

> API Cleanup: code deduplication
> ---
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364136#comment-16364136
 ] 

ASF subversion and git services commented on ISIS-1846:
---

Commit 8ebd31355b1ec18800819f915a41acf166c79d85 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ebd313 ]

ISIS-1846 thread-safe (atomic) writes to _Context (singleton-store)

> API Cleanup: code deduplication
> ---
>
> Key: ISIS-1846
> URL: https://issues.apache.org/jira/browse/ISIS-1846
> Project: Isis
>  Issue Type: Sub-task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> isis-core-applib would be the perfect place to consolidate any internal 
> utility classes such as
> NullSafe (common null check idioms), StringExtensions, ordering algorithms, 
> etc ...
> but we would want to keep these classes contained, meaning they should not be 
> available for public use, just for internal use within Isis' code-base.
> Java 9 has the perfect solution for this. But what can we do in the meantime 
> (with Java 8)?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364140#comment-16364140
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit c1497719fa8276b0d5b8ac2a83771beabf821e39 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c149771 ]

Merge branch 'ISIS-1852_parallel_stream_patch'


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364139#comment-16364139
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 0d749cec1c964b903150988d5e1457bda65f185e in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0d749ce ]

ISIS-1852: fixes unit test

the algorithm was wrong, I think


> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364138#comment-16364138
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 3706fa92cf0d3668a0a18be21b759f585c187692 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3706fa9 ]

ISIS-1852 testcase backported to JDK 7

> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1860) CommandReification.DISABLED is broken / incorrectly documented.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364001#comment-16364001
 ] 

ASF subversion and git services commented on ISIS-1860:
---

Commit 392d475ac421ace05b18128f10cb2dea543aeba0 in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=392d475 ]

ISIS-1860: improves docs regarding CommandReification


> CommandReification.DISABLED is broken / incorrectly documented.
> ---
>
> Key: ISIS-1860
> URL: https://issues.apache.org/jira/browse/ISIS-1860
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> Don't intend to change the implementation, but what I observe is that setting 
> commandReification=DISABLED does not necessarily prevent a command from being 
> persisted.  All it does is prevent a CommandFacet from being installed on the 
> corresponding action or property in the metamodel.
> A Command object is always created by CommandContext.  If there is a 
> CommandService implementation, then it delegates to that to act as the 
> factory of the Command.  So reification always occurs.
> If an action invocation or property edit causes objects to be modified, then 
> the Command#setPersistHint(...) is set to true.  And, if there is no command 
> facet, then the CommandServiceJdo will default the 
> Command#setPersistence(...) to PERSIST_IF_HINTED.
> The net result is that if commandReification is DISABLED, then commands are 
> still persisted if they cause any objects to be dirtied.  
> To prevent commands being persisted, instead use 
> @Action(commandPersistence=NOT_PERSISTED), and make sure that 
> @Action(command=ENABLED).
>  
> object is updated with a persist hint.  In the case of the incode platform's 
> Command module, the CommandService#complete(Command) is called, its 
> implementation will 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364002#comment-16364002
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit e29b26f535079e051b3d84f6a148dfff9c4bd7bc in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e29b26f ]

ISIS-1852 allow local thread variable propagation to any child threads

> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363995#comment-16363995
 ] 

ASF subversion and git services commented on ISIS-1829:
---

Commit b892b97f026a0f83c984b8a1fce8e8a434ea3ecd in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b892b97 ]

ISIS-1829: extracts methods to make flow easier to follow


> AppManifestAbstract#withFixtureScripts no longer works.
> ---
>
> Key: ISIS-1829
> URL: https://issues.apache.org/jira/browse/ISIS-1829
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> workaround is to use overrideFixtureScripts
> I also think that the inverse of using overrideConfigurationProperties is 
> broken in 1.16.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363993#comment-16363993
 ] 

ASF subversion and git services commented on ISIS-1829:
---

Commit 6eb767fd80500f9ef6157009d3022d81420b86bd in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6eb767f ]

ISIS-1829: adds condition for a builder that inherits from 
AppManifestAbstract2.Builder


> AppManifestAbstract#withFixtureScripts no longer works.
> ---
>
> Key: ISIS-1829
> URL: https://issues.apache.org/jira/browse/ISIS-1829
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> workaround is to use overrideFixtureScripts
> I also think that the inverse of using overrideConfigurationProperties is 
> broken in 1.16.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1852) Iterating over query result list with parallelStream produces next exception

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364003#comment-16364003
 ] 

ASF subversion and git services commented on ISIS-1852:
---

Commit 3706fa92cf0d3668a0a18be21b759f585c187692 in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3706fa9 ]

ISIS-1852 testcase backported to JDK 7

> Iterating over query result list with parallelStream produces next exception
> 
>
> Key: ISIS-1852
> URL: https://issues.apache.org/jira/browse/ISIS-1852
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Vladimir Nisevic
>Assignee: Andi Huber
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> Given the the result from database, e.g.
> {code:java}
> final List devices = 
> repositoryService.allInstances(MobileDevice.class);{code}
> When I iterate over list with parallelStream
> {code:java}
> filteredDevices.parallelStream().forEach(mobileDevice -> {
> // my stuff here
> });{code}
> Then I get this exception
> {code:java}
> ... 134 more
> Caused by: java.lang.IllegalStateException: No service of type class 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault is 
> available on this 
> at 
> org.apache.isis.core.runtime.services.ServiceInstantiator$2.invoke(ServiceInstantiator.java:217)
> at 
> org.apache.isis.core.runtime.services.metrics.MetricsServiceDefault_$$_jvstad5_7.postLoad(MetricsServiceDefault_$$_jvstad5_7.java)
> at 
> org.datanucleus.api.jdo.JDOCallbackHandler.postLoad(JDOCallbackHandler.java:305)
> at org.datanucleus.state.StateManagerImpl.postLoad(StateManagerImpl.java:4443)
> at 
> org.datanucleus.state.StateManagerImpl.initialiseForCachedPC(StateManagerImpl.java:645)
> at 
> org.apache.isis.objectstore.jdo.datanucleus.JDOStateManagerForIsis.initialiseForCachedPC(JDOStateManagerForIsis.java:112)
> at 
> org.datanucleus.state.ObjectProviderFactoryImpl.newForCachedPC(ObjectProviderFactoryImpl.java:280)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromLevel2Cache(ExecutionContextImpl.java:5210)
> at 
> org.datanucleus.ExecutionContextImpl.getObjectFromCache(ExecutionContextImpl.java:5101)
> at 
> org.datanucleus.ExecutionContextImpl.findObject(ExecutionContextImpl.java:3048)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObjectForDatastoreId(PersistentClassROF.java:460)
> at 
> org.datanucleus.store.rdbms.query.PersistentClassROF.getObject(PersistentClassROF.java:385)
> at 
> org.datanucleus.store.rdbms.scostore.CollectionStoreIterator.(CollectionStoreIterator.java:100)
> at 
> org.datanucleus.store.rdbms.scostore.FKSetStore.iterator(FKSetStore.java:1080)
> at 
> org.datanucleus.store.types.wrappers.backed.Collection.loadFromStore(Collection.java:374)
> at 
> org.datanucleus.store.types.java8.wrappers.backed.Collection.stream(Collection.java:70)
> at 
> a1.guidedselling.offer.hardware.MobileDevice.referenceNextDevicePriceForTarifWithoutService(MobileDevice.java:195)
> at 
> a1.guidedselling.templates.OfferTemplatesRepository.lambda$offerTemplatesFor$1(OfferTemplatesRepository.java:102)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at 
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
> at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at 
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1859) Use of "timestamp" in JDOQL queries.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364000#comment-16364000
 ] 

ASF subversion and git services commented on ISIS-1859:
---

Commit a47243ff9fb6aac28d9a4b80b807fb0693216532 in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a47243f ]

ISIS-1859: adds a hint-n-tip doc


> Use of "timestamp" in JDOQL queries.
> 
>
> Key: ISIS-1859
> URL: https://issues.apache.org/jira/browse/ISIS-1859
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 1.16.1
>
>
> As posted by me on the DN gitter channel...
> {code:java}
> I have an entity CommandJdo that has a property called "timestamp", of type 
> java.sql.Timestamp
> My JDOQL for this is:
> SELECT
> FROM org.isisaddons.module.command.dom.CommandJdo
> WHERE executeIn == 'FOREGROUND'
> && timestamp > :timestamp
> && startedAt != null
> && completedAt != null
> ORDER BY timestamp ASC
> Running against SQL Server 2016 this gave me a different result first time it 
> was run compared to subsequent times.
> Running SQL Profiler I found the underlying SQL as:
> exec sp_prepexec @p1 output,N'@P0 datetime2',N'SELECT 
> ''org.isisaddons.module.command.dom.CommandJdo'' AS 
> NUCLEUS_TYPE,A0.arguments,A0.completedAt,A0."exception",A0.executeIn,A0.memberIdentifier,A0.memento,A0.replayState,A0.replayStateFailureReason,A0."result",A0.startedAt,A0.targetAction,A0.targetClass,A0.target,A0."timestamp",A0.transactionId,A0."user",''2018-01-24
>  17:29:18.3'' AS NUCORDER0 FROM isiscommand.Command A0 WHERE A0.executeIn = 
> ''FOREGROUND'' AND A0."timestamp" > @P0 AND A0.startedAt IS NOT NULL AND 
> A0.completedAt IS NOT NULL ORDER BY NUCORDER0 OFFSET 0 ROWS FETCH NEXT 2 ROWS 
> ONLY ','2018-01-24 17:29:18.300'
> To unpick this, the key bit is: '
> '2018-01-24 17:29:18.3'' AS NUCORDER0
> ... ORDER BY NUCORDER0
> So in the JDOQL the "ORDER BY timestamp ASC", the "timestamp" is being 
> evaluated as the current time, I suppose as a sort-of built-in function.
> Which was surprising.
> My fix was to change the JDOQL to be:
> ORDER BY this.timestamp ASC{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363998#comment-16363998
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 39524c701a60d4d7729a17b75aec6fc8fb637ee1 in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=39524c7 ]

ISIS-1813: removes the petclinic tutorial, since out of date


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1847) Eventbus: AbstractDomainEvent incorrect veto handling?

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363996#comment-16363996
 ] 

ASF subversion and git services commented on ISIS-1847:
---

Commit 8c2c4038ede2927290dbfab4ba41f146970546c8 in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8c2c403 ]

ISIS-1847: adds missing breaks in veto handling of AbstractDomainEvent

with some unit tests to specify exact behaviour.


> Eventbus: AbstractDomainEvent incorrect veto handling?
> --
>
> Key: ISIS-1847
> URL: https://issues.apache.org/jira/browse/ISIS-1847
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> When refactoring switch statements I found 2 in
>  isis-core-applib's
>  *org.apache.isis.applib.services.eventbus.AbstractDomainEvent*
>  where the cases have no break statements.
> Is this intentional or a bug?
> Just for reference, here's the refactored version [1].
> [1] 
> [https://github.com/apache/isis/blob/8e8b5f1a8e4780b467ab31a7d909f89e499244a9/core/applib/src/main/java/org/apache/isis/applib/services/eventbus/AbstractDomainEvent.java]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363997#comment-16363997
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 93c1897fdfcc695a0c300fb67739adac4699e04f in isis's branch 
refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=93c1897 ]

ISIS-1813: updates document template to include version


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1860) CommandReification.DISABLED is broken / incorrectly documented.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363971#comment-16363971
 ] 

ASF subversion and git services commented on ISIS-1860:
---

Commit 392d475ac421ace05b18128f10cb2dea543aeba0 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=392d475 ]

ISIS-1860: improves docs regarding CommandReification


> CommandReification.DISABLED is broken / incorrectly documented.
> ---
>
> Key: ISIS-1860
> URL: https://issues.apache.org/jira/browse/ISIS-1860
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> Don't intend to change the implementation, but what I observe is that setting 
> commandReification=DISABLED does not necessarily prevent a command from being 
> persisted.  All it does is prevent a CommandFacet from being installed on the 
> corresponding action or property in the metamodel.
> A Command object is always created by CommandContext.  If there is a 
> CommandService implementation, then it delegates to that to act as the 
> factory of the Command.  So reification always occurs.
> If an action invocation or property edit causes objects to be modified, then 
> the Command#setPersistHint(...) is set to true.  And, if there is no command 
> facet, then the CommandServiceJdo will default the 
> Command#setPersistence(...) to PERSIST_IF_HINTED.
> The net result is that if commandReification is DISABLED, then commands are 
> still persisted if they cause any objects to be dirtied.  
> To prevent commands being persisted, instead use 
> @Action(commandPersistence=NOT_PERSISTED), and make sure that 
> @Action(command=ENABLED).
>  
> object is updated with a persist hint.  In the case of the incode platform's 
> Command module, the CommandService#complete(Command) is called, its 
> implementation will 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363969#comment-16363969
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 6d682f63b2fdf76a28803bbaeedd3d18214ead0d in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6d682f6 ]

ISIS-1813: adds missing copyright notices


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1859) Use of "timestamp" in JDOQL queries.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363970#comment-16363970
 ] 

ASF subversion and git services commented on ISIS-1859:
---

Commit a47243ff9fb6aac28d9a4b80b807fb0693216532 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a47243f ]

ISIS-1859: adds a hint-n-tip doc


> Use of "timestamp" in JDOQL queries.
> 
>
> Key: ISIS-1859
> URL: https://issues.apache.org/jira/browse/ISIS-1859
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 1.16.1
>
>
> As posted by me on the DN gitter channel...
> {code:java}
> I have an entity CommandJdo that has a property called "timestamp", of type 
> java.sql.Timestamp
> My JDOQL for this is:
> SELECT
> FROM org.isisaddons.module.command.dom.CommandJdo
> WHERE executeIn == 'FOREGROUND'
> && timestamp > :timestamp
> && startedAt != null
> && completedAt != null
> ORDER BY timestamp ASC
> Running against SQL Server 2016 this gave me a different result first time it 
> was run compared to subsequent times.
> Running SQL Profiler I found the underlying SQL as:
> exec sp_prepexec @p1 output,N'@P0 datetime2',N'SELECT 
> ''org.isisaddons.module.command.dom.CommandJdo'' AS 
> NUCLEUS_TYPE,A0.arguments,A0.completedAt,A0."exception",A0.executeIn,A0.memberIdentifier,A0.memento,A0.replayState,A0.replayStateFailureReason,A0."result",A0.startedAt,A0.targetAction,A0.targetClass,A0.target,A0."timestamp",A0.transactionId,A0."user",''2018-01-24
>  17:29:18.3'' AS NUCORDER0 FROM isiscommand.Command A0 WHERE A0.executeIn = 
> ''FOREGROUND'' AND A0."timestamp" > @P0 AND A0.startedAt IS NOT NULL AND 
> A0.completedAt IS NOT NULL ORDER BY NUCORDER0 OFFSET 0 ROWS FETCH NEXT 2 ROWS 
> ONLY ','2018-01-24 17:29:18.300'
> To unpick this, the key bit is: '
> '2018-01-24 17:29:18.3'' AS NUCORDER0
> ... ORDER BY NUCORDER0
> So in the JDOQL the "ORDER BY timestamp ASC", the "timestamp" is being 
> evaluated as the current time, I suppose as a sort-of built-in function.
> Which was surprising.
> My fix was to change the JDOQL to be:
> ORDER BY this.timestamp ASC{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363967#comment-16363967
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 93c1897fdfcc695a0c300fb67739adac4699e04f in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=93c1897 ]

ISIS-1813: updates document template to include version


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1847) Eventbus: AbstractDomainEvent incorrect veto handling?

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363965#comment-16363965
 ] 

ASF subversion and git services commented on ISIS-1847:
---

Commit 8c2c4038ede2927290dbfab4ba41f146970546c8 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8c2c403 ]

ISIS-1847: adds missing breaks in veto handling of AbstractDomainEvent

with some unit tests to specify exact behaviour.


> Eventbus: AbstractDomainEvent incorrect veto handling?
> --
>
> Key: ISIS-1847
> URL: https://issues.apache.org/jira/browse/ISIS-1847
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1, 2.0.0-M1
>
>
> When refactoring switch statements I found 2 in
>  isis-core-applib's
>  *org.apache.isis.applib.services.eventbus.AbstractDomainEvent*
>  where the cases have no break statements.
> Is this intentional or a bug?
> Just for reference, here's the refactored version [1].
> [1] 
> [https://github.com/apache/isis/blob/8e8b5f1a8e4780b467ab31a7d909f89e499244a9/core/applib/src/main/java/org/apache/isis/applib/services/eventbus/AbstractDomainEvent.java]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363968#comment-16363968
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 39524c701a60d4d7729a17b75aec6fc8fb637ee1 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=39524c7 ]

ISIS-1813: removes the petclinic tutorial, since out of date


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1810) Release tasks for 2.0.0-M1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363973#comment-16363973
 ] 

ASF subversion and git services commented on ISIS-1810:
---

Commit 1b19e6e5dd9799d8247223b50ddc574628e244b3 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1b19e6e ]

ISIS-1810: fixes compile issues arising from merge


> Release tasks for 2.0.0-M1
> --
>
> Key: ISIS-1810
> URL: https://issues.apache.org/jira/browse/ISIS-1810
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363964#comment-16363964
 ] 

ASF subversion and git services commented on ISIS-1829:
---

Commit 6eb767fd80500f9ef6157009d3022d81420b86bd in isis's branch 
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6eb767f ]

ISIS-1829: adds condition for a builder that inherits from 
AppManifestAbstract2.Builder


> AppManifestAbstract#withFixtureScripts no longer works.
> ---
>
> Key: ISIS-1829
> URL: https://issues.apache.org/jira/browse/ISIS-1829
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> workaround is to use overrideFixtureScripts
> I also think that the inverse of using overrideConfigurationProperties is 
> broken in 1.16.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Merging maint-1.16.1 into master; checking status of our branches

[Andi Huber]

Thx Dan,

answering inline ...

Cheers, Andi!

On 14.02.2018 12:55, Dan Haywood wrote:
> Hi Andi
>
> just an fyi, I'm currently merging maint-1.16.1 into master.
>
> I'm thinking of cutting a 2.0.0-M1 release (from the master branch) at
> some point quite soon.  
>
> Can I check, what's the current state of master and the various
> feature branches.  I see:
>
> - ISIS-1846_internal_utils - this looks like further useful stuff, and
> I know that master has already merged some of this branch in.  Could
> the new commits be merged into master (a fast-forward merge, I think)?
This branch introduces the new 'Internal API', a collection of code
idioms frequently used in isis-core-applib. If we commit to using this
Internal API, we should merge this branch into 2.0.0-M1 as soon as
possible. (Not sure if a fast forward will work ... there's a lot of
code being moved around, but you may definitely try.)

> - ISIS-1740_where_am_i - my recollection was this was close to being
> done and could be merged in (behind a config option?). 
Yes is ready, can be merged in. Only documentation is missing. We have
config options to enable or disable this feature. It introduces a new
annotation in applib: @Parent

> - ISIS-1852_parallel_stream_patch - this looks like a bit of a spike
> to support some JEE use cases, should this be based on M2?
No ISIS-1852 [1] is rather a severe issue, which also affects 1.16. (It
prevents use of parallel streams on collections of domain objects.)

>
>
> We also have for M2:
>
> - dev/2.0.0-M2 which has the DN 5.1 and much more of the JEE stuff
> - ISIS-1779-jax-rs-2 ... hmm, looks like all of this branch except the
> very last commit (Transition to JAX-RS 2.0 Client API) was actually
> rebased onto dev/2.0.0-M2.  So, I think this last commit needs to be
> cherry-picked onto M2?
Let's not worry about ISIS-1779-jax-rs-2 too much right now. The last
commit [2] is kind of an experiment, and maybe I need to redo some of
these ideas anyway.

>
>
> thanks
> Dan
>
>
>

[1] https://issues.apache.org/jira/browse/ISIS-1852
[2]
https://github.com/apache/isis/commit/fd8670e8337f99832f767bf24c26dde33bf34cc5

Merging maint-1.16.1 into master; checking status of our branches

[Dan Haywood]

Hi Andi

just an fyi, I'm currently merging maint-1.16.1 into master.

I'm thinking of cutting a 2.0.0-M1 release (from the master branch) at some
point quite soon.

Can I check, what's the current state of master and the various feature
branches.  I see:

- ISIS-1846_internal_utils - this looks like further useful stuff, and I
know that master has already merged some of this branch in.  Could the new
commits be merged into master (a fast-forward merge, I think)?
- ISIS-1740_where_am_i - my recollection was this was close to being done
and could be merged in (behind a config option?).
- ISIS-1852_parallel_stream_patch - this looks like a bit of a spike to
support some JEE use cases, should this be based on M2?


We also have for M2:

- dev/2.0.0-M2 which has the DN 5.1 and much more of the JEE stuff
- ISIS-1779-jax-rs-2 ... hmm, looks like all of this branch except the very
last commit (Transition to JAX-RS 2.0 Client API) was actually rebased onto
dev/2.0.0-M2.  So, I think this last commit needs to be cherry-picked onto
M2?


thanks
Dan

Re: [VOTE] Apache Isis Core release 1.16.1 RC1

[Andi Huber]

+1


On 14.02.2018 11:10, Dan Haywood wrote:
> I've cut a release for Apache Isis Core and the two archetypes:
>
> * Core 1.16.1
> * HelloWorld Archetype 1.16.1
> * SimpleApp Archetype 1.16.1
>
> The source code artifacts have been uploaded to staging repositories on
> repository.apache.org:
>
> *
> http://repository.apache.org/content/repositories/orgapacheisis-1064/org/apache/isis/core/isis/1.16.1/isis-1.16.1-source-release.zip
> *
> http://repository.apache.org/content/repositories/orgapacheisis-1065/org/apache/isis/archetype/helloworld-archetype/1.16.1/helloworld-archetype-1.16.1-source-release.zip
> *
> http://repository.apache.org/content/repositories/orgapacheisis-1065/org/apache/isis/archetype/simpleapp-archetype/1.16.1/simpleapp-archetype-1.16.1-source-release.zip
>
> For each zip there is a corresponding signature file (append .asc to the
> zip's url).
>
> In the source code repo the code has been tagged as isis-1.16.1-RC1,
> helloworld-archetype-1.16.1-RC1 and simpleapp-archetype-1.16.1-RC1; see
> https://github.com/apache/isis/tags
>
> For instructions on how to verify the release (build from binaries and/or
> use in Maven directly), see
> https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releases
>
> Please verify the release and cast your vote.  The vote will be open for a
> minimum of 72 hours.
>
> [ ] +1
> [ ]  0
> [ ] -1
>

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363751#comment-16363751
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 0e041cfb2427df0b008a14a70e90b281976b727d in isis's branch 
refs/heads/release-1.16.1-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0e041cf ]

ISIS-1813: updates docs and example apps

The updates to example apps WILL BE in the released archetypes for 1.16.1 RC1


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363753#comment-16363753
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 403c85a83a407ba4ed084b7a234a50e6f1fcb590 in isis's branch 
refs/heads/release-1.16.1-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=403c85a ]

ISIS-1813: updates release notes for 1.16.1


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ApacheCon NA 2018 - Travel Assistance applications open.

[Dan Haywood]

*(forwarding this on, as requested by ASF)*



The Travel Assistance Committee (TAC) are pleased to announce that travel
assistance applications for ApacheCon NA 2018 are now open!

We will be supporting ApacheCon NA Montreal, Canada on 24th - 29th
September 2018

 TAC exists to help those that would like to attend ApacheCon events, but
are unable to do so for financial reasons.
For more info on this years applications and qualifying criteria, please
visit the TAC website at < http://www.apache.org/travel/ <
http://www.apache.org/travel/> >. Applications are now open and will close
1st May.

Important: Applications close on May 1st, 2018. Applicants have until the
closing date above to submit their applications (which should contain as
much supporting material as required to efficiently and accurately process
their request), this will enable TAC to announce successful awards shortly
afterwards.

As usual, TAC expects to deal with a range of applications from a diverse
range of backgrounds. We therefore encourage (as always) anyone thinking
about sending in an application to do so ASAP.
We look forward to greeting many of you in Montreal

Kind Regards,
Gavin - (On behalf of the Travel Assistance Committee)
—

[VOTE] Apache Isis Core release 1.16.1 RC1

[Dan Haywood]

I've cut a release for Apache Isis Core and the two archetypes:

* Core 1.16.1
* HelloWorld Archetype 1.16.1
* SimpleApp Archetype 1.16.1

The source code artifacts have been uploaded to staging repositories on
repository.apache.org:

*
http://repository.apache.org/content/repositories/orgapacheisis-1064/org/apache/isis/core/isis/1.16.1/isis-1.16.1-source-release.zip
*
http://repository.apache.org/content/repositories/orgapacheisis-1065/org/apache/isis/archetype/helloworld-archetype/1.16.1/helloworld-archetype-1.16.1-source-release.zip
*
http://repository.apache.org/content/repositories/orgapacheisis-1065/org/apache/isis/archetype/simpleapp-archetype/1.16.1/simpleapp-archetype-1.16.1-source-release.zip

For each zip there is a corresponding signature file (append .asc to the
zip's url).

In the source code repo the code has been tagged as isis-1.16.1-RC1,
helloworld-archetype-1.16.1-RC1 and simpleapp-archetype-1.16.1-RC1; see
https://github.com/apache/isis/tags

For instructions on how to verify the release (build from binaries and/or
use in Maven directly), see
https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releases

Please verify the release and cast your vote.  The vote will be open for a
minimum of 72 hours.

[ ] +1
[ ]  0
[ ] -1

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363730#comment-16363730
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit ad8d4305e1793b7a1333eb71b610411cf4ffa221 in isis's branch 
refs/heads/release-1.16.1-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ad8d430 ]

ISIS-1813: recreating helloworld archetype


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363729#comment-16363729
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 4c39bdb4d6c3964e3cca2f266c51892a58afa18e in isis's branch 
refs/heads/release-1.16.1-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4c39bdb ]

ISIS-1813: recreating simpleapp archetype


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-1813) Release tasks for 1.16.1

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363728#comment-16363728
 ] 

ASF subversion and git services commented on ISIS-1813:
---

Commit 354439f3c5594d49263eaa94405fe158c1ed4d92 in isis's branch 
refs/heads/release-1.16.1-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=354439f ]

ISIS-1813: fixes java7/8 compilation issue (unused import from Java 8)


> Release tasks for 1.16.1
> 
>
> Key: ISIS-1813
> URL: https://issues.apache.org/jira/browse/ISIS-1813
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)