[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #719: OAK-9950|Update tika version in oak

2022-09-26 Thread GitBox
reschke commented on code in PR #719: URL: https://github.com/apache/jackrabbit-oak/pull/719#discussion_r979870483 ## oak-parent/pom.xml: ## @@ -61,7 +61,7 @@ 1.7.32 1.2.10 2.0.206 -1.24.1 +1.26 Review Comment: I believe we should upgrade to the

[GitHub] [jackrabbit-oak] nit0906 commented on pull request #719: OAK-9950|Update tika version in oak

2022-09-26 Thread GitBox
nit0906 commented on PR #719: URL: https://github.com/apache/jackrabbit-oak/pull/719#issuecomment-1257849140 An update to commons-lang3 is also needed to update tika to 1.26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-filevault] reschke merged pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-26 Thread GitBox
reschke merged PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #721: OAK-9862 - Some tests in oak-search are not cleaning up Elastic Search indexes after the test

2022-09-26 Thread GitBox
fabriziofortino merged PR #721: URL: https://github.com/apache/jackrabbit-oak/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-26 Thread GitBox
fabriziofortino merged PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-filevault] kwin merged pull request #246: Document implicit namespace registration

2022-09-26 Thread GitBox
kwin merged PR #246: URL: https://github.com/apache/jackrabbit-filevault/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #721: OAK-9862 - Some tests in oak-search are not cleaning up Elastic Search indexes after the test

2022-09-26 Thread GitBox
nfsantos opened a new pull request, #721: URL: https://github.com/apache/jackrabbit-oak/pull/721 Fix: Elasticsearch indexes created by common tests (oak-search module) were not being deleted at the end of the tests. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
kwin commented on code in PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979279113 ## vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java: ## @@ -1200,28 +1200,37 @@ private boolean

[GitHub] [jackrabbit-filevault] reschke commented on pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
reschke commented on PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#issuecomment-1257024542 > The IT fails because the bad namespaces are not registered. Either add those via CND file or programmatically in the IT. They only fail for the property; no. The

[GitHub] [jackrabbit-filevault] reschke commented on a diff in pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
reschke commented on code in PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979278843 ## vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java: ## @@ -1200,28 +1200,37 @@ private boolean

[GitHub] [jackrabbit-filevault] kwin commented on pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
kwin commented on PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#issuecomment-1256994717 The IT fails because the bad namespaces are not registered. Either add those via CND file or programmatically in the IT. -- This is an automated message from the Apache Git

[GitHub] [jackrabbit-filevault] kwin commented on pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
kwin commented on PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#issuecomment-1256988904 I guess we also need adaptations in

[GitHub] [jackrabbit-filevault] reschke commented on a diff in pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
reschke commented on code in PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979257377 ## vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java: ## @@ -1200,28 +1200,37 @@ private boolean

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #245: JCRVLT-658: Importer fails for invalid namespace names

2022-09-24 Thread GitBox
kwin commented on code in PR #245: URL: https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979253264 ## vault-core/src/test/resources/test-packages/badnamespacenames.zip/META-INF/vault/config.xml: ## @@ -0,0 +1,93 @@

[GitHub] [jackrabbit-oak] gnaresh19 commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-23 Thread GitBox
gnaresh19 commented on code in PR #715: URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r978985478 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java: ## @@ -151,6 +153,7 @@ private

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-23 Thread GitBox
nfsantos commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978722673 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelperTest.java: ## @@ -16,26 +16,29 @@ */ package

[GitHub] [jackrabbit-oak] smiroslav commented on a diff in pull request #698: OAK-9928 Add benchmark for access of binary values in cloud DataStore

2022-09-23 Thread GitBox
smiroslav commented on code in PR #698: URL: https://github.com/apache/jackrabbit-oak/pull/698#discussion_r978577801 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/SegmentTarFixture.java: ## @@ -346,6 +354,7 @@ public Oak[] setUpCluster(int n,

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-23 Thread GitBox
nfsantos commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978570331 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -41,51 +48,65 @@ class ElasticIndexHelper

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-23 Thread GitBox
nfsantos commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978566806 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -16,18 +16,25 @@ */ package

[GitHub] [jackrabbit] rkovarik commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-23 Thread GitBox
rkovarik commented on code in PR #128: URL: https://github.com/apache/jackrabbit/pull/128#discussion_r978566775 ## jackrabbit-jcr2spi/src/test/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImplTest.java: ## @@ -0,0 +1,39 @@ +package

[GitHub] [jackrabbit] mduerig commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-23 Thread GitBox
mduerig commented on code in PR #128: URL: https://github.com/apache/jackrabbit/pull/128#discussion_r978547476 ## jackrabbit-jcr2spi/src/test/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImplTest.java: ## @@ -0,0 +1,39 @@ +package

[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-23 Thread GitBox
joerghoh commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978383530 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -41,51 +48,65 @@ class ElasticIndexHelper

[GitHub] [jackrabbit-oak] anchela merged pull request #717: OAK-9954 : Dynamic membership/group should spot conflicts with existing groups

2022-09-23 Thread GitBox
anchela merged PR #717: URL: https://github.com/apache/jackrabbit-oak/pull/717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-23 Thread GitBox
joerghoh commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978382436 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -16,18 +16,25 @@ */ package

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #718: OAK-9930 - Thread leak in elastic index statistics module

2022-09-23 Thread GitBox
fabriziofortino merged PR #718: URL: https://github.com/apache/jackrabbit-oak/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-23 Thread GitBox
tihom88 commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r978373595 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelperTest.java: ## @@ -16,26 +16,29 @@ */ package

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #718: OAK-9930 - Thread leak in elastic index statistics module

2022-09-23 Thread GitBox
fabriziofortino commented on code in PR #718: URL: https://github.com/apache/jackrabbit-oak/pull/718#discussion_r978364437 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexStatistics.java: ## @@ -63,6 +65,15 @@ public class

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

2022-09-23 Thread GitBox
fabriziofortino merged PR #711: URL: https://github.com/apache/jackrabbit-oak/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit] rkovarik commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-23 Thread GitBox
rkovarik commented on code in PR #128: URL: https://github.com/apache/jackrabbit/pull/128#discussion_r978318905 ## jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java: ## @@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {

[GitHub] [jackrabbit] rkovarik commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-23 Thread GitBox
rkovarik commented on code in PR #128: URL: https://github.com/apache/jackrabbit/pull/128#discussion_r978318905 ## jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java: ## @@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-23 Thread GitBox
nit0906 commented on code in PR #715: URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r978311689 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileSplitter.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-22 Thread GitBox
nit0906 commented on code in PR #715: URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r978288503 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileSplitter.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the

[GitHub] [jackrabbit-oak] nit0906 merged pull request #697: Oak-9917 | Better ES test coverage

2022-09-22 Thread GitBox
nit0906 merged PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #718: OAK-9930 - Thread leak in elastic index statistics module

2022-09-22 Thread GitBox
nfsantos opened a new pull request, #718: URL: https://github.com/apache/jackrabbit-oak/pull/718 Reuse a Thread pool to execute the requests to refresh the cache in the Elastic Index statistics instead of creating a new thread pool for every refresh operation (these thread pools were not

[GitHub] [jackrabbit-oak] nit0906 commented on pull request #697: Oak-9917 | Better ES test coverage

2022-09-22 Thread GitBox
nit0906 commented on PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#issuecomment-1254962360 > Is there a replacement for LuceneIndexDescendatSpellCheckTest? This file was removed, but I don't see a replacement. Or is it redundant with some other test? @nfsantos -

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

2022-09-22 Thread GitBox
nfsantos commented on code in PR #711: URL: https://github.com/apache/jackrabbit-oak/pull/711#discussion_r977598229 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -445,6 +445,12 @@ public

[GitHub] [jackrabbit] reschke commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-22 Thread GitBox
reschke commented on code in PR #128: URL: https://github.com/apache/jackrabbit/pull/128#discussion_r977595502 ## jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java: ## @@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #697: Oak-9917 | Better ES test coverage

2022-09-22 Thread GitBox
fabriziofortino commented on code in PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#discussion_r977560831 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexPlannerCommonTest.java: ## @@ -0,0 +1,233 @@ +/* + *

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #708: OAK-9946: Consistency check for versionable nodes

2022-09-22 Thread GitBox
rishabhdaim commented on code in PR #708: URL: https://github.com/apache/jackrabbit-oak/pull/708#discussion_r977515877 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/AsyncDocumentProcessor.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache

[GitHub] [jackrabbit] reschke commented on pull request #128: JCR-4608 Upgrade to commons-collections4

2022-09-22 Thread GitBox
reschke commented on PR #128: URL: https://github.com/apache/jackrabbit/pull/128#issuecomment-1254844749 can you try to rebase this based on what's currently in trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #708: OAK-9946: Consistency check for versionable nodes

2022-09-22 Thread GitBox
rishabhdaim commented on code in PR #708: URL: https://github.com/apache/jackrabbit-oak/pull/708#discussion_r977480174 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/AsyncNodeStateProcessor.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

2022-09-22 Thread GitBox
fabriziofortino commented on code in PR #711: URL: https://github.com/apache/jackrabbit-oak/pull/711#discussion_r977465765 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java: ## @@ -445,6 +445,12 @@ public

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #697: Oak-9917 | Better ES test coverage

2022-09-21 Thread GitBox
nit0906 commented on code in PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#discussion_r977142300 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexPlannerCommonTest.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

2022-09-21 Thread GitBox
stefan-egli commented on PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1254002255 Regarding the "two separate metrics" question: I think there's two different layers to this question: a code design and a metric design question. I've only had a quick look at

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #709: OAK-9945 - Migrate index creation from Rest High Level Client to the new Java API Client

2022-09-21 Thread GitBox
fabriziofortino commented on code in PR #709: URL: https://github.com/apache/jackrabbit-oak/pull/709#discussion_r976628273 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexWriter.java: ## @@ -158,24 +159,23 @@ private void

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #544: Bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] closed pull request #544: Bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /oak-parent URL: https://github.com/apache/jackrabbit-oak/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #544: Bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] commented on PR #544: URL: https://github.com/apache/jackrabbit-oak/pull/544#issuecomment-1253828112 Looks like com.fasterxml.jackson.core:jackson-databind is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #712: OAK-9947: upgrade jackson (including databind) to 2.13.4

2022-09-21 Thread GitBox
fabriziofortino merged PR #712: URL: https://github.com/apache/jackrabbit-oak/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #697: Oak-9917 | Better ES test coverage

2022-09-21 Thread GitBox
nfsantos commented on code in PR #697: URL: https://github.com/apache/jackrabbit-oak/pull/697#discussion_r976447576 ## oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexPlannerCommonTest.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
fabriziofortino merged PR #713: URL: https://github.com/apache/jackrabbit-oak/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain commented on code in PR #715: URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r976324312 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java: ## @@ -265,6 +271,55 @@ public void reindex()

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #587: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain commented on code in PR #587: URL: https://github.com/apache/jackrabbit-oak/pull/587#discussion_r969237928 ## oak-run-commons/pom.xml: ## @@ -147,6 +147,11 @@ h2 ${h2.version} + +org.lz4 +lz4-java +

[GitHub] [jackrabbit-oak] amit-jain opened a new pull request, #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain opened a new pull request, #715: URL: https://github.com/apache/jackrabbit-oak/pull/715 - Parallel indexing enabled by splitting the FlatFileStore taking into account aggregation and then running multiple threads to do the indexing - LZ4 compression enabled Work over

[GitHub] [jackrabbit-oak] amit-jain commented on pull request #587: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command

2022-09-21 Thread GitBox
amit-jain commented on PR #587: URL: https://github.com/apache/jackrabbit-oak/pull/587#issuecomment-1253484891 New PR which incorporates the review comments https://github.com/apache/jackrabbit-oak/pull/715 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] jelmini closed pull request #707: Add failFast option to ConsistencyChecker

2022-09-21 Thread GitBox
jelmini closed pull request #707: Add failFast option to ConsistencyChecker URL: https://github.com/apache/jackrabbit-oak/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] nfsantos commented on pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
nfsantos commented on PR #713: URL: https://github.com/apache/jackrabbit-oak/pull/713#issuecomment-1253402399 > Where did you take these digests from? I take them from a run of the unit tests. I run the tests with a version of the Elastiknn for which I don't have the digest and copy

[GitHub] [jackrabbit-oak] joerghoh commented on pull request #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
joerghoh commented on PR #713: URL: https://github.com/apache/jackrabbit-oak/pull/713#issuecomment-1253360241 Where did you take these digests from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #601: Bump mongo-java-driver from 3.12.7 to 3.12.8 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] closed pull request #601: Bump mongo-java-driver from 3.12.7 to 3.12.8 in /oak-parent URL: https://github.com/apache/jackrabbit-oak/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #601: Bump mongo-java-driver from 3.12.7 to 3.12.8 in /oak-parent

2022-09-21 Thread GitBox
dependabot[bot] commented on PR #601: URL: https://github.com/apache/jackrabbit-oak/pull/601#issuecomment-1253335587 Looks like org.mongodb:mongo-java-driver is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] reschke merged pull request #695: OAK-9925: update MongoDB Java Driver dependency to 3.12.11

2022-09-21 Thread GitBox
reschke merged PR #695: URL: https://github.com/apache/jackrabbit-oak/pull/695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] jsedding merged pull request #676: OAK-9785 - Tar SegmentStore can be corrupted during compaction

2022-09-21 Thread GitBox
jsedding merged PR #676: URL: https://github.com/apache/jackrabbit-oak/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #713: OAK-9951 - Improve support for running unit tests with Elasticsearch 8

2022-09-21 Thread GitBox
nfsantos opened a new pull request, #713: URL: https://github.com/apache/jackrabbit-oak/pull/713 Add OOTB support for testing with Elasticsearch 8.3.3 and 8.4.1. Now it is enough to pass the property -DelasticDockerImageVersion=[8.3.3|8.4.4] to the Maven build. In more detail: the

[GitHub] [jackrabbit-oak] fabriziofortino opened a new pull request, #712: OAK-9947: upgrade jackson (including databind) to 2.13.4

2022-09-20 Thread GitBox
fabriziofortino opened a new pull request, #712: URL: https://github.com/apache/jackrabbit-oak/pull/712 The original goal of this task was to upgrade jackson-databind since versions before 2.13.0 are affected by [CVE-2020-36518](https://nvd.nist.gov/vuln/detail/CVE-2020-36518).

[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #711: OAK-9948 - Migrate search suggestions request from RHLC to new Java Client

2022-09-20 Thread GitBox
nfsantos opened a new pull request, #711: URL: https://github.com/apache/jackrabbit-oak/pull/711 Migrate Elasticsearch usage of HLRC to new Java Client in call to suggestions for spellchecking and in a test for similarity. -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin merged pull request #84: JCRVLT-651 allow to exclude main artifact from validation

2022-09-20 Thread GitBox
kwin merged PR #84: URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #207: OAK-9050 Remove redundant (un-)boxing in oak-segment-tar

2022-09-19 Thread GitBox
github-actions[bot] commented on PR #207: URL: https://github.com/apache/jackrabbit-oak/pull/207#issuecomment-1251753159 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] mreutegg opened a new pull request, #708: OAK-9946: Consistency check for versionable nodes

2022-09-19 Thread GitBox
mreutegg opened a new pull request, #708: URL: https://github.com/apache/jackrabbit-oak/pull/708 Some refactoring and new checks on jcr:baseVersion and jcr:versionHistory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #705: OAK-9932 - Allow specifying the version of the ES docker image used for tests.

2022-09-19 Thread GitBox
fabriziofortino merged PR #705: URL: https://github.com/apache/jackrabbit-oak/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg closed pull request #208: OAK-9054-Fix of OAK-8930 leading to increase in time to get blobs from Azure.

2022-09-19 Thread GitBox
mreutegg closed pull request #208: OAK-9054-Fix of OAK-8930 leading to increase in time to get blobs from Azure. URL: https://github.com/apache/jackrabbit-oak/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #208: OAK-9054-Fix of OAK-8930 leading to increase in time to get blobs from Azure.

2022-09-19 Thread GitBox
mreutegg commented on PR #208: URL: https://github.com/apache/jackrabbit-oak/pull/208#issuecomment-1250670619 This was committed to SVN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #208: OAK-9054-Fix of OAK-8930 leading to increase in time to get blobs from Azure.

2022-09-18 Thread GitBox
github-actions[bot] commented on PR #208: URL: https://github.com/apache/jackrabbit-oak/pull/208#issuecomment-1250474285 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #209: OAK-9060: override ColumnImpl#copyOf() in in FacetColumnImpl

2022-09-17 Thread GitBox
github-actions[bot] commented on PR #209: URL: https://github.com/apache/jackrabbit-oak/pull/209#issuecomment-1250175305 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #213: OAK-9069 Remove unnecessary (un)boxing in oak-auth-external

2022-09-17 Thread GitBox
github-actions[bot] commented on PR #213: URL: https://github.com/apache/jackrabbit-oak/pull/213#issuecomment-1250175296 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #214: OAK-9070 Remove unnecessary (un)boxing in oak-authorization-principalbased

2022-09-16 Thread GitBox
github-actions[bot] commented on PR #214: URL: https://github.com/apache/jackrabbit-oak/pull/214#issuecomment-1249977821 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #215: OAK-9071 Remove unnecessary (un)boxing in oak-benchmarks

2022-09-16 Thread GitBox
github-actions[bot] commented on PR #215: URL: https://github.com/apache/jackrabbit-oak/pull/215#issuecomment-1249977815 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #216: OAK-9072 Remove unnecessary (un)boxing in oak-blob-plugins

2022-09-16 Thread GitBox
github-actions[bot] commented on PR #216: URL: https://github.com/apache/jackrabbit-oak/pull/216#issuecomment-1249977805 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] rishabhdaim commented on pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

2022-09-16 Thread GitBox
rishabhdaim commented on PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1249557733 I think we discussed on these lines earlier to create a separate `StatsCollector` for throttling operation but It would essentially mean to duplicate the stats collection logic

[GitHub] [jackrabbit-oak] mreutegg merged pull request #683: OAK-9918: DocumentNodeStore consistency check

2022-09-16 Thread GitBox
mreutegg merged PR #683: URL: https://github.com/apache/jackrabbit-oak/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #683: OAK-9918: DocumentNodeStore consistency check

2022-09-16 Thread GitBox
mreutegg commented on code in PR #683: URL: https://github.com/apache/jackrabbit-oak/pull/683#discussion_r972963822 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/OrphanedNodeCheck.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #683: OAK-9918: DocumentNodeStore consistency check

2022-09-16 Thread GitBox
mreutegg commented on code in PR #683: URL: https://github.com/apache/jackrabbit-oak/pull/683#discussion_r972963172 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/OrphanedNodeCheck.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #683: OAK-9918: DocumentNodeStore consistency check

2022-09-16 Thread GitBox
mreutegg commented on code in PR #683: URL: https://github.com/apache/jackrabbit-oak/pull/683#discussion_r972959861 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/document/check/OrphanedNodeCheck.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software

[GitHub] [jackrabbit-oak] mreutegg closed pull request #226: OAK-9082 Remove unnecessary (un)boxing in oak-store-composite

2022-09-16 Thread GitBox
mreutegg closed pull request #226: OAK-9082 Remove unnecessary (un)boxing in oak-store-composite URL: https://github.com/apache/jackrabbit-oak/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #226: OAK-9082 Remove unnecessary (un)boxing in oak-store-composite

2022-09-16 Thread GitBox
mreutegg commented on PR #226: URL: https://github.com/apache/jackrabbit-oak/pull/226#issuecomment-1249102483 Closing this PR because the proposed changes are unrelated to boxing (`Long.valueOf()` vs `Long.parseLong()`). -- This is an automated message from the Apache Git Service. To

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #227: OAK-9083 Remove unnecessary (un)boxing in oak-store-document

2022-09-16 Thread GitBox
mreutegg commented on PR #227: URL: https://github.com/apache/jackrabbit-oak/pull/227#issuecomment-1249098465 Closing this PR because impact on performance is questionable. See also discussion in OAK-9083. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] mreutegg closed pull request #227: OAK-9083 Remove unnecessary (un)boxing in oak-store-document

2022-09-16 Thread GitBox
mreutegg closed pull request #227: OAK-9083 Remove unnecessary (un)boxing in oak-store-document URL: https://github.com/apache/jackrabbit-oak/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] mreutegg merged pull request #228: OAK-9084 Remove unnecessary (un)boxing in oak-store-spi

2022-09-16 Thread GitBox
mreutegg merged PR #228: URL: https://github.com/apache/jackrabbit-oak/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg merged pull request #229: OAK-9085 Remove unnecessary (un)boxing in oak-webapp

2022-09-16 Thread GitBox
mreutegg merged PR #229: URL: https://github.com/apache/jackrabbit-oak/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg closed pull request #237: s3Connector changes for regions apart from aws default regions

2022-09-16 Thread GitBox
mreutegg closed pull request #237: s3Connector changes for regions apart from aws default regions URL: https://github.com/apache/jackrabbit-oak/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #235: s3Connector changes for regions apart from aws default regions

2022-09-16 Thread GitBox
mreutegg commented on PR #235: URL: https://github.com/apache/jackrabbit-oak/pull/235#issuecomment-1249071511 Change has been committed to SVN: http://svn.apache.org/viewvc?rev=1879352=rev -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jackrabbit-oak] mreutegg closed pull request #235: s3Connector changes for regions apart from aws default regions

2022-09-16 Thread GitBox
mreutegg closed pull request #235: s3Connector changes for regions apart from aws default regions URL: https://github.com/apache/jackrabbit-oak/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #237: s3Connector changes for regions apart from aws default regions

2022-09-16 Thread GitBox
mreutegg commented on PR #237: URL: https://github.com/apache/jackrabbit-oak/pull/237#issuecomment-1249071913 Change has been committed to SVN: http://svn.apache.org/viewvc?rev=1879390=rev -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #694: Bump postgresql from 42.2.18 to 42.4.1 in /oak-parent

2022-09-16 Thread GitBox
mreutegg commented on PR #694: URL: https://github.com/apache/jackrabbit-oak/pull/694#issuecomment-1249064559 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

2022-09-16 Thread GitBox
mreutegg commented on PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1248989611 I only noticed now that Stefan also

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

2022-09-16 Thread GitBox
mreutegg commented on code in PR #690: URL: https://github.com/apache/jackrabbit-oak/pull/690#discussion_r972666014 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreStats.java: ## @@ -157,6 +203,41 @@ public

[GitHub] [jackrabbit-oak] mreutegg merged pull request #688: OAK-9891: Removal (purge) of version of a node does not remove associated labels

2022-09-16 Thread GitBox
mreutegg merged PR #688: URL: https://github.com/apache/jackrabbit-oak/pull/688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #702: OAK-9535: Support recovery of large branch merge - backport to 1.8

2022-09-15 Thread GitBox
rishabhdaim commented on code in PR #702: URL: https://github.com/apache/jackrabbit-oak/pull/702#discussion_r972120239 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/RecoveryTest.java: ## @@ -157,6 +169,69 @@ public void recoverOther() throws

[GitHub] [jackrabbit-oak] anchela merged pull request #669: OAK-9902 : Configuration for ExternalUserValidator

2022-09-15 Thread GitBox
anchela merged PR #669: URL: https://github.com/apache/jackrabbit-oak/pull/669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #702: OAK-9535: Support recovery of large branch merge - backport to 1.8

2022-09-15 Thread GitBox
mreutegg commented on code in PR #702: URL: https://github.com/apache/jackrabbit-oak/pull/702#discussion_r971858137 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/RecoveryTest.java: ## @@ -157,6 +169,69 @@ public void recoverOther() throws

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #702: OAK-9934: Backport of Oak-9535 "Support recovery of large branch merge" to 1.8

2022-09-15 Thread GitBox
mreutegg commented on code in PR #702: URL: https://github.com/apache/jackrabbit-oak/pull/702#discussion_r971762034 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBranch.java: ## @@ -130,6 +130,15 @@ public NodeState

[GitHub] [jackrabbit-oak] mreutegg merged pull request #701: OAK-9535: Support recovery of large branch merge - backport to 1.22

2022-09-15 Thread GitBox
mreutegg merged PR #701: URL: https://github.com/apache/jackrabbit-oak/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    3   4   5   6   7   8   9   10   11   12   >