Re: [GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread Claude Warren
Why would you not fix the bug? On Mon, May 11, 2015 at 1:33 PM, ajs6f g...@git.apache.org wrote: Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r30033794 --- Diff:

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100894484 Sounds good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread Claude Warren
I replied before my system picked up the previous 2 notes. No problems here. On Mon, May 11, 2015 at 2:13 PM, ajs6f g...@git.apache.org wrote: Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100901273 Because the comment

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/57#discussion_r30033649 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/base/block/BlockMgrCache.java --- @@ -58,10 +58,7 @@ private BlockMgrCache(int readSlots, int writeSlots,

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100901273 Because the comment disappeared-- clearly something else was going on, as @afs later indicated he already fixed the bug. What is the problem? --- If your project is set up

[jira] [Created] (JENA-937) RiotReader can be removed ; use ReaderRIOT for the LangRIOT hierarchy.

2015-05-11 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-937: -- Summary: RiotReader can be removed ; use ReaderRIOT for the LangRIOT hierarchy. Key: JENA-937 URL: https://issues.apache.org/jira/browse/JENA-937 Project: Apache Jena

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100901958 Oh, cool. Yeah, there's a number of message-emitting sources here, eh? Asynchronous transactions are tricky. {grin} --- If your project is set up for it, you can reply to

[GitHub] jena pull request: Remove caching gear from jena-core and use inst...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/59 Remove caching gear from jena-core and use instead that in jena-base You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

2015-05-11 Thread amiara514
Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-100941772 Some new tests have been submitted. About the implementation, your proposal would use a StandardAnalyzer on indexing phase and a localized queryAnalyzer for

Re: jena-permissions POM and plugin

2015-05-11 Thread Andy Seaborne
That's my understanding as well for category-a licenses. In DEPENDENCIES is nice but nothing in NOTICE is needed. Seems that Eclipse going on about EPL was not accurate. Andy On 09/05/15 15:18, Stian Soiland-Reyes wrote: Technically those Maven plugins are never included in any Jena

[jira] [Created] (JENA-938) Clean up dead code

2015-05-11 Thread A. Soroka (JIRA)
A. Soroka created JENA-938: -- Summary: Clean up dead code Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/60 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from jena-arq, jena-base, jena-core, jena-csv, jena-iri, an jena-permissions. Includes removals for: Unthrown

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread A. Soroka (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538062#comment-14538062 ] A. Soroka commented on JENA-938: https://github.com/apache/jena/pull/60 Clean up dead code

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538061#comment-14538061 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request:

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-100955353 One last thing: it seems like a good idea to me to put a note in `CacheSimple` about the slot-replacement and fixed-size qualities that are demanded there. Or maybe instead

[GitHub] jena pull request: Remove caching gear from jena-core and use inst...

2015-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538384#comment-14538384 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538454#comment-14538454 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request:

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538142#comment-14538142 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request:

Jena: Spark vs. Drools

2015-05-11 Thread Paul Houle
I just want to share a few of my desiderata for working with RDF data. There really are a few of these that are contradictory in nature. These touch on the Graph/Model split and similar things. One of them is streaming processing with tools like Spark, where the real point is raw speed, and

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-101007860 Good suggestion. I'll add that as I do #59. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538364#comment-14538364 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101010157 The files in package thrift/wire starting `RDF_` are autogenerated by the Thrift code generator. They'll get uncleaned if that's remade. (Thrift code generation is not part of

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538414#comment-14538414 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538699#comment-14538699 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on a diff in the pull

[jira] [Closed] (JENA-936) Typo: org.aapche.jena.riot

2015-05-11 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne closed JENA-936. -- Resolution: Fixed Typo: org.aapche.jena.riot -- Key: JENA-936

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/63#discussion_r30086187 --- Diff: jena-core/src/main/java/jena/rdfcompare.java --- @@ -108,11 +105,6 @@ protected static void usage() { protected static void read(Model

[jira] [Commented] (JENA-936) Typo: org.aapche.jena.riot

2015-05-11 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538741#comment-14538741 ] Andy Seaborne commented on JENA-936: Thank - now fixed in jena.staging.apache.org.

[GitHub] jena pull request: Relying more on Guava impl for caching

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/57#issuecomment-101003455 Thank you. Merged into code base, and reflecting the conversion here: Keep Cache0 (avoid nulls!) and keep the general CacheSet over a Cache due to otherwise changing the

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101013671 Please, if it's easy to do that; ditto the javacc overwrites. (sparql_10 are sparql_11 actually code directly from SPARQL spec so anything touching them gets special

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101015106 Yes. (Sorry about assuming that was clear - over-familiarity with the code layout) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

2015-05-11 Thread osma
Github user osma commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-101017747 Great tests! I wonder if there isn't a better method to convert 3 letter ISO 639 language codes to the 2 letter equivalents. But since there is only a relatively

[GitHub] jena pull request: jena-text multilingual indexing (take 2)

2015-05-11 Thread amiara514
Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/52#issuecomment-101035985 But since there is only a relatively small number of Lucene analyzers anyway, maybe this is OK. It's why it's done like this :-) No, that wouldn't

Re: Jena: Spark vs. Drools

2015-05-11 Thread Bruno P. Kinoshita
Hi Paul I worked with Jena in a Hadoop/Hive cluster, but without Spark. There was only one job that took too long to work on my dataset, but I suspect it was due to something in my custom code - which could be replaced in parts now by Elephas - or due to the lack of optimization in the storage

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538647#comment-14538647 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/63 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from the src/main resources in jena-core and jena-base, including: Unnecessary @SuppressWarnings annotations

Re: another clean up suggestion: dead code and its resuscitation

2015-05-11 Thread aj...@virginia.edu
I've laid in a ticket: https://issues.apache.org/jira/browse/JENA-938 and attached a few PRs of reasonable size. They contain the removal of superinterfaces that don't need declaration, checked exceptions that cannot be thrown, and unnecessary typecasts. Those seemed to be entirely

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101011238 Hm. Do you think it's worth taking a look at those Thrift tools to see if I can get them to gen cleaner code? (It has to be said that I've never used Thrift.) --- If your

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538372#comment-14538372 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101012864 Yeah, I know what Thrift is, but I have no direct experience with it. I've worked with a few code generating frameworks (mostly for WSDL-related stuff) that gave relatively

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538395#comment-14538395 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/60#issuecomment-101014513 Okay, I will make that happen, but I'm not sure what you mean by javacc overwrites. You mean methods `sparql_10` and `sparql_11`? --- If your project is set up for it, you

Re: Jena: Spark vs. Drools

2015-05-11 Thread Paul Houle
I've processed cumulative terabytes of data with https://github.com/paulhoule/infovore which was developed pre-Elephas. One issue I have is that at this scale the reader has to be 100% bombproof. Every triple I read is on a single line, but it guaranteed that there will be a bad triple in

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/61 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from jena-elephas and its submodules, jena-querybuilder, and jena-fuseki1 and jena-fuseki2, including: Unthrown

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538285#comment-14538285 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-11 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/62 JENA-938: Nonfunctional cleanup in various modules Remove some forms of dead code from jena-jdbc and its submodules, jena-sdb, jena-spatial, jena-tdb and jena-text, including: Unthrown checked