[GitHub] jena pull request #458: JENA-1481, JENA-1586: Delete databases and expel fro...

2018-08-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/458#discussion_r209309616 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java --- @@ -288,28 +294,89 @@ protected void execDeleteItem

[GitHub] jena pull request #458: JENA-1481, JENA-1586: Delete databases and expel fro...

2018-08-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/458#discussion_r209307965 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/IO.java --- @@ -364,4 +369,31 @@ public static String uniqueFilename(String directory, String base

[GitHub] jena pull request #449: JENA-1578

2018-07-27 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r205813086 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1740,243 @@ public String toString

[GitHub] jena pull request #449: JENA-1578

2018-07-27 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/449#discussion_r205813451 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ParameterizedSparqlString.java --- @@ -1734,4 +1740,243 @@ public String toString

[GitHub] jena pull request #448: JENA-1575: tdbloader - unnecessarily specific class ...

2018-07-13 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/448#discussion_r202350272 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/TDBLoader.java --- @@ -219,11 +211,14 @@ public final void setGenerateStats(boolean generateStats

Old internal notes?

2018-06-28 Thread ajs6f
that don't exist and plans that don't seemed to have been carried out. Am I missing something, or shall I move that page to the Cwiki instance as historical-only? ajs6f

Re: [jira] [Commented] (JENA-1568) Don't use JUnit3 TestCase for in SSE tests

2018-06-28 Thread ajs6f
I'm not surprised. We do some clever things in tests! My suggestion is really just to add a ticket (an "epic" or whatever) to track overall migration status, so that we do at least have it on the table as a conscious long-term goal. ajs6f > On Jun 28, 2018, at 11:08 AM, Claude

Re: Towards Jena 3.8.0

2018-06-22 Thread ajs6f
Andy, I can do it as well, but what would be really great would be for someone who hasn't done it to enjoy the opportunity! It's very straightforward (we have extensive notes [1]) and a great way to learn about some of Jena's machinery beyond the codebase itself. ajs6f [1] https

Re: Commit workflow

2018-06-20 Thread ajs6f
integrations and make the switch... ajs6f > On Jun 20, 2018, at 9:52 AM, Aaron Coburn wrote: > > Thanks Andy, this is very helpful. > > Best, > Aaron > >> On Jun 20, 2018, at 6:02 AM, Andy Seaborne wrote: >> >> Aaron, Chris, all, >> >> On

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-06-15 Thread ajs6f
See comments in-line... ajs6f > On Jun 15, 2018, at 9:49 AM, Maxime Lefrançois > wrote: > > Dear all, > > Regarding our contribution proposal to enable extensions to override SPARQL > operators in Jena > > We finally got the agreement from our institution

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194564667 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194566823 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194567840 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194564937 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194568224 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #431: JENA-1559: Alternative PrefixMapping implementation;...

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/431#discussion_r194399107 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/PrefixMappingOver.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #434: JENA-1562: Fix for Graph.size() for TDB2 graphs

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/434#discussion_r194398578 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/store/GraphViewSwitchable.java --- @@ -79,16 +83,34 @@ public TransactionHandler

[GitHub] jena pull request #431: JENA-1559: Alternative PrefixMapping implementation;...

2018-06-11 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/431#discussion_r194364163 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/PrefixMappingOver.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #434: JENA-1562: Fix for Graph.size() for TDB2 graphs

2018-06-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/434#discussion_r194269455 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/GraphView.java --- @@ -165,6 +165,9 @@ public void performDelete( Triple t ) { Node o

Re: New dependency : Apache Commons Compress

2018-06-03 Thread ajs6f
This all sounds quite reasonable, but I have one question: why would we include awaitility in the downloads? Isn't it only used for test code? ajs6f > On Jun 3, 2018, at 1:53 PM, Andy Seaborne wrote: > > JENA-1554 (support bz2 compression support) / PR#427 includes adding a new >

Re: Jena Eyeball [was: JENA-1541]

2018-05-23 Thread ajs6f
+1. ajs6f > On May 21, 2018, at 1:44 PM, Bruno P. Kinoshita <ki...@apache.org> wrote: > > Sounds good to me > +1 > > Sent from Yahoo Mail on Android > > On Tue, 22 May 2018 at 5:08, Andy Seaborne<a...@apache.org> wrote: To pull > this into a pl

[GitHub] jena pull request #423: Tweaks

2018-05-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/423#discussion_r189391950 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/nodevalue/NodeFunctions.java --- @@ -254,28 +254,33 @@ public static String lang(Node node

[GitHub] jena pull request #423: Tweaks

2018-05-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/423#discussion_r189388128 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/nodevalue/NodeFunctions.java --- @@ -254,28 +254,33 @@ public static String lang(Node node

[GitHub] jena pull request #423: Tweaks

2018-05-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/423#discussion_r189388102 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/nodevalue/NodeFunctions.java --- @@ -254,28 +254,33 @@ public static String lang(Node node

[GitHub] jena pull request #423: Tweaks

2018-05-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/423#discussion_r189388383 --- Diff: jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/txn/TransactionCoordinator.java --- @@ -88,6 +89,22 @@ // See

Re: parsing and matching triples

2018-05-12 Thread ajs6f
> On May 11, 2018, at 6:48 PM, Andy Seaborne <a...@apache.org> wrote: > On 11/05/18 20:35, ajs6f wrote: >>> On May 9, 2018, at 3:31 AM, Dave Reynolds <dave.e.reyno...@gmail.com> wrote: >>> On 08/05/18 16:55, ajs6f wrote: >>>> Forking a thread of

[GitHub] jena issue #421: Escape @xerces.internal annotations

2018-05-12 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/421 Okay, either way works for me. This is already done, so easier! ---

Re: Old code.

2018-05-12 Thread ajs6f
n"? (From which of course things could be moved back to the released space if they get some love and attention.) ajs6f > On May 12, 2018, at 5:32 AM, Andy Seaborne <a...@apache.org> wrote: > > schemagen is in jena-cmds > > jena-maven-tools is a maven plugin. > >

[GitHub] jena issue #421: Escape @xerces.internal annotations

2018-05-12 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/421 I've never seen `@xerces.internal` before, but it seems to denote types internal to Xerces, right? My one question is: do we need to keep it on all types or can we stick it on a package comment? (Since

Re: parsing and matching triples

2018-05-11 Thread ajs6f
> On May 9, 2018, at 3:31 AM, Dave Reynolds <dave.e.reyno...@gmail.com> wrote: > > On 08/05/18 16:55, ajs6f wrote: >> Forking a thread off to dev@: >> Do we have a global policy about where null is accepted as a wildcard? I >> know it works in at least some p

Re: parsing and matching triples

2018-05-11 Thread ajs6f
, and variables. @param other a node to test for matching @return true iff this node accepts the other as a match */ which doesn't discuss null. ajs6f > On May 9, 2018, at 8:23 AM, Andy Seaborne <a...@apache.org> wrote: > > > > On 08/05/18 16:55,

Re: Jena Eyeball [was: JENA-1541]

2018-05-11 Thread ajs6f
Not to hijack the thread, but I think a natural question is: do we have any other such examples (well-defined portions of code that aren't under any real maintenance and that we are not releasing)? ajs6f > On May 11, 2018, at 9:10 AM, Chris Dollin <chris.dol...@epimorphics.com>

Re: Jena Eyeball [was: JENA-1541]

2018-05-11 Thread ajs6f
I can see two options: retire it from the docs, or set up a special doc area with lots of warnings on it for "unmaintained/experimental/use-at-your-own-risk/no releases" stuff. We've talked about what to do with non-core stuff before, but this seems a bit different... ajs6f > On

Re: parsing and matching triples

2018-05-08 Thread ajs6f
code to use the actual wildcard objects. ajs6f > On May 8, 2018, at 11:51 AM, Andy Seaborne <a...@apache.org> wrote: > > Barry, > > As a general concept "matching" happens at different levels. > > Triple.match corresponds to the matching done by Graph.fin

[GitHub] jena pull request #416: JENA-1545: ParserProfileWrapper and public checkTrup...

2018-05-07 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/416#discussion_r186517509 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/system/ParserProfile.java --- @@ -49,6 +49,12 @@ /** Create a triple */ public Triple

[GitHub] jena pull request #415: JENA-1543: QueryEngineHttp support for JSON queries.

2018-05-07 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/415#discussion_r186387602 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -538,13 +539,29 @@ else if ( actualContentType.equals

[GitHub] jena issue #299: Turtle Star

2018-05-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/299 +1 on keeping the "default" check as-is, but making the choice of calling it / changing it available via a wrapper. ---

Re: CMS diff: SPARQL S-Expressions (or "SPARQL Syntax Expressions")

2018-05-03 Thread ajs6f
Committed, thank you! ajs6f > On May 3, 2018, at 11:36 PM, Evgeniy Tsvigun <anonym...@apache.org> wrote: > > Clone URL (Committers only): > https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Fnotes%2Fsse.mdtext > > Ev

Re: new branch for JPMS?

2018-04-27 Thread ajs6f
w branch coming from? Are you suggesting decomposing the entire package structure of the codebase and recomposing it in a branch? On what basis would packages be grouped? ajs6f > On Apr 26, 2018, at 2:58 PM, Christopher Johnson <chjohnso...@gmail.com> > wrote: > > In reference to

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-26 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/401 This, to my mind, is now well into the realm of 4.0-sized changes. ---

[GitHub] jena issue #390: Bugfix Tutorial 6: Missing "/" at the end of an URI resulte...

2018-04-24 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/390 @kinow Yep, those Commons threads are exactly what brought it back to my mind. Okay, I suggest that we leave this particular issue as @kinow suggests (Jira ticket and go from there) and I will (sometime

Re: Question about Jena Indexing

2018-04-24 Thread ajs6f
Hello, Anuj-- I may be missing something about your question, but wouldn't Model.add(Model) [1] work here? ajs6f [1] https://jena.apache.org/documentation/javadoc/jena/org/apache/jena/rdf/model/Model.html#add-org.apache.jena.rdf.model.Model- > On Apr 24, 2018, at 7:14 AM, anuj ku

[GitHub] jena pull request #406: JENA-1532 | Added support for escaping special chara...

2018-04-23 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/406#discussion_r183508856 --- Diff: jena-text-es/src/main/java/org/apache/jena/query/text/es/TextIndexES.java --- @@ -422,6 +422,27 @@ public EntityDefinition getDocDef

[GitHub] jena pull request #406: JENA-1532 | Added support for escaping special chara...

2018-04-23 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/406#discussion_r183494640 --- Diff: jena-text-es/src/main/java/org/apache/jena/query/text/es/TextIndexES.java --- @@ -422,6 +422,27 @@ public EntityDefinition getDocDef

[GitHub] jena issue #390: Bugfix Tutorial 6: Missing "/" at the end of an URI resulte...

2018-04-22 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/390 Not to hijack the thread, but do we also want to open a ticket to get all of the relevant (tutorial) files into Git alongside the main codebase? Or should we just subsume that into the larger project

Re: Build failed in Jenkins: Jena_Development_Test #2911

2018-04-21 Thread ajs6f
This seems a bit weird-- not being able to make directories for checkout? Have we seen this before? ajs6f > On Apr 21, 2018, at 12:49 PM, Apache Jenkins Server > <jenk...@builds.apache.org> wrote: > > See > <https://builds.apache.org/job/Jena_Development_Te

[GitHub] jena pull request #404: JENA-1528: Expose HTTP client socketTimeout from Jen...

2018-04-21 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/404 JENA-1528: Expose HTTP client socketTimeout from Jena You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1528 Alternatively you can

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-21 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/401 That sounds like a set of changes (e.g. module renaming) much better suited for 4.0. ---

[GitHub] jena pull request #401: [JENA-1524] org.apache.jena.system is split by org.a...

2018-04-17 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/401#discussion_r182101777 --- Diff: apache-jena-osgi/jena-osgi/src/main/resources/META-INF/services/org.apache.jena.system.JenaSubsystemLifecycle --- @@ -1,4 +1,4

[GitHub] jena pull request #396: JENA-1520: tdb2.tdbstats: cmd and fix for rdf:type

2018-04-13 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/396#discussion_r181458378 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/solver/stats/StatsCollectorNodeId.java --- @@ -18,39 +18,39 @@ package

[GitHub] jena pull request #398: JENA-1523: Allow internal variables names in variabl...

2018-04-13 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/398#discussion_r181455157 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/tokens/TokenizerText.java --- @@ -739,16 +739,21 @@ private String readWordSub(boolean

Re: Old tickets.

2018-04-13 Thread ajs6f
> Yet open tickets do in some ways suggest they may happen sometime which isn't > the case. Agree 100%. I'm pretty happy closing tickets with a status that indicates just what you are saying; "This is so old that we can no longer effectively work it. If you disagree, please open a new

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-04-07 Thread ajs6f
the timing myself. ajs6f > On Apr 6, 2018, at 9:36 AM, Maxime Lefrançois <maxime.lefranc...@emse.fr> > wrote: > > Well, > > I think I have a pretty clear idea how I would do this. We would end up > using a registery like for custom functions or datatypes. > That reg

Re: [VOTE] Apache Jena 3.7.0 RC2

2018-04-06 Thread ajs6f
empty Maven repo [1], the second configures Maven to download artifacts with 10 threads (instead of the default 5) which makes filling that repo a good bit faster [2]. I'll vote today or tomorrow once I have a chance to do some checks for signing, checksums, etc. ajs6f [1] https

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-04-03 Thread ajs6f
I agree. I can imagine plenty of use cases for such a powerful pair of extension points. Maxime, how can we help you attack that work? Is there a design that is already clear to you? Are there any blockers we can help remove? ajs6f > On Mar 28, 2018, at 5:08 AM, Rob Vesse &

Re: [VOTE] Apache Jena 3.7.0 RC1

2018-04-01 Thread ajs6f
t; + can the source archive really be built? Yes. ajs6f > On Mar 29, 2018, at 2:28 PM, Andy Seaborne <a...@apache.org> wrote: > > Hi, > > Here is a vote on a release of Jena 3.7.0. > > This is the first proposed candidate for a 3.7.0 release. > > There are pro

Re: Build 3.7.0

2018-03-29 Thread ajs6f
I see the logic here, but mightn't it be good to add some config for this to override it in certain settings? ajs6f > On Mar 29, 2018, at 1:06 PM, Rob Vesse <rve...@dotnetrdf.org> wrote: > > Yeah it's a security think > > In production it is recommended not to incl

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-03-27 Thread ajs6f
Bruno raises an interesting question-- would this contribution have any effect (or should it) on jena-spatial? Would it be either necessary or if not, appropriate to integrate there? (I'm particularly interested in this because it might help decide between core and an extension.) ajs6f

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-03-27 Thread ajs6f
ajs6f > On Mar 26, 2018, at 5:40 PM, Bruno P. Kinoshita <ki...@apache.org> wrote: > > Hi Maxime, > Don't know whether it would be best as part of jena core or in an extension, > but sounds very interesting! Will let others comment on this. > At work, one item in

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175918594 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/JsonIterator.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-20 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/385 To be clear, what is here at Github is essentially a read-only mirror. What's at Apache is the real deal. We've talked about reversing that mirroring relationship (so that we could merge PRs here

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-20 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/385 Hey, @xristy, you want to push instead to the `master` branch at Apache: https://git-wip-us.apache.org/repos/asf/jena.git ---

Re: git.apache.org issue?

2018-03-19 Thread ajs6f
you could try downloading a large file of about that size from somewhere else in Apache infrastructure to see if it's your connection to Apache. Otherwise, you can always checkout the Github mirror, which is the same code: g...@github.com:apache/jena.git ajs6f > On Mar 19, 2018, at 7:10

Re: number of git clones?

2018-03-19 Thread ajs6f
PR. (Of course, I'm not going to merge anything, just an example!) hub provides some other useful tools, for forking on Github and sending PRs and so forth. Well-worth the price of admission! ajs6f > On Mar 19, 2018, at 6:44 AM, Rob Vesse <rve...@dotnetrdf.org> wrote: > > You can ha

[GitHub] jena pull request #384: JENA-1158: Make the union graph a graphView(Quad.uni...

2018-03-15 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/384#discussion_r174826544 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/GraphView.java --- @@ -146,7 +148,7 @@ private static Node graphNode(Node gn) { public

[GitHub] jena pull request #384: JENA-1158: Make the union graph a graphView(Quad.uni...

2018-03-15 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/384#discussion_r174825806 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/DatasetGraphBase.java --- @@ -69,9 +69,11 @@ public boolean containsGraph(Node graphNode

[GitHub] jena issue #379: Refactor tests; don't test for GregorianYear< 0

2018-03-10 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/379 Ok, `testDateTime_9` LGTM and if the others are just cut-and-paste, it should all be good. ---

[GitHub] jena pull request #377: JENA-1503: Bug in XSDDateTime toString

2018-03-09 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/377#discussion_r173498951 --- Diff: jena-core/src/test/java/org/apache/jena/graph/test/TestTypedLiterals.java --- @@ -989,7 +991,17 @@ public void testXSDanyURI() { Node

Re: Towards Jena 3.7.0

2018-03-09 Thread ajs6f
take-- I just closed the ticket. ajs6f

[GitHub] jena pull request #377: JENA-1503: Bug in XSDDateTime toString

2018-03-09 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/377 JENA-1503: Bug in XSDDateTime toString You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1503 Alternatively you can review and apply

Re: Possible fuseki/memory store bug

2018-03-07 Thread ajs6f
I've got a PR in now for 1499 (TIM remembers graph names even after they are empty): https://github.com/apache/jena/pull/374 Whether or not that's the whole story here, that's a different question! ajs6f > On Mar 7, 2018, at 12:23 PM, Andy Seaborne <a...@apache.org> wrote: > >

[GitHub] jena pull request #374: JENA-1499: Pruning TIM indexes on tuple deletion

2018-03-07 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/374 JENA-1499: Pruning TIM indexes on tuple deletion You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1499 Alternatively you can review

Re: [jira] [Commented] (JENA-1499) The TIM dataset retains a memory of named graphs after deleting all quads.

2018-03-07 Thread ajs6f
+1! ajs6f > On Mar 7, 2018, at 11:29 AM, Claude Warren <cla...@xenei.com> wrote: > > This looks like a prime candidate for a contract test (as soon as we agree > on what the action should be) > > Claude > > On Wed, Mar 7, 2018 at 4:26 PM, A. Soroka

[GitHub] jena pull request #373: JENA-1454: Fix to handle text output format.

2018-03-06 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/373#discussion_r172649617 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseResultSet.java --- @@ -131,26 +130,30 @@ public static void

[GitHub] jena pull request #373: JENA-1454: Fix to handle text output format.

2018-03-06 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/373#discussion_r172649522 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseResultSet.java --- @@ -131,26 +130,30 @@ public static void

[GitHub] jena pull request #372: Reformatting + two RiotChars functions.

2018-03-06 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/372#discussion_r172582451 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/lang/BlankNodeAllocatorGlobal.java --- @@ -18,41 +18,39 @@ package org.apache.jena.riot.lang

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/114 Hey, @kinow , is this ready for rebase and review? I can try rebasing it into a separate PR, or you can if you have time... then (hopefully) we can get it in! ---

[GitHub] jena issue #353: Refactoring complex methods of classes FBRuleInfGraph and L...

2018-03-06 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/353 I simply don't know enough about our inferencing gear to comment on this… @der, can you say anything? ---

[GitHub] jena pull request #367: JENA-1391: Add methods for ModelCollectors to API in...

2018-03-05 Thread ajs6f
GitHub user ajs6f reopened a pull request: https://github.com/apache/jena/pull/367 JENA-1391: Add methods for ModelCollectors to API in ModelUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1391b

[GitHub] jena pull request #367: JENA-1391: Add methods for ModelCollectors to API in...

2018-03-05 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/367 ---

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172276168 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172272325 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172252346 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172254605 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172251788 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172254303 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #369: JENA-1492: Pass down transactions from general datas...

2018-03-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/369#discussion_r172252112 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/TxnDataset2Graph.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] jena issue #369: JENA-1492: Pass down transactions from general datasets

2018-03-05 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/369 Okay. `::wrap` vs. `::create` is not what I am referring to as reformatting. It's stuff like [this](https://github.com/apache/jena/pull/369/files#diff-27cb8b74e951d2872a91a48066930e2d) or [this](https

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-05 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/368 This looks basically good to me: with an additional commit addressing https://github.com/apache/jena/pull/368#pullrequestreview-101006841, I'll be happy to merge this. ---

[GitHub] jena issue #369: JENA-1492: Pass down transactions from general datasets

2018-03-05 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/369 There is some new `Assembler` stuff and reformatting, so I'm not totally clear what the thrust of this PR is: is it to ensure that `Model`s wrapping other `Model`s (e.g. for inferencing) correctly pass

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-04 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/368 Urp, just realized that `Model extends PrefixMapping`, so this is fine wrt compatibility. Sorry for the confusion! ---

[GitHub] jena issue #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-04 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/368 This seems like a useful change, but it is not back-compatible, so in theory we should hold it for a major version release. ---

[GitHub] jena pull request #368: JENA-1495 Return Model from PrefixMapping methods.

2018-03-04 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/368#discussion_r172049845 --- Diff: jena-core/src/main/java/org/apache/jena/rdf/model/Model.java --- @@ -1051,4 +1051,12 @@ Remove all the statements matching (s, p, o) from this model

[GitHub] jena pull request #367: JENA-1391: Add methods for ModelCollectors to API in...

2018-03-01 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/367 JENA-1391: Add methods for ModelCollectors to API in ModelUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1391b

[GitHub] jena pull request #363: JENA-1491: Migrate FindBugs to StopBugs

2018-02-16 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/363 JENA-1491: Migrate FindBugs to StopBugs You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1491 Alternatively you can review

[GitHub] jena pull request #361: Small improvements

2018-02-15 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/361#discussion_r168644094 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/solver/BindingTDB.java --- @@ -120,6 +121,8 @@ public Node get1(Var var) if ( id == null

[GitHub] jena pull request #361: Small improvements

2018-02-15 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/361#discussion_r168523058 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/solver/BindingTDB.java --- @@ -120,6 +121,8 @@ public Node get1(Var var) if ( id == null

[GitHub] jena pull request #362: JENA-1389: Return 'this' rather than 'void' from Dat...

2018-02-15 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/362 JENA-1389: Return 'this' rather than 'void' from Dataset You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1389 Alternatively you

[GitHub] jena issue #359: Fixes for transactions after JENA-1458

2018-02-11 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/359 I meant code review. (I have no problem believing that I overlooked them, just surprised that everyone did.) ---

Re: [DRAFT] Apache Jena and Java9

2018-02-11 Thread ajs6f
e obvious to some what we mean . ajs6f > On Feb 11, 2018, at 1:39 PM, Andy Seaborne <a...@apache.org> wrote: > > I thought that some text about the status of Jena and Java9 would be useful > to users@ to state the current state. This could go in the 3.7.0 release &

<    1   2   3   4   5   6   7   8   9   10   >