[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210896418 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/ListUtils.java --- @@ -34,49 +34,40 @@ { private ListUtils() {} -public

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210893804 --- Diff: jena-fuseki2/jena-fuseki-embedded/src/main/java/org/apache/jena/fuseki/embedded/FusekiServer.java --- @@ -455,30 +527,36 @@ private static void

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210856558 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/ListUtils.java --- @@ -34,49 +34,40 @@ { private ListUtils() {} -public

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210855762 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/NodeUtils.java --- @@ -18,12 +18,9 @@ package org.apache.jena.sparql.util

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210855919 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/NodeUtils.java --- @@ -105,15 +102,23 @@ public String accept(Node x) { Iterator conv

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210857578 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ServiceRouter.java --- @@ -120,10 +120,12 @@ protected boolean

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210857731 --- Diff: jena-fuseki2/jena-fuseki-embedded/src/main/java/org/apache/jena/fuseki/embedded/FusekiServer.java --- @@ -20,10 +20,9 @@ import static

[GitHub] jena pull request #463: Cleanup

2018-08-17 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r210857986 --- Diff: jena-fuseki2/jena-fuseki-embedded/src/main/java/org/apache/jena/fuseki/embedded/FusekiServer.java --- @@ -455,30 +527,36 @@ private static void

[GitHub] jena pull request #462: Fix HTML syntax

2018-08-13 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/jena/pull/462 Fix HTML syntax Noticed this one while inspecting some PHP code that had a copy of Jena Fuseki inside. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] jena issue #461: JENA-1591: use boolean value in if expression

2018-08-11 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/461 Rebased and amended to use my apache e-mail in the commits. Merging. Thanks!!! ---

[GitHub] jena issue #460: JENA-1590: fix if statement in RDFWriter#output

2018-08-11 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/460 Merging (amended my e-mail in the commit, replacing the no-reply from GitHub by my apache.org one) ---

[GitHub] jena pull request #461: JENA-1591: use boolean value in if expression

2018-08-11 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/jena/pull/461 JENA-1591: use boolean value in if expression Another one found in Eclipse while I was reading some other code for UUID's. The value returned from the `Set` object will be a `boolean`, so the `== null

[GitHub] jena pull request #460: JENA-1590: fix if statement in RDFWriter#output

2018-08-11 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/jena/pull/460 JENA-1590: fix if statement in RDFWriter#output Eclipse alerted for some Dead code in this class, and after having a look, I thought we actually had to check the `lang` in the second `if`, not `ct

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-11 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209424635 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/sys/TDBInternal.java --- @@ -176,6 +176,23 @@ public static synchronized void expel(DatasetGraph

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416335 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Upload.java --- @@ -20,35 +20,39 @@ import static

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416339 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Upload.java --- @@ -20,35 +20,39 @@ import static

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416731 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/IO.java --- @@ -364,4 +369,31 @@ public static String uniqueFilename(String directory, String base

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416586 --- Diff: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/sys/TDBInternal.java --- @@ -176,6 +176,23 @@ public static synchronized void expel(DatasetGraph

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416401 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/HttpAction.java --- @@ -18,8 +18,8 @@ package

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416490 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/server/DataService.java --- @@ -151,50 +151,24 @@ public long getRequestsBad

[GitHub] jena pull request #459: Fuseki code maintenance.

2018-08-10 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/459#discussion_r209416344 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/HttpAction.java --- @@ -270,30 +269,50 @@ public boolean isTransactional

[GitHub] jena issue #455: JENA-1584: A Javacc Turtle parser for reference.

2018-08-05 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/455 Tested just the new parser with with the following code: ```java public static void main(String args[]) { try { java.io.Reader in = new java.io.StringReader

[GitHub] jena pull request #455: JENA-1584: A Javacc Turtle parser for reference.

2018-08-05 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/455#discussion_r207735246 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/lang/extra/javacc/TokenMgrError.java --- @@ -0,0 +1,165 @@ +/* Generated By:JavaCC: Do not edit

[GitHub] jena pull request #455: JENA-1584: A Javacc Turtle parser for reference.

2018-08-05 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/455#discussion_r207735233 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/lang/extra/javacc/ParseException.java --- @@ -0,0 +1,205 @@ +/* Generated By:JavaCC: Do not edit

[GitHub] jena pull request #455: JENA-1584: A Javacc Turtle parser for reference.

2018-08-05 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/455#discussion_r207735228 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/lang/extra/javacc/ParseException.java --- @@ -0,0 +1,205 @@ +/* Generated By:JavaCC: Do not edit

[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg

2018-08-05 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/456#discussion_r207734465 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuildLib.java --- @@ -0,0 +1,125 @@ +/* + * Licensed

[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg

2018-08-05 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/456#discussion_r207734729 --- Diff: jena-fuseki2/jena-fuseki-embedded/src/main/java/org/apache/jena/fuseki/embedded/FusekiServer.java --- @@ -246,6 +248,13 @@ public Builder enableStats

[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg

2018-08-05 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/456#discussion_r207734712 --- Diff: jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/package-info.java --- @@ -16,38 +16,17 @@ * limitations under the License

[GitHub] jena issue #447: JENA-1574: Resolve named graph URIs.

2018-07-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/447 Code looks good, and I think this is for a recent e-mail thread in one of the mailing lists. Are you going to add any unit tests as well? Not sure if it's easy/doable to test that part as well

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/436 The docs look really good! Only feedback I have: * It's possible to avoid the empty commit, by amending the last commit adding "this closes #123". That's what I normally do when I wor

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-19 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/436 @xristy if you'd like to merge it, and you cannot use the GitHub interface, then you can * Add a remote in your git repository using the developerConnection URL from the pom.xml (https

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195659829 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/QueryMultilingualAnalyzer.java --- @@ -0,0 +1,75 @@ +/** + * Licensed

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195659628 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/QueryMultilingualAnalyzer.java --- @@ -0,0 +1,75 @@ +/** + * Licensed

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195658758 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -316,6 +326,13 @@ protected Document doc(Entity entity

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195660039 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/DefineAnalyzersAssembler.java --- @@ -39,7 +44,46 @@ text:analyzer

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195659038 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -549,56 +567,81 @@ private String frags2string(TextFragment[] frags

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-14 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/436 This weekend I'm working on Commons, but planning on trying this pull request if time allows, so hopefully providing feedback if that worked with the Japanese example discussed in JIRA soon. ---

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194243520 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194243515 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194243525 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194243510 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #432: JENA-1560: PrefixMappingUtils

2018-06-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/432#discussion_r194243482 --- Diff: jena-core/src/main/java/org/apache/jena/util/PrefixMappingUtils.java --- @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #427: JENA-1554, JENA-1555: Support bz2 compressed files d...

2018-06-04 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/427#discussion_r192701731 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/IO.java --- @@ -158,15 +177,18 @@ static public OutputStream openOutputFileEx(String filename) throws

[GitHub] jena pull request #427: JENA-1554, JENA-1555: Support bz2 compressed files d...

2018-06-04 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/427#discussion_r192694578 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/io/IO.java --- @@ -77,10 +81,28 @@ static public InputStream openFileEx(String filename) throws

[GitHub] jena pull request #427: JENA-1554, JENA-1555: Support bz2 compressed files d...

2018-06-03 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/427#discussion_r192605754 --- Diff: pom.xml --- @@ -68,6 +68,7 @@ 3.4 1.5 1.11 +1.16.1 --- End diff -- 1.17 was just released... maybe

[GitHub] jena pull request #415: JENA-1543: QueryEngineHttp support for JSON queries.

2018-05-07 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/415#discussion_r186383751 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -538,13 +539,29 @@ else if ( actualContentType.equals

[GitHub] jena pull request #415: JENA-1543: QueryEngineHttp support for JSON queries.

2018-05-07 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/415#discussion_r186369128 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -538,13 +539,29 @@ else if ( actualContentType.equals

[GitHub] jena pull request #415: JENA-1543: QueryEngineHttp support for JSON queries.

2018-05-07 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/415#discussion_r186369795 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/QueryExecUtils.java --- @@ -191,6 +197,11 @@ private static void doSelectQuery(Prologue prologue

[GitHub] jena pull request #415: JENA-1543: QueryEngineHttp support for JSON queries.

2018-05-07 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/415#discussion_r186369815 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -538,13 +539,29 @@ else if ( actualContentType.equals

[GitHub] jena issue #409: JENA-1534: Test for filter-only variables in EXISTS.

2018-04-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/409 Learning a bit more of Jena internals (weather is really bad here in the antipodes :-) ). So picked this PR to review, so that I could learn more about Jena internals. Had a look

[GitHub] jena pull request #410: JENA-1535: Parse a specified language if given --syn...

2018-04-27 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/410#discussion_r184821458 --- Diff: jena-cmds/src/main/java/riotcmd/CmdLangParse.java --- @@ -218,8 +218,14 @@ public ParseRecord parseFile(String filename

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Branch created: [JENA-632-before-merge](https://github.com/kinow/jena/tree/JENA-632-before-merge). Won't delete it this year, in case we need to revisit. Followed

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 :tada: should I proceed with the merging? If so, I will squash the 18 commits into a single one before, as said before, but with a backup branch just-in-case. And then start working on the documentation

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184646447 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184639752 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-26 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184510334 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-26 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184509707 --- Diff: jena-arq/src/main/java/org/apache/jena/query/Query.java --- @@ -515,6 +519,18 @@ public void addHavingCondition(Expr expr) havingExprs.add

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-25 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 @afs also removed the `Number()` clause as that was not being used any more. Ready for review again :+1: And big thanks for all the feedback (and patience!) so far. ---

[GitHub] jena issue #390: Bugfix Tutorial 6: Missing "/" at the end of an URI resulte...

2018-04-22 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/390 @ajs6f good point. I remember some projects in ASF keep the example code in the main code repository (e.g. [Commons Imaging](https://github.com/apache/commons-imaging/tree/master/src/test/java/org

[GitHub] jena issue #390: Bugfix Tutorial 6: Missing "/" at the end of an URI resulte...

2018-04-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/390 Note: these files are not in GitHub, but in SVN. For example: http://svn.apache.org/repos/asf/jena/site/trunk/content/tutorials/sparql_data/vc-db-1.rdf @supergitacc would you be interested

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-21 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 Merged in a56f7710d88e368824042863e1ebef9afc7fd5f3, closing (forgot to use the magic words in the commit to close this PR automatically) ---

[GitHub] jena pull request #395: JENA-1488: add a selective folding analyzer

2018-04-21 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/jena/pull/395 ---

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-18 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r182394976 --- Diff: jena-arq/Grammar/master.jj --- @@ -2176,6 +2251,19 @@ String String() : { Token t ; String lex ; } } } +#ifdef ARQ +Number

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-18 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r182392871 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-18 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Rebase'd against master. Added `TestJsonEval.java`, with a couple more tests. Then understood why the projected variables were not working. Updated the grammar to call the method that populates

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-18 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r182390129 --- Diff: jena-arq/Grammar/master.jj --- @@ -326,6 +361,46 @@ void AskQuery() : {} SolutionModifier() } +#ifdef ARQ +void JsonQuery

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-15 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 Thanks for testing it @osma ! If there are no objections until next weekend I will merge it. With 3.7.0 out, we probably have some more time for testing, and then update the documentation

[GitHub] jena pull request #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/395#discussion_r181240620 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/filter/TestSelectiveFoldingFilter.java --- @@ -0,0 +1,135 @@ +/** + * Licensed

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 Used `luke` to look at the Lucene index created, and everything checked. Had a bit of struggle with the queries, but it was my mistake. ---

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 As it is possible to see, that as the configuration white-lists only `ä`, the `ö` is escaped with the filter. ---

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 ![screenshot_2018-04-13_00-51-46](https://user-images.githubusercontent.com/304786/38678650-c0c8cfbe-3eb5-11e8-83f7-72ac846cf661.png) ![screenshot_2018-04-13_00-52-12](https://user

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 Then, started Fuseki in Eclipse (FusekiCmd, with --config /.../fuseki.ttl). Loading the data file on to the /ds/ endpoint, everything works as expected. I loaded a modified `books.ttl` and got

[GitHub] jena issue #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/395 Example configuration used for testing: ``` @prefix :<#> . @prefix fuseki: <http://jena.apache.org/fuseki#> . @prefix dc: <http://purl.org/

[GitHub] jena pull request #395: JENA-1488: add a selective folding analyzer

2018-04-12 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/jena/pull/395 JENA-1488: add a selective folding analyzer This PR adds a selective folding analyzer, as explained in JENA-1488. It takes a list of characters, used as a white list. Everything

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-21 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175998281 --- Diff: jena-arq/Grammar/master.jj --- @@ -2176,6 +2251,19 @@ String String() : { Token t ; String lex ; } } } +#ifdef ARQ +Number

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 @afs had a quick look at your gist and it looks good! I won't be able to have a proper look at it and to commit for the next ~8 hours. But feel free to commit to this branch and update the pull request

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 And only started working again on this because you bumped this PR @ajs6f :-) learning a lot working on this ticket, and with JENA-1488, hope to start contributing back to Jena more now. ---

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Will apply some of the changes tonight. But I'm afraid I may not be able to fix the serialization issues before this weekend when there might be a new release. This weekend I'll be in Japan for some

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175923999 --- Diff: jena-arq/Grammar/master.jj --- @@ -99,7 +99,42 @@ import org.apache.jena.sparql.core.Quad ; #endif public class CLASS extends

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175923550 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/http/QueryEngineHTTP.java --- @@ -532,6 +535,18 @@ else if ( actualContentType.equals

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175923748 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/JsonIterator.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175922851 --- Diff: jena-arq/Grammar/master.jj --- @@ -99,7 +99,42 @@ import org.apache.jena.sparql.core.Quad ; #endif public class CLASS extends

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Replied @afs `s last comment, and also rebased the code. Even though it's rebased, there's quite a few commits... let me know if I should squash the commits or if it's preferable to leave the commit

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-20 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175680295 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ResultSetFormatter.java --- @@ -516,6 +520,41 @@ static public void outputAsJSON(boolean booleanResult

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-18 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/385 +1 @rvesse comments. And +1 for the great PR @xristy !!! Tested with the WIP `SelectiveFoldingFilter` for JENA-1488, and it worked like a charm! :tada: :tada: :tada: First created a normal

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 ![screenshot_2018-03-17_00-18-10](https://user-images.githubusercontent.com/304786/37518419-ec3b0fb4-2979-11e8-8c70-32666946d00b.png) ![screenshot_2018-03-17_00-17-44](https://user

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060216 --- Diff: jena-arq/src/main/java/org/apache/jena/query/Query.java --- @@ -707,6 +719,8 @@ public void visit(QueryVisitor visitor

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060320 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/JsonIterator.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175061201 --- Diff: jena-arq/src/main/java/org/apache/jena/query/ResultSetFormatter.java --- @@ -516,6 +520,41 @@ static public void outputAsJSON(boolean booleanResult

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060362 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/QueryExecutionBase.java --- @@ -335,7 +340,45 @@ public boolean execAsk

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-03-16 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r175060592 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-15 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Most of the tests are done, just need to add at least basic coverage for the SPARQL changes. Then will spend some minutes playing with the queries in Fuseki, before updating the PR. Aiming to push

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-14 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 FWIW, the output of the second test right now is ``` { "s" : "s" , "p" : "" , "o" : "def@en"

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-14 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 +1 for the current draft I would use it [here](https://github.com/kinow/jena/blob/a948f300fb40701e49e83db9d03e5d83da8145f6/jena-arq/src/main/java/org/apache/jena/sparql/engine

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-12 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Going to check how to get the correct values with JSON. Great catch, as I was using just Strings. But shouldn't be too hard. Will also include the initial tests with the next changes, covering

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Done, and ready for review again. ---

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Rebased! Tested the `ARQParser` main method (which is added here, but I find very handy for quickly testing it, but happy to remove if others prefer). And got the following

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Rebasing again, now manually, testing in Eclipse. Previous branch before the GitHub rebase archived at https://github.com/kinow/jena/tree/JENA-632-3 ---

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-09 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Rebased using GitHub's interface :tada: (never used it before, hope didn't make any silly mistakes :-) ). Good points @afs ! I noticed the existing SPARQL to JSON result writers, so adjusted

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-03-07 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Hey @ajs6f , I think so. My weak memory seems to tell me that the last time I did that... shortly after, there was some work on JSON (JSON-LD? Or maybe pure JSON) somewhere else in Jena; and when I saw

  1   2   >