[
https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278929#comment-14278929
]
Jay Kreps commented on KAFKA-1507:
--
I think the right way to do this is have a proper
[
https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279037#comment-14279037
]
Joe Stein commented on KAFKA-1697:
--
With this patch I think we should change the existing
[
https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279037#comment-14279037
]
Joe Stein edited comment on KAFKA-1697 at 1/15/15 6:21 PM:
---
With
Right, so this looks like it could create an issue similar to what's
currently being discussed in
https://issues.apache.org/jira/browse/KAFKA-1649 where users now get errors
under conditions when they previously wouldn't. Old clients won't even know
about the error code, so besides failing they
The idea of KIPs came up in a previous discussion but there was no real
crisp definition of what they were. Here is an attempt at defining a
process:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
The trick here is to have something light-weight enough that it isn't
GitHub user SylviaVargasCTL opened a pull request:
https://github.com/apache/kafka/pull/42
Trunk
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/kafka trunk
Alternatively you can review and apply these changes as the
Looping in the mailing list that the client developers live on because they
are all not on dev (though they should be if they want to be helping to
build the best client libraries they can).
I whole hardily believe that we need to not break existing functionality of
the client protocol, ever.
This would sting a whole lot less if there was a programmatic way to get what
server version is in use. Also, how will this work in mixed version clusters
(during an upgrade, for example)?
On Jan 15, 2015, at 10:10, Joe Stein joe.st...@stealth.ly wrote:
Looping in the mailing list that the
[
https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279012#comment-14279012
]
Sriharsha Chintalapani commented on KAFKA-1507:
---
[~jkreps] thanks for the
I very much agree on what Joe is saying, let's use the version field as
intended
and be very strict with not removing nor altering existing behaviour
without bumping the version.
Old API versions could be deprecated (documentation only?) immediately and
removed completely in the next minor version
[
https://issues.apache.org/jira/browse/KAFKA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278895#comment-14278895
]
Sriharsha Chintalapani edited comment on KAFKA-1461 at 1/15/15 4:24 PM:
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278905#comment-14278905
]
Onur Karaman commented on KAFKA-1333:
-
Hey everyone. I spoke with Guozhang about this
[
https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278790#comment-14278790
]
Hernan Rivas Inaka commented on KAFKA-1649:
---
I managed to get that error on
[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278880#comment-14278880
]
German Borbolla commented on KAFKA-1577:
I will try to reproduce with the release
See https://builds.apache.org/job/Kafka-trunk/370/changes
[
https://issues.apache.org/jira/browse/KAFKA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278895#comment-14278895
]
Sriharsha Chintalapani commented on KAFKA-1461:
---
[~guozhang] I had the
Thanks for reporting this. I will remove that option in RC2.
Jun
On Thu, Jan 15, 2015 at 5:21 AM, Jaikiran Pai jai.forums2...@gmail.com
wrote:
I just downloaded the Kafka binary and am trying this on my 32 bit JVM
(Java 7)? Trying to start Zookeeper or Kafka server keeps failing with
[
https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278873#comment-14278873
]
Joel Koshy commented on KAFKA-1577:
---
[~german.borbolla] can you make sure you don't have
[
https://issues.apache.org/jira/browse/KAFKA-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-595.
--
Resolution: Implemented
Assignee: Manikumar Reddy
Yes I think we can close this.
Decouple
[
https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278907#comment-14278907
]
Sriharsha Chintalapani commented on KAFKA-1507:
---
[~junrao] [~nehanarkhede]
The integration tests for the producer are in with the server since the
dependency is that the server depends on the clients rather than vice
versa). Only the mock tests are with the clients. You should be able to add
to one of the tests in
core/src/test/scala/integration/kafka/api/Producer*
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278855#comment-14278855
]
Jay Kreps commented on KAFKA-1333:
--
Hey [~abiletskyi] A relatively full-fledged Java
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278920#comment-14278920
]
Jay Kreps commented on KAFKA-1333:
--
Woooh!!! :-)
Add consumer
Next time the protocol is evolved and new error codes can be introduced, would
it make sense to add a new one called Deprecated (or Deprecation or
DeprecatedOperation or whatever sounds best)? This would act as a more
precise form of Unknown error. It could help identify what the problem is
Is the protocol bump caused by the behavior change or the new error code?
1) IMO, error_codes are data, and clients can expect to receive errors
that they don't understand (i.e. unknown errors). AFAIK, clients don't
break on unknown errors, they are simple more challenging to debug. If
we
clients don't break on unknown errors
maybe true for the official java clients, but I dont think the assumption
holds true for community-maintained clients and users of those clients.
kafka-python generally follows the fail-fast philosophy and raises an
exception on any unrecognized error code
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279407#comment-14279407
]
Onur Karaman commented on KAFKA-1476:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1476:
Attachment: KAFKA-1476_2015-01-15_14:30:04.patch
Get a list of consumer groups
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279412#comment-14279412
]
Gian Merlino commented on KAFKA-1866:
-
At least, I think it has that benefit. I
Gian Merlino created KAFKA-1866:
---
Summary: LogStartOffset gauge throws exceptions after log.delete()
Key: KAFKA-1866
URL: https://issues.apache.org/jira/browse/KAFKA-1866
Project: Kafka
Issue
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29831/
---
(Updated Jan. 15, 2015, 10:30 p.m.)
Review request for kafka.
Bugs:
On Jan. 13, 2015, 5:36 a.m., Neha Narkhede wrote:
To make review easier, could you add the output of the command for all
options for 2 consumer groups that consume 2 or more topics to the JIRA? It
will make it easier to review. One thing to watch out for is the ease of
scripting the
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279518#comment-14279518
]
Guozhang Wang edited comment on KAFKA-1333 at 1/15/15 11:34 PM:
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279518#comment-14279518
]
Guozhang Wang commented on KAFKA-1333:
--
[~abiletskyi] sorry for getting late on this.
Hi,
At LinkedIn we used an audit module to track the latency / message counts
at each tier of the pipeline (for your example it will have the producer
/ local / central / HDFS tiers). Some details can be found on our recent
talk slides (slide 41/42):
Gwen,
I think the only option that wouldn't require a protocol version change is
the one where acks 1 is converted to acks = -1 since it's the only one
that doesn't potentially break older clients. The protocol guide says that
the expected upgrade path is servers first, then clients, so old
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani reassigned KAFKA-1866:
-
Assignee: Sriharsha Chintalapani
LogStartOffset gauge throws exceptions
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279529#comment-14279529
]
Gian Merlino commented on KAFKA-1866:
-
Anything that calls log.delete() should do it.
[
https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279473#comment-14279473
]
Sriharsha Chintalapani commented on KAFKA-1866:
---
[~gian] any steps to
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1476:
Attachment: sample-kafka-consumer-groups-sh-output.txt
I've attached a sample run of
Thanks Jay for kicking this off! I think the confluence page you wrote up
is a great start.
The KIP makes sense to me (at a minimum) if there is going to be any
breaking change. This way Kafka can continue to grow and blossom and we
have a process in place if we are going to release a thorn ...
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao reassigned KAFKA-1864:
--
Assignee: Jun Rao
Revisit defaults for the internal offsets topic
The errors are part of the KIP process now, so I think the clients are safe :)
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
On Thu, Jan 15, 2015 at 5:12 PM, Steve Morin steve.mo...@gmail.com wrote:
Agree errors should be part of the protocol
On Jan 15, 2015,
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279715#comment-14279715
]
Neha Narkhede commented on KAFKA-1476:
--
Thanks for attaching the output,
The hacky method that Dana suggests does not sound too hacky to me
actually.
Since such scenario will only happen when 1) new clients talk to older
server and 2) older clients talk to new server with some APIs deprecated,
and correlation_id is always set to meaningful numbers before, old
clients
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29952/#review68395
---
core/src/main/scala/kafka/server/OffsetManager.scala
On Jan. 16, 2015, 2:54 a.m., Gwen Shapira wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 77
https://reviews.apache.org/r/29952/diff/1/?file=823279#file823279line77
I'm wondering why you chose to change defaults here and not in
KafkaConfig?
Unless I'm
On Jan. 16, 2015, 2:54 a.m., Gwen Shapira wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 77
https://reviews.apache.org/r/29952/diff/1/?file=823279#file823279line77
I'm wondering why you chose to change defaults here and not in
KafkaConfig?
Unless I'm
Hi,
1. Not sure if I understand your question.. could you elaborate?
2. Yes, and then the data for that topic will be distributed at the
granularity of partitions to your consumers.
3. The default value is set to 60 seconds I believe. You can read the
config docs for its semantics here:
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1864:
---
Attachment: kafka-1864.patch
Revisit defaults for the internal offsets topic
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279615#comment-14279615
]
Jun Rao commented on KAFKA-1864:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279616#comment-14279616
]
Jun Rao commented on KAFKA-1864:
Attached is a patch. A couple of the unit tests fail
Hi,
I got convinced by Joe and Dana that errors are indeed part of the
protocol and can't be randomly added.
So, it looks like we need to bump version of ProduceRequest in the
following way:
Version 0 - accept acks 1. I think we should keep the existing
behavior too (i.e. not replace it with -1)
Jun Rao created KAFKA-1868:
--
Summary: ConsoleConsumer shouldn't override dual.commit.enabled to
false if not explicitly set
Key: KAFKA-1868
URL: https://issues.apache.org/jira/browse/KAFKA-1868
Project:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29953/#review68383
---
Ship it!
Ship It!
- Joel Koshy
On Jan. 16, 2015, 1:02 a.m., Jun
[
https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279677#comment-14279677
]
Jun Rao commented on KAFKA-1864:
Also, another impact in this patch is that the offset
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29953/
---
Review request for kafka.
Bugs: kafka-1868
[
https://issues.apache.org/jira/browse/KAFKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279626#comment-14279626
]
Jun Rao commented on KAFKA-1868:
Created reviewboard
Agree errors should be part of the protocol
On Jan 15, 2015, at 17:59, Gwen Shapira gshap...@cloudera.com wrote:
Hi,
I got convinced by Joe and Dana that errors are indeed part of the
protocol and can't be randomly added.
So, it looks like we need to bump version of ProduceRequest in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29952/#review68381
---
core/src/main/scala/kafka/server/OffsetManager.scala
[
https://issues.apache.org/jira/browse/KAFKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1868:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the review. Committed to both
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279715#comment-14279715
]
Neha Narkhede edited comment on KAFKA-1476 at 1/16/15 2:21 AM:
Hey Joe,
Yeah I guess the question is what is the definition of major? I agree we
definitely don't want to generate a bunch of paperwork. We have enough
problems just getting all the contributions reviewed and checked in in a
timely fashion...
So obviously bug fixes would not apply here.
I
[
https://issues.apache.org/jira/browse/KAFKA-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1674:
---
Fix Version/s: 0.8.2
This is simple documentation correction. we can push this to 0.8.2
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279930#comment-14279930
]
Andrii Biletskyi commented on KAFKA-1333:
-
[~guozhang] many thanks for such
[
https://issues.apache.org/jira/browse/KAFKA-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279396#comment-14279396
]
Alexey Ozeritskiy edited comment on KAFKA-1804 at 1/16/15 7:44 AM:
[
https://issues.apache.org/jira/browse/KAFKA-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278435#comment-14278435
]
Manikumar Reddy commented on KAFKA-595:
---
[~nehanarkhede] We have given support for
I just downloaded the Kafka binary and am trying this on my 32 bit JVM
(Java 7)? Trying to start Zookeeper or Kafka server keeps failing with
Unrecognized VM option 'UseCompressedOops':
./zookeeper-server-start.sh ../config/zookeeper.properties
Unrecognized VM option 'UseCompressedOops'
Error:
Yes, we can add a check. This option works only with 64 bit jvm.
On Jan 15, 2015 6:53 PM, Jaikiran Pai jai.forums2...@gmail.com wrote:
I just downloaded the Kafka binary and am trying this on my 32 bit JVM
(Java 7)? Trying to start Zookeeper or Kafka server keeps failing with
Unrecognized
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278739#comment-14278739
]
Andrii Biletskyi commented on KAFKA-1333:
-
Hey [~guozhang],
We are considering
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29952/#review68406
---
Ship it!
core/src/main/scala/kafka/server/OffsetManager.scala
[
https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Holoman updated KAFKA-1810:
Attachment: KAFKA-1810_2015-01-15_19:47:14.patch
Add IP Filtering / Whitelists-Blacklists
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29714/
---
(Updated Jan. 16, 2015, 12:47 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279609#comment-14279609
]
Jeff Holoman commented on KAFKA-1810:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1868:
---
Attachment: kafka-1868.patch
ConsoleConsumer shouldn't override dual.commit.enabled to false if not
[
https://issues.apache.org/jira/browse/KAFKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1868:
---
Status: Patch Available (was: Open)
ConsoleConsumer shouldn't override dual.commit.enabled to false if not
[
https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Stein updated KAFKA-1810:
-
Reviewer: Gwen Shapira
Add IP Filtering / Whitelists-Blacklists
[
https://issues.apache.org/jira/browse/KAFKA-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279660#comment-14279660
]
Joel Koshy commented on KAFKA-1868:
---
Appears to be a side-effect of KAFKA-924
On Jan. 16, 2015, 1:25 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 79
https://reviews.apache.org/r/29952/diff/1/?file=823279#file823279line79
The only issue here is the problem raised in KAFKA-1867 - even though
that should not happen in
+1 on Joe's suggestions, glad to see it happening!
On Thu, Jan 15, 2015 at 5:19 PM, Gwen Shapira gshap...@cloudera.com wrote:
The errors are part of the KIP process now, so I think the clients are
safe :)
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
On
I created a KIP for this suggestion:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1+-+Remove+support+of+request.required.acks
Basically documenting what was already discussed here. Comments will
be awesome!
Gwen
On Thu, Jan 15, 2015 at 5:19 PM, Gwen Shapira gshap...@cloudera.com
81 matches
Mail list logo
