[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-03-25 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380359#comment-14380359 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-25 Thread Guozhang Wang
> On March 12, 2015, 1:04 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 67 > > > > > > The name is a bit misleading since the port value is actually fixed. > > Maybe we can r

Re: MirrorMaker improvements

2015-03-25 Thread Jiangjie Qin
Hi Jun, I think bumping up socket.receive.buffer.bytes will help but might not be sufficient. There are actually two related factors here: 1. Pipelining TCP packets when send a single request/response. 2. Pipelining multiple requests/responses Bumping up socket.receive.buffer.bytes help with the 1)

Re: [VOTE] KIP-15 add a close with timeout to new producer

2015-03-25 Thread Jiangjie Qin
Hi Jay, The reason we keep the blocking behavior if close() or close(timeout) is called from callback is discussed in another thread. I copy/paste the message here: It looks that the problem we want to solve and the purpose we want to achieve is: If user uses close() in callback, we want to let u

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-25 Thread Mayuresh Gharat
> On March 25, 2015, 4:48 p.m., Mayuresh Gharat wrote: > > examples/src/main/java/kafka/examples/Producer.java, line 56 > > > > > > messageNo++ can be outside the if-else block and used once. LGTM else. - Mayuresh

Re: MirrorMaker improvements

2015-03-25 Thread Jun Rao
To amortize the long RTT across data centers, you can tune the TCP window size by configuring a larger socket.receive.buffer.bytes in the consumer. For the last one, it seems that you want identical mirroring. The tricky thing is to figure out how to avoid duplicates when there is a failure. We ha

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-25 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review77747 --- examples/src/main/java/kafka/examples/Producer.java

[jira] [Commented] (KAFKA-2038) Unable to restart brokers after it went down with no space left on disk

2015-03-25 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380190#comment-14380190 ] Mayuresh Gharat commented on KAFKA-2038: I suppose this will involve manual interv

Re: [VOTE] KIP-15 add a close with timeout to new producer

2015-03-25 Thread Jay Kreps
Wait, actually, why would the thread block forever? I would understand throwing an error and failing immediately (fail fast) and I would understand logging an error and blocking for the time they specified (since that is what they asked for), but the logging an error and putatively blocking forever

Re: [VOTE] KIP-15 add a close with timeout to new producer

2015-03-25 Thread Jay Kreps
+1 -Jay On Tue, Mar 24, 2015 at 2:43 PM, Guozhang Wang wrote: > +1. > > On Tue, Mar 24, 2015 at 2:15 PM, Jiangjie Qin > wrote: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+producer > > > > As a short summary, the new interface

Metrics package discussion

2015-03-25 Thread Aditya Auradkar
Hey everyone, Picking up this discussion after yesterdays KIP hangout. For anyone who did not join the meeting, we have 2 different metrics packages being used by the clients (custom package) and the server (codahale). We are discussing whether to migrate the server to the new package. What in

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-25 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review77732 --- bin/kafka-run-class.sh

[jira] [Commented] (KAFKA-1994) Evaluate performance effect of chroot check on Topic creation

2015-03-25 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379959#comment-14379959 ] Ashish K Singh commented on KAFKA-1994: --- [~gwenshap] My apologies for the delay. Kin

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-03-25 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379900#comment-14379900 ] Ashish K Singh commented on KAFKA-1856: --- Thanks for helping out [~charmalloc]! > Ad

[jira] [Commented] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-03-25 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379898#comment-14379898 ] Ashish K Singh commented on KAFKA-1982: --- Pinging [~junrao] again :) > change kafka.

[jira] [Commented] (KAFKA-2038) Unable to restart brokers after it went down with no space left on disk

2015-03-25 Thread K Zakee (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379515#comment-14379515 ] K Zakee commented on KAFKA-2038: On Mar 21, 2015, at 11:50 AM, svante karlsson wrote: Th

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379451#comment-14379451 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- [~guozhang] Sorry, seems I mi

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1501: - Attachment: KAFKA-1501_2015-03-25_00:44:50.patch > transient unit tests failures d

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379441#comment-14379441 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- Updated reviewboard https://r

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-25 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31806/ --- (Updated March 25, 2015, 7:45 a.m.) Review request for kafka. Bugs: KAFKA-150

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-25 Thread Ewen Cheslack-Postava
> On March 12, 2015, 1:04 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, line 67 > > > > > > The name is a bit misleading since the port value is actually fixed. > > Maybe we can r

<    1   2